From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.8838.1662012111544503461 for ; Wed, 31 Aug 2022 23:01:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=e0CZwng1; spf=permerror, err=too many SPF records (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662012111; x=1693548111; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4pHhXJhw73cELvNKXQ2MGiI88uDDSo2T2pbhlLTKbio=; b=e0CZwng1bB8MpTN6kFybOeDjVj/K8mXdUe9vI8KdsjDWhg0cK7uvNVSl CiI1C3RgeO8YR9ji2mmkSSEp1FZwuvtlGvFLFYXjA8ribAwhJhCkZUi6K kxlvh85WgWSbvEw3N75xDltI1uNAiWFCXDToU5G+ctXEz/BtoRCCvtIm3 TeLrD549FL4yzs2lNsxC0E56K+rRJinT2YRVLrekt0jqa4Y8u9Mxyys66 7Sz3ogz282arA2skcf18eo3e7xp2gLQnofbLRvwKqiYPn6Od8nJ6nEbYv SqNkHhlYFJjSQ128UaiJzlPsa2GnWmn6t6aoydK3z34iYXpUAYFb+wXJN w==; X-IronPort-AV: E=McAfee;i="6500,9779,10456"; a="276026278" X-IronPort-AV: E=Sophos;i="5.93,280,1654585200"; d="scan'208";a="276026278" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 23:01:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,280,1654585200"; d="scan'208";a="563314685" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 31 Aug 2022 23:01:35 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 23:01:35 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 23:01:34 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 31 Aug 2022 23:01:34 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 31 Aug 2022 23:01:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K47JjyRP/7Dc6dRCRMo06B1LFScCu//hz55n+9DIsv0NuVWOmy+WPCZYN+va9+o+vUj61uHFm91BsASnk6PbLUvAejNg8IjreFGtPQTwTdYfd0S5ax20lo3EZlQG0SQcZR/ZxKknCX37oUb3AtCoI3ZkqCY59evSxqPdTdly/3P+8Vo0jvh96wF4CFPItEdYK9jUeH5+ix0n5QDY+03GfDbSuDtzEJGc8PpOm08ZcA2N+fa+/f/DcgWkFAoONXgTN1LKjzOHGAGkoJcqvUq5ZnJzt9BCZ6KWu/nsD5E+Jl6DIhsUSOmY0BQ9Pqw+nIiLOFAPQC4XPZtO3S2dgjgOLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fqx9x8MxE9PeJbyCFWEWq0Havj/dF4ZFOCDKLvjei4E=; b=UYl3zx+zsu4ENaeXhpP6HKa4TCvx6cOgXIKfEQWwdR9jeY5bqkhmmgrPWPRQNELkC4eLsTVm2dXApfvWz3vDK4zYhuS10z9uChkN3IpXTFANC0V1UatwUn+IK9Ga0m6iFHYtMRj2gsmOXRs+FcWSONIvEIbC7p96yULwu4GoxJEH4WNL5fFMVjXuSZ2IyvVZnhXThuK8Z23yHxwdXKILeyppVDPbkCbCh5NchfsbIcdnOshaS/NzHw4eRlG7EtQ5xLOAKly1zOiuPtPDGNPA5Z0qXGTrgLrgWmxJy1J0Nx7P1ZLA4oi18YuONDtU7qI3QN+CNZLRAP32B5WKm0AEZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by MWHPR1101MB2093.namprd11.prod.outlook.com (2603:10b6:301:50::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Thu, 1 Sep 2022 06:01:32 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::613a:668:ad30:2cb6]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::613a:668:ad30:2cb6%3]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 06:01:31 +0000 From: "Chiu, Chasel" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. Thread-Topic: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library. Thread-Index: AQHYvWYvAMRRWH14eUSbim1GwUxVIK3JorkAgABy0nA= Date: Thu, 1 Sep 2022 06:01:31 +0000 Message-ID: References: <20220831181842.3141-1-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5bfc2a04-6686-4ed3-b1f2-08da8bdf6ac5 x-ms-traffictypediagnostic: MWHPR1101MB2093:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KrhomTELi1ikBl3o2NmRSj08rbQuEjRKXW6W9C4naxDbqeaIxM0nazGInMMs7+3B1ZdwUc6d8qcdYPtPNKMd4LcvIRTB6/lij1zfz/ITttvHslpRhV+xmAh0KlzW6YJUNv/cXNMEMhqAK0G3rOIJm8nSDlzCEVREvoef9nBLp6DvWnjFnhp4F7+5LLpMFl25pEHMt0kUsV5N5+zkNLvl3aYWrCwXN+J9nHNSZPvRjoCZJMgrJfrFP/jVpc+lsZPOeY/L0zwyyLTrIpxgJohkY1eTz+rR7HCIs7PyodzKpmCtFE4pLv5jaZ2Cs7p5U9WY3HVyupbGwLDSEc6Qc8Dgr1TLiio3zwfPuqn5w3qB+v85GZZ/BT+rCp9NhsuUMyyvR4wq02sv/+FfCpYCsd+lcZqpoJ/M5aEAPJEskAAKoF6wol/T2DTtYJX7eTuQjOHUh7rf9UDEpbOOXIBnVkM5d9Z9NqcvOvFQVgJBsFh4H4Pn2XP0SkSfqKt9IC8IAoltHKQAQywYplkwjxp/joxaTiGhM/mnMTAuPN3N96YuSRzIa5riLGWhiBsKuVmWTcAhRD1MKaoL1lNqPFtYKwZwHXj2/URJM78AixPQ86cyJrxKEXIFhH1SBUExqP0m0DkEuSiHGqNdb2S5q+SxrJMUFlr5gE9Rz6QfOcxKe5chnp5on5B1JdKaXSzX8G4Sp73AaAhE9wsjRLvQ61rt1loC2GqVRzJ46/ARNYkMGsu06KYMgw6Zj7sS6TBPwN1qCBjmAAuiGf4xsyUnjEn4tEAuwQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(396003)(366004)(376002)(136003)(82960400001)(76116006)(86362001)(9686003)(53546011)(26005)(107886003)(71200400001)(33656002)(6506007)(41300700001)(186003)(83380400001)(122000001)(7696005)(478600001)(38070700005)(66946007)(8676002)(66446008)(110136005)(55016003)(316002)(54906003)(64756008)(4326008)(38100700002)(66476007)(66556008)(52536014)(2906002)(8936002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bLVs/D+KdgDCTgMswXK9yeX6XXg+aIkxtx35NGogfy2Zb+nY584aChhdW6lz?= =?us-ascii?Q?731rNvzVFobdJmgx2kjqFKRHI3p6MaX1pl35QzVsIfQxnEy1EL/17svx5ITF?= =?us-ascii?Q?4RfNW9x5yh26sX7cjmOKPG6PkaojorULfRAcbk4CKR3sjQXYEb/jwI2PsrsL?= =?us-ascii?Q?FLkr/nUvT5oZqmE1ORHanZ4hidQ59piAX7PoADCSDWAwKMTsjlC8lyMXsXjH?= =?us-ascii?Q?90PZ+mSvvp1HFvHzZUmY1X6BncR5WPjf9BAza/r25bqwp5wz8Yf5eimmOfuf?= =?us-ascii?Q?/fvnvXUOU93cISwLRYOLFRlsdrGDVlWDPq/iGTR/mrQGvQqRGNTsqGTbjlEt?= =?us-ascii?Q?MthDKI3oBFss1IpR+zRvMAMT6ntudObL6GGFLsFCNbmOyN2TsJNjFNg568EH?= =?us-ascii?Q?dc/TLWvNWrGrDlPzE+Yeaa3lBCB3OdsjB/ZY6wsY4sQ/yNvqgp6fC7VEy9sH?= =?us-ascii?Q?jJs7jmEnbT7GRap8CoXI/qOkXDhJNNdECDr+hzoF+5NhqofEUhXhudPN1ARZ?= =?us-ascii?Q?DcCwm9+OtZThxIN2/lHvpNCysxXG5ucYogZjbtdXm2EvrjeOUBkckEdDf1lo?= =?us-ascii?Q?fhOoOrm5qjiC5k12HMz4uB4OjOh22y6EG4mI0coCKAt+6W56s8eEKHbARtEV?= =?us-ascii?Q?DzmSD8CsviCQjJxQX/ud93Kq9lqTeNbcRosVsFiNW4gTeATkmNePgqQeHBMS?= =?us-ascii?Q?gVMWikZ+h2ixSH6LI1KldYFeKlK43cXZXuBQseSAkiMtPcG6a8Kvb+K60Lhy?= =?us-ascii?Q?AHt0teQCIezaB5xnsqvPbxYaR252j6+Gfl4Gxom+JV5R63oRvtZX1xHzJuya?= =?us-ascii?Q?JY8w8+EtErA2bIo2Sakl8MHeckzJWLGKL8an00YzCcfM9j0xTO7mx1KE2+Fk?= =?us-ascii?Q?6eeATcHq5eVRDtHgOAIKA8bXh1ySMaiw+7CfuoShUqzdBFFSSpJzQzqnAa4R?= =?us-ascii?Q?f+l3lXFP/RX0WyGL+2HXsXhBZAKv4xwNQZVMzVAtWO1AMS/Gz3UQ83OEEJZ1?= =?us-ascii?Q?9L4wU3dHEU0vaMWXW6g7mbgL0ozi6qZc6a0sSaa+7TNlCLjD8T/papfgiwJ5?= =?us-ascii?Q?6Dv+4yn8qQZEGp0Mc8cmy3iQD3OCIhbk+NQaSc0MfaACJLGOgglNMu6yAwsg?= =?us-ascii?Q?hCTOC3WoT42e0kBlnJuer5JoutoUkFfqzKDdiIRHMlrFdmhzYUJ4zry/edRA?= =?us-ascii?Q?wiHIpKpIJZJwG0N7l+mkssnvkaABNzFn9eCzsVLdPOUQkepl/qrBmDB8bi1A?= =?us-ascii?Q?NFeOJSCArPx89Dn/rgqeCUYm+OHaD9eAcMQ+P6ZxHYc98qDe2LDGB3WcH7d9?= =?us-ascii?Q?pbQTTe2J+9KWCnYc4Z+yRY/qvw1FDcSo6WUCfFM7Bm+zrGVysL8r1f2So8Zm?= =?us-ascii?Q?SiPu1/5OpnE+jm2JFi5fX7P8M8lDU82kiCBh/w+2P5vPZtgrB4qBNpAttntH?= =?us-ascii?Q?P5rBysk2RfWcBSG1ZPUlWXnMoyphzmuuXOIsSwzKYVELVFOuPIHJ34eXt8jq?= =?us-ascii?Q?vlMS/eDvxOEfGFyB/ikzVyUpOdH8ZCwON5X8YykNydPAg+yT9I6PclslI2jZ?= =?us-ascii?Q?8E6tgE0cx8tIIp1oUue+5OdEO51erAYhmLDjW/2z?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bfc2a04-6686-4ed3-b1f2-08da8bdf6ac5 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2022 06:01:31.1187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b7vXCxNnufaUfaaIsoD7EO4NShj/XSr0cvwKlvD5E5lGohUIAQOYv95jZ1Nxu7iV2yQs0CLphPRAmsRpz76tpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2093 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agree. I'm sending patch to rename this lib from edk2 and will send patch t= o rename this lib from MinPlatformPkg dsc too. Thanks, Chasel > -----Original Message----- > From: Oram, Isaac W > Sent: Wednesday, August 31, 2022 4:10 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Gao, Liming > ; Dong, Eric > Subject: RE: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 > MultiPhase library. >=20 > This sample library does not do anything. If the design is such that a N= ULL > library is functional, then a NULL library should be implemented. Having= a > sample library that has the same function as a NULL library doesn't make > sense to me. > It looks like a NULL library would work fine in this design. If you upda= te to > IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/B > aseFspWrapperPlatformMultiPhaseLibNull.inf, that would be acceptable to > me. >=20 > Regards, > Isaac >=20 > -----Original Message----- > From: Chiu, Chasel > Sent: Wednesday, August 31, 2022 11:19 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; Dong, > Eric > Subject: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase > library. >=20 > FSP Wrapper has implemented FSP 2.4 MultiPhase support and required > platform to include new library instance. >=20 > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Chasel Chiu > --- > Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > index 8e91dba6ac..d4191c4b01 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > @@ -54,6 +54,8 @@ >=20 > TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatform > HierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf > FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLi > b/BaseFspMeasurementLib.inf+ > FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspW > rapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLi > bSample.inf+ > FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrappe > rMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf > TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventL > ogRecordLib.inf > TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpm > MeasurementLib.inf -- > 2.35.0.windows.1