public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v1 2/7] IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate GUID
Date: Wed, 7 Sep 2022 03:33:24 +0000	[thread overview]
Message-ID: <BN9PR11MB5483F6F159E375078870C81BE6419@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220907031914.397-3-mikuback@linux.microsoft.com>


Thanks for fixing this bug.
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Tuesday, September 6, 2022 8:19 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH v1 2/7] IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate
> GUID
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048
> 
> The FILE_GUID for this library instance file is a duplicate of
> Library/SecFspSecPlatformLibNull/SecFspSecPlatformLibNull.inf.
> 
> This change replaces the duplicated GUID value with a unique GUID.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
> b/IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
> index a79f6aecda6d..b9dd132ea863 100644
> --- a/IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
> +++ b/IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf
> @@ -15,7 +15,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = BaseFspMultiPhaseLib
> -  FILE_GUID                      = C128CADC-623E-4E41-97CB-A7138E627460
> +  FILE_GUID                      = 74C14477-E742-4A0A-9787-27B1CF34F698
>    MODULE_TYPE                    = SEC
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = FspMultiPhaseLib
> --
> 2.28.0.windows.1


  reply	other threads:[~2022-09-07  3:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  3:19 [PATCH v1 0/7] Enable CI in Intel FSP Packages Michael Kubacki
2022-09-07  3:19 ` [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors Michael Kubacki
2022-09-07  3:36   ` [edk2-devel] " Chiu, Chasel
2022-09-07  3:19 ` [PATCH v1 2/7] IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate GUID Michael Kubacki
2022-09-07  3:33   ` Chiu, Chasel [this message]
2022-09-07  3:19 ` [PATCH v1 3/7] IntelFsp2Pkg: Add CI YAML file Michael Kubacki
2022-09-07  3:19 ` [PATCH v1 4/7] IntelFsp2WrapperPkg: Fix code formatting errors Michael Kubacki
2022-09-07  3:34   ` Chiu, Chasel
2022-09-07  3:19 ` [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove duplicate LibraryClasses entry Michael Kubacki
2022-09-07  3:49   ` [edk2-devel] " Chiu, Chasel
2022-09-07  4:34     ` Michael Kubacki
2022-09-07  4:47       ` Chiu, Chasel
2022-09-07  3:19 ` [PATCH v1 6/7] IntelFsp2WrapperPkg: Add CI YAML file Michael Kubacki
2022-09-07  3:19 ` [PATCH v1 7/7] .azurepipelines: Add IntelFsp2Pkg and IntelFsp2WrapperPkg to CI Michael Kubacki
2022-09-09  1:35   ` [edk2-devel] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB5483F6F159E375078870C81BE6419@BN9PR11MB5483.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox