From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.142.1628217885247468446 for ; Thu, 05 Aug 2021 19:44:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=G5gWeW09; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="194567238" X-IronPort-AV: E=Sophos;i="5.84,299,1620716400"; d="scan'208";a="194567238" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 19:44:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,299,1620716400"; d="scan'208";a="669233181" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 05 Aug 2021 19:44:44 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 19:44:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 5 Aug 2021 19:44:43 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 19:44:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fIj1+BABicBMBLfWF85V9TCziJQU3bXVfy+W/uYU3HZhVUHy5Z0TqJwpUn35kq/SZWM2yvgqNcMBAUeUdZ7KzYYrPe6igmHF2CivOSJYLUpA0vK4NAHnnM1oYf1YQ73Uag8aYop8Dievqp7p6WN9kzwEQ7k0bvTr9Hyx14tYj+mMjGCT9qLIo3nio9Qe6RxsxLayLxezmWEQzLR/MRvfp0uvq0lT7Rg4/7djMbfNXgzvYcJJwPVbw0r+oqnDMOOFLSDxa/56QoN3hWdQBJT08hZfAIR8mpOHDEqfyy752+6iTw2/xza9ge+h3WsALmALXPd4sy42+bUkuV6MfEn6Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30w5xfjxqKB3/bqdXcQK0dvkdN29xqkXMfmBfTfMFtU=; b=DuBd84juZTJVwvysVR1pLGJYe/Q4mh7DZUW2z2nx4OLctWugZmoqtKzlTzPncY6aVKB3FMKHA41ja4Fo6flzPCv7QPDFjsLN1BGxS4bgXeD88EJzT4p88w65RhKC2/4r7YGnaJBNmd4rMRH6o/qh227pS5QE1hPBG6BNxEqjCS8rEWQqvVBVdEgNjFm2vqP7vStD0fDSuMhQ2LiKorVSQY7cotsd9lvRz0XZuIO9Ok5FT3wZJIsadAOdXxvW1aKXmEhHGTaQCV8DownY/gB5ENSekO/rDrJAT3ohJruWJ6m6QRLtccogYaFFWbjLnKMiOtK7X93qflS97OvlNjdV6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30w5xfjxqKB3/bqdXcQK0dvkdN29xqkXMfmBfTfMFtU=; b=G5gWeW09iaqjFfuwWUkTZYmMyllxh3zPFkDQGQBLJlsYhBMb/GKCKPxx2ircudLodTC7oJxnmzYi8IzsyFvebGAFov+JZXB7RJveOhph1AYsLxS5fH6kKVs+fKFXSqwVPfzpgO7uVvaZAYIu8pFRKjdrc/s7N9W4olEkgqOs4mI= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB1859.namprd11.prod.outlook.com (2603:10b6:404:104::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15; Fri, 6 Aug 2021 02:44:41 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6413:4198:3c40:777f]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6413:4198:3c40:777f%3]) with mapi id 15.20.4394.017; Fri, 6 Aug 2021 02:44:41 +0000 From: "Chiu, Chasel" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" , Benjamin Doron CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][PATCH v5 43/46] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API Thread-Topic: [edk2-platforms][PATCH v5 43/46] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API Thread-Index: AQHXiBEglQMKbwN4EEqHuhH9OJKIv6tlydMQ Date: Fri, 6 Aug 2021 02:44:41 +0000 Message-ID: References: <20210803023914.1569-1-mikuback@linux.microsoft.com> <20210803023914.1569-44-mikuback@linux.microsoft.com> In-Reply-To: <20210803023914.1569-44-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 679c1f76-36b4-49bd-5a8c-08d958842447 x-ms-traffictypediagnostic: BN6PR11MB1859: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1186; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9jBaHswXz60xYepNkCI1UykkcXAM2eVoDFfsYREIloqYmQJ0HSGhfl3Wpm9G0K1eR1P1iJdHWFvDfrIg3BVCfK4l86AysgcxFFADotptBNKdwplbz/m1Im51deVC+wXmTuswcnD3KZW4C3XvVV8rAGi4KBj2sisqideW8nrCMJTitHsk5b+aPwiBJHMWuZld+MrdaDmuuV9nmudqtQPe+wQuJDtZCWchzAXFfCwc327VxA8mymZLkakydZtfkSIuuFJIuAEmIU6GjcKR9g0WPivvXBNYBzna/w57gd80bTANFRQ8Cu2c2284uQb35L1wL+r+7L1JRAVPlMnaBQq1I2gpGLbiVbrk6SlfgN4sPumg97As4OiH3wH69eAV6VA+HMjYE8tHwtP8u/YYTJsiMVKBs1N+4f6vVmCAOJjla6kFi5hnbE7MwYnH6/zefr3mzbeejNxC43A9J3OKCs1/kQ3nVWV1FU+0+LwRXbrTOIqpqcpX8gfGolrE48uzVGncafEkoD+yFj6i11K15JW9gbG/IZSVd9CclEgN82/BCY0JpFIcJqeejV4cjvW19ggyqh1jNM532ogRBfNIQVqVgCQimyEFIQ3aUAA+b1WWi09mkqqkEkD5o5cGANggSVfA4kZVHGngLhxvTc7g9JB1Rb4jlTjUEA56vwWZQJmAFqlf/xMm122hsMIzwWIwhxN/jvcANTyBdw2ksXxKik3ga0rEguI4vk+X/RvGbMYUQ6t1P6NSEE1eZXNS6UPpYaPpvZUeZXcSy/mByMIUWQQM8nimBn8fcZGSeV0ycm3/+ym8msYtfnfdidPY0tRvaJOg x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(38070700005)(52536014)(66946007)(83380400001)(15650500001)(86362001)(316002)(7696005)(2906002)(5660300002)(110136005)(76116006)(38100700002)(66556008)(186003)(478600001)(8936002)(26005)(122000001)(71200400001)(107886003)(8676002)(53546011)(6506007)(66476007)(64756008)(4326008)(66446008)(9686003)(55016002)(33656002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8LdBdpSnHnSKZzc0ZPHfWhp7g6ro3V9I11sQ0HOndgl72E1d4Ud3Lxohmeuj?= =?us-ascii?Q?nxQffK5VJmP826wl/1uGJN2uIoyCB7WxopUwLi7Ig458y5EdF5mTChU6ZOxg?= =?us-ascii?Q?NsZT4szHzIzbM/S41eppjR3Ua7LIg0a/9XsnTZJ+q3E1j1dDAjoCZ0CF4uXn?= =?us-ascii?Q?S/RRSGoLR1BYbk1ef2RL1z44IkaCdcqxw6Rvyc5g64TgA0CQQeHOfJfNMBPs?= =?us-ascii?Q?QEfV4z+EbOySygDZkLrqsOuuzmzoVQUWUwyJNQSTvpiPknC83df1iogyqKb5?= =?us-ascii?Q?Oi0SQ8yP+VXMDlhG6TVA1JOYBEGGCmiRdtKHZLlom6tj91mjhRJ0BI172Dva?= =?us-ascii?Q?i3uF2D+NYuso7Hmw5CBCVM5Zy7mpxIIfyQ1VgFXA9TBMA0O1Jei34IddOaYl?= =?us-ascii?Q?seSVBMIf4HgDXlAf1hSvcK0DnPntdUNA866H9aYYUiwor6iSYq3IPFvGXZsd?= =?us-ascii?Q?ezrlVPNZ3u469P2poA33etxnp6+DXt4eYEqFwKeOJO+lBFFWmeoT30Oa6fcN?= =?us-ascii?Q?datk3H7+nLNk3NaN9w0AP39u/mMI7cL+u03CU8Iuo2Ck5pq9b/ijzzuIajaR?= =?us-ascii?Q?lI/ZK/y00bR1Q2HGTYRt+Kizepkha+smStanERdakH69TGG1W5Lpno67EL0l?= =?us-ascii?Q?pAKfkDeaOrnDH8stcx2mh22nqeRaiZTEr1eCd0tamw1gT++yelBRZ54yu25A?= =?us-ascii?Q?TT11VcgAWiDcbyRG7ak9yax8Dr1x9ZMcN+/x6Ix4dnYdlenrq23Mlw3SUoy6?= =?us-ascii?Q?ebpVBUTeI2Dndpyj8MraoceaBUfnpEAXr9CnpN1p0cfrNCk/1sciSx7q44qt?= =?us-ascii?Q?UOwa6aQ5X+T7fzxRVKKWGN/xP8UXHj6TsUpf38gdO5/a+r7F6nfvhbAtXBtU?= =?us-ascii?Q?emiBQ/o1W7sCtqsikk5Np+aBkoUbMw5EkG84Exz+WkneqKhmVyQ2EhB3OZjG?= =?us-ascii?Q?wf1eywjCbWg6C7beKkT0RY4prH4EVCMKZtfA0EDDWti+PalhyJjPAl0E4K4+?= =?us-ascii?Q?eO1NXBP3IhIGsKgenNnCOt0mdnuMhXIxnp7CJjxv2HP8gd76DZIXex3K9KZd?= =?us-ascii?Q?GWDwI4I50mZsO4x6WYMb3/qqRkMG7CvQyKBNIR5vSfgAc59gwnmPArOTQHdZ?= =?us-ascii?Q?j95FiJg+4Fj/8qGsFzbBQQ4bz+nKz6MB5P/ANDNmV4Nq4PmeJcjNxr+WL+uR?= =?us-ascii?Q?jG7Jl53hX6HsdQHNLHvFb2mwEX00tEx2RjrKGpzt7+aBDGBLCMtEsYXdsxyn?= =?us-ascii?Q?q3uju9Y+xB6XwRjlCFXtGqW9bXYAssn2wxbqruC4YvBZ2HKOKlcd/oz0hYux?= =?us-ascii?Q?WT769//UEt+rFLDIjhky+TdA?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 679c1f76-36b4-49bd-5a8c-08d958842447 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2021 02:44:41.5954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 41kSgSOHtYNcXDm+K0vpIlENYuuWLqhngEQBD0zX8XWGlJB7+iQIVlkcrDqtub0okhla1IJRlKk/5IlMLnKqAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1859 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu Tested-by: Benjamin Doron > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Tuesday, August 3, 2021 10:39 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v5 43/46] > KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 >=20 > Updates usage of gPchSpiPpiGuid to use the new interface that identifies = SPI > flash regions by GUID. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiS > erialPortLibSpiFlash.c | 4 ++-- >=20 > Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiS > erialPortLibSpiFlash.inf | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.c > b/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.c > index fc48bdc6fccb..fe8883a8af29 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFla > +++ sh/PeiSerialPortLibSpiFlash.c > @@ -98,7 +98,7 @@ SerialPortWrite ( > LinearOffset =3D (UINT32) (FixedPcdGet32 (PcdFlashNvDebugMessageBase= ) > - FixedPcdGet32 (PcdFlashAreaBaseAddress)); > Status =3D PchSpiPpi->FlashErase ( > PchSpiPpi, > - FlashRegionBios, > + &gFlashRegionBiosGuid, > LinearOffset, > NvMessageAreaSize > ); > @@ -118,7 +118,7 @@ SerialPortWrite ( >=20 > Status =3D PchSpiPpi->FlashWrite ( > PchSpiPpi, > - FlashRegionBios, > + &gFlashRegionBiosGuid, > LinearOffset, > BytesWritten, > (UINT8 *) &Buffer[SourceBufferOffset] diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.inf > b/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.inf > index b959cd1f4612..b8ae214f0920 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.inf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFla > +++ sh/PeiSerialPortLibSpiFlash.inf > @@ -43,6 +43,7 @@ [Ppis] > gPchSpiPpiGuid >=20 > [Guids] > + gFlashRegionBiosGuid > gSpiFlashDebugHobGuid >=20 > [Pcd] > -- > 2.28.0.windows.1