From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.5682.1624844247780180130 for ; Sun, 27 Jun 2021 18:37:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XjqRhmrt; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10028"; a="207691649" X-IronPort-AV: E=Sophos;i="5.83,304,1616482800"; d="scan'208";a="207691649" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2021 18:37:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,304,1616482800"; d="scan'208";a="418990576" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 27 Jun 2021 18:37:26 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Sun, 27 Jun 2021 18:37:26 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Sun, 27 Jun 2021 18:37:26 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Sun, 27 Jun 2021 18:37:26 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Sun, 27 Jun 2021 18:37:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aD+FSxZ2Ta2/HY4jShKfVnws22ybm/rpjAEvH7hduNJ8bxnZpcgnk4tZ+O0LHFWRiGeX12aVWMXVG+DWtrFc57GpCQwxVubzZrP3u6oGBDTO0CufOjHLQdCll6UeHMMDKX3uj1vlJ7XKen/lJyXtvpVLMe//VWV/aSwcRL60rhtIiVi83up5VJkIlKJfW1L+0lhUWvz7x3W//cZTEUGbblyq+vJ+zM7v4sGC54VJSGJP+q7uZ+a0MoqSawWCnuUcQ4Hj78wQGOe472WbL0G1Ju/MYwUiQMFUaenA+peNivTjFnbnnOgnkrtmhvmZd+DX2I3Ug2CLbzJAdbMNLIFzPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ome/O6eoqboGg7AX5Iqt24N38aNNRiQ1V638yvkudvQ=; b=WjpOb/jGQ2b7Vrqjgm8N1Kuv6M6qGMEHWDGu7ufZuaTXaQj0/HU9HjaxjGgZZejLSAEN1SmqhVnIrGeytvbt6MSJF0jnZELkh/5Ng8ob3gMRV2SCmfODoFXBbHk8vyUUZX16yJRa7FBO7+ZgswI4LhxkNneaSseuLjnacmmWOo68Ry2fbgG0TOsozJ8lVuJrFNMO1pQILLRHUXmpXKElZbRY7CgW+E4CJbf2WM7pN6Rk8tAbZA08LbCCd02M+OP2qSo1u07GQXoSaaxNeq93iQiOfeNBqZ8uTKLlyPlh3o2zRcs450WE4dxrb5+QME63KXeWPto4PMmJ+xh2mWq9Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ome/O6eoqboGg7AX5Iqt24N38aNNRiQ1V638yvkudvQ=; b=XjqRhmrtg4nxQ0iYCi7fQ2wsE3FeVsTGObBLPdZ/iaOtPSjlVfZOBdfEck5E5zRrCfHjkP8hWnL+b2iqFEhDJ67vimoPZJbYQEn3NXK3en1lMnxKbvnbixRAnRBRdSWPRQszmtiNOc0gwSk8IsAZrLCjvEex3Lt9+Bz0MQa29OM= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB3858.namprd11.prod.outlook.com (2603:10b6:405:7e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.26; Mon, 28 Jun 2021 01:37:08 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2162:be61:a479:4168]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2162:be61:a479:4168%7]) with mapi id 15.20.4264.026; Mon, 28 Jun 2021 01:37:08 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 17/41] KabylakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v4 17/41] KabylakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs Thread-Index: AQHXagg8ExYkqZZpMEe9D5H8i4BTl6soqB4A Date: Mon, 28 Jun 2021 01:37:08 +0000 Message-ID: References: <20210625212120.235-1-mikuback@linux.microsoft.com> <20210625212120.235-18-mikuback@linux.microsoft.com> In-Reply-To: <20210625212120.235-18-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [114.43.34.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a4057566-75c1-45c3-ac44-08d939d53e3f x-ms-traffictypediagnostic: BN6PR11MB3858: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ll7LGkNfG3FYueXND9BoYx5WVI3wRiI2QX//5s7Cw7HB+1/6pSl1zyTb9mpLuJs6PwQI9Cc3a/26gjwPvKdPUoBFR5AmN+fLIsNdLbsMZ/m+pMiJ6xM4oyex25rP/ndOUk0xT/DJvGUn7F4COKgrnXDOpxePaJwNEqlIYVAWNZ3MmHsaxSX++ctRHONdWqp9UJ70FXbFAixpmEau/Fz1KDqgmWf+61PyHEhM9dSQ0hecnSStueaKzI2f/8h7nsTe84iLZoO3XkoCiVDAbgcq53LjuZeZEDqTHngAAi4h1649HDE5cyJV04a4dK25d+PhweQCmkzp1pAbx1mkQ6bRU3iQjIr7vnZsr9Ht2us9EMcsJqq1xUh66/m9CkslUqSnxcm9/yJ1O/FvzpJx/pvG2PkF8hqSxYJrr5MXm4SSMmwlgiQYxEdBc0d4GpeDkjwZY3+hSiyna3dgOD6sXLvXAaEC9Gc6OvwwOqTxKfHsMtoJcL34QeioiL0F+4/RMX9Ycx+GfezgbN0t1IWUtDg2kqKK9FDPJLow2gEc1ZiFAVT+9bocGVmQ0gBYPR9Ylb0PoJS6YASL1U6rCZ7wQh+dIOxbPY00IVUHaFFMfmbvfYuvh2aHVN4Evt+61lEaMYeYckblI7x9wohoA6XMVTK2ep+YeDJ/cCFLZ73OcD8wOmFRYLHr2p58jBmM9hemKUgYegORX1d3N2Qniz1JaygmsgsWZQ9Tvu8IE17f1tp6bqv/DLjlSpncniKFbbCl2oLH0Og//5MSYbS135YOTnjOl59SIjIuZO70Wpes6eI8izWs82eGXSMY+wTZD939jIDe x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(396003)(346002)(376002)(136003)(366004)(122000001)(52536014)(966005)(71200400001)(38100700002)(55016002)(9686003)(316002)(8936002)(4326008)(6506007)(53546011)(107886003)(8676002)(7696005)(2906002)(64756008)(83380400001)(33656002)(186003)(478600001)(54906003)(110136005)(86362001)(26005)(66946007)(66476007)(66446008)(76116006)(66556008)(5660300002)(11716005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HFEZ6YQdlgvfrqenk6grx8x3ZDiKRWmcIN7gkOcfEf0g3rjyQLgFrJDbke4P?= =?us-ascii?Q?K1Xt9PbF8srKs0nl6J9PbP6pSB9odvQYhb2N5ZjwoTsLj/JiVtB+2pG3V/qE?= =?us-ascii?Q?cuvHJTDdGfFFDZUxLfYhWVaXBbDxTWMkC8t11/TzKkIvLsK40HBPlKBvIMHp?= =?us-ascii?Q?iHx5COQp3V5atT+iEeoN0zxcAuPNgql9mkHvn9QU3iDZGBnXBHpVsnB2SxZ3?= =?us-ascii?Q?fjXZnVBvMt8oZ8HkXhy3gfF6oiN1aWOfvGOAj2uFCH8NIdPR+Xf9h9DLqZ9b?= =?us-ascii?Q?07cED8nLkpxzGix2baw8rxrCC7gXcRD++VRA/BfofoYGiLPj+R1+Ps9uoSbv?= =?us-ascii?Q?5mokREMhithokK+MJ3ZYpohgSsPL0+WueuE+A3LhgekGLcK/PDobpLjP1pTK?= =?us-ascii?Q?UZe4NEGdVWs941wJ9mRLTxY6GULN3d24cxmJV/3LUVJUMFzbgofDsMDit145?= =?us-ascii?Q?4N+ej2QnNolAJ0Ih8MKWOoPpt+FV4fiY35P06NyxiAWEwogii1tamcp44+5S?= =?us-ascii?Q?g7tiII/O0vpKh5lbqIOO03U7gipuAjZcy/eF2xYLanBWC5gDuYo84Jk/hfgB?= =?us-ascii?Q?c7bZ//IRqNg5kziDCFV/C/fD665WJN3qbsrqbIwzqhKKyhDsb+6ix/Yn12bo?= =?us-ascii?Q?bdyvVwFNNI4AE0W45dDoMa5ETFlHROkzJRNr9QJ5hA5OMPk9iPlmHzLq2zxT?= =?us-ascii?Q?Axt2a4DZqC0GnKi38kYTYCEKEoP5c7EYnVmoz7tqXG3Fb1D4C2M9zuoxaJ9H?= =?us-ascii?Q?hkEwjeK0tE81lEdvemZcLXWXJs/hd2vCR53NmCGRpFRIFbf2/eMfZaLqNqgr?= =?us-ascii?Q?asWrKQS7A8BK3Rw2ND7rrGXmBxCwvIB3x2sO6qWCVrk/DpX6t/u6HHw9llMp?= =?us-ascii?Q?imW8aNa8PjAKJWtaBBMskGqU3849r2SlnEFpNmDzs+jXN5a4D+H2oAhJRm77?= =?us-ascii?Q?VFslWvZT1XgjF1Aa5HtkGsmSKZ1RUzHP2QaTBg0E2hcFH185rPwmW04xOdZv?= =?us-ascii?Q?HYxfo5wjPg10Sm3kmfb906CwSjDb897EZM//CzUM2oRcoP940uM9CmDrsLjP?= =?us-ascii?Q?4miu4iHnYBjda1i9qeNp5Rjg121CWU23g67lKyEJ6F6DhXilT8YKfive8HYQ?= =?us-ascii?Q?7JespvX1IigOpw9CvWvkESYg29fIOJGHu/HluoXrpYhZVXbRXwoOGrJ1DpNP?= =?us-ascii?Q?6gkcyPwldX/5ZuKQxrO11DfrpVEMJ9DQiy2OHDq4X5IFMfZOIqLhqlYBbXIj?= =?us-ascii?Q?sA7URaynNNfolD7dNo6iheJJ0rQ/GIW4JeVM7NCI6YvPqebhRrBXye1oa6cY?= =?us-ascii?Q?p0ecJixjSOzQQXep34m9cDYe?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4057566-75c1-45c3-ac44-08d939d53e3f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2021 01:37:08.3658 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zD440dVafj3ZBCxdAPcEp2RjwT4ZTkXJx5loM8tDjA1IzGINAOJBkmag2uqc5rzeciQAX+Dky0BzW2WygDtNcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3858 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Saturday, June 26, 2021 5:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: [edk2-devel] [edk2-platforms][PATCH v4 17/41] KabylakeSiliconPkg= : > Use IntelSiliconPkg BIOS area and ucode PCDs >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 >=20 > Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs = are > declared in IntelSiliconPkg.dec. >=20 > Cc: Chasel Chiu > Cc: Sai Chaganty > Signed-off-by: Michael Kubacki > Reviewed-by: Nate DeSimone > --- >=20 > Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicy= Lib.in > f | 4 ++-- > Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec = | 10 +++------- > 2 files changed, 5 insertions(+), 9 deletions(-) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPoli= cyLib. > inf > b/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPoli= cyLib. > inf > index d3b4d9e318b8..3ca373a23c0a 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPoli= cyLib. > inf > +++ b/Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCp > +++ uPolicyLib.inf > @@ -45,8 +45,8 @@ [Ppis] > gSiPolicyPpiGuid ## CONSUMES >=20 > [FixedPcd] > -gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase > -gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize > +gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase > +gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize >=20 > [Pcd] > gSiPkgTokenSpaceGuid.PcdSmmbaseSwSmi > diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > index 3881671757a3..5ff7b39ca60e 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec > @@ -63,7 +63,7 @@ [Guids] > gEfiCapsuleVendorGuid =3D {0x711c703f, 0xc285, 0x4b10, {0xa3, = 0xb0, 0x36, > 0xec, 0xbd, 0x3c, 0x8b, 0xe2}} > gEfiConsoleOutDeviceGuid =3D {0xd3b36f2c, 0xd551, 0x11d4, {0x9a, = 0x46, > 0x0, 0x90, 0x27, 0x3f, 0xc1, 0x4d}} > ## > -## > +## > ## > gSmbiosProcessorInfoHobGuid =3D {0xe6d73d92, 0xff56, 0x4146, {0xaf, 0xa= c, > 0x1c, 0x18, 0x81, 0x7d, 0x68, 0x71}} > gSmbiosCacheInfoHobGuid =3D {0xd805b74e, 0x1460, 0x4755, {0xbb, 0x3= 6, > 0x1e, 0x8c, 0x8a, 0xd6, 0x78, 0xd7}} > @@ -264,7 +264,7 @@ [Protocols] > ## > gEfiSmmVariableProtocolGuid =3D {0xed32d533, 0x99e6, 0x4209, {0x9c, 0x= c0, > 0x2d, 0x72, 0xcd, 0xd9, 0x98, 0xa7}} ## -## > +## > ## > gSmbiosProcessorInfoHobGuid =3D {0xe6d73d92, 0xff56, 0x4146, {0x= af, 0xac, > 0x1c, 0x18, 0x81, 0x7d, 0x68, 0x71}} >=20 > @@ -453,13 +453,9 @@ [PcdsFixedAtBuild] > ## NOTE: The size restriction may be changed in next generation processo= r. > ## Please refer to Processor BWG for detail. > ## > - > gSiPkgTokenSpaceGuid.PcdFlashAreaBaseAddress|0xFF800000|UINT32|0x1000 > 0001 > -gSiPkgTokenSpaceGuid.PcdFlashAreaSize|0x00800000|UINT32|0x10000002 >=20 > gSiPkgTokenSpaceGuid.PcdTemporaryRamBase|0xfef00000|UINT32|0x000100 > 28 > gSiPkgTokenSpaceGuid.PcdTemporaryRamSize|0x2000|UINT32|0x00010029 > - > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE60000|UINT32|0x3000 > 0004 > - > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A0000|UINT32|0x3000 > 0005 > - > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x00660000|UINT32|0x30 > 000006 > + > ## > ## PcdEfiGcdAllocateType is using for EFI_GCD_ALLOCATE_TYPE selection #= # > value of the struct > -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#77114): https://edk2.groups.io/g/devel/message/77114 > Mute This Topic: https://groups.io/mt/83794799/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20