From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.3914.1678873782942472538 for ; Wed, 15 Mar 2023 02:49:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Q96c3FRo; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678873782; x=1710409782; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yI2bRpG3+uDw/nbSiK4JG9VuCU1wili8BN7z9Z3HK3I=; b=Q96c3FRoNMxut2rzlqWnch+I60nYdzzp0BABd6i+mSQ32hQJA6O/YP5t NCpNIfIO9wlsYtHJSrI9gQV7b7JW2bdmVcTMqPnMwnTZuBzGjDyHmFm6F B+FMjCddXL5N/q3aMPmqhR9bw6g2X7u0Ot79RJlL8pMusDKa3DRNiEpJX 75WvsVIPaG+QzZmayxiMeWkaBvZlh+NWTm3oFA/AY7fjH3HkLMu9U/u4r a1W5z3RePebqDwVZwQRCHhzhYgim1lqPPw9jZKGBLY4PlLZEUD+Pasd8E x3IVvIoHTXKZBzC48a6LhpdmHhP42WTpOA50i/Uawu4YiWYJ/hkTq+1hM g==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="317312304" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="317312304" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 02:49:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="629392245" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="629392245" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 15 Mar 2023 02:49:36 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 02:49:35 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 02:49:35 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 15 Mar 2023 02:49:35 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 15 Mar 2023 02:49:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBJ+1tw0+KYvFVlZ8bzPO6flWY3UIpzoVI7ruQ6yd7puozIENu1inA654OHWGtRYmlTSJG0i5gub9dWz8yzholuiGNEMbESO4bFZMt9DzJLag+2erqlmp3yc9geEff4Is1YKSbE2iCETH4OuH823fhMjNPf+9157ZQikiJ9juD4PzvxZPbfX8k+napGzrl0iWGApmjBPIp8b5Llq+BLiUInimpI6IyOgrNSXSwX1RM31PM4mhNlt0ronBkiUWpqU2N7t4cTJ2rFDPzb1qzjfC5iBonO5CKSK6kIiCaj32W+LdseSFZrLzEfz9i47X+Ytiozk92akluuQ3dRmz3w3hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VBOOlAGZyeJfp3sFGAMxBBThY2gbfmszWEZamMs3h6g=; b=UUr5V2PlwnLA8kPPf49ohsNJwZIE+NG2v0ZtFWkbF5nU2qrzMWq1VjAFfKiDwfOC3ioNZ1mA2QC1yvHKBAokmxGd5vzM8nRHZb/WtKfdwxK93bDotQ6Q4ESUDMP8v5BZUc1THbBy2tVfcMGvysMjCoI0hSBiSla8qO6W9+pkfRnHXzgaQ+Bq1jLpVMwEXRWWnBRzn3iB6sFaqF+5VPfJSLvW0MLqOiVE1C8D+W8tPhUKK/O98/ccG6TG0B0K/YMPlsXoK2nyZE6rN1JZv77tpAH5YkxjgwrZYw/phP665AoX85mEhG+TfqoCE+q/dr1shz11hxcm3GftgYPSZLs9qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM8PR11MB5574.namprd11.prod.outlook.com (2603:10b6:8:39::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar 2023 09:49:33 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc%8]) with mapi id 15.20.6178.029; Wed, 15 Mar 2023 09:49:33 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V2 09/14] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter. Thread-Topic: [Patch V2 09/14] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter. Thread-Index: AQHZUaYQLaZoSJ4V8ka/grwfssN7HK77YYiggAA+ZAA= Date: Wed, 15 Mar 2023 09:49:33 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-10-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DM8PR11MB5574:EE_ x-ms-office365-filtering-correlation-id: d3f3572b-c687-4b68-decd-08db253a94a1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6lQzqEnRSltfbl8/76IhQ+NKpIqSmb5LRzGTFoQ5SGzil6ip7LlQuMzeJ0IrrynebtEghmyjX9eoe+auhA8EppgkAFOus8RyPwjAxoTsdil04mMrwyyZB7KCkQdLHRVklOn6LNOgWYZai/scs5Lwwb+uQwAg6Efh8ToQBQzBBUJTSwnsHIuPGYZ9Nh2UaPsS6AGJlwdAusOkCjPD4aepZSaFB6g/a62TQrRx+H8/qobzy9A0CpNU4uQQ96IprIbF5MxTDUAeFUfykoY4WlLOiM0ujSWFlzil0WhAUwFt3/jiNsjUpD/0nrsp15EfGf6FYMALs6dvbdeHUJ5WVRfd4iNMdvoe0AiH4rllLFvpJT9tZnjTxKvqJoaGrlbQIWxsH/moj6TEm3x4rcNVTtVv8E22yV0wzlTX5GIV+khcgyoW1PrZvR7GtutmUROhDRgLefnNLkjH4V4hjFHC52iXq3f+N8hziZjr6AKPf8w0uAGAJiIvYWRGzVHZWHbuEX11um7qBrgSe/d9c0PIVy0+Wz3DBPdfayVMFqJk4uX15ayZ3gqSLTgpJ6GZkIPKzBj1v6/0TCZkzsCwhyn/cCy9R7f/TMiZ3KFhpu4HELzGiB8KQ3Ut6qp48gje1oVds2D+aon4X2mt5E4aPPYl/Ar0be0ycYuK1QQ50ipmEDeaoP9TGcEX7Ya7gkeSn0gtTSNFzsSLiukwxGgU829Ygowpzw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199018)(5660300002)(4744005)(83380400001)(478600001)(7696005)(53546011)(71200400001)(9686003)(6506007)(26005)(186003)(66446008)(38070700005)(76116006)(66556008)(52536014)(66946007)(55016003)(64756008)(33656002)(41300700001)(4326008)(8936002)(66476007)(86362001)(54906003)(110136005)(316002)(38100700002)(82960400001)(122000001)(2906002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q/uku8OWlnHdc1KTunDoGwkQP4RA24vjrz9T72iZQdUQKWcYB8xDw8Rw9UKw?= =?us-ascii?Q?HLdl8w4Sl1/O4usSexL9fkIhWZGuJBdlhCQGosBn3txTSS/JFzRZvlQV2g3Q?= =?us-ascii?Q?NrOfw2Xr5vESvOlT2aDei3dgaQYMBFOp2c0kIo+YgFIuLNHAgoEHfRY2bCrt?= =?us-ascii?Q?rUi++QGlAdGQGBv+VBjMjYQ4QErbVMnPiUAWVOqNzy3r1ydYm8wH5XIVQsid?= =?us-ascii?Q?ZmDst6CKQbEuSZTCN5V2+3Y4el6mg1cYdoTlZCuqvJ2GHFMPb6V9Oy6F7rVo?= =?us-ascii?Q?+xSxA0T+CF9e+bTlb3qyIZJfzv3AL0q+UuennSPEqYu4dqSwJOmFgm2oD0zY?= =?us-ascii?Q?W74J8P+E/fY6T+5F1fX1nHfROaUE7qD64kHJLWqXq8G7UwFaa+9KomS4nWuN?= =?us-ascii?Q?VuZesOy1ihtbk5knUfyHmaFSocHu/q+YYnaZg5zIvPh8iKS5wPLCNd+3Z/Dj?= =?us-ascii?Q?D4U0M8qVb2fWGRemTwdxj2Teu8h6FRkvt49IajozfEEDss4sYhKwiuSHGvPy?= =?us-ascii?Q?nmRs648feo0q2Q27yGkfVpRJYrotqvirfDgNwZXpY6ZnwgYTYdt3t8s56/mx?= =?us-ascii?Q?oIZTPIA6+P7mz9icaO0uVNsGThUka2+Hpvz0yp0hFw6MGC/wC+ukAJ3x7uZ1?= =?us-ascii?Q?+5084R2C75rgVPTGwN2U/4LZlGRkBVhMVgH3yLBSskWmoat1udnaL1UsJJiM?= =?us-ascii?Q?L3283nVDvfItq6JWGy3hzvvaaE06daxxZoHQRayu3W5FNNr0IE5g4/jOp/ou?= =?us-ascii?Q?OR9zDg6Sle3unVnhSr7PkoCHLH2zPm20vxA81PnyAqiPWHrSsdX/JZe1n/YF?= =?us-ascii?Q?1pdmbDbVzN8vLADmZRNVyYv9ObKF8uiIAelRKzHRXxR7+zfH14IeUrysfqMb?= =?us-ascii?Q?J6trzJ/Ns9/Q/os6pnbE6iY0NwoLPqHpgX60MUNjw7iiahYf0ySs+xvDVw2R?= =?us-ascii?Q?3hLOSHOipS6v1MoPYPsvaHbaHMzcMIj7SPTf5zTgKjdxI8/D0RTSZhv4EdEF?= =?us-ascii?Q?/tTiLDY4LoiM66gOILG6+Z7J/8/f0b7k6kytjEQ3AwDeEQmGPuO76aR5S4rS?= =?us-ascii?Q?/cIpntSxc52Zucuss3uNV1TU74wo7PfdEC9+mcIqVTD2o+Y2MV11477Qne2r?= =?us-ascii?Q?g7eFxFqDz2cr5BuykKKQW/rDDCrtFbfn0wiLFjb9D2Sz/i+hk6Nol4V7gwSn?= =?us-ascii?Q?E/YOwU+EXRDvIguPXUXYB7+Bda+9MERppOk6nNg/rGH5vUybbRs/kaVf5PWI?= =?us-ascii?Q?yq05RxC924KaNiTtmfT8ezYhMDJDyHTWArwMNYsW6MMy/m1wCc9FQG2iLq2J?= =?us-ascii?Q?NYugaPdAqLADPWNl+0uCcyqwD1s7d4JE1igVbYRwjEidT1VVrzey66O3GxWX?= =?us-ascii?Q?UbALs7JIazjkMGUcCVGIGKi2/LQQszVqg7SXHO5oh2nal+LoOVzwobKECjXL?= =?us-ascii?Q?q8pLaJQq0F9g5oN+VDIQUAYmbiM3Ul3Q2EWJYa7nJY/YXhwH668Fx9G3QQe9?= =?us-ascii?Q?p3xgJ7E9fbBxsrZD3KDhPxWMg9MmLA5oj6saYNc2eB5EGggn2he4XufHnFr+?= =?us-ascii?Q?GVqEC5nSY+xKK8ASMGEz6+C9484h9rpMIU9JQ1rh?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3f3572b-c687-4b68-decd-08db253a94a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 09:49:33.4555 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cSKvhdFqFpNudT66nCfwrNu1tnFL3IwPFrX3mRgcEKdD8LkPzJMf5UI5LLMlMkciZJZxfOw5euStAPcmCCs5Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5574 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the comments. Will change the code and add the comments in next = version patch. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Wednesday, March 15, 2023 2:02 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [Patch V2 09/14] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModi= fied parameter. > + IA32_PAGING_ENTRY ParentPagingEntryContent; 1. how about "OriginalParentPagingEntry"? > + IA32_PAGING_ENTRY PrevLeafPagingEntryContent; 2. how about "OriginalCurrentPagingEntry"? >=20 > + // > + // Check if ParentPagingEntry entry is modified. > + // 3. Can you add more comments to explain why checking parent entry content i= s enough? > + if (ParentPagingEntryContent.Uint64 !=3D ParentPagingEntry->Uint64) { > + if (IsModified !=3D NULL) { 4. Can you always pass a non-NULL IsModified to MapInLevel()? 5. By the way, it's good that this patch doesn't enhance test case to test = IsModified return value.