From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Hsueh, DoraX" <dorax.hsueh@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Oram, Isaac W" <isaac.w.oram@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Dong, Eric" <eric.dong@intel.com>,
"Chuang, Rosen" <rosen.chuang@intel.com>,
"Kuo, Ted" <ted.kuo@intel.com>
Subject: Re: [edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib
Date: Wed, 26 Jul 2023 15:00:17 +0000 [thread overview]
Message-ID: <BN9PR11MB5483FDDB9409F049176F5C5EE600A@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <91966a5d364d469145becb9ebe7d971a2c8015f4.1690181689.git.dorax.hsueh@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
Thanks,
Chasel
> -----Original Message-----
> From: Hsueh, DoraX <dorax.hsueh@intel.com>
> Sent: Monday, July 24, 2023 2:43 AM
> To: devel@edk2.groups.io
> Cc: Hsueh, DoraX <dorax.hsueh@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>;
> Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>;
> Chuang, Rosen <rosen.chuang@intel.com>; Kuo, Ted <ted.kuo@intel.com>
> Subject: [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib
>
> From: DoraX Hsueh <dorax.hsueh@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4508
>
> Remove IA32 only dependency, Because we need to support both IA32 and X64.
> Apply to a modern platform supporting x64.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Rosen Chuang <rosen.chuang@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Signed-off-by: DoraX Hsueh <dorax.hsueh@intel.com>
> ---
> .../PeiFspWrapperPlatformLib/PeiFspWrapperPlatformLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib
> /PeiFspWrapperPlatformLib.inf
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib
> /PeiFspWrapperPlatformLib.inf
> index dafd17dc..489b34cf 100644
> ---
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib
> /PeiFspWrapperPlatformLib.inf
> +++
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib
> /PeiFspWrapperPlatformLib.inf
> @@ -51,7 +51,7 @@
> IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
>
> MinPlatformPkg/MinPlatformPkg.dec
>
>
>
> -[LibraryClasses.IA32]
>
> +[LibraryClasses]
>
> SiliconPolicyInitLib
>
> SiliconPolicyUpdateLib
>
> PeiServicesTablePointerLib
>
> --
> 2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107271): https://edk2.groups.io/g/devel/message/107271
Mute This Topic: https://groups.io/mt/100333272/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-07-26 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 9:43 [edk2-devel] [PATCH] MinPlatformPkg: Remove IA32 in PeiFspWrapperPlatformLib dorax.hsueh
2023-07-24 9:51 ` Hsueh, DoraX
2023-07-26 15:00 ` Chiu, Chasel [this message]
2023-07-26 16:10 ` Isaac Oram
[not found] ` <17757707CC86C58B.21334@groups.io>
2023-07-26 16:16 ` Isaac Oram
-- strict thread matches above, loose matches on Subject: below --
2023-07-24 10:07 dorax.hsueh
2023-07-31 20:44 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483FDDB9409F049176F5C5EE600A@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox