From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.2740.1658351224761153653 for ; Wed, 20 Jul 2022 14:07:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Nbx3W9je; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658351224; x=1689887224; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2dJnenxGudyi0D3w95IlcQiJTqKel4c3NkjI/QsBtmc=; b=Nbx3W9jegSQHUlSpmN8e9z6giaXNlqCU4d8wd2pzN852RPoa1w55d5hE /a1tQpIQim1m4om9rA34C9X05Sos68TesoYwMZ3Z5yxFGJDP1N3wbXVqf bkne/xlCxKVntVhkgjmKWm1nThthYvQinZ8uHAsv+30uRx0fQlpmRYXVf ByCrKXPxdxC96qaxtZl6mds2dJfT/EtJEq2HVzp1RwMadjDIMifKuZmSH +BTZEsR//V/BRsEggCkDOu7BmFGNiUp/ORunAdT82X9AyKZEDdAyu15nC rsVx3lMB0i1nzVOkHQ9vCPK/tEbUjX+3hLGQi4rKvyZlamguNXdIFdzBM w==; X-IronPort-AV: E=McAfee;i="6400,9594,10414"; a="284441828" X-IronPort-AV: E=Sophos;i="5.92,287,1650956400"; d="scan'208";a="284441828" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 14:07:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,287,1650956400"; d="scan'208";a="740431988" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 20 Jul 2022 14:07:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 20 Jul 2022 14:07:03 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 20 Jul 2022 14:07:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 20 Jul 2022 14:07:03 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 20 Jul 2022 14:07:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C0jgtMcmWT6b6Fd7JkzBQC0ZGCPgV2yGOrZo+8DJVA91gBFLN9xUUqEi65+QMAy/ttnvAZ1BZadls1zZEVZ8tQdRZjoWdSK6WKJZHx3fYJdDd3TPWJro2cgoUULGSVYSs+9MEcGlBEkGo4YOUNHT3D6f3in6TL8GDQy3fdxM8l8ee2z5VcdfyyBNxEGDzJZdStN4WU/X/BMOsLhFC595C/p9GoTW8g9wPh43rBG9uVj/97+1eEulgRLaM0R9Wb8WU+NhGUFZnJLWMDhnhdYf47GTYDXXFxgcqs+NrKcmOOaADIenWrfeCeCYtBv00GjyNN9iDA9s11UsBO+N+JDYEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=53iDqtYOEsz65y8JELy1KX5ZYi4FdwwLRPkUvpBPQe0=; b=jOfFfItoq+WNmX6tYQC1lRAn6lqSGU8TMGPY+sBIo70ZwoUVp+mIr/Z1wU5FWKv/4pzs52uo0e47YIdNpbHGfKPA/ME+VpLevuvRL6qG6QcGunUgA5oYDnGjyBmLVjjqoHQtVZQLNrh6AUKTy8AHb2rWfPT1fBsFm/JKkSZbOhHgW+N7XJuAslgciObpRy3X5Y8bQZGUetFnDwiVTxOMwxw0aODTSV3A+6LTIi9gkHtWdbzcy5V65R71gpDech5BUhLZAq9oZB680l8RgX3GfkKhTQdPyHzrdoxGsCXMUA/v2i5aVnXE1ZV9eVkBYThu6Xy3xRCeHRf/6B/S5nhhxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by CY4PR11MB1590.namprd11.prod.outlook.com (2603:10b6:910:6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 21:07:01 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::a113:c892:d94:dd10]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::a113:c892:d94:dd10%8]) with mapi id 15.20.5438.024; Wed, 20 Jul 2022 21:07:01 +0000 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg: Add FSPI_ARCH_UPD. Thread-Topic: [PATCH] IntelFsp2Pkg: Add FSPI_ARCH_UPD. Thread-Index: AQHYnGs0BsKwX3jPm0SxWVlJ42RvXa2HvEIAgAAEENA= Date: Wed, 20 Jul 2022 21:07:00 +0000 Message-ID: References: <20220720190134.3734-1-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9cae4c98-649d-48b6-0f73-08da6a93ca1c x-ms-traffictypediagnostic: CY4PR11MB1590:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IBaXQecO4rH4FtSNgN3v8Nu8Ixp+/q+xd7mkNTElMisfUKWDi+nhVIFe95cReau3nwIosOG+OJrRqVWuyknIfLog/LXJih5eIUEA6DyOdsvA2zmhKSbmlsFGTu87uyapGWNQ4YX7WIzznm/6BUUK7v7DQyBn7tzuRhO9D/4SmlUX4pb7dA4mmuoOBmjGxwJvq+eb7XlpeuMGfHSBow01K8uiMzbazDzEs0dZ2s8rbg2TXtsP1u3BDlmsZf4HncCfmudBd5CoJiBnBtdBiv/z+8pPOVPcSlpkl+4r4SCx/dOXmcA3Z/6iimHi8D4zBZ9SXOEFCXhj5A1qxlnBdVYtpP620sdfZErusOwvglfvFrGWXTWvjWR1aGhtXa/mub0wtZKBSKoCX5vMgc27XP3TPP1UzQ0yUWm43O0lx0QdwX98gTqeGYYwdLGfa0H8HAEU3AyErCo4G94jDUj7JOTJzRsdZKF8QCvYaXq3+LkCsLNsuNGoKRxTc4zeQ+8gnu8xwtYgPsTmxGkdvx4etM7blHyDYYGr6ed0QTWBF4fO7z34apc2c3eIGzsD+fGqT1JvTF4GznXcP3F8/HezLWk9SVyBnu4p0LZG4QxAbZNgO9cxITd/5+vQmWPIs0gevMqOuRC/L7XDKR1j3gwZJGDDFvCGj8eoAwr0GlUwYmzlEMKd48K6ZqFsrGYLLJj5VECAEaBlq50S45e8OotuzUN8pNAMr985PeZYU77jOREZUd344W95QWYS21JciJcmTVTL6JZA1nMC283OvlH1C9i0khMYWkhNx0uXte5jJg+ByEy77eAhV5O7qcK+iB6SZYQ+R0lD8W6Fsk9z6Tug12N2dQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(136003)(39860400002)(346002)(376002)(186003)(110136005)(19627235002)(82960400001)(9686003)(86362001)(38100700002)(66946007)(107886003)(64756008)(122000001)(66446008)(76116006)(4326008)(478600001)(8676002)(38070700005)(66556008)(316002)(83380400001)(55016003)(966005)(71200400001)(66476007)(53546011)(2906002)(26005)(41300700001)(7696005)(6506007)(33656002)(5660300002)(52536014)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fOEQeUbSNLxomcAydSi4LuUBtkoEr8g2o/6SMhjbudgaqzC/DNg3rlW2CNxW?= =?us-ascii?Q?+UyIGXO3D6bl8tFcg+Hse+2XIR1YOktIb3yJxhDK4O0g1GGJgoDdHqlu2Cut?= =?us-ascii?Q?f13ML8spmOXnae4IeQps/J2sXVUCrrji5AWRUx2vKF44pCbF7BltP2VBfOXC?= =?us-ascii?Q?nl2DOC9zdPqsO7VdZQuGTEsKmj9+j8BUgGlb03PiHVKAihoskJzE7FrcGyM3?= =?us-ascii?Q?7C++n/BEksqUpSPqblq8q/CgDkb31OcDDtgWeONK6ELGeRux3ANAeliBmYIg?= =?us-ascii?Q?KS90q0DVz53Jf8jHQVnLiXwDAc08NXP2dFRyqAarPVnWHrPYmADfgfeXSRIr?= =?us-ascii?Q?p3caAwuImSqzDlYeeOb1bOOkyI+VliHRqob5Me/NxiIPHi6/hZBkrvnVypD9?= =?us-ascii?Q?tb+FYSf/WdUddmSWY/H1JGObKUhKFHTHcczqdzsu82lnOQfSDdJoJtgJUYip?= =?us-ascii?Q?lPTJyCw/tsnebWQznMzr3L2LrbbGhNDudLXOFNwd/qjotamuVxX7KoT9OXub?= =?us-ascii?Q?F/ujGRZSovVcj3D7Ak/BTGz5f5gZsKdVdUZflsCH+bJM0EUqxvv7cbWmfxRm?= =?us-ascii?Q?Li/vppbpWHGSXchjXU5bO284VJJwzDi53HkzYPh6tuZmvol5MqmYeO6y8W9l?= =?us-ascii?Q?q+3XPSTN2Yz7Mtj10wP2ieFpKIclFXbDaA5O9M4lnndZ64llFtO0hpRBAVS8?= =?us-ascii?Q?VTFJPhQfV3OubOS5XGEzDN1MJWIrOrnTDQTwfRQ9azDwTbm8dE0ZQoTjj2zl?= =?us-ascii?Q?d4ulDZ8EiEg0TlHsn+zb/iPZfYjx/YVqFiIBn4AD6AoYquswKT4ZuNahWDJU?= =?us-ascii?Q?k+JjzWIRLC34xWBOxn3C066jipXiw+Bi/bd3DugE+/j8uWfkueURJU9FkpDV?= =?us-ascii?Q?2fcxReed6BGnExPTFWLRoF/zR6PGUwuQ+vS8t2mCepcu3Ue9ariJjBsV9y0L?= =?us-ascii?Q?4sraFJ2KUnG96EgA27j/EKxcOKJx5AZ9C35J7vW1FCMhH83U9IPtqwS700Q9?= =?us-ascii?Q?PjSX3lIFd1DI70EKt4q18YRQe2VEbGA4l0VU0CDUirQDx3vbInAqBfQZNYPD?= =?us-ascii?Q?c+1VXNGoaCMbg/qnxKms+REua0infPHbwwy7+xUnsHjGYO+pj65hk24olGYK?= =?us-ascii?Q?pLiPHn5s7/7yyGSror8GbsnROqJMty5P2njHS5aynF8kMj2J+Uf8ERxS2Amc?= =?us-ascii?Q?/6WHw7HxTcA9PQqQKxIJEEO5Gq92jIvaR+pHFm2+TRHT+Yps9KTYBiM20BcO?= =?us-ascii?Q?wO9X3OukE39Y+Kkx1dn/mBywBLY9qhlGrQ+u6jELRn5vVKdVnxCPIkXg8j1Y?= =?us-ascii?Q?GbMGigkLQjqBOsd6o/CBpu14BbqNiK3V4aF7MLWghXHse1VBw84rHjXGkz12?= =?us-ascii?Q?wLFoKmUelOFS/OVE8BTYshphKB+dNCdU8umFYGQI8MgxDPgUOHPer6xofI8R?= =?us-ascii?Q?QZm/NLhpV6mWPjJ6XAS5QNCcaNDPq70HjcpDJu9tQCkfWqVIUgQPHbbqNvGW?= =?us-ascii?Q?EewSFj2XJ0PQgFps3QXBXFMcvJDFbwE8jaEDbVbfb7oswxS8P9be4mjHTUUS?= =?us-ascii?Q?I4yA2woADEhnxYXWbnefLJAb85CSHDOsNqmJJEp7?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cae4c98-649d-48b6-0f73-08da6a93ca1c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 21:07:00.9607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7kamugbN8HyJeBfvfXqJt2Y+SwC0a7TkEeL0e1FNsEjaeNRBjpVVXn7t2OKeIbZu0x9ih82OuhsPn34/KSDirA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1590 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Nate! I have sent V2 to add this comment, please review again. > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, July 20, 2022 1:52 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Zeng, Star > Subject: RE: [PATCH] IntelFsp2Pkg: Add FSPI_ARCH_UPD. >=20 > Hi Chasel, >=20 > Please see feedback inline. >=20 > Thanks, > Nate >=20 > > -----Original Message----- > > From: Chiu, Chasel > > Sent: Wednesday, July 20, 2022 12:02 PM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Zeng, Star > > Subject: [PATCH] IntelFsp2Pkg: Add FSPI_ARCH_UPD. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3993 > > > > Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION bumpping > up, > > and some comments for clarification. > > > > Cc: Nate DeSimone > > Cc: Star Zeng > > Signed-off-by: Chasel Chiu > > --- > > IntelFsp2Pkg/Include/FspEas/FspApi.h | 69 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > ----- > > IntelFsp2Pkg/Include/FspGlobalData.h | 2 +- > > 2 files changed, 63 insertions(+), 8 deletions(-) > > > > diff --git a/IntelFsp2Pkg/Include/FspEas/FspApi.h > > b/IntelFsp2Pkg/Include/FspEas/FspApi.h > > index bf46f13f73..ad5d62c385 100644 > > --- a/IntelFsp2Pkg/Include/FspEas/FspApi.h > > +++ b/IntelFsp2Pkg/Include/FspEas/FspApi.h > > @@ -1,6 +1,6 @@ > > /** @file > > Intel FSP API definition from Intel Firmware Support Package > > External > > - Architecture Specification v2.0 - v2.2 > > + Architecture Specification v2.0 and above. > > > > Copyright (c) 2014 - 2022, Intel Corporation. All rights reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -100,13 +100,14 @@ > > typedef struct { > > /// "XXXXXX_T" for FSP-T > > /// "XXXXXX_M" for FSP-M > > /// "XXXXXX_S" for FSP-S > > + /// "XXXXXX_I" for FSP-I > > /// Where XXXXXX is an unique signature > > /// > > UINT64 Signature; > > /// > > /// Revision of the Data structure. > > - /// For FSP spec 2.0/2.1 value is 1. > > - /// For FSP spec 2.2 value is 2. > > + /// For FSP spec 2.0/2.1, this value is 1 and only FSPM_UPD having > ARCH_UPD. > > + /// For FSP spec 2.2 and above, this value is 2 and ARCH_UPD prese= nt in all > UPD structures. > > /// > > UINT8 Revision; > > UINT8 Reserved[23]; > > @@ -134,7 +135,7 @@ typedef struct { > > } FSPT_ARCH_UPD; > > > > /// > > -/// FSPT_ARCH2_UPD Configuration. > > +/// FSPT_ARCH2_UPD Configuration for FSP 2.4 and above. > > /// > > typedef struct { > > /// > > @@ -196,7 +197,7 @@ typedef struct { > > } FSPM_ARCH_UPD; > > > > /// > > -/// FSPM_ARCH2_UPD Configuration. > > +/// FSPM_ARCH2_UPD Configuration for FSP 2.4 and above. > > /// > > typedef struct { > > /// > > @@ -209,6 +210,11 @@ typedef struct { > > /// > > UINT32 Length; > > /// > > + /// Pointer to the non-volatile storage (NVS) data buffer. > > + /// If it is NULL it indicates the NVS data is not available. >=20 > Please add the following to this comment: >=20 > This value is deprecated starting with v2.4 of the FSP specification and = will be > removed in an upcoming version of the FSP specification. >=20 > > + /// > > + EFI_PHYSICAL_ADDRESS NvsBufferPtr; > > + /// > > /// Pointer to the temporary stack base address to be > > /// consumed inside FspMemoryInit() API. > > /// > > @@ -232,7 +238,7 @@ typedef struct { > > /// This value is only valid if Revision is >=3D 2. > > /// > > EFI_PHYSICAL_ADDRESS FspEventHandler; > > - UINT8 Reserved1[24]; > > + UINT8 Reserved1[16]; > > } FSPM_ARCH2_UPD; > > > > /// > > @@ -265,7 +271,7 @@ typedef struct { > > } FSPS_ARCH_UPD; > > > > /// > > -/// FSPS_ARCH2_UPD Configuration. > > +/// FSPS_ARCH2_UPD Configuration for FSP 2.4 and above. > > /// > > typedef struct { > > /// > > @@ -285,6 +291,40 @@ typedef struct { > > UINT8 Reserved1[16]; > > } FSPS_ARCH2_UPD; > > > > +/// > > +/// FSPI_ARCH_UPD Configuration. > > +/// > > +typedef struct { > > + /// > > + /// Revision of the structure is 1 for this version of the specifica= tion. > > + /// > > + UINT8 Revision; > > + UINT8 Reserved[3]; > > + /// > > + /// Length of the structure in bytes. The current value for this fie= ld is 32. > > + /// > > + UINT32 Length; > > + /// > > + /// The physical memory-mapped base address of the bootloader SMM > firmware volume (FV). > > + /// > > + EFI_PHYSICAL_ADDRESS BootloaderSmmFvBaseAddress; > > + /// > > + /// The length in bytes of the bootloader SMM firmware volume (FV). > > + /// > > + UINT64 BootloaderSmmFvLength; > > + /// > > + /// The physical memory-mapped base address of the bootloader SMM FV > context data. > > + /// This data is provided to bootloader SMM drivers through a HOB by= the > FSP MM Foundation. > > + /// > > + EFI_PHYSICAL_ADDRESS BootloaderSmmFvContextData; > > + /// > > + /// The length in bytes of the bootloader SMM FV context data. > > + /// This data is provided to bootloader SMM drivers through a HOB by= the > FSP MM Foundation. > > + /// > > + UINT16 BootloaderSmmFvContextDataLength; > > + UINT8 Reserved1[24]; > > +} FSPI_ARCH_UPD; > > + > > /// > > /// FSPT_UPD_COMMON Configuration. > > /// > > @@ -393,6 +433,21 @@ typedef struct { > > FSPS_ARCH2_UPD FspsArchUpd; > > } FSPS_UPD_COMMON_FSP24; > > > > +/// > > +/// FSPI_UPD_COMMON Configuration. > > +/// > > +typedef struct { > > + /// > > + /// FSP_UPD_HEADER Configuration. > > + /// > > + FSP_UPD_HEADER FspUpdHeader; > > + > > + /// > > + /// FSPI_ARCH_UPD Configuration. > > + /// > > + FSPI_ARCH_UPD FspiArchUpd; > > +} FSPI_UPD_COMMON; > > + > > /// > > /// Enumeration of FSP_INIT_PHASE for NOTIFY_PHASE. > > /// > > diff --git a/IntelFsp2Pkg/Include/FspGlobalData.h > > b/IntelFsp2Pkg/Include/FspGlobalData.h > > index 697b20ed4c..cf94f7b6a5 100644 > > --- a/IntelFsp2Pkg/Include/FspGlobalData.h > > +++ b/IntelFsp2Pkg/Include/FspGlobalData.h > > @@ -12,7 +12,7 @@ > > > > #define FSP_IN_API_MODE 0 > > #define FSP_IN_DISPATCH_MODE 1 > > -#define FSP_GLOBAL_DATA_VERSION 1 > > +#define FSP_GLOBAL_DATA_VERSION 0x2 > > > > #pragma pack(1) > > > > -- > > 2.35.0.windows.1