From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.7932.1636004754771591109 for ; Wed, 03 Nov 2021 22:45:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=mZkvbUuF; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ming.tan@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="218555384" X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="218555384" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 22:45:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="468355528" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 03 Nov 2021 22:45:53 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 22:45:53 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 22:45:53 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 3 Nov 2021 22:45:53 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 3 Nov 2021 22:45:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9TvyTyZl3zDBmlBwz3oQkX78/LqFjZHVgZSgimyKQkpFdZ5ksvjrNmfwRNvHsfcIe8z8LGIzGZz9AwFBnnb+v2YZmjTM0AXC9CsaqL/nh8Q0uAY1pV6obVRfcwgRfq/bbeGS2G8gVMycyqjmXgpkHN2tmgD1eYfcsnD4bNYbIOWuOo05G/VLCfDb+8PQG5ZSL1EC5PJOuO31dRhzDW1b91XBt+SvWs6wA4ENsXBobDiA3mTKM3kcxok4RlukR9HFNf8ZexAxC7G4f+GlADNRavHJNs9913Vr1VTca7E5Y0hvUutzRdTmbdSPoAtxnlUip41i7IOEu8oqnqiHAr5OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3IRxmJerczhwQoo3UoL417CHaVnimcjZxiw4xUmiGjU=; b=gStgjB5leueoBhcWccZoycMX/oxYH5O5E/PB/PM89nfN8BiegJLldC2nftbtimAyF67OmKAkL2P50ZJ4hZeFTi7amYGM+9hZmUDKRVkHDy2WZME7ZAKqhSJoH+g9ZFfmzwWW4DoHnpMxn/B++ho7cejR6OKJBelNm3YtI650ly941XiV70df91l6+Y2/drfw7sOeKozWREe6wOp2UCQsRz39uG6jbDtFG0cTs5RGNEr7EDRCSuKSP5bJ7PKWly8hvrYtcuP3khgWlpmHZhSXBTW90iE+bybg5dO3VCjygXJFUUp962+GATAaqQaUktlqnHE4pud2hhOO/5Vvk2t6pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3IRxmJerczhwQoo3UoL417CHaVnimcjZxiw4xUmiGjU=; b=mZkvbUuF3pvY1KkcmZ+CYzq8hBGxQi66p3QVi5+TMhzcdSxdVfeS3Rk8illWLCRCVrca+ajBLNf2PY41T2jbR+fdU3dZTNcHRAvkeukQG9WmKRSu9KnVIsZJ2/9qhHFxU1Xh3lmOChNFuYKlo1g3HFnFT9mJ/8Tgk/EdSSG05io= Received: from BN9PR11MB5513.namprd11.prod.outlook.com (2603:10b6:408:102::11) by BN9PR11MB5387.namprd11.prod.outlook.com (2603:10b6:408:11c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 05:45:51 +0000 Received: from BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::2d2f:59c2:c16d:fe6b]) by BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::2d2f:59c2:c16d:fe6b%9]) with mapi id 15.20.4669.010; Thu, 4 Nov 2021 05:45:51 +0000 From: "Tan, Ming" To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. Thread-Topic: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. Thread-Index: AQHXywAKjtJ5AeDiREizieeZBwnAEKvy4JoggAAHi+A= Date: Thu, 4 Nov 2021 05:45:51 +0000 Message-ID: References: <20211027065653.6579-1-ming.tan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2021-11-04T05:21:37Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=85f9226e-f1ef-4bf7-8591-aa259c201c02; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 661eb08e-93cd-4e0f-e89e-08d99f565c51 x-ms-traffictypediagnostic: BN9PR11MB5387: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r4rHWi6w29/uGPkoput7xhYXVnwzs14IRaMygkJA+tVS85o5CESFVFQeX3zR+L6f0Yz9MvE4viuizmf8TJDt/7KF5Z7H9HqYDasgHZPpjBeADCo0rSpqTQydH2MZdPU5MHHXsX+vVzCtNw7R90LC3gt9Q27vTCN00U0aVz34RUgSfQN5ZG8fRYN2bN9zZ2lfYmGT7/ynYjocO/SoGVetu+JFPRJE43nMP0N3ao69REeba25Y/cnIAtfu0xT0keFDQAb5ouO4jBR5eR8JpYNv+bVbmMHJ5gDpwFDdhnCO1tAGnTJWPeTpOG2w6jZ/9XAXnMJN5+8WuzEV1qOCz3y+CzAhUnSKuQIdUka4zqnQOyktQrzYFTgSH3x0ZKXXAjnvFsAufPSb/jROGIG5CwYzwlJzol/UqikVCjYrmiRvdBVw1kWUjATRFvaWF86YBRDYMwmALRM82yGAgqJEngvOpwQq/wOsMAGaZAVM6CgSnNLVtkdy2/aZr1v+p3gqJzdmtKqslHpm7gC2YDmi3KzUV8kFkPQNwkdq2jc3z24ItovCmX7ne16rLXQSos/5bT8oXea3TJZhqWlMiMmag++7BAJbnQfWISdlGzl6wmwNmejySECtzhMeclO0sjP/urxp2sJfdQRi4f3+gcZq9HYVSWZ4b8NhR3vF7EDXTKcCxAtZozzV1F/zVHlX+5tgq1buJOme2N7Ziz+s0T6bz7H8K1/jeXnsHAI2CCPdcbuJclHkJ8sVTiVaP5lOmBcuzgb2M7h/sYrb6V8o6JWGhqX3X/Bk519TxTYG9cf9Zt6vFNwidOE2rrY631wbhTcoWKx71UxXNGcRX5lwKV6WkrIwqg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5513.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(122000001)(71200400001)(86362001)(38070700005)(508600001)(2906002)(66946007)(110136005)(45080400002)(9686003)(316002)(55016002)(76116006)(82960400001)(186003)(38100700002)(966005)(33656002)(7696005)(8676002)(5660300002)(66476007)(8936002)(53546011)(52536014)(6506007)(66446008)(66556008)(64756008)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Qfibiqg0F+m5pH8C0P3P3CIKFMHofPMfHx+peKhDEz/24DwN/Le4fqT72QRa?= =?us-ascii?Q?Xu0/u8WziBfSYIU5YP3kr1q4whsKz0SwlC61mdd0TlVWemZ8LutebfbnBF6G?= =?us-ascii?Q?TQwCbEgXs59vyUKN3ougMcYicFKcmLFIqzIWkbY+lX9k1EmE3Y45S5IkwCTZ?= =?us-ascii?Q?O69JZNOLyMv5gsRrgkqEYFic3xEb0PcXOQa6kqn0HPTBoHLKw0MDT44kbu8S?= =?us-ascii?Q?8019qF2gNEH1RnZf7GHo46lkUuZIzyHWbsr1JHV0T/fi0G7j7/uKU3IfWn63?= =?us-ascii?Q?ZJLk4ZMdUl8Ojzv1fzn19T2OfLQG9aKbqbQ27zoVTzDPFRGaKVoFtDOnJ2n3?= =?us-ascii?Q?uvRbxGPqMpsg8klVoZqYKYo/ZixvrbVx6bu9VY2meebl8urHllrukAQej6f9?= =?us-ascii?Q?F5G0npXwk8x0zMjf7oIVoU+x5R1WnQQpa8Zwzysofi833YszXsdR2HYJNcyQ?= =?us-ascii?Q?DZ9SEDXmgjl/zbK8/8Pk9bh23fsQmTDU4c8mcjHnw9bWVXDs1SssuDpeO85g?= =?us-ascii?Q?FYtaBYegTbEOjP+kRchL8eUVs5QjF5dVbEi1tcBEunLKenrOuiBOtX1zhMiH?= =?us-ascii?Q?klh0V0Cq/MP7STZ7MZyPPa61W2C7qRRwUv2iEkpKaeTH8RNQyJu1FnBBddmr?= =?us-ascii?Q?PE8CeNgOVdHVqD6b7Cy+VjXCA82cInmco6R098vjSuhBtktKdW+B5LzgXxZg?= =?us-ascii?Q?cL0pTUKSrBko23MMF2EU7hbqBJImV81MQv1xAsolAurFz/S8hYO5NHMfbB82?= =?us-ascii?Q?qP8j8rXhZzZi/yHeQVdm4xMz7L+vEv7EPX0CrloFm9xuq7y2HmqJXwFzivOF?= =?us-ascii?Q?stycfBAvGJI6p8OzLr++gQT+6WKEioJjJ0ZcQjkhX7QOIolhZx6EbvIkBgHq?= =?us-ascii?Q?XsaRaYBZO7n7FXe591Cs4RMiRDUGNGAe5nHldDRdUKRa/1IxP/nPmw/epP0J?= =?us-ascii?Q?z3tS6b71po0itUOe+4ms1UAnByy6GqutfIIv/n43DJbaT7HmVapjqnIf9aM3?= =?us-ascii?Q?pZoEbkR87RIROGOAn8NlOc3aFRzgfY7+baZp7FvaR5VgPWYy5nyXNXSJSKP1?= =?us-ascii?Q?03pdWtIV1GNk28k9rpYrMJxdXRbbELx7pizWStgTssauhxKrXZaHHhYTnuy0?= =?us-ascii?Q?uyrDNuT93VEnz5LJzp+zTSRCLayMw1oTLpCrBengywYcW6bncsb8JItSS83U?= =?us-ascii?Q?aV954jHPztXbpHBus+62qA+G/+xMbo6HPU3EsKFljVT+jwGPX0gCi9LdXMb5?= =?us-ascii?Q?0I7bGx37fhNNELb8qClODTfmtJkm9L68doRlnfW5G8gy9cnKF0IyyUR668Rp?= =?us-ascii?Q?hcYpTWpKQ94WMHrqblICdJ9Ux8mCQAI3ai6/wRdIf5YEyGP725yvUqW0ohpa?= =?us-ascii?Q?Qpuk6MI2wnamqSlpO22C+J6HVYPNHTGKlVaB5kTCSGhJvDEMxe231eLL4Z1C?= =?us-ascii?Q?/GULYz0riyFh5hTnRURwnWoeobT9KtwXzbyEzrXhmUrPylzGXz9eF1SsnWGn?= =?us-ascii?Q?HsNh2pnL2F4C35HLVGUT1S3EJfWghMLOqvqlR1sDliiVhqim8QqZcpyF9quV?= =?us-ascii?Q?3FQ8BKvdTBErQaaUsLUufu/8I72+gokzOp8/qxQxmJek0pULjITgyfV1S6KK?= =?us-ascii?Q?ycFoWVg3EvXNRCBIsjKYluI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5513.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 661eb08e-93cd-4e0f-e89e-08d99f565c51 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 05:45:51.2858 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GKXGjuQGb1h4Zsq6RmMtOBGtdXPykSRUgaLRqWX3haO1PhDYul5NbmFDanDTokJU5xu1R5418rZK0c8jf4JZpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5387 Return-Path: ming.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Abdul: The following are the testing result using FWTS 21.08.00: spcr: SPCR Serial Port Console Redirection Table test. ---------------------------------------------------------------------------= ----- Test 1 of 3: SPCR Serial Port Console Redirection Table test. Serial Interface: 16550 compatible Baud Rate: 115200 Terminal Type: VT100 PASSED: Test 1, No issues found in SPCR table. Test 2 of 3: SPCR Revision Test. Test 3 of 3: SPCR GSIV Interrupt Test. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D 1 passed, 0 failed, 0 warning, 0 aborted, 0 skipped, 0 info only. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D The following are currently code without my patch using FWTS 21.08.00: spcr: SPCR Serial Port Console Redirection Table test. ---------------------------------------------------------------------------= ----- Test 1 of 3: SPCR Serial Port Console Redirection Table test. Serial Interface: 16550 compatible FAILED [HIGH] SPCRIllegalIRQ: Test 1, SPCR PC-AT compatible IRQ 0xff is inv= alid Baud Rate: 115200 Terminal Type: VT100 FAILED [HIGH] SPCRPciFlagsBit0: Test 1, SPCR PCI flags compatibility bit 0 = is 0, expecting 1 for PCI device Test 2 of 3: SPCR Revision Test. Test 3 of 3: SPCR GSIV Interrupt Test. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D 0 passed, 2 failed, 0 warning, 0 aborted, 0 skipped, 0 info only. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D BR/Tan Ming. -----Original Message----- From: Attar, AbdulLateef (Abdul Lateef) =20 Sent: Thursday, November 4, 2021 1:22 PM To: devel@edk2.groups.io; Tan, Ming Subject: RE: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device inte= rrupt setting. [Public] Code changes looks good. Is fwts passing now? I think FWTS has wrong test case. It expects Global system interrupt number to be zero for APIC interrupt typ= e, which is wrong. In my opinion it should check for Global system interrupt number for zero i= n case of PC-AT interrupt type. Thanks AbduL -----Original Message----- From: devel@edk2.groups.io On Behalf Of Tan, Ming vi= a groups.io Sent: Wednesday, October 27, 2021 12:27 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrup= t setting. [CAUTION: External Email] REF: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3708&data=3D04%7C01%7CAbdulL= ateef.Attar%40amd.com%7Cb53806998fbe4d20cfc008d99917110f%7C3dd8961fe4884e60= 8e11a82d994e183d%7C0%7C0%7C637709147065715846%7CUnknown%7CTWFpbGZsb3d8eyJWI= joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sd= ata=3DrvzXQBpKAzzWr0VGZZoCJyVcJBhOvzvlbdrxzEe1KQk%3D&reserved=3D0 The original code will cause FWTS V21.08.00 testing failed. spcr: SPCR PC-AT compatible IRQ 0xff is invalid spcr: SPCR PCI flags compatibility bit 0 is 0, expecting 1 for PCI device Now modify the SpcrAcpi for following: 1. Disable the support of PC-AT compatible IRQ support. Now only support IO-APIC interrupt type. 2. Set irq to 0. 3. Set the GSI to the value read from PCI device cfg space 0x3C. 4. Set PCI Flags to 1. Signed-off-by: Ming Tan --- V2: Fix a typo .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c index 86c40e90b8..7ad0c058c8 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.c +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ Acpi.c @@ -324,7 +324,9 @@ GetPciTypeInfo ( } gSpcrInfo.BaseAddress.Address =3D BaseAddress; - gSpcrInfo.Irq =3D (UINT8) Irq; + gSpcrInfo.InterruptType =3D=20 + EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERRUPT_TYPE_APIC; + gSpcrInfo.Irq =3D 0; + gSpcrInfo.GlobalSystemInterrupt =3D (UINT32)Irq; gSpcrInfo.PciDeviceId =3D DeviceId; gSpcrInfo.PciVendorId =3D VendorId; @@ -332,6 +334,7 @@ GetPciTypeInfo ( gSpcrInfo.PciDeviceNumber =3D (UINT8) Device; gSpcrInfo.PciFunctionNumber =3D (UINT8) Function; gSpcrInfo.PciSegment =3D (UINT8) SegNum; + gSpcrInfo.PciFlags =3D 1; Done: if (Resources !=3D NULL) { -- 2.29.2.windows.3 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82732): https://nam11.safelinks.protection.outlook.com/= ?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F82732&data= =3D04%7C01%7CAbdulLateef.Attar%40amd.com%7Cb53806998fbe4d20cfc008d99917110f= %7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637709147065715846%7CUnknown%= 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M= n0%3D%7C3000&sdata=3Dm6rywrR9G355hZ1IHgi5XCtuYpK52Fu19aQaGZFBtbA%3D&= ;reserved=3D0 Mute This Topic: https://nam11.safelinks.protection.outlook.com/?url=3Dhttp= s%3A%2F%2Fgroups.io%2Fmt%2F86622293%2F6129197&data=3D04%7C01%7CAbdulLat= eef.Attar%40amd.com%7Cb53806998fbe4d20cfc008d99917110f%7C3dd8961fe4884e608e= 11a82d994e183d%7C0%7C0%7C637709147065715846%7CUnknown%7CTWFpbGZsb3d8eyJWIjo= iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdat= a=3DGrAh49Txcr%2Bd9xAwq1l%2FFo6sGqZZN%2BcXX2Q1TT3ss44%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D04%7C01%7CAbdulLateef.A= ttar%40amd.com%7Cb53806998fbe4d20cfc008d99917110f%7C3dd8961fe4884e608e11a82= d994e183d%7C0%7C0%7C637709147065715846%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w= LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3DC= Ym4d5gMEDoei40a4lXbB6eEB%2B81It7wXuCu6maMZ5M%3D&reserved=3D0 [abdattar@= amd.com] -=3D-=3D-=3D-=3D-=3D-=3D