From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.59]) by mx.groups.io with SMTP id smtpd.web09.2735.1649138097068488014 for ; Mon, 04 Apr 2022 22:54:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=d9Ui4yz2; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.59, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWXgIwXqlnwfXzhSdDwpsSymzaeRQ7uQdkTDRx8LIqDcUA787Uy3yfs+6dZrJSqYSYUyaNTkfVCZ/+tXEKRzBUWdxCcurrh9nVzDFVIMS7Pwq1LYqBSK/GlqgLZ+PfK2XCoVxJlXl7xhrWHplTrBgWKQwhJRr6CTiQHWWdjETo1Qo4SHzwrUZzRX5Nl+a+uk5H5+paPInLTePeMnYwQfIPcLErU6lRxgM9Sb+IqiX6vbpxtkpLt//0WjD8s+EgsIWp6Jdead/PjCIvkP02P6Jn7WB8l7hoajotviSb6B/Z1FfTPO858MBVChtXNuyi9jMJGDusN0vkw/iltm0mn6aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=baBahXmcamm8pmSZdFy7HJwh+SM6+yESY+WosQOzm+Y=; b=NHeI6g4oPjD08KPnvo4YIrA2MpIXlvEtPiFLtwOwG3yTmrHuPLk+hG6HOAAlrNpndFyyBhnTG4V30cYl4En7p+Jsjh2P8rN6tWxjqJ9GdemYmvVE4vPsKVp8JkRGKD22rPKEe6ItsB5OfY3SQ1ZzkmdLQRaWo3u10nZvOexyPVXT4IE9pkhQCNlI8lv6EiQZ16O5k3OT+6ylfynp4KB4HaUqqwfEhXqQzUsLqI86pRyH698Z4LdfL6FuuyV3Vo+rG6FHEpH2h/84OmMEyoyoSB3/FpzFgk2h1ZJGvEQtxKHLVnn+CmFdaNM+b/Gs0c2Su5rzHN7T5xxD9LdY9qf7zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=baBahXmcamm8pmSZdFy7HJwh+SM6+yESY+WosQOzm+Y=; b=d9Ui4yz2JQXqZGmm8egH8k6q3Pj6K9589mmmExVQqEJ81cqdxwZRdeXKm83qt8PGS6evSY6Se6IElHcNGLBd3yBAV6/Lo7eD7n0BBR8RA02AaITbyZvaFeGZePvlmDFLs9HfUJoqqX5axrmlTfIgGRYVo7t5dk8gNWwSCHOj75I= Received: from BN9PR12MB5225.namprd12.prod.outlook.com (2603:10b6:408:11e::8) by SN1PR12MB2543.namprd12.prod.outlook.com (2603:10b6:802:2a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr 2022 05:54:53 +0000 Received: from BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::9c90:3a43:7d51:e3bb]) by BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::9c90:3a43:7d51:e3bb%7]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022 05:54:53 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "devel@edk2.groups.io" , "Attar, AbdulLateef (Abdul Lateef)" , Eric Dong , Liming Gao Subject: Re: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path Thread-Topic: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path Thread-Index: AQHYOCe8DXWnwdvFRkiQYGDCSXxmgazg8qDA Date: Tue, 5 Apr 2022 05:54:52 +0000 Message-ID: References: <16DC746BF95A26AB.23353@groups.io> In-Reply-To: <16DC746BF95A26AB.23353@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=1fb290bd-4388-42a2-86d2-dc41e13cd412;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-04-05T05:54:16Z;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ccb4204-4bab-41d9-9645-08da16c8cdf1 x-ms-traffictypediagnostic: SN1PR12MB2543:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M5E5q7ajlOLQFk6072JA0ne49iCrw+AR1/lrx9+N0FE5KXLblNAPG9TcPCn7gEiFgkLUYpcG99m9tGwQDY+kQjfC2DGNeO4OrAg9QSc7Gw6rlDc0VltVnIwqxUWTos8VEgh0XUYfzzq2/8+jeOHvYxvN77RzpCjzqu9M9SwOiVJIrDPyv1z7FOEF5/xOHp62rT3vH0X+maW24n4rqyQaZVofemlq3zd+07Ib2ij04eVWZHjn1CmYq95XSRjfmE9cVN8ET/uw1WvJXx1MgggedVkSiRw3qCsrIyg0uBDqcL1gDbOsmJRxCuucx4jwUQmu9M5utvGm+iad0bGoYMtC/LDJKG/h8v1rEG7lgSO4iKr1KOB/iWkcAR5VrSquTL+a0rF54kUjIxBi3APQrUnpISUIIN2Pxi/qadZ19BXy4fyuKcyGmMbwNvCdYMoz46BmlmVv7Z08uNgJJSOND//DF41SMQCGOlYf1ifO1watN2bHy2tzU10kUxLb5rnvHIwzWNyav2CTdJ9Ck3fgqIQgtR7tyNgoVE5E81hwq3Ydn7MAfydmgVMgRX3N9YCCvo3T3cG/1edpybkhU2yJYIFE0BmJrmj3iub++UVRGm2oP0vchMBCSlaHaKMP4nYcAsKcmEhA5Fvxv3GDW6BzAGCDpqA8kT0WcuxxV66VvbZLlrsBQa6y5WTUY6L9ZKShwpdG0o/68IH1HvZq6AtyBTb6cCXM5mrTTHvafOmTGOPwPAoIu30MjTkPyzkFIbm2dqdI3ys4k/0KtKYRHAfRvPckzmYoYWk8KtAa7V495PBF1WM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5225.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(122000001)(2906002)(38070700005)(83380400001)(110136005)(38100700002)(966005)(55016003)(33656002)(6506007)(71200400001)(52536014)(8936002)(86362001)(5660300002)(76116006)(66946007)(66556008)(66476007)(66446008)(316002)(8676002)(45080400002)(64756008)(186003)(508600001)(7696005)(9686003)(26005)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CfCshq2C+tF362/KSkoYU0KYblPRZRc3X3tt4Q5kTmxsN6BwZwNjLlYrHJgA?= =?us-ascii?Q?/diGJzBuyIGsgEdcujrUOPgBd2d8Fh5Kc+Sl1ptfOy6tfJ33Av5nRCIzSCnv?= =?us-ascii?Q?M8LaHSaw4GDnounNh6F3fdOQgtr4iuWJkdLsJmenKVs5p+viGpAm7XNHEwQF?= =?us-ascii?Q?MQ0AipLzJZkG6LY2b4ohiowgfW5h60xLkA7ryfdfWwSTlNfC/nqqgipPheQS?= =?us-ascii?Q?HxvD4DoTq/R/5RtCK9Ay4+r/y7GYXoRAZSLpnLoYfOwgx1Db/+/JFrePWRvT?= =?us-ascii?Q?/lmw/+X+K0lfiwZGqrqcYfdQwIwsNRbU7WupvjTD+BhuJ2OCMwZIQXhU3ZNK?= =?us-ascii?Q?NYtx3ycQsaB1ztiuYlgm9hZ0MHO972JSFyQ9E3hTIh8om18McSmG8Sw1FlB7?= =?us-ascii?Q?iMFOGJ355fDD1Y2oAJvTFuRadik3miVsWlT9BbxrQsYQNVELgGhgr53WQV6Y?= =?us-ascii?Q?zOy9ih1xbahszmnNymFyYgy8LXmUY7VpqfNdlLUlafz8EHQ9wJZYmbmEU22J?= =?us-ascii?Q?+BV4YpGPyIowceFDKgFaEJN6J/bLOmhHGpMgKJsH04yPVHLss5nHWYjpF4fZ?= =?us-ascii?Q?mySatrn9ieyokfFBkpjmlTU7TIluTrqWhhJDPGViUnsOkckPJjUIRD6VoU+g?= =?us-ascii?Q?+IBDbFUfY3/9PvUpFCTO+3qkh00yq9a31pnWZ8iToAGuLIt0Acz3IQb+EFH4?= =?us-ascii?Q?Q4A97zhWVSxYifmuZmS7g/2OfzvIxgTXS6TdYNvc+I4RnrrQ6LnaMI6Bx959?= =?us-ascii?Q?ZW6kdBcYKLZS61LE6MN22gvcaKPKIVpu9SI/UoMLh+AUSsptoKF7vNmkkJ9U?= =?us-ascii?Q?KMh2CqAFTxraIZ0bC8Gm9VwOjbq69Kct/GVrql6OFOdQD4xsVzIvlE/WcdV+?= =?us-ascii?Q?wCwU9/vlwiy6EWG1qX57tP7LgyCYsVE4FjcUjUC9Z8nG8Zc2VjeQMotBImEP?= =?us-ascii?Q?lMKaDPTWPhTEzhKBbr8tMeSgDkE+YahGzXy40wVcdWU8l61DNMKFfSVD/woA?= =?us-ascii?Q?HXU+DWPAoFN95ulDJKX1Y/DJcLXg1g6AKbWHd0e7YmqbsAg32pfST6ApEBeG?= =?us-ascii?Q?UwDuEP9xsZi7qRpSbGIP9yWcvlsUU0XnAxFQnQAMKH5QwZ+xQaH8LDqj0RxG?= =?us-ascii?Q?vctl22U86O4kPBa4WmKGR/sGIduE9WLsYc5Tgsx7cgCHVbfwweIDmhLHvMis?= =?us-ascii?Q?bnGOEzrz/Wa7seEaPkd/XLhLYwWXR09fSXhD96UyL20elhiFw96fCV0zOzQ6?= =?us-ascii?Q?7ZbINBp+JGN+qWWL3UaJOnmTe8N6hdvC3MGzHewA+LAtwhqy39oFFg0JVzaQ?= =?us-ascii?Q?E7h2x5zJdtp2P6PmkiJiBxbMUwtC9jBRArRX85GeYvCs6jl/lsxMU3hjN/PF?= =?us-ascii?Q?/9ftbadomAGReE1/U//V07d1VavgsqwW+HZzqNIMeoyq7bzqUbGpOqrPPhYS?= =?us-ascii?Q?8CHFt+036vJo78KUFS9Aw9Cwp2M+1tTXtov47OpOv8Q44yh4eYkCuTvRAtKK?= =?us-ascii?Q?WJc+yOOEuV3CHJuMkZSp2XA+dEnXOq9Q7qHaC3BlBeqJRa+Xck1MpxMgkEUV?= =?us-ascii?Q?U/YZACPOT1JgFhKR3eVvpm+/AGXMcyr0JD+I+Iu5hxPXrcMY2F0zhD2plM3d?= =?us-ascii?Q?YKQVU1ahzfjjBUMiTuWfMHx0iwOUkTXg2HNneMyJudVD+bW2SBWIuOgk1IwH?= =?us-ascii?Q?8O0MFCBb9J0Q0K6D4ea1MEcVXSHmEBCWARCVPGZRBw3J12MNh7MPa2uf6m7w?= =?us-ascii?Q?DhTftVXFiQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5225.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ccb4204-4bab-41d9-9645-08da16c8cdf1 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2022 05:54:52.9685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6wYvQFVLDnG1ejRPgveysJI7x9EjxyWjUbdDt+L12ZRQ2Z2FBQQqw1M1+vc08k0Flc4cAg5qiTQypM9B1kUctw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2543 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [Public] Hi, Could you please review the patch? Thanks AbduL -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abdul Lateef= Attar via groups.io Sent: 15 March 2022 10:16 To: devel@edk2.groups.io Cc: Eric Dong ; Liming Gao Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy de= vice path [CAUTION: External Email] (Resending patch with [edk2-platforms] prefix with correct emailid). GCC compiler puts the DevicePath PCDs to the read-only section. During boot= if try to process the device path after PtrGetPtr it throws a page fault e= xception. Hence making a local copy using DuplicateDevicePath() to avoid the page fau= lt exception. REF : https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg= ithub.com%2Fabdattar%2Fedk2-platforms%2Ftree%2FBoardModulePkg&data=3D04= %7C01%7CAbdulLateef.Attar%40amd.com%7Cdd04fc2187754979081008da063ebd5d%7C3d= d8961fe4884e608e11a82d994e183d%7C0%7C0%7C637829164332474465%7CUnknown%7CTWF= pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D= %7C3000&sdata=3DMX%2FlzKO2jVyPHaaURb7b8kMyNWFAlMPZ%2B0gK%2Ffrh5xo%3D&am= p;reserved=3D0 Cc: Eric Dong Cc: Liming Gao Abdul Lateef Attar (1): BoardModulePkg: Copy device path before processing Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | = 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) -- 2.25.1