From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.78]) by mx.groups.io with SMTP id smtpd.web09.7640.1634735620130639990 for ; Wed, 20 Oct 2021 06:13:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=1isc0lC+; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.78, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nx+cMORjPfhKC2D7Y4RhJMFfMcQLERHoJSNueKKBploQOp+J6W4AjAdDcSuKjPeAMHi4YjhlSqN2zgSdiUIQTRk3ELe3WENGJsg12D8kZC2n12ucCC1aUGu4iSB84zMpXUwHHD/ljDkYLkxU9Z4mPwkHftTjGTX4XrI92vvAc4F6b/NplhdslENnIPRmlNkC6BHftLb/JUbtSTm5LaDc2IWfwYlwhA85NWKowp0I4TewSTi/zzIeq8mvsoiY2oGs6ze/DPtAioTMlpgyy8xoSem5R+CK+2ZzmTbWpC0VSOwr2qWT5Cc9CwQmIrwXA/zufYgi/zQoWLlgrh97HQ8QgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=44uzgwFqvanG6vrd7/4KFFiNp2RBOAmN8FCZzjzMKWM=; b=hADPXQiu/Pu8Y1Bk1KdBLrX/ybUSr1aQIO5PMlfk8ynX7CXtyW3bHZQSvbFkYbMWYx2Lhi+gjdupTkMzXsgLOE3JgohBbe4ALwcEw94BSShP7UHXisOqKLJswMYpYHiQxJOEGIlAZQ8o4DgQUa1cM+A9/xRH9i7X6v0wS4hmQ5zmafhPMLp6ldTiNUMS5qm9adc74j4F7qHaK2TWDbiz6UrMdRCrbV80vV5wriNCTKUzCLUlYPAdG9O7/nc7/MX3L6Ig6YB9eS43UcTx3uQCq3FeqFMdfyiMs62zeIp9VRjClH96CGBhjyUm7x59O5ZvYXCCgZqWhV9md2pKVhk9HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=44uzgwFqvanG6vrd7/4KFFiNp2RBOAmN8FCZzjzMKWM=; b=1isc0lC+hnCTdkwoFdWs35xyR6vC8YBJm9pLBLhadfzVTmKgbiMaM2Yz4VQt58pP1yknuKm6BDdARaVFlez2GXywrc6w6Q8VroI8cLUrsL8AnC4Wk3Ea0dx+jE2JhL/nmJfK5TtErKtwREvtNOojXdaYFd4yY7b4OAKs5ozAIUE= Received: from BN9PR12MB5225.namprd12.prod.outlook.com (2603:10b6:408:11e::8) by BN9PR12MB5306.namprd12.prod.outlook.com (2603:10b6:408:103::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct 2021 13:13:38 +0000 Received: from BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::b120:67b6:bcd5:9746]) by BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::b120:67b6:bcd5:9746%6]) with mapi id 15.20.4628.016; Wed, 20 Oct 2021 13:13:38 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure Thread-Topic: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure Thread-Index: AQHXmP0LzehBDP1XaUenLMIgivkTraubEWkggEElA4A= Date: Wed, 20 Oct 2021 13:13:38 +0000 Message-ID: References: <20210824153013.30144-1-AbdulLateef.Attar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=true; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-10-20T13:13:35Z; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only-AIP 2.0; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ActionId=6bebc327-8186-4da8-913f-72abb5dea63b; MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=1 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e0610a66-6204-4d87-d1d9-08d993cb6df3 x-ms-traffictypediagnostic: BN9PR12MB5306: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kBf6kQi5wPr68AbbeDr/VNPfA/1DvwZLVewPE9yEoOtiKuVaw0yFDbLc3zUnKEGgYPgaFdUvIu5DAm+QHgrLK/y0fVehOfat62dvOXusnwBWoMywaNvQzm7xMifbVGZhObNHLdK8VX2ICHqyi4yi5miUqcNX5HfmVHJ5crAt2a769GBnG/5NSLYwc/uchzG5j7qdQcpbiSd4nN9aalzWZwL6DGlPwXmbXHC4cEkkKqu5vazMcr/LuGUzzOhsgOIeWyOOfALhO8kMceh1jEoKBrLAhz6L1OAz9AiT3j3HgLcvLxywTqT0iQehTnSOpWwTOaxVd+44eBpSvFeezhzJ/P/Ayac6kQaDs7iPd4qn++SFgubdfajA9SqDPwCczDWzsHGxLf/ar6LY6OUDuTN7qZfMeiedn1Xy57rNdMvgheMAoHNQx+YW3hilVlcnPndv2clg3yixPVYb3gyx7/qjbeFKzQHcy7FZJvivEXsfPy9y+U2SCEVjlDWw33HfTVEP0p7YRzhX+Pkq8W6m6PINacT2PpgOwiwMWUe8TqdTgKxQc5rYDzFXw57J3zdghtknsw5pWiLhEOUXTVVFws65vh+VHPSQcHppPB0nSXGB0zBB3nTe0jOwVSdgaWGQ/fIK6IFxr530ltnLDDCUxeiuyv4w93dAqEiQTNNbZ2eThB5Qycg0tt751lsUkcTxb59ALgWghG1NLkL+UNhN/PvtsQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5225.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(33656002)(55016002)(316002)(52536014)(2906002)(122000001)(8676002)(71200400001)(26005)(76116006)(508600001)(9686003)(38070700005)(7696005)(8936002)(66946007)(66476007)(38100700002)(6506007)(83380400001)(110136005)(64756008)(53546011)(66446008)(66556008)(186003)(86362001)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bJehXNoLKyt9655/Rc6hNtaRQU02kndqJ9rcvxrRtVwLwSCgqdg2RNvEY8lJ?= =?us-ascii?Q?SFB7i7NAQpkXi7ZON+r5AkC3+7o8MvWA+8Cr/ZxZtRfXK1UKzXTHrtLM7qC5?= =?us-ascii?Q?ruyd9Lp+PnQjdsYBMfnThLSZGKNZ0jpCYF339kTMFWo+zadK+48riD3dq9Qe?= =?us-ascii?Q?/MKtPVU41a700qFK18NhQAomdxhT8vDyITh1Qhfc/0dq0cTRn78Z7XIQOr5K?= =?us-ascii?Q?n7SJL3r6v2KttQgXkNLiT1HHEh74d96ZrX7fN0Owc5Jih+Cn5yHG+uHa/MSf?= =?us-ascii?Q?CJ+WW5oDSVa+qrnt3JbCMXk6J8jw29z9Xg8lA43pnNdY6HWPKtH+9BYWDckV?= =?us-ascii?Q?W3ALcKB71xglU52wqRAaDNn/sQOLapYefjynlQjakgvbl8N+evd1OVu0bAZv?= =?us-ascii?Q?OHgE8Lq7AbIpOey5h7B5N5b6pb2aVl3ukZqn10mUCgYApnHBD6CaloI3BbTe?= =?us-ascii?Q?RJkms5hU9wa/kPuFz+B0L9E04kkrLTbXXYQIXl3lnq7tsrIijBkgk+7cSbDI?= =?us-ascii?Q?B5WME5LE+cpJgiA5wzPnvTVVPK4/Aj+rbezQ3naoPnNJsMdYpJqeLxBT/iuj?= =?us-ascii?Q?9GxKobqP3dJIv8GaJoJUnQMyqimenWMDL/jdKIoHESsCPnU7d/YcJhEka7rg?= =?us-ascii?Q?cIyflNIoSJAKXb7at7dZFaPu3NFytiX9mYUazjvcQ7vypGCMhSWsgHK7BSGR?= =?us-ascii?Q?iQGdgcsYhbvowcW+IJg5DqkTXvg/7p2gSyX/K2b8of9Nbfmix8I2KaSy2Ax2?= =?us-ascii?Q?/P1RHooZkm5UO8WIJynOW4DvqBusc/iQbSz6za+QRhLmk8wQdvYZXE2QUN0g?= =?us-ascii?Q?GbfIeKuBVjL9E2vImqALaSDDUYFqfMLrJZelLf2yvEwafOl+qPBTZhvp6zjS?= =?us-ascii?Q?SHaNpdStNPra+qvvvzcYygxfIf8OXBVWPWzz/Qxw+3bk4eQrrYLO9JY4KW+d?= =?us-ascii?Q?EZSP3OQFxhY1KwKNnH7AfWrPjmXmk7qZWvDt9tSucdaIR3PuE1KHvgb5ngrn?= =?us-ascii?Q?vVbF2j/Nj40qFKBLwfJjFUzIzG22HBW1wpoCoIqoU1Lc6lgzaF9NhTnJbmX1?= =?us-ascii?Q?AgMa9fOdwop6b4EiC6WlHfmUjAp2FHT0HoswryGJXRn1Yg+QpTMPLFlAih2o?= =?us-ascii?Q?yWQZeE51xwg4Br17GwbgwMzJttGtndeJ2e+xkvd2o5lkHZURD5oG9Zrqy1fH?= =?us-ascii?Q?k3rtz0zxLYPo3vUqgKHNKNY049Aq8uM/4UhJ4lFeGDxDUltARHtLGEAaSiuK?= =?us-ascii?Q?hOpA4Po1yHKft7TPsnZJDiXV39wfuSTrwfdkd2k3NEyKqCZ9cUCqq3wq2eRx?= =?us-ascii?Q?YpStfjCIMazPC4jd1m/DNFYJ?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5225.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0610a66-6204-4d87-d1d9-08d993cb6df3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2021 13:13:38.1179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: abdattar@amd.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5306 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only] Gentle reminder to merge the code. -----Original Message----- From: Gao, Zhichao =20 Sent: 09 September 2021 07:54 To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io Cc: Ni, Ray Subject: RE: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC struc= ture [CAUTION: External Email] Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Abdul Lateef Attar > Sent: Tuesday, August 24, 2021 11:30 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ;=20 > Abdul Lateef Attar > Subject: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC=20 > structure > > Parse and print the below interrupt structures > - I/O APIC Structure > - Interrupt Source Override Structure > - Processor Local x2APIC Structure > - Local x2APIC NMI Structure > > Signed-off-by: Abdul Lateef Attar > --- > .../Parsers/Madt/MadtParser.c | 99 +++++++++++++++++++ > 1 file changed, 99 insertions(+) > > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > er.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > er.c > index 15aa2392b6..2ba8c9ae52 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > er.c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPars > +++ er.c > @@ -181,6 +181,57 @@ STATIC CONST ACPI_PARSER GicITSParser[] =3D { > {L"Reserved", 4, 16, L"0x%x", NULL, NULL, NULL, NULL} }; > > +/** > + An ACPI_PARSER array describing the IO APIC Structure. > +**/ > +STATIC CONST ACPI_PARSER IoApic[] =3D { > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, > + {L"I/O APIC ID", 1, 2, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Reserved", 1, 3, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"I/O APIC Address", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Global System Interrupt Base", 4, 8, L"0x%x", NULL, NULL, NULL,=20 > +NULL} }; > + > +/** > + An ACPI_PARSER array describing the Interrupt Source Override Structur= e. > +**/ > +STATIC CONST ACPI_PARSER InterruptSourceOverride[] =3D { > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, > + {L"Bus", 1, 2, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Source", 1, 3, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Global System Interrupt", 4, 4, L"0x%x", NULL, NULL, NULL,=20 > +NULL}, > + {L"Flags", 2, 8, L"0x%x", NULL, NULL, NULL, NULL} }; > + > + > +/** > + An ACPI_PARSER array describing the Processor Local x2APIC Structure. > +**/ > +STATIC CONST ACPI_PARSER ProcessorLocalX2Apic[] =3D { > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, > + {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL}, > + > + {L"X2APIC ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, {L"Flags",=20 > + 4, 8, L"0x%x", NULL, NULL, NULL, NULL}, {L"ACPI Processor UID", 4,=20 > + 12, L"0x%x", NULL, NULL, NULL, NULL} }; > + > +/** > + An ACPI_PARSER array describing the Local x2APIC NMI Structure. > +**/ > +STATIC CONST ACPI_PARSER LocalX2ApicNmi[] =3D { > + {L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, > + {L"Flags", 2, 2, L"0x%x", NULL, NULL, NULL, NULL}, > + > + {L"ACPI Processor UID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, =20 > + {L"Local x2APIC LINT#", 1, 8, L"0x%x", NULL, NULL, NULL, NULL}, =20 > + {L"Reserved", 3, 9, L"0x%x%x%x", Dump3Chars, NULL, NULL, NULL} }; > + > /** > An ACPI_PARSER array describing the ACPI MADT Table. > **/ > @@ -357,6 +408,54 @@ ParseAcpiMadt ( > break; > } > > + case EFI_ACPI_6_3_IO_APIC: { > + ParseAcpi ( > + TRUE, > + 2, > + "IO APIC", > + InterruptContollerPtr, > + *MadtInterruptControllerLength, > + PARSER_PARAMS (IoApic) > + ); > + break; > + } > + > + case EFI_ACPI_6_3_INTERRUPT_SOURCE_OVERRIDE: { > + ParseAcpi ( > + TRUE, > + 2, > + "INTERRUPT SOURCE OVERRIDE", > + InterruptContollerPtr, > + *MadtInterruptControllerLength, > + PARSER_PARAMS (InterruptSourceOverride) > + ); > + break; > + } > + > + case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC: { > + ParseAcpi ( > + TRUE, > + 2, > + "PROCESSOR LOCAL X2APIC", > + InterruptContollerPtr, > + *MadtInterruptControllerLength, > + PARSER_PARAMS (ProcessorLocalX2Apic) > + ); > + break; > + } > + > + case EFI_ACPI_6_3_LOCAL_X2APIC_NMI: { > + ParseAcpi ( > + TRUE, > + 2, > + "LOCAL x2APIC NMI", > + InterruptContollerPtr, > + *MadtInterruptControllerLength, > + PARSER_PARAMS (LocalX2ApicNmi) > + ); > + break; > + } > + > default: { > IncrementErrorCount (); > Print ( > -- > 2.25.1