From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.89]) by mx.groups.io with SMTP id smtpd.web10.7920.1636003303608919702 for ; Wed, 03 Nov 2021 22:21:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=tAGFGfbo; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.89, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UkPhHANciIYXO4sXHg2n1Tu7wnjJ7kHLx5milZOQ18CvCXWEMI/VIsTNljTju0uoa13ggynlAxcBdPK/d/jwmuXRsffgr+IBAueQB30Qr5ejg4Hhfu9SQAy9ecoWNZsHQRgtUNSSqDdTfhzmV6OKpU9bSPOIQ3U2ZV1OcCsifmDUHijJykh0OjcNriZDLyj2P+umbD7s9l1hw66HUvmK4gLhhiJZ4Gzg4vp2AySHIvVKcO85CiWA5eA3Symwe65/tMCMVwne3tRQl6V5Vn8j9caRArAJHQlr8KDRCP4eUYfJSHNPsHmC6gHrgfYoiOnTpnL+9GYn7JYNERP7o+53+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0hRhL3VXQKYZM+m92MyIXKvawYcRFTo6WbMeiH29s2E=; b=BDVjLhnuyGccbp+viXiEo280LFvuN/6hUylY5qoh/HYysPYs/IPh4D6AvppzwiMTojfHLcuYZS0Zqf2TrEVCGkaeKBXWSPWT44y6Rhr7e30aqG58NVcOyGoUZCUQcA/jpkZjfYlJbt2V5w6E41+tqWh6aheqPcQqTw3VNSt4yVbFyn0jwIWvo8dBw6EgM72deb530LItqBEPhwIeOR9JrQ16xK/V9Et9Iz5jrMx8lsmJfPvhsUKOF9pGrKFWJXZlJtiIQb648gZpaIGMGi0Kp+IgZnTQL5SzbbBWfcgE76/egHY/DBM/Ra1por2dEUb+siN92YPeOIoYk3IQj42wqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0hRhL3VXQKYZM+m92MyIXKvawYcRFTo6WbMeiH29s2E=; b=tAGFGfbo+RXQmhzIEkgZtGRUjHz/4Dt1U/Anodx1Vn5CeVbK8faIl/7QJANrqBwOxvUodOK13TXoChWVdA0xcAASOvzjIIIi2M7eFP0/cAT0EkHYMF4FPq8Ul2jCGHcZUeRctd+YJl1Ku6rPtk56wcQTh5G6e1F43zcbbB8HoXo= Received: from BN9PR12MB5225.namprd12.prod.outlook.com (2603:10b6:408:11e::8) by BN9PR12MB5035.namprd12.prod.outlook.com (2603:10b6:408:134::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Thu, 4 Nov 2021 05:21:41 +0000 Received: from BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::14b8:a8a2:a20c:a152]) by BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::14b8:a8a2:a20c:a152%5]) with mapi id 15.20.4669.010; Thu, 4 Nov 2021 05:21:41 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "devel@edk2.groups.io" , "ming.tan@intel.com" Subject: Re: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. Thread-Topic: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrupt setting. Thread-Index: AQHXywAKjtJ5AeDiREizieeZBwnAEKvy4Jog Date: Thu, 4 Nov 2021 05:21:41 +0000 Message-ID: References: <20211027065653.6579-1-ming.tan@intel.com> In-Reply-To: <20211027065653.6579-1-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2021-11-04T05:21:37Z; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=85f9226e-f1ef-4bf7-8591-aa259c201c02; MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=1 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dde5b4d8-c862-4f33-8a3c-08d99f52fc34 x-ms-traffictypediagnostic: BN9PR12MB5035: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MWfVl3PlrEFTYdILRqgGacEXz5TVDNzSQoaaHLVxR5rB5o2qRolp+Q/fh1HA92gEB7vNnxMJWWseWcEkIAHJNuIw6syEwm+FgAXu/YNjZKvsPIGKzys0plqGqqKIIUTvkxJXJzQV4+llEHh86nrFJ2XBRVFyXhuNJo3pIZwzd/G7B83/MhMzJd8DGZL5wSCW8rpsDpQvFX23cU9eavAH4yTkzv3PqoW26/35Ut6JgDiTujFgrNLyUFBMZ3677caNis/ONF1cd+MHGCSCqgRq4NrRfC0BvRM7oQdsxCvzGYPIFhFJkKnCko0yLoYpwFseMIUt6YSlpQ417+EONemUd7BBWo3Joxfrhj5EV4zYuhGnyp3nzGGReUV7J1JGBbur+mnSnruFknt5B2k7/QZHHCfp92z8NiEuh4FxIfJLgIpCJlAAAP+9u0G6wsHYK22lW+28K9cUfn3P/ksY1lSCinOEkpx4SX7SpXbblF4rulKYIQ5689yvROnlaFQWRNoJiMJwnRr1MiZUYi/9e0e37mMsID5cHXeMzbyrlz0fsSsNWCEKRLHf2PsvZnMMDIMj/19AiP2Tcik7bibly2H0ny7k9+/G5e++UVGl0BvpXoVOsn57LpdiWgtZqQ7Zym4jiPTtAWiEiYdXhlfhU7lYQS+YE0lDDYFUl0X3q57bGHM2s5TMSY1CURVcspNpOQAv2o+/xqT1djKGR2x0IP8KxoiHskdLrcYEUAzJpaoTgkQyNHgyGD5a1OTydFF87UkMuSLa6HAsPi+5gJ3udRnpUIavqKMEiMV2yO2EXuXkKnE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5225.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7696005)(508600001)(66946007)(8676002)(122000001)(76116006)(2906002)(45080400002)(186003)(966005)(64756008)(71200400001)(33656002)(38100700002)(52536014)(83380400001)(66476007)(66556008)(66446008)(53546011)(6506007)(9686003)(55016002)(8936002)(38070700005)(26005)(5660300002)(110136005)(86362001)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F55nMGSJ0xLh6xNB7elQtwFXgDrICRBa+YUx0/U6WkYWcUsCY+dkXx9D51yg?= =?us-ascii?Q?KLs/d6/h4snfvD71eqNB1rw7m9aAnQL9woyDcxpG9Y1DAF6BdimZqgOwoNEo?= =?us-ascii?Q?3bpR24HLjHxgTrexj8e8aG7DXpNGvDOUZj7ab1Secs2RqczVZxonvbasDwrr?= =?us-ascii?Q?QKNuw3VVL6fyuOuZyfiRuTIQBKrzszldAfS6Xv1c2YbTXXxXZgriWm7KD8CX?= =?us-ascii?Q?r0iICNbrMQLqQ9Lan4ajfF6HeqAqGKCuz54EY6f1UEg4iQEFu5kG3Z5UlI6A?= =?us-ascii?Q?dRoLO/d2rTcpIuam7e68rEMwucfXoeKVR7mkyjvedthqYJII/zy8W7zqDB3n?= =?us-ascii?Q?8tjzpu79ATPGVAc/4nWtN9vv5EEPLCYHssAaHcX5dfTltgWbaqOYKBSVAesM?= =?us-ascii?Q?k9ukYZ7FzZWUkzQRU/TaqbJ0cFnkAEtFjFiQka7LrjPMFfwDhPE1L0sgRhkb?= =?us-ascii?Q?9mtOzo2jzq3WeYjBZofxKzxsTSrNhDIDbc2yLbcaNOgWetMNNstHJ4EpSDXZ?= =?us-ascii?Q?6Y1SPHbm9UzGpZhm+xdjiDxlQnGBZWMZvl93sh8+8vQQ3DlS3HXc5MooJ0w/?= =?us-ascii?Q?uIkppExtnPAU/lxPVKTg8kDwxXQ8E9T2qcBaK1/0dFx3/yq5IYpugkNUV7Fq?= =?us-ascii?Q?caqVBjS/6t8vL+3uICM53WTvm6XB6BcjUUK2mguoWMEJAeIBmLB0zgCrVnGj?= =?us-ascii?Q?blcZrKxrptqdvuf1E70E4k1kagm2pMVVk1HEuGijSRdJHdDiEyGh6AFjFv5O?= =?us-ascii?Q?GTH4TksMkgCrPSQcIpxDDayB+mIg1dkqbny9rKfheI3zwP5X3ZNDfLkjepq2?= =?us-ascii?Q?6NP/R4QYfzwIZPU9BMluMKkelEe4fIVfWquDLCJ4Q2GwJEOEsltP5caD3Kt7?= =?us-ascii?Q?VEUVl9eI4iKRVtoJx/hEoKlmA9f2JvCNykcxzLlYJjPLh5HTlpb3JCeQ9bbt?= =?us-ascii?Q?U+XdOm698B5qogEe0ZfL33VsnZWbTVnI8enFC0qYjspEOYc257tDEAw/wzll?= =?us-ascii?Q?uUXLocRm2DL/kylg0hsK7LKlJq3tP9pVDheYU8V1OFBZ7k2YxxGEvChLI2+h?= =?us-ascii?Q?m7vXz+UuEblbL6KLL/F8uuYW6fE5CHDWT1GFyJXL1t4gKzL+GKGSJXHBX1VD?= =?us-ascii?Q?NExqC4tr+kyyHsUoe0IZgTHhilvHBjDbMFzgsH504O0kqrApq2wYbQOIffxi?= =?us-ascii?Q?1YuXxUOQoODG8XpJo4TDVvA1VMg/Gxmyl5QbVIfu8byjNyr12he4tXzT+g6U?= =?us-ascii?Q?PmcCyuAFbVXd1fIi9Jp1o+cnUhcOcuRMQAhg42lJxzMTcsFdPODtRL1ipDBe?= =?us-ascii?Q?LArOYYBqrKwh//qAqOCJ+RaOr9uZyQgyFT+K22g4/tb4H54T2ndoaOHgGA0K?= =?us-ascii?Q?AQPoAstbfh7O3+4HeXXVuPPaZWg7M3tR5mBd4VKmSMUaTL4ti6IzkxSLbYaD?= =?us-ascii?Q?Dj0stesfU6T1Xr8oSi5XyBkIwn1AbhaAdL7/qXWsPAOpUE2q8dumUMGKSQJW?= =?us-ascii?Q?PeIz3LAqlk2bJCPLQWA7E2n63vYoboVBLysXGeyH/O5qWZi1lgYymPu0sFb+?= =?us-ascii?Q?gHOY8ww0pWqBznLxjBxeXNQDabtz9mdLR4ZBvw1ggXEIpfjAbtmrBq5mbG3J?= =?us-ascii?Q?g3mWYE/n/LiODGOJiwOAm08=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5225.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dde5b4d8-c862-4f33-8a3c-08d99f52fc34 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 05:21:41.4772 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g+tUi9EpJklQxmzOOZjulRzXRZ1GEWPV6h5WwFH8CwIHOt/fXPMQ3wAvkrU5OajiGe1MLQfGmVWtlwoVhNKDbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5035 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [Public] Code changes looks good. Is fwts passing now? I think FWTS has wrong test case. It expects Global system interrupt number to be zero for APIC interrupt typ= e, which is wrong. In my opinion it should check for Global system interrupt number for zero i= n case of PC-AT interrupt type. Thanks AbduL -----Original Message----- From: devel@edk2.groups.io On Behalf Of Tan, Ming vi= a groups.io Sent: Wednesday, October 27, 2021 12:27 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2] SpcrFeaturePkg: Modify PCI device interrup= t setting. [CAUTION: External Email] REF: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3708&data=3D04%7C01%7CAbdulL= ateef.Attar%40amd.com%7Cb53806998fbe4d20cfc008d99917110f%7C3dd8961fe4884e60= 8e11a82d994e183d%7C0%7C0%7C637709147065715846%7CUnknown%7CTWFpbGZsb3d8eyJWI= joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sd= ata=3DrvzXQBpKAzzWr0VGZZoCJyVcJBhOvzvlbdrxzEe1KQk%3D&reserved=3D0 The original code will cause FWTS V21.08.00 testing failed. spcr: SPCR PC-AT compatible IRQ 0xff is invalid spcr: SPCR PCI flags compatibility bit 0 is 0, expecting 1 for PCI device Now modify the SpcrAcpi for following: 1. Disable the support of PC-AT compatible IRQ support. Now only support IO-APIC interrupt type. 2. Set irq to 0. 3. Set the GSI to the value read from PCI device cfg space 0x3C. 4. Set PCI Flags to 1. Signed-off-by: Ming Tan --- V2: Fix a typo .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c index 86c40e90b8..7ad0c058c8 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.c +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ Acpi.c @@ -324,7 +324,9 @@ GetPciTypeInfo ( } gSpcrInfo.BaseAddress.Address =3D BaseAddress; - gSpcrInfo.Irq =3D (UINT8) Irq; + gSpcrInfo.InterruptType =3D=20 + EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERRUPT_TYPE_APIC; + gSpcrInfo.Irq =3D 0; + gSpcrInfo.GlobalSystemInterrupt =3D (UINT32)Irq; gSpcrInfo.PciDeviceId =3D DeviceId; gSpcrInfo.PciVendorId =3D VendorId; @@ -332,6 +334,7 @@ GetPciTypeInfo ( gSpcrInfo.PciDeviceNumber =3D (UINT8) Device; gSpcrInfo.PciFunctionNumber =3D (UINT8) Function; gSpcrInfo.PciSegment =3D (UINT8) SegNum; + gSpcrInfo.PciFlags =3D 1; Done: if (Resources !=3D NULL) { -- 2.29.2.windows.3 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82732): https://nam11.safelinks.protection.outlook.com/= ?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F82732&data= =3D04%7C01%7CAbdulLateef.Attar%40amd.com%7Cb53806998fbe4d20cfc008d99917110f= %7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637709147065715846%7CUnknown%= 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M= n0%3D%7C3000&sdata=3Dm6rywrR9G355hZ1IHgi5XCtuYpK52Fu19aQaGZFBtbA%3D&= ;reserved=3D0 Mute This Topic: https://nam11.safelinks.protection.outlook.com/?url=3Dhttp= s%3A%2F%2Fgroups.io%2Fmt%2F86622293%2F6129197&data=3D04%7C01%7CAbdulLat= eef.Attar%40amd.com%7Cb53806998fbe4d20cfc008d99917110f%7C3dd8961fe4884e608e= 11a82d994e183d%7C0%7C0%7C637709147065715846%7CUnknown%7CTWFpbGZsb3d8eyJWIjo= iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdat= a=3DGrAh49Txcr%2Bd9xAwq1l%2FFo6sGqZZN%2BcXX2Q1TT3ss44%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D04%7C01%7CAbdulLateef.A= ttar%40amd.com%7Cb53806998fbe4d20cfc008d99917110f%7C3dd8961fe4884e608e11a82= d994e183d%7C0%7C0%7C637709147065715846%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w= LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3DC= Ym4d5gMEDoei40a4lXbB6eEB%2B81It7wXuCu6maMZ5M%3D&reserved=3D0 [abdattar@= amd.com] -=3D-=3D-=3D-=3D-=3D-=3D