From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.59]) by mx.groups.io with SMTP id smtpd.web11.26361.1650870911979860555 for ; Mon, 25 Apr 2022 00:15:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=MiBgLGsV; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.59, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OJ8PB7HAgX3xmDVq65qXRSnVgiFCy1PbT+2pwEUXj2CK3D1djM1osz25RpTnfONqAs2shPBrliBHVKjtgOgU87LbjlCcexmMmkyQpaF3DNLo1CN75l4IpEtcAsYC9HNdCJB+JW6UAeVIDEdEEjDnQnnGpJS+IO6pCvPQbp2MRAZnq3eBesWemWaVCD6Op6gp0GFvidUyY69b6PfMQYPo2qu/5u3KO1lau2H6UYVSjOmDADwNvN3BfJZGCJLQlDFmZ5CbOtqIAvCPgxhRh6GTeBXTkmHnYuCVMUxWQB5O55BKhTwrCftCVgUgj0j5yCvknZDFKXgvmkwZuEuVXrL/Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wLTIKeNccf8UhN0UVx/oRgCF/y50cgp73GZ/2Yjbr/o=; b=Ix8/sGzArUqCuAdKSnhI4ZPkgdeBYIxSnca5QI8LRIoEETeSq6xWawkTY+fL13PRsL42+ipeuYc7raU4+tOBichOZtKn5MWl0vP0dx02FztcKGOSr4T4GeY+Mn8XmyHmo1CEv+Z3YJmchzfKhTtBkGxYgFRwgXCPh6t+PtZQfDfEmy04j1SR43kiODWWu4qlXTA/s1IZYtdpG6zjQU65CMpASHj4V9k3sip9/ndeoGaEG4Z07tU/zAe5fKV8EjNOCIzk21B8ftm1mmsXEQh29CakfOHVtJ9Eh2YsooUcLLfgf7e/3ee0XR5HN8tkzrFF6ptgD8cGzRPiHPrX9oM3eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wLTIKeNccf8UhN0UVx/oRgCF/y50cgp73GZ/2Yjbr/o=; b=MiBgLGsV9Eshp5/fsIYG4cxCc7ersNcFhe7amTi8P5lVPt7ykac7bMxkpkPHh2KyRedWrNOPvYqFY1lvWgevw55zYJoXVYe1qIfniRqVrsZH0uomM8PZK5pAWzPkVo061F7bW8tw6rTtIGB0/XQK+PQH5OjoIjYAneYI/mIDM7c= Received: from BN9PR12MB5225.namprd12.prod.outlook.com (2603:10b6:408:11e::8) by BN7PR12MB2610.namprd12.prod.outlook.com (2603:10b6:408:22::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr 2022 07:15:09 +0000 Received: from BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::dc2b:d965:2793:796d]) by BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::dc2b:d965:2793:796d%5]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 07:15:09 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "devel@edk2.groups.io" , Eric Dong , Liming Gao Subject: Re: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path Thread-Topic: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path Thread-Index: AQHYOCe8DXWnwdvFRkiQYGDCSXxmgazg8qDAgB+FVpA= Date: Mon, 25 Apr 2022 07:15:08 +0000 Message-ID: References: <16DC746BF95A26AB.23353@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=1fb290bd-4388-42a2-86d2-dc41e13cd412;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-04-05T05:54:16Z;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 523bf826-53ba-41b5-d91e-08da268b54bd x-ms-traffictypediagnostic: BN7PR12MB2610:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sXmFkQ3s6Y7sEcJQ1Tn6oIu9Q76dasoQolWNVq1gtDGUIj7bRG+GFqUU+vuu2XmLxvWLumnmsJaTUjNxTpc5ABWC95yOzlg9wAMyp3KynPgxt63wczA87gbr1Oiz+NbIiKNsptUpeN/bePnX6AbGqU7X6BqEvb+m3yABTBcJXBzKy34sFS8rvuOI5G+AGVDpAFWvbswgvD9fWJ1+C6wMhtgYxVxlrjzdOXZV5/huFeu+lNdLTha7XLsqAm2nk0Cj4HzCBCC9bLFvKIJf0YXWwQeY34HZqLG/+PT5SfrU2cOrJbLb+9EdB0UgtcXlHTOt1Rx/joOlJSQSIA11fbWh2VyH+ZCJrh4dp9vRIzVYk36zd4HvY7zhK5sYwZ3Do6wwhx0QmKDR4p3O2+NMBj9ro441EdLjOe3hxbdNs1AgqMlCI+dfZqNca70Xa/pxE+0Tlx6HS0Msd5KqGrLAUql2ulsJQzLMvh5KXqZV2p/GG0QJbVx073vNHIuGWudVJyAtN6jRRpb7W7NAty+WuPz13xrOYQyxnj5LkCWGJmkwQCr1ebyAW24wAZedx5lfFLKVF7OLkkrTj2gWsO9Er26c0rJl/VGaXujOJxlQXnOmJttPYvGFg7KXOt/mwZBsLnI5LE4rgDpUpsp2PDWFwosVUjEPxFmzjtpl4s2f7hzZmvybDszh1KAP7LvAdZbYKq8DHEOh2/Lc+e8A9+tG4D+h7kIVtYFV1Y5Gqyn/SDvRjA7n5eZ1xZxv5djPZwDyJ6pbKmrAMyVP4d+r2DXo7Xl3AuPlsucYe4gE2tIC6IXTFes= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5225.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(71200400001)(76116006)(316002)(66476007)(66556008)(64756008)(66446008)(33656002)(6506007)(83380400001)(55016003)(9686003)(7696005)(53546011)(26005)(8676002)(66946007)(45080400002)(52536014)(8936002)(5660300002)(2906002)(508600001)(122000001)(110136005)(38100700002)(38070700005)(86362001)(966005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VuCZQRFQb4LzbAi/Y8B+FpODEJbGfiLUhT4qZkv3Ew1iPXywlaP6f6NqcPUU?= =?us-ascii?Q?2lfoFtEJ1RC4qP1nZwS5cXqitx4F7LcpyyKciDSNanr58VdS1MA91tPyg50r?= =?us-ascii?Q?C32tFOqNEhkxOS4HOrCigoftnrb8/+9xG/khCRwg+8nVr/TXF9dddpO7SYgj?= =?us-ascii?Q?OPULh2naM2SQ901OdEeM08vGQNKGUrMt9sjlj53RmStQoXGf/hpDsd0IooPF?= =?us-ascii?Q?45lMd8Xe7qTWALn24m3W/6mymBiQWCf/kP6JOIsfndyYpjXN0PhXXdNMPNGf?= =?us-ascii?Q?CpHWmtxN9bqs4Q5Jfw2Qa3LJYOj/i4jtyU5rTfGbfrOaYn65r7WPAzG4j+W5?= =?us-ascii?Q?MuSLUiXAx68Uo2ZZoTqP4mcaoHi65Xj1GJnaf0Cm+O31gsI7HlirrOH8xJaB?= =?us-ascii?Q?Qrat/QPTKWaKTzb780x1sAJCkby1mjzaxOUNRAk8onEU8eGlNA7pRpMef166?= =?us-ascii?Q?It0p1V81xEic4JDKij46lTJS7wepCeFHqsojzSwTf1aL4hUfjJO5dtAC5qpa?= =?us-ascii?Q?KftSbyPAELfPk5Ry8DdnicgBPLKiJSANqWZgwqirox06AP//OgGszceq031l?= =?us-ascii?Q?wRbjR4rPDhEQSIx+Y0DCCco2KM59ppO/Fb8E4XPSBDjKEEtdUpAPCMydBMah?= =?us-ascii?Q?8YDRmn7YupDW0ko3Q+qXwCssWVNSUqGO5AvfVbkR3eIsHV/PUMutXytTte0K?= =?us-ascii?Q?iZyzdqm85+m2tpPkHpXmzdxwcAZnxnB9klcBleREDntflRMBGxJyGP0c6bj1?= =?us-ascii?Q?bLTm39skHpNbGpj4V9s69bZE3gdskFN5RsbOcWAYVU4QA4Q8996eQPT65nPi?= =?us-ascii?Q?xYbJgCCOGN3ezav9veKz41lZMo24Tns3b0HbdAaCu6e757QwWDdeXv11ebOn?= =?us-ascii?Q?W6nSOYQA0tYKrbWva5W1GftIZHcr/GDmXMXvVVnXsUuZTEScbnF0XaYjk/Am?= =?us-ascii?Q?VC3qAVuHsYDAUHmzwy3c6N2FGmv8zufWqffOlKL4MkZRIwgUoHUxxE/wSemi?= =?us-ascii?Q?1MtNQi9EZ2gNSacYYhPqYcMpW/s28poT6dUcGZedYRRbA2S57OYbb3heDAlK?= =?us-ascii?Q?Cv2hXyMvOEHZRCtveOJrEH8l4oRoAa1slE3ra97L+vZ4oPlpaf1g5xRCsZ8x?= =?us-ascii?Q?LhZRsJuA0LnshPxUty6kVrwzfQaJhOx43km0EthyR+PjgROjOHnvgK9iLzvM?= =?us-ascii?Q?k/PJU3MEs6X9Zwt0YJRGF63c54rGEmiXA4wHB/o4jCaadJvBtWpo7kjrFmhZ?= =?us-ascii?Q?zGlcEr37MYFx/JA/fr7obPU9bu82sbE0rqHiUqtaGe/VgG59PsENsMKPmJ9h?= =?us-ascii?Q?3WylHSquwIZzfITt5DzeMfr+X74GUswZtxwnkU0bIFwv/n11cisz6QsBvGKg?= =?us-ascii?Q?SfXG+S9xAQEHucKasyxMB6K/9cv8wHua/LA7Nrcm17jtuam+SUd0hvqFZnHb?= =?us-ascii?Q?9ijYJskGBlOxmbixIzmuvBsUJaAD7Bbz5eKd9zQZL+9v0SRXIsygyZdxHr8+?= =?us-ascii?Q?GZl8dbDvlLOcnqj5P4HT0BD8vdWZwhNQlDeOtJ4SGMuN89OVQYJ111ckIMpT?= =?us-ascii?Q?7PYLSfYn438rCp6/M/GGYZrim9S9nSPEZIEqht079/0VdZl/ywAGZvZ2JBas?= =?us-ascii?Q?WVaHVUoNVZshwy2YEFQDps4AJJqpoy+feRYru4nUqzzREl6iw8PgyDVxX4e3?= =?us-ascii?Q?CxdzFITtFKlMWQUmRvsvQlaq5OEGL4b7LFYkOKrD/WVrT/g32XP6K2lZnr9+?= =?us-ascii?Q?P+2B2P8wyQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5225.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 523bf826-53ba-41b5-d91e-08da268b54bd X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2022 07:15:08.9759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IAUgcnMNN/toHpWErbNEI5f3RAzR+Vu+wu0QvwRepzfmR6g/iRL6ohQBvqmDaWOPIeGiB/+2L5BUnDVvw9qQTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR12MB2610 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [Public] Hi, Please review the patch. Thanks AbduL -----Original Message----- From: Attar, AbdulLateef (Abdul Lateef) Sent: 05 April 2022 11:25 To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) ; Eric Dong ; Liming Gao Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Cop= y device path [Public] Hi, Could you please review the patch? Thanks AbduL -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abdul Lateef= Attar via groups.io Sent: 15 March 2022 10:16 To: devel@edk2.groups.io Cc: Eric Dong ; Liming Gao Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy de= vice path [CAUTION: External Email] (Resending patch with [edk2-platforms] prefix with correct emailid). GCC compiler puts the DevicePath PCDs to the read-only section. During boot= if try to process the device path after PtrGetPtr it throws a page fault e= xception. Hence making a local copy using DuplicateDevicePath() to avoid the page fau= lt exception. REF : https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg= ithub.com%2Fabdattar%2Fedk2-platforms%2Ftree%2FBoardModulePkg&data=3D04= %7C01%7CAbdulLateef.Attar%40amd.com%7Cdd04fc2187754979081008da063ebd5d%7C3d= d8961fe4884e608e11a82d994e183d%7C0%7C0%7C637829164332474465%7CUnknown%7CTWF= pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D= %7C3000&sdata=3DMX%2FlzKO2jVyPHaaURb7b8kMyNWFAlMPZ%2B0gK%2Ffrh5xo%3D&am= p;reserved=3D0 Cc: Eric Dong Cc: Liming Gao Abdul Lateef Attar (1): BoardModulePkg: Copy device path before processing Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | = 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) -- 2.25.1