From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.74]) by mx.groups.io with SMTP id smtpd.web10.7263.1647501032553264192 for ; Thu, 17 Mar 2022 00:10:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=N16wXzQm; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.74, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ESlv5vZw2vxhltNtvT0kXfRuJUPC8Gv7xj+KU46iCEiNJ39KfHOj6oqMALgimWQfkT1qJeeaOhQPiBjSw/FOXl91xJf7blfwTKg7MtcFST+LaKwbad+Fu8UuByReohGC9EkG7iEyT7mRx8tjfGg2RLSJp44qL0k9QB3e93HqSfSaYpxOoCmNUR0XT7Xy5Gdqqz0qEZgY42PRPmWEIOCoeVuGek9sBaELqvp9Y43Vd6M/YKkTi9D08+b2KrO9wfSz1fecegnpTAcHx7ZxcPbZK6pKOjmirROsp33hz2ch9QUbm8A0kMZ/DLOe+SdaA0cpCRsEIWaiRznsq3PcH29j+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j89VOyqSBW/cTe/XPEJv53oBDv4sy6EpLdH7NW7qAxk=; b=RumTWWix3M8o1e/xXAwekDmxzeQnSqm4NFvooKIKNqXFrJm4oyIBN5tTsEde1oHnDqbLryYt5uQdf6tMbWXXb3bK7TpNHORq0ggUS2k3BhNnl8tRZlM1A1popKgZNkWKSKN4yhAilisSCAfc4KyiLQvO4fUZ2IqNhArhVREHGG4Y3vvAMIbe4Sbue9+SsCbiAU9Gi7pbAmrcKDtJFsQDITEtMwcahAGG67kTk+owmuNVgoE+pOyRYxwK5EFH9zwRVrAPoCQKwEeEE2xoyNAKXKkoR0HuR0MfjGw9RCqN42ivCm7X8OijgQpVSbXeLkU7gXMyQwSXy14nm4jLTB7l5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j89VOyqSBW/cTe/XPEJv53oBDv4sy6EpLdH7NW7qAxk=; b=N16wXzQmVcH8hJFW8nwk+PLQ8EKe7owiiG+mU5ZlARi9uwfD9qV44MNmopMaYKGJ3nuD2JyqNXZYqKeNmS4dszGYa+mMCFTxsscvWnb3o6BmVaZUp06y83QgkMcJilZTQ3bwQoqmVrdZe8expkUbXVIqnBxLA4KaDsE3/8+MIsU= Received: from BN9PR12MB5225.namprd12.prod.outlook.com (2603:10b6:408:11e::8) by BY5PR12MB4098.namprd12.prod.outlook.com (2603:10b6:a03:205::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Thu, 17 Mar 2022 07:10:30 +0000 Received: from BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::55b8:ee72:d0a1:99f1]) by BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::55b8:ee72:d0a1:99f1%9]) with mapi id 15.20.5081.017; Thu, 17 Mar 2022 07:10:30 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Ni, Ray" , Sami Mujawar Subject: Re: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Thread-Topic: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Thread-Index: AQHYIyZTgXzkoCca10eTEKbVs1SzIKydpgKAgCWvu9A= Date: Thu, 17 Mar 2022 07:10:29 +0000 Message-ID: References: <20220216111355.9801-1-abdattar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d0753388-6809-4955-e6ec-08da07e5385b x-ms-traffictypediagnostic: BY5PR12MB4098:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cMJibUbmrKZGhfSApgcW4WWfMEmo9B2bPUvkfulINlYQCg/R0U9aX05PhfzeWAPsKwXkD6dU23VKw8CTvbcWRn3DaRDs98F7Yua4FXHyjIpthjN/SggVWds/WVoPiy4f6zu7yQxl8YjOJaKKlCeVFExaTqzkuwHKwivnm8Yp0ERgnfeN0ioapRE6OToWpcIaWTDALPLdB0mGvcGqEypJXlTRhqTKOu5GDdJSrpvek5vXKZmQiW+tREyJedBnpI43H6E+N7/YQRciwtTsi2u+n6RSHzBi6V3Oc8hyU4kqR8nMs7jsuuRrGEGJ/Ra8LqzMX7IHmEh+oW9hQV4vMVfOmOZW97l58TYlJGt5QoDUSh1wame9uDYsZzwXehlxcnjj9brj8axHMFkbBV/Ytt4iz8jnsF9onIknOqIY12H/RiEkqcGvcong+vrdgjUWI+OvBoGAKJGOPn7bPzoCWL5W1Zd5AG2nselgKzeUpwfdoUCVOUnxpeFjDjb/P32PX9O3i697PPy6O7bKtrc1/pYv5Ed8deBtlC8NLWI7UbKs838nJE0wHh4JdvB7ceDQocvJkjjsEazlkwmcneWeuv/pQ4AJWzKEFINe5R8Nq1cVvW7K6v2Gi6/Q3P6gHVIMV34KWUSrNZC+cKJd1jeK1zkk1biRlz+KUHialLEMkLTue+PK52si35xLeeJTylkKosaiiYEY0bTIQDVJqqR3xuFBR+Zo9iN4IZuHG4Dcn8tnDR0YD6qf9JsN8TElaM1v9zkXwaq+nenT29rWiaaXgYGMrNZM2TFdYre5na8N7VskTjQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5225.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(53546011)(7696005)(9686003)(38100700002)(316002)(38070700005)(122000001)(5660300002)(8936002)(55016003)(76116006)(66556008)(66476007)(66946007)(4326008)(8676002)(66446008)(33656002)(52536014)(64756008)(26005)(186003)(54906003)(110136005)(45080400002)(83380400001)(508600001)(966005)(2906002)(86362001)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ihf2mwTHAs6abAY5KlcAytR7xg4Ni7fJ5khW2Bacya/kfvR6GaR93vCnDqju?= =?us-ascii?Q?tYY3kuU+mpnMLt7ATLIfjcv5DZEZtNRZjJoZ9sjZ+C/FLY6vEUyyTsGnE744?= =?us-ascii?Q?SYtn6XRQAnPPBml9zAcd7hHXakHsQA9gUAwuFCB8+Vm9FTHr/di8u+cCZShf?= =?us-ascii?Q?WgdGTgL+izHmlfUCq+8t4y9nLutarDeIClajdtXYyjUIYi0RDlvfB/1pdxi5?= =?us-ascii?Q?rfVjfkFOv4aD6Ys0PczP+GiyqaSWQD4iuMGCqxptnpx/LBiMTjInVRG5VtZy?= =?us-ascii?Q?fgmG1DEpW990f4qWr24I+Nhgu61WtpGBOLpwd/BnDW+jC7fG0dI3qoaRJge5?= =?us-ascii?Q?dJAcO5tZa9VcBdhYluIY5RrWEmq6acangopvxEdinBlxOhODlfdoWGdRmWIf?= =?us-ascii?Q?DRHi2dscszzd9GQOyp5nY6K6KgIWAH61eAeNQ03Y/Vv7q8tDMXlPXw0ANcx6?= =?us-ascii?Q?o/HwB3kt/7u8Vf6iupEDxNLcQ7cvBR16nUaJqqeHcv8R9KPSWxVbGAuEju7m?= =?us-ascii?Q?5Zk7uw4xwddKbUIWxhshXAv/ublMI+1/3RjI5bofkSc0AqGNxH09NOrapj92?= =?us-ascii?Q?DA60ZMb9RRwREaltNQYyNoebuJ+HlSo9zOP+c8pnzU5cjHQ+w2TF2CjEP7yR?= =?us-ascii?Q?/dIswCC5qTlqc6Ieyx3ZrzY4ykuIAxjGtIvR+iLIWtpOs+VHXM+rPhHvkmOW?= =?us-ascii?Q?9Yj+GrX6nY+QF2N4kfj1m6ikqaIgFH10UIOa/3gAD3SDwiAdORE2UGjRpoMx?= =?us-ascii?Q?/BTEcGDN36u7kMl7c6gjbp6KeJFk9uLyTojw82iI69A6FqibB6M6ZhjL7jRB?= =?us-ascii?Q?JPy3Qqiu5O4ns66z6fBVxaHylGFEx2xIq1W92pCU9BJKkxQAixrfGiJFSRxG?= =?us-ascii?Q?OOO4oSAtbTzpAKSOadfWyiasyn2iAN4t3nHH29cQa0fskvSjbk7Jg7AfDmrH?= =?us-ascii?Q?owsyB9sYJKIkTMp7XB7YoAiyuizXgt3JyaGgATBEc0y2pGASUa/UGqk8Uunm?= =?us-ascii?Q?z08IyHeNdnWL4v+InEGc67O090OaLXj7sB5FHt7TN/QFHNVOK00qF3bhyjev?= =?us-ascii?Q?j+/bbZt4mn9TxUDTbyxePe8x6qPDlLKrWuTP9aal3pweCbdzblb5OS2DqXgM?= =?us-ascii?Q?LZ4Nzd6v5bnIAGP2E9DeamEyx+pdknKq83uhiXMfKAsh82fs/KdKBkQOY7lr?= =?us-ascii?Q?wdRSZ/m+jIJmUDpcg7NF69UAsHC0eG5UfI7/lHCcggzHkqipVUt+sL7AVIdU?= =?us-ascii?Q?u5l3GVjz77NLXG+QfH/PpD8d8qQ2Vuw91xb7tG/RsGTbYIVyj8o+xCSf+8j5?= =?us-ascii?Q?R9FGw+22fzMWEoSE4GT4ELs1gEgA9OmiWR2zQSrjQr7f5jpG38sEDafxMxRP?= =?us-ascii?Q?5eMl90VI7lznkibaPEN38SlBqDutzwFrwp3pvh3Ce6ydPuy2GrxqHZCE9MoT?= =?us-ascii?Q?i97nbvn84l87qV8gh+WtNiIGMRhN86QZ?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5225.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0753388-6809-4955-e6ec-08da07e5385b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2022 07:10:29.9861 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jyXAgM2wgCAuA/pVfJFogu5kPUYZtTe06JzbQPUhV5vMSOjc14gRJ2RPjS9mXKCtPtnihWFYkhKYu2mJYbvsYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4098 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gentle reminder for PR. -----Original Message----- From: Gao, Zhichao =20 Sent: Monday, February 21, 2022 1:10 PM To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io Cc: Ni, Ray ; Sami Mujawar Subject: RE: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield pa= rser [CAUTION: External Email] Patchset Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Abdul Lateef Attar > Sent: Wednesday, February 16, 2022 7:14 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ;=20 > Sami Mujawar > Subject: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield=20 > parser > > Hi, > Sorry for the delayed reply. > I had updated the patch according to the review comments. > Please review the updated patch. > > REF:=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Fabdattar%2Fedk2%2Ftree%2FFadtFlagsParserV5&data=3D04%7C01%7 > CAbdulLateef.Attar%40amd.com%7Cdbcced5d461947c4c52908d9f50d60e9%7C3dd8 > 961fe4884e608e11a82d994e183d%7C0%7C0%7C637810260090713957%7CUnknown%7C > TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC > I6Mn0%3D%7C3000&sdata=3DlqrY9GyWZTJl%2BsRa%2F223ft8ei5rKBbm36av4SQh4 > l9g%3D&reserved=3D0 > > > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar > > Abdul Lateef Attar (2): > ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser > ShellPkg/AcpiView: PrintFormatter for FADT Flags field > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h |= 48 > +++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c |= 188 > ++++++++++++++++++++ > =20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > | 167 +++++++++++------ > 3 files changed, 348 insertions(+), 55 deletions(-) > > -- > 2.25.1