public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>
To: Sami Mujawar <sami.mujawar@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Ray Ni <ray.ni@intel.com>, Zhichao Gao <zhichao.gao@intel.com>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser
Date: Tue, 14 Dec 2021 11:18:07 +0000	[thread overview]
Message-ID: <BN9PR12MB5225A3F1F0D6CE3C41B7C081E0759@BN9PR12MB5225.namprd12.prod.outlook.com> (raw)
In-Reply-To: <aeb9c49a-090e-9772-80fe-c0983ea57b09@arm.com>

Hi Zhichao Gao, Ray Ni, Sami Mujawar,
   Please review and create PR if looks good.
Thanks
AbduL

-----Original Message-----
From: Sami Mujawar <sami.mujawar@arm.com> 
Sent: Monday, November 22, 2021 11:24 PM
To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>; nd <nd@arm.com>
Subject: Re: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

[CAUTION: External Email]

Hi Abdul,

Thank you for this patch series.

This series looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 22/11/2021 10:21 AM, Abdul Lateef Attar wrote:
> Hi Sami, Zhichao,
>     Addressed all review comments.
> Created two different patches, one for bitfield parser and another for 
> FADT Flags parser.
>
> Thanks
> AbduL
>
> REF : 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> ub.com%2Fabdattar%2Fedk2%2Ftree%2FFadtFlagsParser&amp;data=04%7C01%7CA
> bdulLateef.Attar%40amd.com%7C95999e9fce1346f1eb8608d9ade11d90%7C3dd896
> 1fe4884e608e11a82d994e183d%7C0%7C0%7C637732004653569840%7CUnknown%7CTW
> FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3D%7C3000&amp;sdata=%2Btp2oW%2Bo3WoF7b4RnPFot3z5vggrUiwOaL%2FiPl4U
> WHY%3D&amp;reserved=0
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Abdul Lateef Attar <abdattar@amd.com> Abdul Lateef 
> Attar (2):
>    ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser
>    ShellPkg/AcpiView: PrintFormatter for FADT Flags field
>
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  45 +++++
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              | 177 ++++++++++++++++++++
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c |  59 ++++++-
>   3 files changed, 280 insertions(+), 1 deletion(-)
>


  reply	other threads:[~2021-12-14 11:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 10:21 [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Abdul Lateef Attar
2021-11-22 10:21 ` [PATCH v3 1/2] " Abdul Lateef Attar
2021-11-22 10:21 ` [PATCH v3 2/2] ShellPkg/AcpiView: PrintFormatter for FADT Flags field Abdul Lateef Attar
2021-11-22 17:54 ` [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Sami Mujawar
2021-12-14 11:18   ` Attar, AbdulLateef (Abdul Lateef) [this message]
2021-12-14 12:04     ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR12MB5225A3F1F0D6CE3C41B7C081E0759@BN9PR12MB5225.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox