From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.62]) by mx.groups.io with SMTP id smtpd.web11.24356.1639480688917353408 for ; Tue, 14 Dec 2021 03:18:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=cunAvWe5; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.62, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J6UqHzoZYx+NLJa4NN9C6WIkCrpmGeNSvleUAFo4wFVMIQv/lrj2TD/Bb8ZRSGyVHHWDH6T4vHARsgUdxaKtZh0RwhFdSNN05YWRB2uof2F3WHqY4LBdHQ5a7FN9PMVYh5Pel9u90BreiZM8MfnGmwR1JfE7belBP4rYtpVbSU0aYroKo4snd9pp0gxjCBsJIUATd37OeVfq0r9cH4TuwfAHHkEnYIyl7bJqXoR6413+5UyziAkmR3dvUMNp09vUzgVAl6/UwtE8eN7SiLTi0A11l6epCdYUas/Ud5Q+cnnw1IWwPXBkkJDQ9RI5VgW4DZoLAdnww8nWGv1XMzolHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BVp8A6msQEGsJu41Cf46zx+EKWAdylKhrAyuaAgWAxA=; b=dClwCQAS0GS8ts+iNL9Xcqs3eBAGvnHQ/yjdEHKr1aIfGQhHeCSUcZCChT3/LAiJhmvkfZkuT4OKSqv6Cb0WoGzxh6mM5/jdXwCl2nhE/QcGMk6vIWKpF9TQoUQGb7sKSrDjd4xHvGbYPfIxUgpR8sEBG9xDomNMn7s7lR6X6I8YbXnnGDrbzBVE6I32fejSmA1687OkFIthaqEJwW+4ou7orQsuMyV3jb4HNnZG0aeTmPznlAn3hLW+sWFwcNzbJQg0bagtcjQXQu68Xn3cUXyAjoNBIDlfkkdqW7OEWXt3GVdwfk0ut8lj69aQwvRSOgoHtK3+zfZMvLu0/wjOXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BVp8A6msQEGsJu41Cf46zx+EKWAdylKhrAyuaAgWAxA=; b=cunAvWe5zj+9xy1sCccdbbgOekBJXO9VGLOAEC0ZkZFssQfEkmA3YsbgCC5JnhtFU+ZKLKLw05l8LGgJPeDDU42246payBGZ4hqBeV+3G7qT/VbanduT7ygfXOWNlV/g2mXvuiA0evwCc+o9sxKROExIesRzr5W930eQiIlgXbU= Received: from BN9PR12MB5225.namprd12.prod.outlook.com (2603:10b6:408:11e::8) by BN9PR12MB5365.namprd12.prod.outlook.com (2603:10b6:408:102::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Tue, 14 Dec 2021 11:18:07 +0000 Received: from BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::5150:f4da:66b8:c277]) by BN9PR12MB5225.namprd12.prod.outlook.com ([fe80::5150:f4da:66b8:c277%8]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021 11:18:07 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: Sami Mujawar , "devel@edk2.groups.io" , Ray Ni , Zhichao Gao CC: nd Subject: Re: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Thread-Topic: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser Thread-Index: AQHX38n8TeqZfGoVLEeMgSmUZ3dsnqwx+B0g Date: Tue, 14 Dec 2021 11:18:07 +0000 Message-ID: References: <20211122102116.22635-1-abdattar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2da5e203-e580-48d1-6fca-08d9bef3678a x-ms-traffictypediagnostic: BN9PR12MB5365:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Egxs204gFezfkZl+LNINgObl372pUAejbEeowoALrgVqmBJo40uk1CZZfNlnDFus53BhZXuoc23c5OukxUICgwExDdLI5Ik69N8wzq7o5qqiFsbt4BpnfxEjvMLEdvwnnubRjfnxsOTy9CNM1tK82zLHakF9JUA1VD6SQP1xTsjLL9jVjtr5RompXoUApQu0dA4oSGTDz5cd99fLol29tgBtzM4+ZEZBGvRlf6ZWNtnAeQMUNJUeZz0M/cJxpJVj6mXzDuf9vm/N1wAamx6wu2A3DgGNtwf4tmMT/cxXxG0JmTe6SnswHdhG9QLzUSlfxmRWC5MZ3YlajhKSWuWyNYAFN+XnovKfwSms+ReJsPjjQ5z4ttQOGCMvqHNvX69HgUVXf6egrv88zvFUN39+UgfsVMDDQtlv4hW2mLc0EqDV8OMHRdt+2RjKQKoxaa5HU5Kv78fCBoQY8vRPYj2m6S7b5eUGow4O+PpYT/TDr9QAMci1yuF26xUO7uECzzF4tITyblr3Kkn1QU2z+aDmk6xy04sjl28DCkfhdGsfJslpUNyQKAPr3k7y54BH0BKo2AyD9hUwhiCR1RADhJIjElYz82LGhmBOYkFNUruZ+U9RnrbGjCXgX/eL8NTopOtPGYJ8RMuLshsG4DjxF0QNqEl428y9757gwwpkIexhoaZMA+YyCXS6IO9yb/vM24d9YfMuJyYTX48r15RLIasneHg8thOFY2OSStxQgIkBLY4mLA/6nJG+t/eYhuulKJdZa3Sk8G/D5E0u5l77KdKuRIG2n73OvUiqRuxt9aToK/8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5225.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(55016003)(6506007)(8936002)(86362001)(7696005)(110136005)(76116006)(122000001)(53546011)(966005)(508600001)(26005)(186003)(8676002)(316002)(5660300002)(4326008)(52536014)(9686003)(66446008)(2906002)(45080400002)(66556008)(38070700005)(71200400001)(38100700002)(66946007)(66476007)(64756008)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DoiBZVFhNQFoov3nSS9+82VVXtNBpfwz6gO6W6jFJTv2M3sHVXcD1VoREyMS?= =?us-ascii?Q?2uJQclBWfmIRyf1ifcEibEaJa76Q4re+VWJrla4EOzSNH5fx7jOEZ2NHN5j+?= =?us-ascii?Q?H31V3VvjshneU90aLQvYIybfyGYeXuPr8Nqvq43wprDcp3YMFd+tatcEjLL+?= =?us-ascii?Q?KkwWymiOHo4VLd4pQe2yLr+hxuxkYvtS+bpqIxj2Hltd+Tvc6H2xT6i6aEpm?= =?us-ascii?Q?gcdNj/yB/xX+Sc/b5P5z5g28PoMI0kxE2IPaW+kujYKA6bc8ERklGrdUBioI?= =?us-ascii?Q?ZxH7Ei5mtgbARWjXeFibkaI/kGAD3J0VpZ2tG8BRAX+dd8XXl2CpbYm7MqV7?= =?us-ascii?Q?ihyeEP3Sqej9dznGZ1YLWFo9ZOci8PfGQ2nJylWyfQO1tU6xPRRXoLKdwYun?= =?us-ascii?Q?7wTO3vd1qk5CP0Q3dXX0b7Fn9MC0HztIDvXJmKi0sgtlpbaohDiot0VIdTrp?= =?us-ascii?Q?/NForOpf00p2tXrlVvcm4MvXNjYdNZoGU/z2yl3IOrD1+1Rj0dUPCxJ25zLU?= =?us-ascii?Q?DXbXvaebB5W2dNgBERPgQ40Od94XA5JBzcP/w1wbQdxXMvo2xA6QDg5NV9k9?= =?us-ascii?Q?oXaiW+f3QmaNikvO0pnuzv1sjbktRGr/0EF0jOd9dXCq960i5ikpV5OyXEaw?= =?us-ascii?Q?N87P6Fi1O1nCA8fHvE5T3YPoJH72e1tKxtwyTv0TJ49ZmIW5c7w4PHYYwq/4?= =?us-ascii?Q?dUwQ7GG4k91FKijpwqorRn8uw5yc2L+UXEdGsCRrVMHpzDElIYG6RfdeDupu?= =?us-ascii?Q?ny/vPdA6b3z0A9b7irYk0jRo4f5UuSX7OMkfFHzkXIAf2Vz815BEmbA5c+Xs?= =?us-ascii?Q?JrDLkDqAKcVjuP2xld6GfFTA2jLF6CrX3JWTfGh+jzF/lDpmjRzIst2of4EB?= =?us-ascii?Q?Fej1eeRxE9CoOJzkShx6IMI8rDSeNv8ioQrkfup0EO8VisCxRLx4VvNYAIXF?= =?us-ascii?Q?ae8fMGeWndw7qoasd8bdopegLmubfX0zKPpuA19zCLtDJgU7r7N89kz027Z3?= =?us-ascii?Q?N+yj8LI1yAxMXoXTd91Xx6HFETsoas4Iia7HBWQJlMvUuZUwjMbypAIq6+q+?= =?us-ascii?Q?TTd/h+8iG4gOkgnwX9LMJ0g1xrfJ+iwsTvIa0gXR7molo/u7PB3r5/ich8iT?= =?us-ascii?Q?R0irCLRNorPpBZTTmmrdDArYeECoeMFn9DuDUdLyDywttiOtnhzJC3WDW/7L?= =?us-ascii?Q?ZF9G4eK+DLG4xJsOIi0ZZpxW/1y836bOYTVWG8dIsYLusPZh+4shSoZsiigZ?= =?us-ascii?Q?9ivbWCYx0/0dPEeevU8N5JcCWRp6KlEmPfvKmXcLeTcvFnvOGI0m3eXA86ct?= =?us-ascii?Q?+OsVrGQHJK4lb8xbGg/cdoMnpq48xlPu0CFNoVerCcgtLs8RE8Kg7mNTIWhe?= =?us-ascii?Q?snKDqz5tganYLCmEhftToCWT/aS2i+Asc72ChX7yerAZyXrLX6uFHjVQ1wTm?= =?us-ascii?Q?TA0qMF27a69sLmT+2y8819f71OxSY+wFOi+vcLenf778JvgncjEu9cEEhf/x?= =?us-ascii?Q?m/lNr4clBp3UQZyCsJZD7EtZT55lNvUug/ChdeRoep7Z12I6K7ExKrX1j0js?= =?us-ascii?Q?zynARgjhWHHmGoUdkRFuR5RGSkGdL61x+HO58rhiEFxfio8fek7iG+nrd43G?= =?us-ascii?Q?O7W1rF7pH/Lu0V05bJF+agI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5225.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2da5e203-e580-48d1-6fca-08d9bef3678a X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 11:18:07.1917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6Xmd9IY3sAZ+wolQmZnNAnxpFNtZ82ARsnOdeh43lxqkNpFhdM9gFA0oct49+P3tTbQEM70R9nuXxfjxCTehtA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5365 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Zhichao Gao, Ray Ni, Sami Mujawar, Please review and create PR if looks good. Thanks AbduL -----Original Message----- From: Sami Mujawar =20 Sent: Monday, November 22, 2021 11:24 PM To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io Cc: Ray Ni ; Zhichao Gao ; nd Subject: Re: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield pa= rser [CAUTION: External Email] Hi Abdul, Thank you for this patch series. This series looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 22/11/2021 10:21 AM, Abdul Lateef Attar wrote: > Hi Sami, Zhichao, > Addressed all review comments. > Created two different patches, one for bitfield parser and another for=20 > FADT Flags parser. > > Thanks > AbduL > > REF :=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Fabdattar%2Fedk2%2Ftree%2FFadtFlagsParser&data=3D04%7C01%7CA > bdulLateef.Attar%40amd.com%7C95999e9fce1346f1eb8608d9ade11d90%7C3dd896 > 1fe4884e608e11a82d994e183d%7C0%7C0%7C637732004653569840%7CUnknown%7CTW > FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 > Mn0%3D%7C3000&sdata=3D%2Btp2oW%2Bo3WoF7b4RnPFot3z5vggrUiwOaL%2FiPl4U > WHY%3D&reserved=3D0 > > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar > Signed-off-by: Abdul Lateef Attar Abdul Lateef=20 > Attar (2): > ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser > ShellPkg/AcpiView: PrintFormatter for FADT Flags field > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h = | 45 +++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c = | 177 ++++++++++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c = | 59 ++++++- > 3 files changed, 280 insertions(+), 1 deletion(-) >