[Public]

Hi Heinrich,
	Not able to attach the patch to the below Bugzilla link (yet to create an account).
Hence attaching the patch with this mail.

Also find the reference branch link below.
https://github.com/abdattar/edk2-test/tree/X64_GCC_Compilation_fix

Thanks
AbduL


-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heinrich Schuchardt via groups.io
Sent: 11 November 2021 21:08
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Gjertsen, Carolyn <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen <arvinx.chen@intel.com>; Venkatesh, Supreeth <Supreeth.Venkatesh@amd.com>
Subject: Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

[CAUTION: External Email]

On 10/26/21 13:42, Abdul Lateef Attar via groups.io wrote:
> Corrects the function declaration/definition by adding EFIAPI.
> Removes duplicate functions.


Unfortunately this mail is not a valid patch:

$ wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchew.org%2FEDK2%2F20211026114226.30761-1-abdattar%40amd.com%2Fmbox&amp;data=04%7C01%7CAbdulLateef.Attar%40amd.com%7C69f89e5e843d4f4c090408d9a5295496%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637722419244229218%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=O69zx8gRDRS9%2B4bGupVaKV8R%2FBDQ6fNhz00pVzb9h3w%3D&amp;reserved=0
$ git am mbox --keep-cr
Applying: SctPkg: Fix X64 build errors for GCC toolchain
error: patch fragment without header at line 246: @@ -84,6 +85,7 @@ InitializeHIIStringBBTest ( Patch failed at 0001 SctPkg: Fix X64 build errors for GCC toolchain

Could you, please, upload the patch to
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2126&amp;data=04%7C01%7CAbdulLateef.Attar%40amd.com%7C69f89e5e843d4f4c090408d9a5295496%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637722419244239170%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=mE96wdLHZwXHoneiPcImLwvMLaohiwuYRuuaKQUzY4o%3D&amp;reserved=0

Best regards

Heinrich