From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0720.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe45::720]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AED661A1E34 for ; Thu, 20 Oct 2016 07:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+0Cedk6urwAmN4+JGAzMR16xdRwWDtxdxYKfdCvBlIA=; b=V1SqWgxa03ubvLa/CcdglfCX0KQNVs9D8pHkWaecOoduQXiH127+W3IbSri0SA9e/3JFkjTlzSBtpyGfVfRQg5mPpPhx8Yacs98GGcEHM+ZtCYEIS7QIaxyCDAXd8K9LEB640HAUM7ux3CZ0TuD38dleQZxwoQnsdRllVyIZGhI= Received: from BY1PR03MB1355.namprd03.prod.outlook.com (10.162.109.25) by BY1PR03MB1356.namprd03.prod.outlook.com (10.162.109.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Thu, 20 Oct 2016 14:49:21 +0000 Received: from BY1PR03MB1355.namprd03.prod.outlook.com ([10.162.109.25]) by BY1PR03MB1355.namprd03.prod.outlook.com ([10.162.109.25]) with mapi id 15.01.0659.028; Thu, 20 Oct 2016 14:49:21 +0000 From: Sean Brogan To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] question about a compressed Ffs3 file inside FFS2 filesystem Thread-Index: AQHSKqvKDpCaH9VQ00GEvnXKQI1tm6CxaWAw Date: Thu, 20 Oct 2016 14:49:21 +0000 Message-ID: References: <4A89E2EF3DFEDB4C8BFDE51014F606A14B497236@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B497236@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sean.brogan@microsoft.com; x-originating-ip: [50.46.222.147] x-ms-office365-filtering-correlation-id: dc1fb5e6-d996-4f93-9cd9-08d3f8f8471c x-microsoft-exchange-diagnostics: 1; BY1PR03MB1356; 7:31JWBKHgyVTawqT9Cl1UdjMMx50bwIWy06u6IC2SRncL4FwR10P6N3CrpUJfoQ+nn+yG8tMOJxHsraZrnwbQnbSU8IndjpqTmvo1RlYt5WtC5VjwYAEwImNzy50O/z43JZcsVqScjvzCFDu2Qy0bT2Le3r6PI7Ar1LqOWGJap2ZbY8fjnaJfpPnYAlfbba7tnFbL6zRFjY5m051jhszQqAp8E/YDKIJ7OEzGhKLQx1H7J+eLEGwPUbXEcgXK7jJzAiKDcVfd5+1hh2IkLOoaxf3TsUDYhXo9y/fUk4s4toHJb+f+/+eTGuKi/d8RLvLRerbUCHoVItDWecePrdWfgqiglxczACJrhNF9qNVrlc7k2++gwmhVKo9pm8G1XaFA x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1356; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(162533806227266)(228905959029699)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(61426038)(61427038); SRVR:BY1PR03MB1356; BCL:0; PCL:0; RULEID:; SRVR:BY1PR03MB1356; x-forefront-prvs: 01018CB5B3 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(189002)(13464003)(377454003)(199003)(3280700002)(107886002)(5660300001)(81156014)(7696004)(81166006)(76576001)(189998001)(74316002)(92566002)(86362001)(19580405001)(86612001)(2950100002)(2906002)(68736007)(5002640100001)(7846002)(2501003)(7736002)(305945005)(575784001)(9686002)(3660700001)(19580395003)(87936001)(11100500001)(99286002)(586003)(54356999)(76176999)(10290500002)(106356001)(10400500002)(5005710100001)(101416001)(106116001)(77096005)(105586002)(10090500001)(33656002)(122556002)(8936002)(97736004)(8676002)(66066001)(5001770100001)(6116002)(102836003)(50986999)(3846002)(8990500004)(15975445007)(2900100001)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR03MB1356; H:BY1PR03MB1355.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2016 14:49:21.5164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1356 Subject: Re: question about a compressed Ffs3 file inside FFS2 filesystem X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2016 14:49:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, Good catch not sure how that happened. Unfortunately now the problem doesn'= t make sense. The code should have IsFfs3Fv =3D True and the debug message= that indicates the code path which ignores the section should not get exec= uted. I'll look at it again today as the problem still exists, just my ana= lysis is incorrect. =20 Current workaround is to make sure FFS2 sizes and guids are used everywhere= so a problem with FFS3 is lurking somewhere. =20 Thanks Sean > -----Original Message----- > From: Gao, Liming [mailto:liming.gao@intel.com] > Sent: Thursday, October 20, 2016 1:27 AM > To: Sean Brogan ; edk2-devel@lists.01.org > Subject: RE: [edk2] question about a compressed Ffs3 file inside FFS2 fil= esystem >=20 > Sean: > In MdePkg.dec, gEfiFirmwareFileSystem2Guid and > gEfiFirmwareFileSystem3Guid are defined below. > gEfiFirmwareFileSystem2Guid =3D { 0x8c8ce578, 0x8a3d, 0x4f1c, { 0x9= 9, 0x35, > 0x89, 0x61, 0x85, 0xc3, 0x2d, 0xd3 }} > gEfiFirmwareFileSystem3Guid =3D { 0x5473c07a, 0x3dcb, 0x4dca, { 0xbd= , 0x6f, > 0x1e, 0x96, 0x89, 0xe7, 0x34, 0x9a }} >=20 > From the dump message, the root FV File System ID is 5473c07a-3dcb-4dca= - > bd6f-1e9689e7349a. It is FF3 file system. >=20 > Thanks > Liming > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Sean Brogan > > Sent: Thursday, October 20, 2016 7:09 AM > > To: edk2-devel@lists.01.org > > Subject: [edk2] question about a compressed Ffs3 file inside FFS2 > > filesystem > > > > We have a condition that occurs when we boot where we see the > > following message and our boot fails because of it. > > DEBUG ((EFI_D_ERROR, "Found a FFS3 formatted section in a non-FFS3 > > formatted FV.\n")); > > > > Which is on line 773 of FwVol.c > > ( https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Pe > > i/FwVol/FwVol.c ) > > > > The condition is caused by a large firmware volume (greater than 16mb) > > that is compressed and put into a smaller FV (less than 16mb). My > > question is why isn't this allowed (seems like a valid scenario). > > Volinfo supports this and decodes binary fine. The PI Vol 3 spec has > > a section 3.2.2 EFI_FIRMWARE_FILE_SYSTEM3_GUID which says FileSystem2 > > doesn't support large files but it seems that the code is not taking > > into account that the section is compressed and therefore you can have > > a large file inside a compressed section inside a FV with File System2. > > > > Feedback/thoughts/comments/Bug? > > > > Here are some details of my scenario. > > Compressed FV has filesystem =3D=3D 8c8ce578-8a3d-4f1c-9935-896185c32dd= 3 > > (ffs3) > > Non compressed FV has filesystem =3D=3D 5473c07a-3dcb-4dca-bd6f- > > 1e9689e7349a (ffs2) > > > > VolInfo dump of the Non Compressed FV showing the nested/compressed FV > > inside. > > > > Decoding > > VolInfo Version 1.0 Build Build 20909 > > Signature: _FVH (4856465F) > > Attributes: 4FEFF > > EFI_FVB2_READ_DISABLED_CAP > > EFI_FVB2_READ_ENABLED_CAP > > EFI_FVB2_READ_STATUS > > EFI_FVB2_WRITE_DISABLED_CAP > > EFI_FVB2_WRITE_ENABLED_CAP > > EFI_FVB2_WRITE_STATUS > > EFI_FVB2_LOCK_CAP > > EFI_FVB2_LOCK_STATUS > > EFI_FVB2_STICKY_WRITE > > EFI_FVB2_MEMORY_MAPPED > > EFI_FVB2_ERASE_POLARITY > > EFI_FVB2_READ_LOCK_CAP > > EFI_FVB2_READ_LOCK_STATUS > > EFI_FVB2_WRITE_LOCK_CAP > > EFI_FVB2_WRITE_LOCK_STATUS > > EFI_FVB2_ALIGNMENT_16 > > EFI_FVB2_ALIGNMENT_32 > > EFI_FVB2_ALIGNMENT_64 > > EFI_FVB2_ALIGNMENT_128 > > EFI_FVB2_ALIGNMENT_4K > > EFI_FVB2_ALIGNMENT_8K > > EFI_FVB2_ALIGNMENT_16K > > EFI_FVB2_ALIGNMENT_32K > > EFI_FVB2_ALIGNMENT_1M > > EFI_FVB2_ALIGNMENT_2M > > EFI_FVB2_ALIGNMENT_4M > > EFI_FVB2_ALIGNMENT_8M > > EFI_FVB2_ALIGNMENT_256M > > EFI_FVB2_ALIGNMENT_512M > > EFI_FVB2_ALIGNMENT_1G > > EFI_FVB2_ALIGNMENT_2G > > Header Length: 0x00000048 > > File System ID: 5473c07a-3dcb-4dca-bd6f-1e9689e7349a > > Revision: 0x0002 > > Number of Blocks: 0x00000028 > > Block Length: 0x00010000 > > Total Volume Size: 0x00280000 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > =3D=3D > > File Name: 9E21FD93-9C72-4C15-8C4B-E77F1DB2D792 > > File Offset: 0x00000048 > > File Length: 0x001F3FFD > > File Attributes: 0x00 > > File State: 0xF8 > > EFI_FILE_DATA_VALID > > File Type: 0x0B EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE > > ------------------------------------------------------------ > > Type: EFI_SECTION_GUID_DEFINED > > Size: 0x001F3FE5 > > SectionDefinitionGuid: ee4e5898-3914-4259-9d6e-dc7bd79403cf > > > > DataOffset: 0x0018 > > Attributes: 0x0001 > > ------------------------------------------------------------ > > Type: EFI_SECTION_RAW > > Size: 0x00000FF8 > > ------------------------------------------------------------ > > Type: EFI_SECTION_FIRMWARE_VOLUME_IMAGE > > Size: 0x01010008 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > =3D=3D > > > > Thanks > > Sean > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel