From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on071b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe49::71b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 947021A1E56 for ; Wed, 19 Oct 2016 16:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vuLSoWiWMELenZl7MYCoVotKFDyNMScfRJRGhMuOJqk=; b=kfn38Q9QZ8EjPdfuOiBZBvLJvjP+bswidCWouienQm9cFfHbid1LeeAOUM9kP8Bx5DwlXdohpjKGI6c551DWNfp+8bM5OLC4p6ya+We75zCImf4vLO3w0pxXcTzi5j/EpKD07hKiY10bFcPi6vPeWW2EeEppvkVE5J9RMRhg+NA= Received: from BY1PR03MB1355.namprd03.prod.outlook.com (10.162.109.25) by BY1PR03MB1355.namprd03.prod.outlook.com (10.162.109.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Wed, 19 Oct 2016 23:09:26 +0000 Received: from BY1PR03MB1355.namprd03.prod.outlook.com ([10.162.109.25]) by BY1PR03MB1355.namprd03.prod.outlook.com ([10.162.109.25]) with mapi id 15.01.0659.025; Wed, 19 Oct 2016 23:09:26 +0000 From: Sean Brogan To: "edk2-devel@lists.01.org" Thread-Topic: question about a compressed Ffs3 file inside FFS2 filesystem Thread-Index: AdIqXbpOUluo4wLNRc25Lw1FgoagFw== Date: Wed, 19 Oct 2016 23:09:26 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sean.brogan@microsoft.com; x-originating-ip: [2001:4898:80e8:b::73e] x-ms-office365-filtering-correlation-id: 5df76d00-53ca-4745-0951-08d3f874f912 x-microsoft-exchange-diagnostics: 1; BY1PR03MB1355; 7:MJTLlEqZo5U3OWqR3nJxBRGUtd3m5GL/MOAd/FzPL6kNBNyllIoWxQM0O+t8sTK/AvIrxOJjI08iBwSnld0ZL35+w66CuPQ4aZioSWKe5qatHalwNJJL/8qUK9XUzUa/BRYVjqdq8O1wp1ALX31lTVmCbZmD+/jJ4884rlE6klove2yELZMYmi8kwHMDl7n9KSJgr5sJtmiRqs2Cg+rJcH7aqYCGdU3yzZ7RYZcZp1nW6qFjwiV4zxYoOPThP8943mqhUtsoqoRMkAVqEZt9i5Al1W1NXYYLNFNb4MCZzLY7KEyPEniFOa6APgu2bBUa+jug781L71EHf1zBWQ1BjM8Px3dn7I2YUagHC4nemQdEMBvVI+WeHY7rY1fXWULd x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1355; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(21748063052155)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(61426038)(61427038); SRVR:BY1PR03MB1355; BCL:0; PCL:0; RULEID:; SRVR:BY1PR03MB1355; x-forefront-prvs: 0100732B76 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(7916002)(189002)(199003)(10400500002)(2900100001)(106356001)(8990500004)(7736002)(10290500002)(86362001)(74316002)(8676002)(7846002)(10090500001)(19580395003)(110136003)(81166006)(15975445007)(77096005)(81156014)(450100001)(33656002)(7906003)(5002640100001)(122556002)(5005710100001)(189998001)(7696004)(107886002)(97736004)(99286002)(87936001)(105586002)(2501003)(50986999)(101416001)(8936002)(68736007)(86612001)(11100500001)(54356999)(9686002)(5660300001)(92566002)(6116002)(229853001)(2351001)(16236675004)(790700001)(6916009)(76576001)(102836003)(3660700001)(3280700002)(575784001)(586003)(19625215002)(2906002)(19300405004)(19617315012)(3826002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR03MB1355; H:BY1PR03MB1355.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2016 23:09:26.4282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1355 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: question about a compressed Ffs3 file inside FFS2 filesystem X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 23:09:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable We have a condition that occurs when we boot where we see the following mes= sage and our boot fails because of it. DEBUG ((EFI_D_ERROR, "Found a FFS3 formatted section in a non-FFS3 formatte= d FV.\n")); Which is on line 773 of FwVol.c ( https://github.com/tianocore/edk2/blob/ma= ster/MdeModulePkg/Core/Pei/FwVol/FwVol.c ) The condition is caused by a large firmware volume (greater than 16mb) that= is compressed and put into a smaller FV (less than 16mb). My question is = why isn't this allowed (seems like a valid scenario). Volinfo supports thi= s and decodes binary fine. The PI Vol 3 spec has a section 3.2.2 EFI_FIRM= WARE_FILE_SYSTEM3_GUID which says FileSystem2 doesn't support large files b= ut it seems that the code is not taking into account that the section is co= mpressed and therefore you can have a large file inside a compressed sectio= n inside a FV with File System2. Feedback/thoughts/comments/Bug? Here are some details of my scenario. Compressed FV has filesystem =3D=3D 8c8ce578-8a3d-4f1c-9935-896185c32dd3 (= ffs3) Non compressed FV has filesystem =3D=3D 5473c07a-3dcb-4dca-bd6f-1e9689e7349= a (ffs2) VolInfo dump of the Non Compressed FV showing the nested/compressed FV insi= de. Decoding VolInfo Version 1.0 Build Build 20909 Signature: _FVH (4856465F) Attributes: 4FEFF EFI_FVB2_READ_DISABLED_CAP EFI_FVB2_READ_ENABLED_CAP EFI_FVB2_READ_STATUS EFI_FVB2_WRITE_DISABLED_CAP EFI_FVB2_WRITE_ENABLED_CAP EFI_FVB2_WRITE_STATUS EFI_FVB2_LOCK_CAP EFI_FVB2_LOCK_STATUS EFI_FVB2_STICKY_WRITE EFI_FVB2_MEMORY_MAPPED EFI_FVB2_ERASE_POLARITY EFI_FVB2_READ_LOCK_CAP EFI_FVB2_READ_LOCK_STATUS EFI_FVB2_WRITE_LOCK_CAP EFI_FVB2_WRITE_LOCK_STATUS EFI_FVB2_ALIGNMENT_16 EFI_FVB2_ALIGNMENT_32 EFI_FVB2_ALIGNMENT_64 EFI_FVB2_ALIGNMENT_128 EFI_FVB2_ALIGNMENT_4K EFI_FVB2_ALIGNMENT_8K EFI_FVB2_ALIGNMENT_16K EFI_FVB2_ALIGNMENT_32K EFI_FVB2_ALIGNMENT_1M EFI_FVB2_ALIGNMENT_2M EFI_FVB2_ALIGNMENT_4M EFI_FVB2_ALIGNMENT_8M EFI_FVB2_ALIGNMENT_256M EFI_FVB2_ALIGNMENT_512M EFI_FVB2_ALIGNMENT_1G EFI_FVB2_ALIGNMENT_2G Header Length: 0x00000048 File System ID: 5473c07a-3dcb-4dca-bd6f-1e9689e7349a Revision: 0x0002 Number of Blocks: 0x00000028 Block Length: 0x00010000 Total Volume Size: 0x00280000 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D File Name: 9E21FD93-9C72-4C15-8C4B-E77F1DB2D792 File Offset: 0x00000048 File Length: 0x001F3FFD File Attributes: 0x00 File State: 0xF8 EFI_FILE_DATA_VALID File Type: 0x0B EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE ------------------------------------------------------------ Type: EFI_SECTION_GUID_DEFINED Size: 0x001F3FE5 SectionDefinitionGuid: ee4e5898-3914-4259-9d6e-dc7bd79403cf DataOffset: 0x0018 Attributes: 0x0001 ------------------------------------------------------------ Type: EFI_SECTION_RAW Size: 0x00000FF8 ------------------------------------------------------------ Type: EFI_SECTION_FIRMWARE_VOLUME_IMAGE Size: 0x01010008 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Thanks Sean