Re: [edk2-devel] Fixing edk2-basetools CI

["Joey Vagedes via groups.io" <joeyvagedes=microsoft.com@groups.io>]

Hello. It can be simplified - You can view the pyproject.toml for edk2-pytool-library and edk2-pytool-extensions:

https://github.com/tianocore/edk2-pytool-library/blob/master/pyproject.toml

Also, Why disable flake8 rather than fix the changes? I also suggest switching to ruff, as it does the same thing but better, and with way more rules / configuration options.

Thanks,
Joey
-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com> 
Sent: Monday, February 12, 2024 3:27 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; Sean <spbrogan@outlook.com>; Michael Kubacki <mikuback@linux.microsoft.com>; Joey Vagedes <joeyvagedes@microsoft.com>
Cc: devel@edk2.groups.io
Subject: [EXTERNAL] Re: Fixing edk2-basetools CI

[You don't often get email from rebecca@bsdio.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

No, setup.py or some other build backend configuration (e.g. Hatchling, Flit or PDM) is still needed to build the distribution package.

I don't know if it could be simplified though: I'll look into that later.


Yes, I suspect we could use the CLI commands feature and remove the wrappers. I'll work on that later, probably after I've gone through the PRs.


--

Rebecca Cran


On 2/11/24 23:03, Kinney, Michael D wrote:
> Hi Rebecca,
>
> Thank you for working on this.
>
> If pyproject.toml is added, then can setup.py be removed completely?
>
> Also, the CLI commands for pyproject.toml are listed as edk2_build and 
> edk2_ecc.  Can't we use this feature of pyproject.toml to add build 
> and ecc to the command set and remove the need for the command 
> wrappers? Perhaps an additional change after we have CI working?
>
> Thanks,
>
> Mike
>
>> -----Original Message-----
>> From: Rebecca Cran <rebecca@bsdio.com>
>> Sent: Sunday, February 11, 2024 8:15 PM
>> To: Sean <spbrogan@outlook.com>; Kinney, Michael D 
>> <michael.d.kinney@intel.com>; Michael Kubacki 
>> <mikuback@linux.microsoft.com>; Joey Vagedes 
>> <joeyvagedes@microsoft.com>
>> Cc: devel@edk2.groups.io
>> Subject: Fixing edk2-basetools CI
>>
>> Hi everyone,
>>
>>
>> I've created a couple of PRs in the edk2-basetools project which I'm 
>> hoping will go towards fixing the CI and allowing releases to be 
>> published again.
>>
>> I'd appreciate any reviews.
>>
>>
>> Disable flake8: 
>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>> hub.com%2Ftianocore%2Fedk2-basetools%2Fpull%2F115&data=05%7C02%7Cjoey
>> vagedes%40microsoft.com%7C3010ff4bb5724033a86708dc2bbd8121%7C72f988bf
>> 86f141af91ab2d7cd011db47%7C1%7C0%7C638433340138909394%7CUnknown%7CTWF
>> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
>> Mn0%3D%7C0%7C%7C%7C&sdata=PFGp81sc5%2FhjgpuOE1QVukPni8TxWUAMk8FpqiHQp
>> 6E%3D&reserved=0
>>
>> Add pyproject.toml and update setup.py:
>> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>> hub.com%2Ftianocore%2Fedk2-basetools%2Fpull%2F116&data=05%7C02%7Cjoey
>> vagedes%40microsoft.com%7C3010ff4bb5724033a86708dc2bbd8121%7C72f988bf
>> 86f141af91ab2d7cd011db47%7C1%7C0%7C638433340138916993%7CUnknown%7CTWF
>> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
>> Mn0%3D%7C0%7C%7C%7C&sdata=bVr7iJr1jyXOaO7OLY4FMm4PS5VqJgXuRflUV1id%2B
>> n0%3D&reserved=0
>>
>>
>> Once CI is working again, I'll start working through the backlog of 
>> open PRs.
>>
>>
>> --
>> Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115353): https://edk2.groups.io/g/devel/message/115353
Mute This Topic: https://groups.io/mt/104306226/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-