From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EC212941B66 for ; Mon, 12 Feb 2024 16:09:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+9zSySdGJcHJ2HxqtTEv59TbzOzxabvd+MGx3QCSZ0k=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707754143; v=1; b=GXuAX/5AOFu5aJ1gfxUl11k30SLe4yowKjbHTL4tESFLL1Vz2of0lpZoyAmnlyx/i3qn4orX UMB5hiOyDZn5xCmxuAELaBrPYMCI+ROrgcSYweQOMnzfo5bMYRlox3oFq6eS66/X85j7cuTHELN bstObTKeWSAfPhUbg8rtVh7s= X-Received: by 127.0.0.2 with SMTP id FtgIYY7687511xYRyMHegBXA; Mon, 12 Feb 2024 08:09:03 -0800 X-Received: from BN1PR04CU002.outbound.protection.outlook.com (BN1PR04CU002.outbound.protection.outlook.com [52.101.56.11]) by mx.groups.io with SMTP id smtpd.web11.10227.1707754142969116705 for ; Mon, 12 Feb 2024 08:09:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KY7UrqoyITqM1dscSEIz7K54LtV1ipnoinViQfGT5PACLXDmS9xdYiXbySyURxYP+BMYas0jQi3MwatWk1R7eGnQlBpda/YMiAjSza4tX7UeugUDgHetnj+V0Ydk0AH03A3Nh+TWKmnRNQUbC1IxupUJLa1N8K4m/e/UcaAK2121K3QtfmsJQRMptcioaQqHnRRQVsLUh77IRbVuxBdHI+gIl5EYOMJPxz4PGUrqWMcUHXHsegV2766fGoImVP0xranMQNVWqHzC8n1UxD5cbt6TuxJ4k8Xofm+vY6hHsN+oYo5xPW/R4uuws+95FTWsedFXxn5RtalET4aziE1rHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/6AkbhvEa1bLkbCgkWY3u6oIAz6aeV98i5dWSf/XQCs=; b=dJt317nQVkg8pzCsK58N5Gnf4bV398CEiVpc8n+BCBS9UyS2nXUqvgDrXmRXgU+rgJXrt/AOV39c0BnNvz/8Z+mmziU7/jb3BvESOTry0Oo6fLLAWMP9AZzfOZlb076PvOKVVwvW06ixPcoKGitPF0sRe3r6L51jpaOMoXDfAa4cv6OcU8Rhg25PX6rTxmPSjMgTUu5GXqOalq82GKHQOYo8FsGK4nnln78+FEEqlaphod8O2H7Tq2Ino6Z2gBylzyV4yYuZSrv/kUfaJCYKI+tPF//9p10O1z/fZY1dJvkAUrhj4cK6GUnOOdOHmScwsSChru/nG0SIuw9TBbgtyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none X-Received: from BY1PR21MB3943.namprd21.prod.outlook.com (2603:10b6:a03:52c::19) by DS7PR21MB3645.namprd21.prod.outlook.com (2603:10b6:8:92::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.7; Mon, 12 Feb 2024 16:08:58 +0000 X-Received: from BY1PR21MB3943.namprd21.prod.outlook.com ([fe80::4c42:b704:da2d:16cb]) by BY1PR21MB3943.namprd21.prod.outlook.com ([fe80::4c42:b704:da2d:16cb%3]) with mapi id 15.20.7316.006; Mon, 12 Feb 2024 16:08:57 +0000 From: "Joey Vagedes via groups.io" To: Rebecca Cran , "Kinney, Michael D" , Sean , Michael Kubacki CC: "devel@edk2.groups.io" Subject: Re: [edk2-devel] Fixing edk2-basetools CI Thread-Topic: [EXTERNAL] Re: Fixing edk2-basetools CI Thread-Index: AQHaXXk5WpLIZMtSX0eNoPFJHCoWxbEGkcCAgABOcFA= Date: Mon, 12 Feb 2024 16:08:57 +0000 Message-ID: References: <2fe83108-e19b-4c95-8c45-08f43594e8cd@bsdio.com> In-Reply-To: <2fe83108-e19b-4c95-8c45-08f43594e8cd@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=07a9e57e-0876-4b6e-aefa-95a1a723fc53;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-12T16:07:24Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY1PR21MB3943:EE_|DS7PR21MB3645:EE_ x-ms-office365-filtering-correlation-id: e9faee2d-59af-4477-9f8d-08dc2be4eb3d x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: wKdtVdQvleV2nu/e3qMBr6puRD+nEnAvECXr9ynm1kS7yb8AStiWhtgTDCZab2Z4P8UohhAwcRbAoFiyJjZmfE1vSSEh/eA/a8fTYqBMshQmREWTa+y4Ir7M3j3+C96irpOucO3z28FJgheUpDP+A0B9EnjUUnUBX5ejG2Jh2ij6VPSLwULu+hlXAO3q9bmrQiT64B1UMKEV7bP9QfjFT7wyMJcY16NI9mssUNy6myY3bwN9EwW99KIzRDE8WC/9mT+V3ovOKSrZn632qk/iRp6YUT410qyKbojxZzR65TjiaIpIgxDd1xRMERanyeFuBBu9uKIjuhWZ/mJNc9pjv8CmD3wA8n8OK4xjkfWZDHbfm9y4v7Ibx7Jut9R8gqx9Xcg/5t/vYbvWQ06qEnIP9z1fDK6wO9vXgiqxD99cwxqqrkA0I6L9iKzVCE+4c83dmyvUyeMxaQe0Bw/bW09cwuCVjMVP9DHY1Ho1Oryzul8Ohm/h6xm2xn/ANMqtP78Ay5FXTMDPITbk7Y6lts39aELfNncC7iv9JpXKB11fHpLT35p4yQpy50J6rWLUiVBZJa178yEq2sQoDmn0LFCRg7Q2KwNK1J0QE5oqvv2sAVw= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pol08Yadg5Hw2IYt1Oi95imn9kXOmbkYlWtyb+WTyf7A/kzxKuPVQFEGe5D3?= =?us-ascii?Q?/KKV/gVsbpIyZKH4XjoiAg45nMrbo32J8wTrcYROH6nzojVsjVuiL3lP6Z5m?= =?us-ascii?Q?vvk5s5LRKfcKIf/qd3TsPmT4FbFSEd55iaL6GPP6B9K3z2FTSO9KePbTW1TZ?= =?us-ascii?Q?BrV5pC1Ckvw9zGDCHQo0Ry2+FSq4TkeCWcAffv8G/QV3MFLt18G+t0QxVCgo?= =?us-ascii?Q?FLnPpgAbL0HB3IApKCBK7Qigl2m7hzXfcBA2kCB3DDW3YtzJeDN/c/SYQbXQ?= =?us-ascii?Q?IY9UEYNubCfK2G+nGuKDO8DnM+Bs3DAqI8VGg2aLbh8vh6D0xpAzQyv+wNgX?= =?us-ascii?Q?Es6rgYujk5aa0gojBpAhjWVUgst0/9Ae5ofdOkEcfBP1G3yTLdjG633bCG6L?= =?us-ascii?Q?WmrzeJHB6vPLu68r8xy752mmeO+ufmg2DvLv5NqAEwdhqVifp819e9+H9ROg?= =?us-ascii?Q?8uf+GZ+uu0e9CeSKjeQyBBAcDhnulCJmE12sAizBNSxPOFiKScovjsOgOEqG?= =?us-ascii?Q?Rh9nhV6/t9AxJlOz16T/SwOZKL2X+EMuTEMN3GQeGEZkMUNe70JFa7GDkj2N?= =?us-ascii?Q?f2YqzvlgZv9UdsPlO6xWEptE+99YxRo9+28pUs9fCCZXQD1luQWBt6LXjI20?= =?us-ascii?Q?SaFBZMLUZm3qIlI/ks5N+8ysv59syWFBwwB+N7xdlk/zg4slghYUNQsHl3Jq?= =?us-ascii?Q?8JcCsZBseUffRJVG+4Nx+jPaSLduCjN4hzLtCfTwgDNCV445IJEhOwYZ6Exp?= =?us-ascii?Q?Y59P/GCfEaYZc5XZAsEDTZHrR4fewMPtpsPrNzxUR9JhJBqgSl+fazJl2jg8?= =?us-ascii?Q?FI4W20I8MfGSKzJeJZmFTdSqqJNIxcVYANZBFXP56/N1rNp0Aw6iiTUSBvZJ?= =?us-ascii?Q?EgIa3eBLdLpCzAf1J9ybOLvFga3xV0rPaW9IsjP1uWlvbMoMn9PpgH5ErjXU?= =?us-ascii?Q?XEGGMom4+fi3fqC68txZn5Nq55o3XUjJ1G59jAFVs8WD49INPpLtiVg1ew/p?= =?us-ascii?Q?xZZZwxYuibtJ/KlIvX+UXNLfeotGfk2O1nh9hyjZbVV80P6lY5qCbWpYmdEf?= =?us-ascii?Q?2JQJp7/r4NdCp8pRggj3FdIFY3h5mdg3UyPnqqBHr4qM5EW67qVKC1dVva8U?= =?us-ascii?Q?mW8yiEn8FQOXlUKi8kN4peq5fXXm+1lzLTR/kCqgHFtp18/NQpqHQVzbXhif?= =?us-ascii?Q?tOgiKQ6ZLT44y0e5zMKZaaGEZnBxevCvtY8X88X7neA4cTX/me7gbbuSgm+b?= =?us-ascii?Q?hQduDD2hmKgZmGe+a2Q2wPlS8kVV+UyXHzpwWeL8F8BmgIFU6PuJIui2t13C?= =?us-ascii?Q?Cg4kYcM0jlfM9n8e9kA+WnlDWQomAXbswzMq17owohSw58yybWsaC0aoJH2S?= =?us-ascii?Q?IDK5hwm3/klGZSQtTOverbnCFGy8TcRzVbY/I5ApRJaJPDIXuooD7poG5v/3?= =?us-ascii?Q?nWJyjbW9hblr+O6HM9eHVY03suhk1PSYlrOcMb/cBjQYRe7iACSGyAJRRB1t?= =?us-ascii?Q?lvu+qE7IYeAUCheTa/g8/CJi7DIZSUPGcUiE?= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY1PR21MB3943.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9faee2d-59af-4477-9f8d-08dc2be4eb3d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2024 16:08:57.8478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: My5eg6LAvXEhbo+LmwDiZ43sb382gEe2cMEAuZoHHo0oSgsC5NnxLkNSVP34MfhT76xtNQ0/vzuEyZsMyEP9EohdVYWCznG8MlPXOZ6yHAA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR21MB3645 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,joeyvagedes@microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EO5mF3YSgDBSNa0vpfchaTypx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="GXuAX/5A"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello. It can be simplified - You can view the pyproject.toml for edk2-pyto= ol-library and edk2-pytool-extensions: https://github.com/tianocore/edk2-pytool-library/blob/master/pyproject.toml Also, Why disable flake8 rather than fix the changes? I also suggest switch= ing to ruff, as it does the same thing but better, and with way more rules = / configuration options. Thanks, Joey -----Original Message----- From: Rebecca Cran =20 Sent: Monday, February 12, 2024 3:27 AM To: Kinney, Michael D ; Sean ; Michael Kubacki ; Joey Vagedes Cc: devel@edk2.groups.io Subject: [EXTERNAL] Re: Fixing edk2-basetools CI [You don't often get email from rebecca@bsdio.com. Learn why this is import= ant at https://aka.ms/LearnAboutSenderIdentification ] No, setup.py or some other build backend configuration (e.g. Hatchling, Fli= t or PDM) is still needed to build the distribution package. I don't know if it could be simplified though: I'll look into that later. Yes, I suspect we could use the CLI commands feature and remove the wrapper= s. I'll work on that later, probably after I've gone through the PRs. -- Rebecca Cran On 2/11/24 23:03, Kinney, Michael D wrote: > Hi Rebecca, > > Thank you for working on this. > > If pyproject.toml is added, then can setup.py be removed completely? > > Also, the CLI commands for pyproject.toml are listed as edk2_build and=20 > edk2_ecc. Can't we use this feature of pyproject.toml to add build=20 > and ecc to the command set and remove the need for the command=20 > wrappers? Perhaps an additional change after we have CI working? > > Thanks, > > Mike > >> -----Original Message----- >> From: Rebecca Cran >> Sent: Sunday, February 11, 2024 8:15 PM >> To: Sean ; Kinney, Michael D=20 >> ; Michael Kubacki=20 >> ; Joey Vagedes=20 >> >> Cc: devel@edk2.groups.io >> Subject: Fixing edk2-basetools CI >> >> Hi everyone, >> >> >> I've created a couple of PRs in the edk2-basetools project which I'm=20 >> hoping will go towards fixing the CI and allowing releases to be=20 >> published again. >> >> I'd appreciate any reviews. >> >> >> Disable flake8:=20 >> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit >> hub.com%2Ftianocore%2Fedk2-basetools%2Fpull%2F115&data=3D05%7C02%7Cjoey >> vagedes%40microsoft.com%7C3010ff4bb5724033a86708dc2bbd8121%7C72f988bf >> 86f141af91ab2d7cd011db47%7C1%7C0%7C638433340138909394%7CUnknown%7CTWF >> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 >> Mn0%3D%7C0%7C%7C%7C&sdata=3DPFGp81sc5%2FhjgpuOE1QVukPni8TxWUAMk8FpqiHQp >> 6E%3D&reserved=3D0 >> >> Add pyproject.toml and update setup.py: >> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit >> hub.com%2Ftianocore%2Fedk2-basetools%2Fpull%2F116&data=3D05%7C02%7Cjoey >> vagedes%40microsoft.com%7C3010ff4bb5724033a86708dc2bbd8121%7C72f988bf >> 86f141af91ab2d7cd011db47%7C1%7C0%7C638433340138916993%7CUnknown%7CTWF >> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6 >> Mn0%3D%7C0%7C%7C%7C&sdata=3DbVr7iJr1jyXOaO7OLY4FMm4PS5VqJgXuRflUV1id%2B >> n0%3D&reserved=3D0 >> >> >> Once CI is working again, I'll start working through the backlog of=20 >> open PRs. >> >> >> -- >> Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115353): https://edk2.groups.io/g/devel/message/115353 Mute This Topic: https://groups.io/mt/104306226/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-