Re: Setting BuildOptions by module type does not seem to work

[Kurt Kennett <Kurt.Kennett@microsoft.com>]

Okay this seems to work:

[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]

Thanks Andrew.

(doesn't match the spec though :) )

K2

-----Original Message-----
From: afish@apple.com [mailto:afish@apple.com] 
Sent: Monday, August 15, 2016 10:30 AM
To: Kurt Kennett <Kurt.Kennett@microsoft.com>
Cc: edk2-devel <edk2-devel@lists.01.org>
Subject: Re: [edk2] Setting BuildOptions by module type does not seem to work


> On Aug 15, 2016, at 9:34 AM, Kurt Kennett <Kurt.Kennett@microsoft.com> wrote:
> 
> No, I had not tried that.  I tried it now and it does not seem to work.
> 
> I have:
> 
> [BuildOptions.AARCH64.common]
>    *_VS2015x86_AARCH64_DLINK_FLAGS = /BORK
> 
> [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER]
>    *_VS2015x86_AARCH64_DLINK_FLAGS = /PLOR
> 
> [BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER]
>    *_VS2015x86_AARCH64_DLINK_FLAGS = /BONK
> 
> And the only one that makes it to the command line is the /BORK one.
> 
> (The tools do not complain about the specification of options as above).
> 

I'm guessing the syntax checking is not very good? 
[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
[BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER]

I see the [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] form used in other places, but you have an extra .common? 

Thanks,

Andrew Fish

> K2
> 
> -----Original Message-----
> From: afish@apple.com [mailto:afish@apple.com]
> Sent: Monday, August 15, 2016 9:22 AM
> To: Kurt Kennett <Kurt.Kennett@microsoft.com>
> Cc: edk2-devel <edk2-devel@lists.01.org>
> Subject: Re: [edk2] Setting BuildOptions by module type does not seem 
> to work
> 
> 
>> On Aug 15, 2016, at 9:10 AM, Kurt Kennett <Kurt.Kennett@microsoft.com> wrote:
>> 
>> DSC spec (January 2016 1.26) says I can do this:
>> 
>> (Section 3.6 pp 76)
>> 
>> ...
>> * [BuildOptions.$(arch).CodeBase.Edk2ModuleType]
>> ...
>> 
>> And this works fine:
>> 
>> [BuildOptions.AARCH64.common]
>>   *_VS2015x86_*_DLINK_FLAGS = /BORK
>> 
>> But when I also do:
>> 
>> [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER]
>>   *_VS2015x86_*_DLINK_FLAGS = /PLOR
>> 
>> The link flags are not affected on the command line - they get the /BORK for all module types, but not the /PLOR for DXE_RUNTIME_DRIVERs.
>> 
> 
> Kurt,
> 
> Have you tried [BuildOptions.AARCH64.EDKII.DXE_RUNTIME_DRIVER]? Do you need EDK compatibility? 
> 
> I'm guessing that works given:
> ~/work/src/edk2(master)>git grep "BuildOptions." -- *.dsc | grep 
> DXE_RUNTIME_DRIVER 
> OvmfPkg/OvmfPkgIa32.dsc:49:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIV
> ER] 
> OvmfPkg/OvmfPkgIa32X64.dsc:54:[BuildOptions.common.EDKII.DXE_RUNTIME_D
> RIVER] 
> OvmfPkg/OvmfPkgX64.dsc:54:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVE
> R] 
> QuarkPlatformPkg/Quark.dsc:885:[BuildOptions.common.EDKII.DXE_RUNTIME_
> DRIVER]
> 
> 
>> I'm not familiar with the DSC processing tools source.  Anybody know where to look to see why not?
>> 
> 
> It starts here: 
> https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/
> build/build.py and uses some code from: 
> https://github.com/tianocore/edk2/tree/master/BaseTools/Source/Python/
> Common
> 
> Thanks,
> 
> Andrew Fish
> 
>> K2
>> 
>> 
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel