public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Christopher Zurcher" <christopher.zurcher@outlook.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"jiewen.yao@intel.com" <jiewen.yao@intel.com>,
	Christopher Zurcher <zurcher@gmail.com>
Cc: "Li, Yi1" <yi1.li@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
	"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction support for IA32
Date: Thu, 22 Sep 2022 01:45:20 +0000	[thread overview]
Message-ID: <BY3PR06MB8018D454F988062F5B888BDDE44E9@BY3PR06MB8018.namprd06.prod.outlook.com> (raw)
In-Reply-To: <MW4PR11MB5872381AB8F65A3626D4A43D8C4E9@MW4PR11MB5872.namprd11.prod.outlook.com>

I have verified performance gains and functional integrity in SHA256, SHA384, and SHA512 hashing as well as AES encryption on Intel hardware as well as QEMU. The assembly implementations included with this patch are limited to SHA and AES to reduce size impact, and to match the currently-available accelerations in the X64 equivalent library. These flows have also been validated on in-market hardware. Previous benchmarking of this code demonstrated a 12x speed improvement for SHA256 compared to the base algorithm.

Thanks,
Christopher Zurcher

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
Sent: Wednesday, September 21, 2022 17:54
To: Christopher Zurcher <zurcher@gmail.com>; devel@edk2.groups.io
Cc: Li, Yi1 <yi1.li@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction support for IA32

Thanks.
Would you please add more detailed description on what test you have done?

e.g. Real platform? Unit Test? Etc.

> -----Original Message-----
> From: Christopher Zurcher <zurcher@gmail.com>
> Sent: Thursday, September 22, 2022 4:26 AM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 <yi1.li@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; 
> Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1 
> <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction 
> support for IA32
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3654
> PR: https://github.com/tianocore/edk2/pull/3352
> 
> This patch adds support for building the native instruction algorithms 
> for the IA32 architecture in OpensslLib. The base variant has been 
> tested with VS2019 and CLANGPDB toolchains, and a GCC variant is also provided.
> 
> The implementation here follows the previous implementation of X64 
> native instructions as committed in 878a92a887.
> 
> Cc: Yi Li <yi1.li@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> 
> Christopher Zurcher (3):
>   CryptoPkg/OpensslLib: Add native instruction support for IA32
>   CryptoPkg/OpensslLib: Commit the auto-generated assembly files for
>     IA32
>   CryptoPkg/OpensslLib: Update generated files for native X64
> 
>  CryptoPkg/CryptoPkg.ci.yaml                                   |    4 +
>  CryptoPkg/Library/OpensslLib/IA32/crypto/aes/aesni-x86.nasm   | 3212
> +++++++++++++++++++
>  CryptoPkg/Library/OpensslLib/IA32/crypto/aes/vpaes-x86.nasm   |  651
> ++++
>  CryptoPkg/Library/OpensslLib/IA32/crypto/modes/ghash-x86.nasm |  700
> ++++
>  CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha1-586.nasm    | 1394
> ++++++++
>  CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha256-586.nasm  | 3364
> ++++++++++++++++++++
>  CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha512-586.nasm  |  579
> ++++
>  CryptoPkg/Library/OpensslLib/IA32/crypto/x86cpuid.nasm        |  433 +++
>  CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/aes/aesni-x86.S   | 3247
> +++++++++++++++++++
>  CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/aes/vpaes-x86.S   |  670
> ++++
>  CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/modes/ghash-x86.S |  703
> ++++
>  CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha1-586.S    | 1389
> ++++++++
>  CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha256-586.S  | 3356
> +++++++++++++++++++
>  CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha512-586.S  |  574
> ++++
>  CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/x86cpuid.S        |  449 +++
>  CryptoPkg/Library/OpensslLib/OpensslLibIa32.inf               |  699 ++++
>  CryptoPkg/Library/OpensslLib/OpensslLibIa32Gcc.inf            |  699 ++++
>  CryptoPkg/Library/OpensslLib/OpensslLibX64.inf                |   53 +
>  CryptoPkg/Library/OpensslLib/OpensslLibX64Gcc.inf             |   53 +
>  CryptoPkg/Library/OpensslLib/UefiAsm.conf                     |   18 +
>  CryptoPkg/Library/OpensslLib/process_files.pl                 |   12 +
>  21 files changed, 22259 insertions(+)  create mode 100644 
> CryptoPkg/Library/OpensslLib/IA32/crypto/aes/aesni-x86.nasm
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32/crypto/aes/vpaes-x86.nasm
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32/crypto/modes/ghash-x86.nasm
>  create mode 100644 CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha1-
> 586.nasm
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha256-586.nasm
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha512-586.nasm
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32/crypto/x86cpuid.nasm
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/aes/aesni-x86.S
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/aes/vpaes-x86.S
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/modes/ghash-x86.S
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha1-586.S
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha256-586.S
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha512-586.S
>  create mode 100644
> CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/x86cpuid.S
>  create mode 100644 CryptoPkg/Library/OpensslLib/OpensslLibIa32.inf
>  create mode 100644 CryptoPkg/Library/OpensslLib/OpensslLibIa32Gcc.inf
> 
> --
> 2.29.2.windows.2







  reply	other threads:[~2022-09-22  1:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21 20:25 [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction support for IA32 Christopher Zurcher
2022-09-21 20:25 ` [PATCH v1 1/3] " Christopher Zurcher
2022-09-21 20:25 ` [PATCH v1 2/3] CryptoPkg/OpensslLib: Commit the auto-generated assembly files " Christopher Zurcher
2022-09-21 20:25 ` [PATCH v1 3/3] CryptoPkg/OpensslLib: Update generated files for native X64 Christopher Zurcher
2022-09-22  0:53 ` [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction support for IA32 Yao, Jiewen
2022-09-22  1:45   ` Christopher Zurcher [this message]
2022-09-23 10:34     ` [edk2-devel] " Yao, Jiewen
     [not found]     ` <171776D81421E66F.25721@groups.io>
2022-09-23 11:08       ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY3PR06MB8018D454F988062F5B888BDDE44E9@BY3PR06MB8018.namprd06.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox