From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.92.41.49]) by mx.groups.io with SMTP id smtpd.web11.6154.1680294008427412935 for ; Fri, 31 Mar 2023 13:20:08 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=Lvmd9AX+; spf=pass (domain: outlook.com, ip: 40.92.41.49, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dOWv0R2MeP+NiApa4CU0MNPCCQV1KBE1RUq9YCDHR1PrPb50lNhLOqYJ2dqx5WGbfFZSmK1k7YTzAcTWw0VXZHk8o7Ht8vyRWZG/lcOl6vRZLpAKoI5OCLBK+eEQVqGt70TafpZ4iI04hxTwwmgd40lUJhiNZjUVAS3U7DYoM3U1D6cy5AfwVb9CrETA+s0iWZwWIfZ8LUOwES4RbJ9YDhpd0mbkeSCfOuTT0IO3FkeQwSa3V533vlQKw9jD1b8shvvrKRCiPAcPokYWMtHO/zhJqShKRLl8fECikprH730HfLlAEo2GgJt0gS05vpIVKfye9k3mxK8RspIr0Caopw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhxP3K6P8UwJ8Yqp33fvKxojGX4R7cOpTCmjc97T258=; b=Qv/pzsmlRMRAOfv+ymZU/3g8khWw4Ql/DkyP+6+oGrju+83y74grQgRUdKUns0rvrqe79sC9x5xOc0z6LbLME7CsLV5cPPZnJuSudEw5qiIIylqtLQ+f3O8PuCTa6ExAJKlpK5l57nU202lGMXXwbGSAUzi+Sz/VaVn6I+IK5ExgpY7Gt8Gjto4ICzvjjVYmSr7qh2iHzDG7sX5WlX3u5gE+di1wUHfG5CL7YLKB7UKrnvHgPgi/evQjTokJ3lBGYqsOKVZvKpRQj0aWBSfXbP2TTqTEtef9qP6jgPVXbHOucusoiIgt/wDI5OnE8uZpFik8H5sIfEhPimxkdIK96g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MhxP3K6P8UwJ8Yqp33fvKxojGX4R7cOpTCmjc97T258=; b=Lvmd9AX+3NyxbqCiDXVbRsKL/UIfe8ZZq41b4106pDew2/u/ktMXFbRa6lAlJrRrg1L29I77kkQtET3zavhGG/n+gO/do+X3zaIKPmb29rK9lpJDLmnEZyOmBTu2SbqAZ2FexTvtBnE0cZGuvfqmjN/BnRNyOCGP1i7pxX8lWtW9HSMvvmUhvYS5ujLK8FkRMu2a1dgn/OmCys1YSmSzKMhd2NAbq87tgb7m9jjkGOugeHdtk/vjeN36Bq94w/uqtk/9eQ9lhi31n0+gDwlTWjWs8LLgz4FZonGmTJlCMZ0Hr8fXMv2VBE5MUSNrvnDF4KEWewBl/DHq0VcPE/+PYQ== Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) by LV2PR19MB5957.namprd19.prod.outlook.com (2603:10b6:408:171::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 31 Mar 2023 20:20:06 +0000 Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::dbe5:112f:db31:2409]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::dbe5:112f:db31:2409%5]) with mapi id 15.20.6086.024; Fri, 31 Mar 2023 20:20:06 +0000 Message-ID: Date: Fri, 31 Mar 2023 13:20:03 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH v3 1/3] Platform/AMD: Adds MinBoardPkg to support MinPlatformPkg To: devel@edk2.groups.io, abdattar@amd.com CC: Ard Biesheuvel , Leif Lindholm , Abner Chang , Michael D Kinney References: From: "Sean" In-Reply-To: X-TMN: [tKpsw6tMB4HsSSBCdmWqq5O+ZZlUz7aI] X-ClientProxiedBy: MW4PR04CA0032.namprd04.prod.outlook.com (2603:10b6:303:6a::7) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <838a837d-a4f0-6bed-b724-2a969f875b81@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR19MB4900:EE_|LV2PR19MB5957:EE_ X-MS-Office365-Filtering-Correlation-Id: a95bf733-2618-4945-bef6-08db3225512b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PoZczi8b5TkXLGhdFoK+OuhQ4Bc0V4rYZUyG0TVC+jyM1FhIbAih1A9pJkddRYxmNkB7WyHK2bPKkfqPI+SVw/5RcynJTxQAHXuZTFYmzFSXdso1u3vWyXDcU3TxZHJuKNvHKgec4T6Gx5/Ng2P1ubBxn7oGDpZJ0Juoc3hqtncN4kWXgYhSBSedgXDEQWIsBA7ziZdtnOrqrUCW24ok/Ra58HUuaHrNhKXt5Qho/6hnKtUL4F/tqk6K2r7efR8TH3jiZdncp+ZZfRZaLk1+KRqzjMTmUKf074oVmKBKz4pMYJA1RzswzPwdotrE5LvHfSB5Xn38ttk8YZmiDy8hswA/AjH72Tq2gNago3WpQWZrucF99/XuVJrrVADFw7+JJHJ9CAQZAVKUfSU+OFbhI0fmiXS+J+iX/2khpTpRYT4A7EszVZRqMYs2ZhzjV8YLhGGtZucJuRUxTskxbHDls8P0YasXJiIcJ8txHfH7EUm3JE4bO6Km7ERvhKWPAdTdvfgjHK/JMMGCxrF7qurG1LXOk6OYSMjxFyrKfYMiFZ1ECGAUG466HYYePn825GENLWc9qY7Z7hG56NBi3hWdub+jfbbwXlia7RuFFSXhMN4= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TYBwonQgvBFzSF9JFC6uljCEuxh89MOO6dsbRuSLmSLHZeSzo3CiOX3znYvX?= =?us-ascii?Q?8TuKNPPh4NXR8SXp3zW84q4D80L6spfIsvU0+RSTlxzhcf5Fbprj+cg/H9Fu?= =?us-ascii?Q?7zggtRaYhurVZnvOXvQ0Je0WRAcJbEm6slhkL66LFDEf8UsfPntW+LMpwxTb?= =?us-ascii?Q?2c+hVMISQQvGB6gHHSuJTsgj8DXOMBvQBH5p0EP3L+9qrduSNz18Q3UnoEgY?= =?us-ascii?Q?OfzJ6XAj8GjxBxerpU/SOnDa3z1Nq+Wx26a8n0vq/DHSU2x6/ecJnvkm8VNW?= =?us-ascii?Q?5oE7mFz02z+Vbrw4dmqEz/ZjIGkru0gOX/2v01Lc3u0Nd4TWlV+46g3Goi+C?= =?us-ascii?Q?UMjM72rYLAklg+dBMJOptZIKU4hCTMGPbv00IM+p57Xba92NeGd38H62w2Gy?= =?us-ascii?Q?+TvpaQeqGG0rgxxUfwGMhW7w2payPRh6IrhvYerbuVaRMZKhbjKvYpbBz2Qi?= =?us-ascii?Q?4USP9Gu4Owm5N+hyDPUbpnsL0hKG/1rc0ENQCFcCqQ/BXXoO6fHYrus3r8jk?= =?us-ascii?Q?k1ivV59hsqMFWqYs0t9Ln1sjTfD2H/8szebcmB2fbIKR7zDCC685IQiBaRuF?= =?us-ascii?Q?N4XhWGK22Qsj+CDCY/Ve8mnOR9W29NvI27OzTbGt6nY8U+KFxjwoD4LQt+Ht?= =?us-ascii?Q?zAxLzmxj9ibE73tn73+omPoMUNB+iEKPNl6A9+0MyarU8TlCvSF0QI55qFsi?= =?us-ascii?Q?bYaak1ovT5qnIAje7+G6F7uRIl9vk+VbdPZ+GcUSxp8MpmHj1PJAuMAd/YS7?= =?us-ascii?Q?gRHBrHjeTj3mdKfSvRtYpP9O5KWMhD/uZOWTAYvLofyGlo9WJlhu48dCUkEU?= =?us-ascii?Q?uOh5HkwwC5OnQVvkjLdce3BTBW4P7p6mmzYy/2lDS+xRhRyaIsQDw0ypAdKb?= =?us-ascii?Q?UMffSbPkdR7pmckoROeMFOPREhL9c61M1BakdB1029O4I3zhQfZcBcoYIC4A?= =?us-ascii?Q?5fNgUCMxIv3c05opGov7NcEtHrqZXsAGByG+O/1VpIwxC4+vrM42vHJsZtHV?= =?us-ascii?Q?SnB40rxNFbuYDjO3ipAMVZZ1KyMYWPDWnqEb3Jc/vnvj+k3RLIlY9NB0Gjdj?= =?us-ascii?Q?ckH57p/vSUE17yqMKvGwQVo5gGrKzI6ITfwv/8vjEEpTCuMAXn4wjLe8JrUA?= =?us-ascii?Q?bUvMsyZ3VLTXh8YCIjOdCm6xFoaedHVpjUZ9u6B4HO6pw5b3qmlky6p/6Blm?= =?us-ascii?Q?//eafnJJlHY/dESGZWPBoGpf4/SciPiIUMtZpg=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a95bf733-2618-4945-bef6-08db3225512b X-MS-Exchange-CrossTenant-AuthSource: BY3PR19MB4900.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 20:20:06.2556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR19MB5957 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Regardless of directory path I would suggest that all "Packages" have a=20 unique and descriptive name.=C2=A0 MinBoardPkg doesn't meet that=20 suggestion.=C2=A0=C2=A0 If/when the edk2 CI tools run I would expect proble= ms/odd=20 behavior if two packages collide in naming. Thanks Sean On 3/22/2023 11:13 PM, Abdul Lateef Attar via groups.io wrote: > Adds initial DEC and DSC file for MinBoardPkg. > This package provides supporting modules for AMD boards to > leverage MinPlatformPkg framework. > > Signed-off-by: Abdul Lateef Attar > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Abner Chang > Cc: Michael D Kinney > --- > Platform/AMD/MinBoardPkg/MinBoardPkg.dec | 19 +++++++++++++++++++ > Platform/AMD/MinBoardPkg/MinBoardPkg.dsc | 21 +++++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 Platform/AMD/MinBoardPkg/MinBoardPkg.dec > create mode 100644 Platform/AMD/MinBoardPkg/MinBoardPkg.dsc > > diff --git a/Platform/AMD/MinBoardPkg/MinBoardPkg.dec b/Platform/AMD/MinB= oardPkg/MinBoardPkg.dec > new file mode 100644 > index 000000000000..23d737d196a2 > --- /dev/null > +++ b/Platform/AMD/MinBoardPkg/MinBoardPkg.dec > @@ -0,0 +1,19 @@ > +## @file MinBoardPkg.dec > +# Declaration file for AMD's MinBoardPkg. > +# > +# This package supports AMD processor family based board as per the Min= Platform > +# Arch specification. > +# > +# Copyright (c) 2023, Advanced Micro Devices, Inc. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +# @par Specification Reference: > +# -https://tianocore-docs.github.io/edk2-MinimumPlatformSpecification/= draft/ 0.7 > +## > + > +[Defines] > + DEC_SPECIFICATION =3D 1.27 > + PACKAGE_NAME =3D MinBoardPkg > + PACKAGE_GUID =3D 44F9D761-9ECB-43DD-A5AC-177E5048701= B > + PACKAGE_VERSION =3D 0.1 > + > diff --git a/Platform/AMD/MinBoardPkg/MinBoardPkg.dsc b/Platform/AMD/MinB= oardPkg/MinBoardPkg.dsc > new file mode 100644 > index 000000000000..8c120c0649e7 > --- /dev/null > +++ b/Platform/AMD/MinBoardPkg/MinBoardPkg.dsc > @@ -0,0 +1,21 @@ > +## @file > +# MinBoardPkg.dsc > +# > +# Description file for AMD MinBoardPkg > +# > +# Copyright (c) 2023, Advanced Micro Devices, Inc. All rights reserved. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + DSC_SPECIFICATION =3D 1.30 > + PLATFORM_GUID =3D 88F8A9AE-2FA0-4D58-A6F9-05F635C05F4E > + PLATFORM_NAME =3D MinBoardPkg > + PLATFORM_VERSION =3D 0.1 > + OUTPUT_DIRECTORY =3D Build/$(PLATFORM_NAME) > + BUILD_TARGETS =3D DEBUG | RELEASE | NOOPT > + SUPPORTED_ARCHITECTURES =3D IA32 | X64 > + > +[Packages] > + MinBoardPkg/MinBoardPkg.dec > +