From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.92.45.42]) by mx.groups.io with SMTP id smtpd.web10.11563.1623773047054381932 for ; Tue, 15 Jun 2021 09:04:07 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=hOLD9NA6; spf=pass (domain: outlook.com, ip: 40.92.45.42, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FFTPVxqtnMgM7Qnwyg9UyGJiN1rd7aR4dehaf6osTW7d75mwuiGBgRpbG/tcR5RqiLvw2kn++xrIdqjvuKhhUU7s0Fr/snMBCvyOKEcAkmdQJOTVfhvHntJIed5wh+ynzVe0d0n/FdqG9hMOGIAfXhq3I0i1Xk8wWNZrL+ldLUDNVlNhItBJzNk+Ee5WbpUOgdTNcWR0JW/Aa+ESmFdQ7vXFzmvElHA7Fqmcj5iZP4L4wd1Fs8gwLxruuA0Gm+mZjhBbJTQSCde+fhYSkccPv2/CUYDsDF4rAAn/D1Ywlohw8U8k/EKekRpEs8jrf+Qz5UQqqlxw3/4lgOnzvzFtHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QB4X/WSzs56ZXL/IhWlmu7CdGPq49O3alNcJujXzB40=; b=IghrIc7KBulUeqoZJy+UwSnj5uGHzOiR3GVDwiya3WxiSy2Nwf642IgJNEswOdBDlWGX/pMpMLST6KdKhiciPrqTR+3d4MZ0ATDcTSWMISWCwx6ziFTdoNY1JNn3+Aw65N4aQKXQ6G5dwADOEn3CVbSNLzvdf+UCB+0uTyMToSGUfbamS401o/9T+9CY4PVlpLv7rankPK709TcNGhytk+7ysF5PiHQvJVcWI+LSv63CX0A6SCFdk7LrXkdOGFHG1UkDZoigQyPhePKgeeuNUfWBwR0gxB/CgTQJzy8Oh0JXVQnu6rTsEhVaWLYsdTJU54yuOmO/fdzqXm/V4KxoeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QB4X/WSzs56ZXL/IhWlmu7CdGPq49O3alNcJujXzB40=; b=hOLD9NA6tp6ZBGKOlSN+aouk4wzhhvxaOEHbt29d/Yq1VccaG3xy6YLj0ZrbjWE3sdReEvOGctWVuYny9y+ZtzsCRHlNk0jTlP4cdoj/zwXIV8O6FcpIjO0fFrqs63R0LubsH6smAJcDXNyw9DcCbxtMGwNvXpxU3Z2hLSCgnHn3lGZnp/cMwa831AQFX9CQiQZF9BhRrhKQV1gvoMBJZeipazfM9Y0We3IgJYge+8JceurJtRVJB0tZWeSSlJoBrk2Fv3I9e8KkR5OQEuuWFJavTy8n/BuN3c3bsdvQ6cfQFptTg/DcZ/WSv9BILYr4142SSRZESwmrYUg8/y+FGQ== Received: from DM6NAM04FT024.eop-NAM04.prod.protection.outlook.com (2a01:111:e400:7ea3::4d) by DM6NAM04HT246.eop-NAM04.prod.protection.outlook.com (2a01:111:e400:7ea3::437) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Tue, 15 Jun 2021 16:04:05 +0000 Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2a01:111:e400:7ea3::48) by DM6NAM04FT024.mail.protection.outlook.com (2a01:111:e400:7ea3::172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22 via Frontend Transport; Tue, 15 Jun 2021 16:04:05 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:D75116EF350A5911EE35DE5B1FAF0A06424220C48F035220139C0592E55CEED0;UpperCasedChecksum:7B486E946F156FEAA7C9512E460BA066A96C1FD38331C3A9F0FEF75D5760C0F2;SizeAsReceived:9174;Count:48 Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::99cc:b318:2817:77ab]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::99cc:b318:2817:77ab%7]) with mapi id 15.20.4242.016; Tue, 15 Jun 2021 16:04:05 +0000 Subject: Re: [edk2-devel] [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure To: devel@edk2.groups.io, pierre.gondois@arm.com, kuqin12@gmail.com CC: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Laszlo Ersek , Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh References: <20210614183431.1657-1-kuqin12@gmail.com> From: "Sean" Message-ID: Date: Tue, 15 Jun 2021 09:04:03 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: X-TMN: [SKzokER7QZW7XWAx+Z5C5W2UVPDkh9Lk] X-ClientProxiedBy: MW4PR03CA0307.namprd03.prod.outlook.com (2603:10b6:303:dd::12) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <28aac111-c564-2b95-6873-d01267bdc88b@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MW4PR03CA0307.namprd03.prod.outlook.com (2603:10b6:303:dd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15 via Frontend Transport; Tue, 15 Jun 2021 16:04:04 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 7a028e72-d245-40a2-7b9e-08d93017334c X-MS-TrafficTypeDiagnostic: DM6NAM04HT246: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GjWrz8prV1yz1zseUyRnM70J79HxKmZ1QCxOfevhJvq5tA2klI1w8LdbzESXl4dDWURdSRmTSzmGoDzz15ls4ca3qwyb/O3RnzhYbE43jiLoQC74bWZA+UeQIGgCnUUxBYK+UvrbcR5v6tUrRIpwilxCdxbjswIagP6YTskD3+OEtUO18sLlnZZKWbM1VG9SJddiI8IufIiqARziLXqkI0KfxM62ybgPj2pXntoGiBu5qJ/zEJeDJ+dfOCREopY1MEbT8OShKysy5ayzdyAZyyzwAF324+2e2cfHNkBNx4Ed4CLsyZN+HEwW3Psbr00S1JUo25wPD0LxpP89RwkW+pWWtY3lkogvNUc9awekFn+QyP9KOayj1Q96b+3Vzwlv95cT1Il3p5eDJ9SslkE27XoOZRW5vOp84iWTc+xqSadJ9VG6q1BJQEww61uRG1FkGyb57vOGrsDg2bzZWnlyC9+3kfhLP39xADIppw6SI3Q= X-MS-Exchange-AntiSpam-MessageData: LWpiT0iMNY7UxZbeQPYKX4cHf0cq0tpNfKGT+ZvyPnfwYsHz8L0Dr4tkg/Y41TAp58wDalmSIEmsTQHMevRzTVzuaF1AgDlTC1aaCebtAPgHi63KTZbh2c0RgV0sTDlnXuVLf0fHVg3bT9YwLKdboQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a028e72-d245-40a2-7b9e-08d93017334c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 16:04:05.4359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DM6NAM04FT024.eop-NAM04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM04HT246 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Pierre, Yes we noticed this the other day. Bugzilla here: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3454 A patch is on the list https://edk2.groups.io/g/devel/message/76428 it implemented your second option. The good news is this doesn't change= =20 the outcome of overall CI because the Windows Vs2019 Agent should have=20 caught all issues and since both must pass the mainline should be ok.=20 There have a been a few issues related to spellchecker that we are=20 trying to get fixed that has caused missed failures. Hopefully today=20 the patches will get merged in. But agree it impacts local scenarios=20 and isn't correct. Thanks again. Nice to see that we both came to the=20 same conclusion for a fix. Thanks Sean On 6/15/2021 7:29 AM, PierreGondois wrote: > Hi Kun and Sean, > As a follow-up to your patch-set, it seems that the spell checker does n= ot currently run as expected. It only runs on files that are 'one level dee= p' in each package. > I.e.: > This was taken from Build/CI_BUILDLOG.txt from the TARGET_ARM_ARMPLATFOR= M artifact at https://dev.azure.com/tianocore/edk2-ci/_build/results?buildI= d=3D23939&view=3Dartifacts&pathAsName=3Dfalse&type=3DpublishedArtifacts but= this can be checked when running the CI locally on ArmPlatformPkg: >=20 > -------Log start--------- > INFO - Cmd to run is: cspell --config /home/vsts/work/1/s/Build/ArmPlatf= ormPkg/cspell_actual_config.json ArmPlatformPkg/**/*.c ArmPlatformPkg/**/*.= h ArmPlatformPkg/**/*.nasm ArmPlatformPkg/**/*.masm ArmPlatformPkg/**/*.asl= ArmPlatformPkg/**/*.dsc ArmPlatformPkg/**/*.dec ArmPlatformPkg/**/*.fdf Ar= mPlatformPkg/**/*.inf ArmPlatformPkg/**/*.md ArmPlatformPkg/**/*.txt > INFO - ------------------------------------------------ > INFO - --------------Cmd Output Starting--------------- > INFO - ------------------------------------------------ > INFO -=C2=A0 1/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c 829.= 48ms > INFO -=C2=A0 2/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c 37.06m= s > INFO -=C2=A0 3/22 ./ArmPlatformPkg/PlatformPei/PlatformPeiLib.c 13.01ms > INFO -=C2=A0 4/22 ./ArmPlatformPkg/PlatformPei/PlatformPeim.c 16.99ms > INFO -=C2=A0 5/22 ./ArmPlatformPkg/PrePeiCore/MainMPCore.c 25.68ms > INFO -=C2=A0 6/22 ./ArmPlatformPkg/PrePeiCore/MainUniCore.c 19.50ms > INFO -=C2=A0 7/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCore.c 20.86ms > INFO -=C2=A0 8/22 ./ArmPlatformPkg/PrePi/MainMPCore.c 18.98ms > INFO -=C2=A0 9/22 ./ArmPlatformPkg/PrePi/MainUniCore.c 9.86ms > INFO - 10/22 ./ArmPlatformPkg/PrePi/PrePi.c 26.83ms > INFO - 11/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCore.h 15.71ms > INFO - 12/22 ./ArmPlatformPkg/PrePi/PrePi.h 16.49ms > INFO - 13/22 ./ArmPlatformPkg/ArmPlatformPkg.dsc 21.03ms > INFO - 14/22 ./ArmPlatformPkg/ArmPlatformPkg.dec 24.63ms > INFO - 15/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf 11.12ms > INFO - 16/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf 15.85ms > INFO - 17/22 ./ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf 9.89ms > INFO - 18/22 ./ArmPlatformPkg/PlatformPei/PlatformPeim.inf 9.14ms > INFO - 19/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf 13.97ms > INFO - 20/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf 9.92ms > INFO - 21/22 ./ArmPlatformPkg/PrePi/PeiMPCore.inf 12.01ms > INFO - 22/22 ./ArmPlatformPkg/PrePi/PeiUniCore.inf 18.06ms > INFO - CSpell: Files checked: 22, Issues found: 0 in 0 files > INFO - ------------------------------------------------ > INFO - --------------Cmd Output Finished--------------- > INFO - --------- Running Time (mm:ss): 00:01 ---------- > INFO - ----------- Return Code: 0x00000000 ------------ > INFO - ------------------------------------------------ > PROGRESS - --->Test Success: Spell Check Test NO-TARGET > -------Log end--------- >=20 > As shown, in the "ArmPlatformPkg/**/*.c" expression, "**" is evaluated a= s a single directory instead of any number of directories. This can be fixe= d by: > =C2=A0- setting the globstar variable (tried on bash): "shopt -s globst= ar", run "shopt globstar" to check its value, or > =C2=A0- modifying .pytool/Plugin/SpellCheck/SpellCheck.py to add quotes= around the files to check so that cspell evaluates the "**" by itself. Thi= s solution seems better as it doesn't require to modify the environment. >=20 > Regards, > Pierre >=20 > On 6/14/21 7:34 PM, Kun Qin via groups.io wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3445 >> >> This patch series is a follow up of previous submission: >> https://edk2.groups.io/g/devel/message/76419 >> >> v2 patches mainly focus on feedback for reviewed commits in v1 patches, >> including: >> a. Adding "Reviewed-by" tags for applicable patches; >> b. Adding "Signed-Off-by" tags for myself for all patches; >> >> Patch v2 branch: https://github.com/kuqin12/edk2/tree/node_14_v2 >> >> Cc: Sean Brogan >> Cc: Bret Barkelew >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Leif Lindholm >> Cc: Sami Mujawar >> Cc: Jiewen Yao >> Cc: Supreeth Venkatesh >> >> Kun Qin (1): >> Azurepipeline: SpellCheck: Enforce Node dependency to use version 14= .x >> >> Sean Brogan (3): >> StandaloneMmPkg: Core: Spelling error in comment >> ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly >> ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords >> >> StandaloneMmPkg/Core/Dispatcher.c | 2 +- >> .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +- >> ArmPkg/ArmPkg.ci.yaml | 19 +++++++++= ++++++++++ >> ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 2 +- >> 4 files changed, 22 insertions(+), 3 deletions(-) >> >=20 >=20 >=20 >=20 >=20