From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E4F7378003C for ; Mon, 22 Apr 2024 20:17:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=m1xdmANrrqcPfvsq+S9Tz/l+Tx4ckNu5toG0NCIHV64=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1713817072; v=1; b=jJIj2VtLqJwNwZ8V6MGU9a9J2sEc8JJOJH/vUWXGgDKHxhF7z1BodLVYF7xurKqwbhdvTjxA MnYszJ5lZHUjqTKLIw8QVuZtIjTAPjVyoz3AVfwrA6467hxlxBbOtVCwOaPdzhDbaUwa/OjOR9n n9++j42ruWmpgSiOSDnFVkwW7Js/suNdBYirbz3hsuH4LiDTtC9mkPVQOz8b5ZIxks5JszrQruV Q2GVljl/5xRqW31uhYDxpwhkjsk/InkoXoxHj/ASjJEjIIIhfQWdlrn52oq9+WYoU8XvnjDSMy/ N6RSbs5Ixc72JPzv5PThC81pA4+EeiG4H5JmQXDCIlUFA== X-Received: by 127.0.0.2 with SMTP id 6SoTYY7687511xaELGTsljUq; Mon, 22 Apr 2024 13:17:52 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.92.42.57]) by mx.groups.io with SMTP id smtpd.web11.2484.1713817071585175381 for ; Mon, 22 Apr 2024 13:17:51 -0700 X-Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) by DM6PR19MB4309.namprd19.prod.outlook.com (2603:10b6:5:2b2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Mon, 22 Apr 2024 20:17:49 +0000 X-Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::dd8c:5326:6d61:12c0]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::dd8c:5326:6d61:12c0%5]) with mapi id 15.20.7472.044; Mon, 22 Apr 2024 20:17:49 +0000 Message-ID: Date: Mon, 22 Apr 2024 13:17:47 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type To: devel@edk2.groups.io, AbdulLateef.Attar@amd.com, Liming Gao , Michael D Kinney , Zhiguang Liu Cc: Abner Chang , Chris Fernald References: <9805eb27892886b351afa9db6256f9ba1ed45978.1711776144.git.AbdulLateef.Attar@amd.com> <9196fe0b-37c5-483c-a560-982a113533d5@amd.com> From: "Sean" In-Reply-To: <9196fe0b-37c5-483c-a560-982a113533d5@amd.com> X-TMN: [NqNo+QHnSLLMOYtHPNwL0WE4MrBob66qD8K1oeC+dg6tfYJ3fD15zqkyTiOHYOoX] X-ClientProxiedBy: MW4PR03CA0188.namprd03.prod.outlook.com (2603:10b6:303:b8::13) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) X-Microsoft-Original-Message-ID: <83be37bd-05c9-4595-b751-4637b5f6a6ac@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR19MB4900:EE_|DM6PR19MB4309:EE_ X-MS-Office365-Filtering-Correlation-Id: d18a2079-46a6-4151-40f3-08dc6309475f X-Microsoft-Antispam-Message-Info: A2u8jJXDhq/w5uyuAN8sONHshebBDfNHGMXgfRu5KufeJWJc82urug1RN7Xi/zibASJN3FYWYgJ4LTFQmXJO5obNj0t4BG6mCIKtTluf7d+VidLjGBuLeYnHJCsbpcS2bReUIaAOwr+KeTYb08wnyLJtVtxdvf9ZcD0uB0H8MD4r+2Dqv2Wc4x5/lf2iWMepOi4rw3pYfCMCkavZi7ed9i3809T6xVqZ3Z6hK3bSa5yOOWmUz0BtvSzI6/fxl11p20xJ2Wqd7QlELd2ePptNFKVbxRkcwIQyPF4nkNuBRIhl2kumpV17yDA8oL82+siq/vCHBPsw1xIdgz08TAMOrdUtNOaXps+6dLTnvwfg3Yry6QfJWReyad1BB/NEYZVXqGQwUn9evWBRcKrdBEJjKEtA3DPeCvfVVcOYfnkeibhrlNJ0ozgzuQ0Kl3tSSgsMXkMj3TkPJNuNGiZWOEMzlBfX6YWiMyNmeeb6OtihC2ZIJQGTOrYOY1lARaGOHQ8gpiU2JmVvel8oG+ByAp58Ma0l51qhmYr3D3by6uqlr0/xiIDxtZ4zsUvKN+LnBp4dmtkINZ1TwwfqvqM0OpZP8UWvCJrCsPIGuzI8W6rw6xDsMsT9xszPzIndj4BGPEGgrejy9UiuJDkqKKMQEFv5Aj+Is65mD3R9ZYPusEaYveZkNo2D1c3GvKkerG1MnUvaviX77O0TbNBRVcrH0bVbeQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MCtUVXZRM2RUYzBWMEMwWm9hMHdHU1ZlWFZKaUJXQXZjS3JhWkJFcXFXVkdy?= =?utf-8?B?NmJxNFdmeE82TkNMT0h3dDAzMjhDVnlBOElxWW1QTC9IV3hiTDlVS0lnUnZw?= =?utf-8?B?RzVBMDRhUGV5eU9JUjhwQW0vRER3Z244UTNHNXhVeU1NL2M0dHJ2TzlPNGl6?= =?utf-8?B?ZGl6aEVvVVhGMVRWK1dDeEN5UHF5VGZhZ0FOL2RpdnNydGYycUdLWTlJaElY?= =?utf-8?B?TVUzK3c3T0ZBTXllNUhEYlVkRlMwZldIZ2NEd0NXRTBmcncrWDNUY2ZZdzF6?= =?utf-8?B?SUFYM2ZmQStiR2JHN2gycWRDNEFmSkc5WjJTVEM5Y1RzM3BmR3VoR3MyQUU4?= =?utf-8?B?NU9qQTRoODhuUXBRWWlyR0JjN0MzU1FJTzVpTjJPS01DSWpZSjFOckJ6U0to?= =?utf-8?B?RHI1VjVObElKb1k3OEhWUmtHdVBIcXFqaWN5Qit3dUtqVldRNmhqN21aeWxG?= =?utf-8?B?aVFYVGplVFRRZ3JXT1BBK0h3aXhNN2tPWHNtcjV0QTBmamh4VE1jbHUzeHQy?= =?utf-8?B?aFpFM1YrYW1IYlphdFowS25TejRkNm1YZEdrT1lpVXQwT3dma3loeVdtZ3hR?= =?utf-8?B?SjJOVHVwOEhZQUh0aG1CMlg2RGNxWHQyOEl5NmxJdFh0QXRlQVBEaVM4TzBq?= =?utf-8?B?VEJkS0daSm5PYVZueEhIcFpFQmI5WnVhbm43cHRPYW9sak4rYTFpNU00WGJV?= =?utf-8?B?cUZlT01iMmR5bE4va3c2a1crTjBMV3VPQkYxZHBZTENUbzVMRVNzN3BsREsv?= =?utf-8?B?SUh6TjlxUTU1WnUvT2ZxNGMxNFl0TjVKdmtYMGI5UW1NRUI5SUduYVpQRHRt?= =?utf-8?B?cEU3YUk5Zk9CWXZzNHNFT3lLZS9yQ05ad1FWclR3Q3BzRWxIT3hVVVYvSjFh?= =?utf-8?B?b0NSNjRmMVNNQ3Z0Q0htTzVDSWxLdktPSUY0NkJmMWJhaC9VczVpMmdneTAv?= =?utf-8?B?WXErdTRZWEwxSWs1RHVpRDhkTk5VaTFBZS9uZ3ZhQ0dQSFVZYm9Melc0WURi?= =?utf-8?B?emtmcFFCM0U5cjVONFEzUFJtdlp0aFVsZG1pKzNVSTJobDBjcmg3WUkrdnBp?= =?utf-8?B?a1F2ZHRYTllCZXR6MUhwWlpQU1hRbjR0bUVJSUk1cXBEejhRRU56MVM3KzlN?= =?utf-8?B?V2Jja2FzUFZOZTJCTzR6bG1haERYZEpkKzV4aWpLUkNUS2hWK1hhQ1kyL2lX?= =?utf-8?B?Z1l1Qnl4VDVpalhMNGVHMkFMQjRtYUI4SzlUSmZwcTZYRTB2TWRwK1JMWVFS?= =?utf-8?B?eWc0YXZiVVJnek9uSWVoZWhKdE96MFhuVlg4NE9XdllEZnQxSkRIeDk5Wmk1?= =?utf-8?B?dk9lcllEVEZpRXIzcExFYWpmL3JzZkFPTis2dU5ndVh6K2wvdkpYZnFJWXd2?= =?utf-8?B?TUREYVl6d0RkRk5QUWxGQVJ2Q1g1MC9KR01GSERPSS9MYUxrcjhvRVVqalNQ?= =?utf-8?B?UDI1Q3liRFpZb2hUeVZ5enN0VzZHaklZamVTZ0cwcmduZHVHMlM5ZkNBbDlU?= =?utf-8?B?Z0N3TkhESzFmLzBSalk3SVVYREE5UGNGMHcyby9YOWdEZWlUNVNpRjFsbk5F?= =?utf-8?B?YTdaUU82OGZDMEZPNFIxL0MwTjB0bjRyd0J4ZnV6dERwTDVWL2YwWWJ6RTlH?= =?utf-8?B?Wk5KRDB5ZE4yclRaUHJlY09SbTNQcUVwZjVsbUtkaWZTYmJyVDFnUEI1WElJ?= =?utf-8?B?T1V3eUlmeTJ0K0VwVXpnWVJzOUl1YmxkS0tUemFHSmsxNFY2YVpicktiRWlx?= =?utf-8?Q?1ggnMJLKEJ6QPBGjpc=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d18a2079-46a6-4151-40f3-08dc6309475f X-MS-Exchange-CrossTenant-AuthSource: BY3PR19MB4900.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2024 20:17:49.1412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR19MB4309 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 22 Apr 2024 13:17:51 -0700 Resent-From: spbrogan@outlook.com Reply-To: devel@edk2.groups.io,spbrogan@outlook.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RsSaLjDuy7TXgyREE4G0Mfrxx7686176AA= Content-Type: multipart/alternative; boundary="------------85QAb8wViDlyDmchLtb0zkhn" Content-Language: en-CA X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=jJIj2VtL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=outlook.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --------------85QAb8wViDlyDmchLtb0zkhn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit This seems like a bad design to require the ipmi interface type at such a high level in the code tree.  UEFI provides plenty protocol and library abstractions for IPMI so I would really prefer not to leak this type of information into a PCD defined in MdePkg.  Happy to discuss IPMI support and I would really like to see edk2, edk2-platforms/Features/ManageabilityPkg at master · tianocore/edk2-platforms (github.com) , microsoft/mu_feature_ipmi: Project Mu - Feature Repo- Firmware support for IPMI (github.com) , and commercial vendors find some sort of alignment going forward as no one wins with the mess that is in the industry now. Thanks Sean On 4/22/2024 3:50 AM, Abdul Lateef Attar via groups.io wrote: > Gentle reminder, review please. > > On 30-03-2024 10:52, Abdul Lateef Attar wrote: >> Define IPMI interface type as per specification version 2.0, >> section C1-1.1. >> >> Cc: Abner Chang >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Zhiguang Liu >> Signed-off-by: Abdul Lateef Attar >> --- >>   MdePkg/MdePkg.dec | 11 ++++++++++- >>   1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec >> index 0c18e1decd..396d960dca 100644 >> --- a/MdePkg/MdePkg.dec >> +++ b/MdePkg/MdePkg.dec >> @@ -9,7 +9,7 @@ >>   # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development >> LP
>>   # Copyright (c) 2022, Loongson Technology Corporation Limited. All >> rights reserved.
>>   # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.
>> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights >> reserved.
>> +# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights >> reserved.
>>   # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
>>   # >>   # SPDX-License-Identifier: BSD-2-Clause-Patent >> @@ -2401,6 +2401,15 @@ >>     # @Prompt Time-out for a response, internal >> gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60000|UINT32|0x00000036 >>   +  ## Indicates IPMI Interface Type >> +  # The IPMI specification defines the following interface types: >> (section C1-1.1) >> +  # 0 - Unknown >> +  # 1 - KCS     : Keyboard Controller Style >> +  # 2 - SMIC    : Server Management Interface Chip >> +  # 3 - BT      : Block Transfer >> +  # 4 - SSIF    : SMBus System Interface >> + gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 >> + >>   [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] >>     ## GUID identifying the Rng algorithm implemented by CPU >> instruction. >>     # @Prompt CPU Rng algorithm's GUID. > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118103): https://edk2.groups.io/g/devel/message/118103 Mute This Topic: https://groups.io/mt/105228733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------85QAb8wViDlyDmchLtb0zkhn Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


This seems like a bad design to require the ipmi interface type at such a high level in the code tree.  UEFI provides plenty protocol and library abstractions for IPMI so I would really prefer not to leak this type of information into a PCD defined in MdePkg.  Happy to discuss IPMI support and I would really like to see edk2, edk2-platforms/Features/ManageabilityPkg at master · tianocore/edk2-platforms (github.com),  microsoft/mu_feature_ipmi: Project Mu - Feature Repo- Firmware support for IPMI (github.com), and commercial vendors find some sort of alignment going forward as no one wins with the mess that is in the industry now. 

Thanks

Sean


On 4/22/2024 3:50 AM, Abdul Lateef Attar via groups.io wrote:
Gentle reminder, review please.

On 30-03-2024 10:52, Abdul Lateef Attar wrote:
Define IPMI interface type as per specification version 2.0,
section C1-1.1.

Cc: Abner Chang <abner.chang@amd.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
---
  MdePkg/MdePkg.dec | 11 ++++++++++-
  1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 0c18e1decd..396d960dca 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -9,7 +9,7 @@
  # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP<BR>
  # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR>
  # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR>
-# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
+# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reserved.<BR>
  # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
  #
  # SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -2401,6 +2401,15 @@
    # @Prompt Time-out for a response, internal
    gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60000|UINT32|0x00000036
  +  ## Indicates IPMI Interface Type
+  # The IPMI specification defines the following interface types: (section C1-1.1)
+  # 0 - Unknown
+  # 1 - KCS     : Keyboard Controller Style
+  # 2 - SMIC    : Server Management Interface Chip
+  # 3 - BT      : Block Transfer
+  # 4 - SSIF    : SMBus System Interface
+  gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038
+
  [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
    ## GUID identifying the Rng algorithm implemented by CPU instruction.
    # @Prompt CPU Rng algorithm's GUID.





_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#118103) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------85QAb8wViDlyDmchLtb0zkhn--