I would suggest updating the commit to reference this bugzilla from 2021 3651 – Remove DxeIpl dependency on ArmPkg (tianocore.org) Reviewed-by: Sean Brogan On 2/8/2024 4:27 PM, Oliver Smith-Denny wrote: > With commita21a994f55e53325d3e060c435ca3a87fd7c2c79 MdeModulePkg no > longer has a hard dependency on ArmMmuLib and therefore ArmLib. This > is the final dependency on ArmPkg, so remove the unused libs and drop > the allowed dependency on ArmPkg as MdeModulePkg should not depend on > it as this is a circular dependency. > > Github PR: https://github.com/tianocore/edk2/pull/5361 > > Cc: Leif Lindholm Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Liming Gao > > Signed-off-by: Oliver Smith-Denny --- > MdeModulePkg/MdeModulePkg.dsc | 2 -- > MdeModulePkg/MdeModulePkg.ci.yaml | 3 +-- 2 files changed, 1 > insertion(+), 4 deletions(-) > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc index 6b3052ff4614..c0f1df3bfbca > 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ > b/MdeModulePkg/MdeModulePkg.dsc @@ -179,8 +179,6 @@ > [LibraryClasses.common.MM_STANDALONE] > MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf > > [LibraryClasses.ARM, LibraryClasses.AARCH64] - > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf - > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > > # diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > b/MdeModulePkg/MdeModulePkg.ci.yaml index 669f54e33c0d..a3de60a12c9e > 100644 --- a/MdeModulePkg/MdeModulePkg.ci.yaml +++ > b/MdeModulePkg/MdeModulePkg.ci.yaml @@ -53,8 +53,7 @@ > "AcceptableDependencies": [ "MdePkg/MdePkg.dec", > "MdeModulePkg/MdeModulePkg.dec", - > "StandaloneMmPkg/StandaloneMmPkg.dec", - > "ArmPkg/ArmPkg.dec" # this should be fixed by promoting an > abstraction + "StandaloneMmPkg/StandaloneMmPkg.dec" ], # > For host based unit tests > "AcceptableDependencies-HOST_APPLICATION":[e -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115288): https://edk2.groups.io/g/devel/message/115288 Mute This Topic: https://groups.io/mt/104250836/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-