From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C64237803D1 for ; Fri, 9 Feb 2024 00:36:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oTUWCeMLia6up8H2GDD1wuYOwTjktkZpROQXWAVp9pg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20140610; t=1707439014; v=1; b=qkoHCaKCVJ0jO6NQbPJV2Eak9pgqVs7+IlbjDTsSqr/6yhSL3D1CocB++tA+tkKa57ueFJ+L F5Gh+LLy7fgAvXUC7nbTltBDaMEV/iH7jfdp1dJnAAAPnHMV4jIokvePoUgl2itrxeLP/MFBqzB orMjuYT5HJqFwsdVTqz8XPoQ= X-Received: by 127.0.0.2 with SMTP id bNzKYY7687511xJLNBcqE3P5; Thu, 08 Feb 2024 16:36:54 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.92.20.10]) by mx.groups.io with SMTP id smtpd.web10.659.1707439013138933999 for ; Thu, 08 Feb 2024 16:36:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dSr+HGqyL65T9SloFoI3SdvG/qOjCu+eL2xJ9HPd/I+5CLHgK8c9qEzR4N5wlNxYh0Ygm2zurDYg7DOm37PjeC1Ub71jDUkKJVhcPp2RQ0O2rvULuB5CtgSyk9m+m18OjzVgL58AULw8T9rB1uweNNQtP/OSjcBwXr0BexjXAzuZYoO0RsCzKESbLedw4f3V9EcoScqxCMNDqE95ER+XSRSwBxs+l5TxfglL7tmeKGHgS4kSX+Ri1IRAXg1zBqgOEtYqvoekV+sTl1thGcrPcx8rEttT083L262TI3fR+Vo07vrpWuKTDZGxKJbILdwffAuMQdw5SHa+xf3/LGLdkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EgS27Wm3UYCUXRspz/cnCAl9vHC21nGyhuLi8eoHoWg=; b=gsn2eW11dJWJYaBF0WnUM8myxWs4Uitjgpo6qZ3+UMap4DEEqf4r86hEqTlLlxGvvIApr7VDAwDUIWAx0/Oio03JYMg8PPWsQW83AdJ+G6kFBvC7ztoGRogKlnvw3xdAG/cYyWM/StVUGR4HkeviQjhCsjG+1mD9gP6KROH7aOlpoOnUsrNxQdVTRL8MVyw3sz/4AX91tO5Ahz/37V+jFp0mnwy1yNVVZqcgNiDPmRKoLMEJc3aLDV4MDAEnz/k8AmyvfqVMrFZNYQncFxvD10zPAlAeD+2gaY6X6G+WI+dN0RAMsgAQBPO76AOU1k/xplTiGLSkKwo1t2sfxMhddQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none X-Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) by MW4PR19MB7128.namprd19.prod.outlook.com (2603:10b6:303:21a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.38; Fri, 9 Feb 2024 00:36:50 +0000 X-Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::2f58:3138:8615:2aee]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::2f58:3138:8615:2aee%3]) with mapi id 15.20.7249.038; Fri, 9 Feb 2024 00:36:50 +0000 Message-ID: Date: Thu, 8 Feb 2024 16:36:48 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: Remove ArmPkg Dependency To: devel@edk2.groups.io, osde@linux.microsoft.com Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Liming Gao References: <20240209002717.21966-1-osde@linux.microsoft.com> From: "Sean" In-Reply-To: <20240209002717.21966-1-osde@linux.microsoft.com> X-TMN: [ohy9WAU2LYqqdSJs4FOlcUjBHeouPT7ul7wSYnS6cVixPVIobs4hZAru7hYOiFz8] X-ClientProxiedBy: CYXPR02CA0006.namprd02.prod.outlook.com (2603:10b6:930:cf::10) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR19MB4900:EE_|MW4PR19MB7128:EE_ X-MS-Office365-Filtering-Correlation-Id: feb91eac-713f-4ca0-ac56-08dc2907343f X-MS-Exchange-SLBlob-MailProps: +b2+gf+2pHT7hfAvnGc9VB0xA1G8fhK+AF5txcY4aaRBQK8d8q1FcqXArbSLA3aPdide+RPsnp5dG7KbovgmxJL2EWrVxJs8yckwAlqo4SsMyeR5xp+5MxPdeUjSHWv84u6bKvaHLru5zaJGKJHMO8CwdibRqRTIFYokxMnu8vlxMTVge/TZ5fQsFjX2ALIxUMM9ZnAm2SzZ0HC+jMArRotX+3sNup6Qn5b7xalWKGlvrQPQPHr+lEcxEP0OgFN5rTw4J8E6d2LxysY06fp35tnhx796kPElhyEuvDSh/M63lYGS7xlrdIHM02tAEzQ9TCChhNvH9cCA17dznXfNkcuZ7TJ4nqfTnEzPn3gcoG52OXRguZI81b/II8uQToYou1qHaNZGLVR1qBvdLg6U55ubfVed/DRp4gImi1FXPWK2Oi9qHRHfxUi+JABc0VZf+hImE8O5tZfm4rp6zTF9+6e/lKTW/FE5CvVyqsY2lpYNBz1jNZ9lJkbzDeBkm1ZCbhtwPUPGR5ROO7pc5sSDpBulJA7ESyx65Cl0IbsBTh/JdMsdNSivYmeZ/x3pLk8wAnAVk4E/4/of81fbfuPqT/cJq3KvsjnvdXknV6iQpMJEBFeqPCtEAiQBO0thopFfrDQTwE509zw7gdcObG/2sqe6cBVH7v8abd1xJSicE6XBdvRIGXavzzr4X8gFV3/SLYNyTieKQBUqKj+GABOPjP/KFRSVg8ZEU4NV5vGpEnHFUonqNpCk21GBqwDL8mO4c+khCZz7lXxbIMHsp/wRK13KQUVwutnBOy+mJ4RbzvocuBdWShxWFCBFhVc8yUetpZLAFfOcRc6xCvKqabQIL3jAik8YLjnPdogUXHB+YAOQghNI2jSUcw== X-Microsoft-Antispam-Message-Info: gVdt+EOkfmx581wC+ZTUO51gjWfcHjOGv7w9i2uq/cea/4CDKPWV0kz7Gz8S1Wwsi8GLdORSzXYXhMZYsuDo2iCxjgg8wv2CP+Uxm470oPbsIj9AuIBMiC7VsDZc2IzfK3uq0+kr9suEiCMBzm0nNJT1P7LViuRmgSQ2KYt2UteDWkaJZsulDAV2t9WxvwVYENyERmPLDj1U8rU4cyknol8hGQHhdeW/9BcisApKrr5oT+XfJrGSHH5EhiPvHribN9fRJVq2ySVdbqxkQiytSb6QPiL040eftrWEPeS2ge+hAfwFMN6aujkqI4bKEFhBSrsyE9JcvNxe9TFRlGTSDyBxCodWCPAMXl5PzWdERbZYl4s2fI6dtnldbCVLU4QGEuY59iJsmOi7IphephycKjDby5mqxl37zYlF7yceUyLYejyYVVTxR55SYwMsd+esQEcsBF9m0ESXAIvJUn23QxkbS0+o0U9adt7vL8vt9ZHiWd2f8P2N0hcfQS7Vr+9LuDCvK6u4iHJK2Nai0F7WlwV3w7xc18dkUkCsqGqoad1kx2nxFipPRr11B4OqIoPR/6uOcE96uiyXGcnt1aubxXFyhNPT5JIoG40VfRBcU2s= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDlUVHhRd2VzajcrMFRKbjI1Ylh4NC9NclR1YVh2WWdkRFZOT3ZLOU9CRFNU?= =?utf-8?B?ODAzQ3NKVjNWOWFZVXdYbkpWdHFXVWhwV2xBQ09QcFF5UEczbWhTbnR4U3Y0?= =?utf-8?B?YVl0WWZIcFhud2JSSG1SM09YQjBQRlV6MU55QTUrN0FRd2ZRL2Zpb0lKaUpr?= =?utf-8?B?cDNzTlRrdllNMVZ0SzUyUHpuOExUVVNpNnFLRDVwMi9IdkY4aG9xeTdwajYx?= =?utf-8?B?RmV6aURPWVF5bWg1VkFlbFFSUWdKeFdKdndyaUhnYTh3U1RuaHBEeXYwRjhK?= =?utf-8?B?S1MyS0VSc3BuRzZEL2d6dStCUVplUmFTaEVlSzNtM1VwUjhTUTMvSG5FT3Ir?= =?utf-8?B?dE5BeTBIeXBWMnlxcGI0N0xGR09ISjc0ay9JZFE3a3pYV1dtbDBTNS83MGpp?= =?utf-8?B?bXdUR1FKUm52NTdXTHJKb0YzMWpBTVh2Tjc4enYzRlJZUmw2MGRFL3V2Wi9J?= =?utf-8?B?Z1ZYcDR6eXZPc3k4QzdFUmZHRExlRk91K01pUHg0TExyNTZKSmJOaGtUV3ZN?= =?utf-8?B?bjliSXRFalNFK1UzV3YwZTJzemUwNzFRdjdURDJTTUcxRHljdFc1VXR6SXAv?= =?utf-8?B?SHVIRVh1YVZxTVEzNzh3b2JWekZtd2ZSeE5OVXhCWjAvVVk1bFlsMFhXT1pt?= =?utf-8?B?MUdVQ1UwZXhDRXVlT0ZXeXVneUNWS25SOHFRaFJGSys0OEdCRU9TR1FIMmgz?= =?utf-8?B?NFdqbk4rdi9QVHVtbExWamc4Sm9wTGtZUFFXTk5mVU9iNDlaeEJLQTJxU3hE?= =?utf-8?B?Q1pLYW14ajd3WVNwRzNtb3JrdFZuYUJJUkJLUzRYd29VKzR0dzd1SVh6OG05?= =?utf-8?B?MFB6L2RvM29rRXdJU3dIWW52OWdSTFlaYzFNQ1lTQ0pJSThMZGMwQnltL0R0?= =?utf-8?B?eVZmTjdLRlh3cXJRWXdnTlhXdmRTaTFnM3p6bWUvOWQ3SUdjbDF2YVBlUGgw?= =?utf-8?B?cnVrWkZSZmhmaDBFRzRoOGZaRmRHZXRKVU83OGlkMjlKamJZVzVwMXBCcW1P?= =?utf-8?B?R2huUUViOG42Uk5DR3h0ME5HWXVOK3drR0JRU1ZlTG5KaEZ5a1NIbDFnVUc5?= =?utf-8?B?Z3FEdFFaNyt5b3RRZXNqdEFlYkhTNXRjSHRYWlNwSFVHbWtJMmhqajlKdGIv?= =?utf-8?B?cmdlbHdYRVVmalRHVlprTlZ4UHBRc1pBK0tKNEFDRFJGODFyU0NYRDhTZlV3?= =?utf-8?B?STV3Z2R0LzJDRlBITnE0aDJWR2VsNXpmUmJnUCtIZ2gydVRnSFRpMWw4Uis5?= =?utf-8?B?WFMwM21GSUVieUlvUmg4ek1wWkdOQ3VhZWdtb3h4MCtHcUtGSExkRTdLcnNB?= =?utf-8?B?dUNjcDFlME9pK2s1aHBMTzQ3M3R3aUdJZWs3NGZrRDd2VGpSMlQxU1JlMnRy?= =?utf-8?B?YVBYc01ZL2RFc1c2WmZ1emtaQUlMdkdaOGZjQTFUbGY5Q21sWS9na2N1NCtN?= =?utf-8?B?b2JoTVZoTmVyUklLTXhGYkZpZytRWmNhM0VMRDlJVXZoL2pVeEZMc0pvYXBx?= =?utf-8?B?WjA4YVlkUzZGUlBYaUtMbi9SZ0N6aGpnRURCOXZETXZQN2V1UC9VaHZFaFdn?= =?utf-8?B?SWNOYk1WRjlMZ2E3eDZkSHV3Um1QSVZSWXBHZUhjckNrb25Ta0M0Q3dzMUNt?= =?utf-8?B?c015UHkvR1hsRncwWkNiemNxUWtHa093ai9XelByUENYa0pEL2dYcmgwSDJJ?= =?utf-8?B?QUdESXUwM2V5RHcvc0lmd0NLclhKYzIxeWFQWllPN2xjaGZlbG1zNjlwVllW?= =?utf-8?Q?gYkCIK9WwrtPUCGwjo=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: feb91eac-713f-4ca0-ac56-08dc2907343f X-MS-Exchange-CrossTenant-AuthSource: BY3PR19MB4900.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 00:36:50.4180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR19MB7128 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,spbrogan@outlook.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZYX86yH4fXxFYxIAYuNU4KPSx7686176AA= Content-Type: multipart/alternative; boundary="------------ClPIQ8fDRyC0svoi6irHXjtu" Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qkoHCaKC; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=outlook.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------ClPIQ8fDRyC0svoi6irHXjtu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I would suggest updating the commit to reference this bugzilla from 2021 3651 – Remove DxeIpl dependency on ArmPkg (tianocore.org) Reviewed-by: Sean Brogan On 2/8/2024 4:27 PM, Oliver Smith-Denny wrote: > With commita21a994f55e53325d3e060c435ca3a87fd7c2c79 MdeModulePkg no > longer has a hard dependency on ArmMmuLib and therefore ArmLib. This > is the final dependency on ArmPkg, so remove the unused libs and drop > the allowed dependency on ArmPkg as MdeModulePkg should not depend on > it as this is a circular dependency. > > Github PR: https://github.com/tianocore/edk2/pull/5361 > > Cc: Leif Lindholm Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Liming Gao > > Signed-off-by: Oliver Smith-Denny --- > MdeModulePkg/MdeModulePkg.dsc | 2 -- > MdeModulePkg/MdeModulePkg.ci.yaml | 3 +-- 2 files changed, 1 > insertion(+), 4 deletions(-) > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc index 6b3052ff4614..c0f1df3bfbca > 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ > b/MdeModulePkg/MdeModulePkg.dsc @@ -179,8 +179,6 @@ > [LibraryClasses.common.MM_STANDALONE] > MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf > > [LibraryClasses.ARM, LibraryClasses.AARCH64] - > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf - > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > > # diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > b/MdeModulePkg/MdeModulePkg.ci.yaml index 669f54e33c0d..a3de60a12c9e > 100644 --- a/MdeModulePkg/MdeModulePkg.ci.yaml +++ > b/MdeModulePkg/MdeModulePkg.ci.yaml @@ -53,8 +53,7 @@ > "AcceptableDependencies": [ "MdePkg/MdePkg.dec", > "MdeModulePkg/MdeModulePkg.dec", - > "StandaloneMmPkg/StandaloneMmPkg.dec", - > "ArmPkg/ArmPkg.dec" # this should be fixed by promoting an > abstraction + "StandaloneMmPkg/StandaloneMmPkg.dec" ], # > For host based unit tests > "AcceptableDependencies-HOST_APPLICATION":[e -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115288): https://edk2.groups.io/g/devel/message/115288 Mute This Topic: https://groups.io/mt/104250836/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------ClPIQ8fDRyC0svoi6irHXjtu Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

I would suggest updating the commit to reference this bugzilla from 2021

3651 – Remove DxeIpl dependency on ArmPkg (tianocore.org)


Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>


On 2/8/2024 4:27 PM, Oliver Smith-Denny wrote:
> With commita21a994f55e53325d3e060c435ca3a87fd7c2c79 MdeModulePkg no > longer has a hard dependency on ArmMmuLib and therefore ArmLib. This > is the final dependency on ArmPkg, so remove the unused libs and drop > the allowed dependency on ArmPkg as MdeModulePkg should not depend on > it as this is a circular dependency. > > Github PR: https://github.com/tianocore/edk2/pull/5361 > > Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Ard Biesheuvel > <ardb+tianocore@kernel.org> Cc: Sami Mujawar <sami.mujawar@arm.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com> --- > MdeModulePkg/MdeModulePkg.dsc | 2 -- > MdeModulePkg/MdeModulePkg.ci.yaml | 3 +-- 2 files changed, 1 > insertion(+), 4 deletions(-) > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc index 6b3052ff4614..c0f1df3bfbca > 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ > b/MdeModulePkg/MdeModulePkg.dsc @@ -179,8 +179,6 @@ > [LibraryClasses.common.MM_STANDALONE] > MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf > > [LibraryClasses.ARM, LibraryClasses.AARCH64] - > ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf - > ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > > # diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > b/MdeModulePkg/MdeModulePkg.ci.yaml index 669f54e33c0d..a3de60a12c9e > 100644 --- a/MdeModulePkg/MdeModulePkg.ci.yaml +++ > b/MdeModulePkg/MdeModulePkg.ci.yaml @@ -53,8 +53,7 @@ > "AcceptableDependencies": [ "MdePkg/MdePkg.dec", > "MdeModulePkg/MdeModulePkg.dec", - > "StandaloneMmPkg/StandaloneMmPkg.dec", - > "ArmPkg/ArmPkg.dec" # this should be fixed by promoting an > abstraction + "StandaloneMmPkg/StandaloneMmPkg.dec" ], # > For host based unit tests > "AcceptableDependencies-HOST_APPLICATION":[e
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#115288) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------ClPIQ8fDRyC0svoi6irHXjtu--