Is there any documentation to why this change is important and what exactly was broken? Thanks Sean ________________________________ From: devel@edk2.groups.io on behalf of duntan Sent: Tuesday, August 9, 2022 6:45:30 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 0/2] Remove mInternalCr3 in PiSmmCpuDxeSmm Add a new IsShadowStack flag in PiSmmCpuDxeSmm. Remove mInternalCr3 in PiSmmCpuDxeSmm. Dun Tan (2): UefiCpuPkg/PiSmmCpuDxeSmm: Add a new IsShadowStack flag UefiCpuPkg/PiSmmCpuDxeSmm: Remove mInternalCr3 in PiSmmCpuDxeSmm UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 30 +++++------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 26 +++++++++----------------- UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 113 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 73 +++++++++++++++++++++++-------------------------------------------------- 4 files changed, 98 insertions(+), 144 deletions(-) -- 2.31.1.windows.1