From: "Sean" <spbrogan@outlook.com>
To: devel@edk2.groups.io, mikuback@linux.microsoft.com
Cc: Sean Brogan <sean.brogan@microsoft.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Andrew Fish <afish@apple.com>,
Leif Lindholm <quic_llindhol@quicinc.com>
Subject: Re: [edk2-devel] [PATCH v1 0/2] Update Pytool PIP Versions
Date: Mon, 14 Nov 2022 13:40:24 -0800 [thread overview]
Message-ID: <BY3PR19MB4900716B3263FD477FE86758C8059@BY3PR19MB4900.namprd19.prod.outlook.com> (raw)
In-Reply-To: <20221112010455.799-1-mikuback@linux.microsoft.com>
This looks good. To avoid any odd failures in stuart_pr_eval, it is
important to pick both of these up. Without these updates we have seen
pr_eval reporting a package doesn't need to be tested when it should.
this leads to bad changes getting through the PR process and breaking
the mainline.
Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
Thanks
Sean
On 11/11/2022 5:04 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> 1. Updates edk2-pytool-library to 0.12.1
> - Picks up a minor bug fix
>
> 2. Updates edk2-pytool-extensions to 0.20.0
> - Picks up a major release
>
> The changes in each update are in the respective patch commit
> messages.
>
> CI was run against both of these patches in this pull request:
> https://github.com/tianocore/edk2/pull/3632
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Michael Kubacki (2):
> pip-requirements.txt: Update to edk2-pytool-library 0.12.1
> pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0
>
> pip-requirements.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
prev parent reply other threads:[~2022-11-14 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 1:04 [PATCH v1 0/2] Update Pytool PIP Versions Michael Kubacki
2022-11-12 1:04 ` [PATCH v1 1/2] pip-requirements.txt: Update to edk2-pytool-library 0.12.1 Michael Kubacki
2022-11-12 1:04 ` [PATCH v1 2/2] pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0 Michael Kubacki
2022-11-14 21:40 ` Sean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY3PR19MB4900716B3263FD477FE86758C8059@BY3PR19MB4900.namprd19.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox