public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sean" <spbrogan@outlook.com>
To: devel@edk2.groups.io, gua.guo@intel.com
Subject: Re: [edk2-devel] [PATCH v8 0/3] Add code coverage support for GCC/MSVC
Date: Tue, 3 Jan 2023 18:49:21 -0800	[thread overview]
Message-ID: <BY3PR19MB49007A751E3C83E8AC621990C8F59@BY3PR19MB4900.namprd19.prod.outlook.com> (raw)
In-Reply-To: <cover.1672658424.git.gua.guo@intel.com>

Looks like a great first step for code coverage collection.

The container support patch series will need to be updated (since it 
hasn't yet been merged) and it will need to account for the new 
requirements for code coverage.

In the future i would like to see the local experience improved (HTML 
reports generated) and metrics tracked per package instead of build 
wide.  These topics can be discussed at the Monday tools meeting but I 
think this series as is should be merged now to start collecting this data.

Thanks for all your efforts.


Series Reviewed-by: Sean Brogan<sean.brogan@microsoft.com>



On 1/2/2023 3:24 AM, Guo, Gua wrote:
> From: Gua Guo <gua.guo@intel.com>
>
> V1: Add coverage option for GCC
> V2: Add ReadMe.md for how to generate coverage report
> V3: Add VS2019 and GCC code coverage support
> V4: Add VS2019 and GCC Azure CI/CD support
> V5: Fix some typo and some flow issue
> V6: Remove html coverage information
>    - Due to python 3.11 install lxml will be failure,
>    pycobertura need it to convert cobertura format to
>    html file.
>    - Add section for developer how to use OpenCppCoverage
>    on IDE Visual Studio
> V7: Remove redundant code and add code coverage pipeline support
>    - Remove redundant code on HostBasedUnitTestRunner.py
>    - Unify coding rule on HostBasedUnitTestRunner.py
>    - Add CodeCoverage Azure pipeline support for GCC5 and VS2019
>
> Gua Guo (3):
>    UnitTestFrameworkPkg: Add code coverage support for GCC
>    BaseTools/Plugin: Add coverage support for Unit Test
>    .azurepipelines: Install code coverage tool
>
>   .azurepipelines/Ubuntu-GCC5.yml               |   5 +-
>   .azurepipelines/Windows-VS2019.yml            |   5 +
>   .../templates/pr-gate-build-job.yml           |  36 +++++++
>   .azurepipelines/templates/pr-gate-steps.yml   |   4 +
>   .../HostBasedUnitTestRunner.py                | 101 +++++++++++++++++-
>   UnitTestFrameworkPkg/ReadMe.md                |  41 +++++++
>   .../UnitTestFrameworkPkg.ci.yaml              |   1 +
>   .../UnitTestFrameworkPkgHost.dsc.inc          |   3 +-
>   pip-requirements.txt                          |   2 +
>   9 files changed, 195 insertions(+), 3 deletions(-)
>

  parent reply	other threads:[~2023-01-04  2:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-02 11:24 [PATCH v8 0/3] Add code coverage support for GCC/MSVC Guo, Gua
2023-01-02 11:25 ` [PATCH v8 1/3] UnitTestFrameworkPkg: Add code coverage support for GCC Guo, Gua
2023-01-02 11:25 ` [PATCH v8 2/3] BaseTools/Plugin: Add coverage support for Unit Test Guo, Gua
2023-01-02 11:25 ` [PATCH v8 3/3] .azurepipelines: Install code coverage tool Guo, Gua
2023-01-02 18:05 ` [edk2-devel] [PATCH v8 0/3] Add code coverage support for GCC/MSVC Michael D Kinney
2023-01-03 16:14 ` Michael Kubacki
2023-01-04  2:49 ` Sean [this message]
     [not found] <17367A3BDC508760.4716@groups.io>
2023-01-02 11:56 ` Guo, Gua
2023-01-02 18:01   ` Michael D Kinney
2023-01-03 15:54     ` Michael Kubacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY3PR19MB49007A751E3C83E8AC621990C8F59@BY3PR19MB4900.namprd19.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox