From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8F60994124C for ; Tue, 23 Apr 2024 06:12:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=p/yFA1wa0XF5/NAy+1GK4KRASXX2+i5I9fs4aGCaz6M=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1713852771; v=1; b=vjHW/5+N3ANxCRDK5sWnlL1Iy4Sd3vmajUjbnC2e0gV5uEdHU/JOGlk31d++mLpJlllOZheS NkNeNW2qi4vJ1AT2nbN4xYy9OP4LJtaOhYlhQ03PH3jxEje0KLCTsay5+idhMk8Yxd4aJ+TDH/4 lsJQ8aV8QY6pFA3Dh3FEckBmKr2I+nAiMqLkMUDAiNHTuU22503G05Ing4EiIXXUg+r/hquX233 zsnhxQT9IIi46J9FUXOOmbNPKx15BeShydilRT59wHpXTv0ZanIh3m2YhQqr7obsWx88hkQ9QP8 3L+sNWT/5XguqL8454V2eq12mheUWXrRHvFm+1+7UZoMA== X-Received: by 127.0.0.2 with SMTP id MUl0YY7687511xup6Gswr9lm; Mon, 22 Apr 2024 23:12:51 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.92.43.13]) by mx.groups.io with SMTP id smtpd.web11.12045.1713852770100068367 for ; Mon, 22 Apr 2024 23:12:50 -0700 X-Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) by SJ0PR19MB5430.namprd19.prod.outlook.com (2603:10b6:a03:3e0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.44; Tue, 23 Apr 2024 06:12:47 +0000 X-Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::dd8c:5326:6d61:12c0]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::dd8c:5326:6d61:12c0%5]) with mapi id 15.20.7472.044; Tue, 23 Apr 2024 06:12:47 +0000 From: "Sean" To: "Attar, AbdulLateef (Abdul Lateef)" , "Chang, Abner" , "devel@edk2.groups.io" , Liming Gao , Michael D Kinney , Zhiguang Liu CC: Chris Fernald Subject: Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type Thread-Topic: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IPMI interface type Thread-Index: AQHagmJiz3eCRpJZXEGP2h32vhzEUrF0QR2AgACeZoCAAF1QAIAAMRwAgAASSVI= Date: Tue, 23 Apr 2024 06:12:47 +0000 Message-ID: References: <9805eb27892886b351afa9db6256f9ba1ed45978.1711776144.git.AbdulLateef.Attar@amd.com> <9196fe0b-37c5-483c-a560-982a113533d5@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-04-23T01:26:34.0000000Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard x-tmn: [h+wgg1EV+CiWz89c7+jTiIQiUKdSNQrl] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR19MB4900:EE_|SJ0PR19MB5430:EE_ x-ms-office365-filtering-correlation-id: 166237a4-2ebe-4259-f80f-08dc635c65b4 x-microsoft-antispam-message-info: VJY7Q8pJRwTq39zWk3JJvtlrf/hSwpJxgGB1LP60JAgfi2DhAQazDWsNhHiG2VmRawYvpmS/TxMla6d5tfyvw7oQMv/Tr7yat6d4UQHbSR9aWobcx+6B3z8zF4cujEo57R4qF3naVYd2Blt9EI+5cvk0mFX6gdtKllm3dytcZyFTRm8wbM+stTUmtDGInV3p4Rq/zobGuPwBP7sYBi0u3Dc6kApObX9B8Yo5bC0CR+W3fLMecxD7d7Se5Q5VJ3OVuEmYsYX2WzVWow+ZHoJm9azYlQIPDShM7eooZQ7sOtcknDHKsx8fwesNBymD5qFx+TJkTujcPOzXiDPSfwEc0ShE0Wewy+x3v48zQBr3/U6o4kWE4QQw4nknp4z6nRo5eH0HWOxy1gB5tF5h15eFlHdwLTFP0v/CR7UUpshSniQdFMu9InSU7HVQqWMgRTwJJTD23Yy/On9Gvx/i0/qRToWUnjW7R1FIl7DzhJDa5R+f+yHM5RoGuVpukxgFxpPbRlI5do45Gtd+b0l21I88KVyeRyz8kSrEFnLEYgRtzf+gMDYNvhwSKx8DnetJbOwfZgNj7Ns8Lym4oxzK3tFvDk1r1AYaXoVfX7mCk1c1vfkTVucu2fb2UEjGIvHfHZGmXJOaEELLj1WhhbjIxB0QmwNZsiopgE5E6wrOdKgTovPrbO/1JFZpSwo3XVy8SMRQet9JVraNQi4IUA07teTGQg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?lms4nKfLRqf+I8NEuHVaOY4S2AhC37PcWx4TqeA3TQ/5dBu0z/DGA1cs?= =?Windows-1252?Q?+M6YQbQGrJZMGG1ZScVo+u3n+UVJ/CcASyyq33fQQI79NiuIP92T+4Cr?= =?Windows-1252?Q?Qu18YYl2U3k4jhrZIDbYBfIGsSy7qJAKC0XLRhl8hizrR3VnPexRvuaR?= =?Windows-1252?Q?LyhMTngbtqoX0Z3I/fKPb9L9grBpQlbM6mXTyBBfgnLWS/QDHrkBpjl+?= =?Windows-1252?Q?BR8iPDw6/fwV65cI7qs+LjoUIoGMyo00xCS58s2LhaqSqUBD/o6ZC6Ah?= =?Windows-1252?Q?J7T/boxqq64Xm+WAtDug4J8UUcr9JUo8/4PAbMxXkgnyAbvNEa26LAWP?= =?Windows-1252?Q?CZwUmKCzg3x8O2sQ6RJIgafVgiUTaHDq7WrfdsSz8e1hxTBYjkSNhUpw?= =?Windows-1252?Q?hiUaDLKjp/vfGhI8nW5qas4ieoYNQ0Am/j/zGGjmfgpVNygQXpjiiuXC?= =?Windows-1252?Q?oZouciwCLxF+9vR0msum99mKGUcpXbwLKy7RWxUCJYQHqM1JkyLK0W7I?= =?Windows-1252?Q?BfSCqtwesoM/kzVk3s9Ns4y0IL7W3a8+dsRkwA8WvWUdfZcE9E4unLcI?= =?Windows-1252?Q?xtmIjNrB6pSzvKqIMReeYDeP5sXQVNAi+GzYDbjukU0A3rh1A3xyZRgR?= =?Windows-1252?Q?hAMe+9Wd/OyLiyLqDZPhmZqFDAhxTTPuUcxJVz35aITUY/qRAoGJsRKR?= =?Windows-1252?Q?GrBEs1G/N0+I4q9zvqoYo3OHFBbnnEXh0/WvIxQ74rC6skVQmFjssE31?= =?Windows-1252?Q?kkhfVcI9+qYEQjKZ+uDwBGYy8kQ2JQgA87PeFuaHpsZ2fAe0eagAJ/1W?= =?Windows-1252?Q?+yohomRXFOLTmdDuhus2vvVvEm94zAbss3y/xbtr2Yt/gFrROYZZOL2l?= =?Windows-1252?Q?HFyHzc9Lc8C8I11kadTYsMXAD9ujDMC95v3mFXZ2sDvPNkw01Ubxdj7d?= =?Windows-1252?Q?SADqeCRIf1ueeMRj3ekLEb17S2IciiBUi7J9YlCXSNZTh54xbaI0n3q2?= =?Windows-1252?Q?uSqpMZ/Y0MNwzhV+nx7td/fM9/agl7VhMfhi31NkgBvhgDRUuiX4hdRJ?= =?Windows-1252?Q?NLiRLEsK+4ccrQIqwcZ8CDvuJWa8YSUQjWG7d50Inga88zFSrn31VRdu?= =?Windows-1252?Q?N9dO8rthDB4QSLWbWln/u8e82DQuBmFDYHwFpw639oDjTGvyl2J0hBp5?= =?Windows-1252?Q?0ynPyzsDqF2HlwlCeXe13/t6VPIl//DUcEvqwIeG5614PmoZ1tFOtBpR?= =?Windows-1252?Q?091CTqII/F+dJh+rWCM2uNLJuhGACGCksrdNy6yLRWFQCyTxR0zT9Fob?= =?Windows-1252?Q?OnVaTJrom0/MX8rShgMwL8XNsSjoyOis/aVl1tF3I34oUrH/?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR19MB4900.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 166237a4-2ebe-4259-f80f-08dc635c65b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2024 06:12:47.3841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR19MB5430 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 22 Apr 2024 23:12:50 -0700 Resent-From: spbrogan@outlook.com Reply-To: devel@edk2.groups.io,spbrogan@outlook.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4VvNBFjHS9w0F12bBFxYW21Vx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BY3PR19MB49007FF3A0206F123CE0E528C8112BY3PR19MB4900namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="vjHW/5+N"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=outlook.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_BY3PR19MB49007FF3A0206F123CE0E528C8112BY3PR19MB4900namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Shoving everything into mdepkg to avoid a perceived dependency issue doesn'= t really solve the problem. If dynamictables pkg wants to be tied to an imp= lementation of ipmi then you will have that dependency problem regardless. = If dynamic tables really wants to be the producer of SPMI then it could qu= ery information from the protocol which would allow it to scale to the 3+ i= mplementations of ipmi I mentioned earlier (assuming the protocol definitio= n can be agreed upon and made common). Or manageability package could be pr= oducer of the table. Traditionally many of the ACPI tables have come from = the realm of the platform because of the detailed information they require.= I don't think dynamic tables package will be able to produce all tables w= ithout more complete abstractions and dependencies. So yes, until there is much better alignment in uefi for ipmi support, I wo= uld prefer the pcds and all implementation details be kept in or moved back= to manageability pkg. Thanks Sean ________________________________ From: Attar, AbdulLateef (Abdul Lateef) Sent: Monday, April 22, 2024 9:47:32 PM To: Chang, Abner ; Sean Brogan ;= devel@edk2.groups.io ; Liming Gao ; Michael D Kinney ; Zhiguang Liu Cc: Chris Fernald Subject: RE: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IP= MI interface type [AMD Official Use Only - General] HI Abner, Moving the IPMI related PCD=92s will cause additional packa= ge dependencies. Suppose if someone wants to implement SPMI table using DynamicTablesPkg (an= d using this PCD); then it will cause dependencies on ManageabilityPkg which is not accepted. Thanks AbduL From: Chang, Abner Sent: Tuesday, April 23, 2024 7:22 AM To: Sean Brogan ; devel@edk2.groups.io; Attar, AbdulL= ateef (Abdul Lateef) ; Liming Gao ; Michael D Kinney ; Zhiguang Liu <= zhiguang.liu@intel.com> Cc: Chris Fernald Subject: RE: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IP= MI interface type [AMD Official Use Only - General] Hi Sean, I was struggling when introduce IPMI KCS base IO PCD in Mde, although it is= a industry value but seems it is fine to have it in ManageabilityPkg. How= do you think if we relocate those IPMI PCDs back to ManageabilityPkg? Thanks Abner From: Sean Brogan > Sent: Tuesday, April 23, 2024 4:18 AM To: devel@edk2.groups.io; Attar, AbdulLateef (= Abdul Lateef) >= ; Liming Gao >; M= ichael D Kinney >; Zhiguang Liu > Cc: Chang, Abner >; Chris F= ernald > Subject: Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to define IP= MI interface type Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. This seems like a bad design to require the ipmi interface type at such a h= igh level in the code tree. UEFI provides plenty protocol and library abst= ractions for IPMI so I would really prefer not to leak this type of informa= tion into a PCD defined in MdePkg. Happy to discuss IPMI support and I wou= ld really like to see edk2, edk2-platforms/Features/ManageabilityPkg at mas= ter =B7 tianocore/edk2-platforms (github.com), microsoft/mu_featur= e_ipmi: Project Mu - Feature Repo- Firmware support for IPMI (github.com), and commercial vendors find s= ome sort of alignment going forward as no one wins with the mess that is in= the industry now. Thanks Sean On 4/22/2024 3:50 AM, Abdul Lateef Attar via groups.io wrote: Gentle reminder, review please. On 30-03-2024 10:52, Abdul Lateef Attar wrote: Define IPMI interface type as per specification version 2.0, section C1-1.1. Cc: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Abdul Lateef Attar --- MdePkg/MdePkg.dec | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 0c18e1decd..396d960dca 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -9,7 +9,7 @@ # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP
# Copyright (c) 2022, Loongson Technology Corporation Limited. All rights= reserved.
# Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.
-# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reser= ved.
# Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -2401,6 +2401,15 @@ # @Prompt Time-out for a response, internal gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60= 000|UINT32|0x00000036 + ## Indicates IPMI Interface Type + # The IPMI specification defines the following interface types: (section= C1-1.1) + # 0 - Unknown + # 1 - KCS : Keyboard Controller Style + # 2 - SMIC : Server Management Interface Chip + # 3 - BT : Block Transfer + # 4 - SSIF : SMBus System Interface + gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 + [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] ## GUID identifying the Rng algorithm implemented by CPU instruction. # @Prompt CPU Rng algorithm's GUID. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118125): https://edk2.groups.io/g/devel/message/118125 Mute This Topic: https://groups.io/mt/105228733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BY3PR19MB49007FF3A0206F123CE0E528C8112BY3PR19MB4900namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
Shoving everything into mdepkg to avoid a perceived depend= ency issue doesn't really solve the problem. If dynamictables pkg wan= ts to be tied to an implementation of ipmi then you will have that dependen= cy problem regardless.  If dynamic tables really wants to be the producer of SPMI then it could query information from the protocol which would allow it to scale to the 3+ implem= entations of ipmi I mentioned earlier (assuming the protocol definition can= be agreed upon and made common). Or manageability package could be producer of the table.  Traditional= ly many of the ACPI tables have come from the realm of the platform because= of the detailed information they require.  I don't think dynamic tabl= es package will be able to produce all tables without more complete abstractions and dependencies. 

So yes, until there is much better alignment i= n uefi for ipmi support, I would prefer the pcds and all implementation det= ails be kept in or moved back to manageability pkg.  

Thanks
Sean 


From: Attar, AbdulLateef (A= bdul Lateef) <AbdulLateef.Attar@amd.com>
Sent: Monday, April 22, 2024 9:47:32 PM
To: Chang, Abner <Abner.Chang@amd.com>; Sean Brogan <spbrog= an@outlook.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Limi= ng Gao <gaoliming@byosoft.com.cn>; Michael D Kinney <michael.d.kin= ney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Chris Fernald <chris.fernald@outlook.com>
Subject: RE: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to de= fine IPMI interface type
 

[AMD Official Use Only - General]


HI Abner,

        &n= bsp;       Moving the IPMI related PCD=92s wi= ll cause additional package dependencies.

Suppose if someone wants to implement SPMI table u= sing DynamicTablesPkg (and using this PCD);

then it will cause dependencies on ManageabilityPk= g which is not accepted.

 

Thanks

AbduL

 

 

From: Chang, Abner <Abner.Chang@amd.com&= gt;
Sent: Tuesday, April 23, 2024 7:22 AM
To: Sean Brogan <spbrogan@outlook.com>; devel@edk2.groups.io; = Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Liming= Gao <gaoliming@byosoft.com.cn>; Michael D Kinney <michael.d.kinne= y@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Chris Fernald <chris.fernald@outlook.com>
Subject: RE: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to de= fine IPMI interface type

 

[AMD Official Use Only - General]

 

Hi Sean,

I was struggling when introduce IPMI KCS base IO P= CD in Mde, although it is a  industry value but seems it is fine to ha= ve it in ManageabilityPkg. How do you think if we relocate those IPMI PCDs = back to ManageabilityPkg?

 

Thanks

Abner

 

 

From: Sean Brogan <spbrogan@outlook.com>
Sent: Tuesday, April 23, 2024 4:18 AM
To: devel@edk2.groups.io= ; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Liming Gao <gaoliming@byosoft.com.cn>; Michael D Kinney <michael= .d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Chang, Abner <Abner.Ch= ang@amd.com>; Chris Fernald <chris.fernald@outlook.com>
Subject: Re: [edk2-devel] [PATCH RESEND v1] MdePkg: Adds a PCD to de= fine IPMI interface type

 

Cautio= n: This message originated from an= External Source. Use proper caution when opening attachments, clicking lin= ks, or responding.

 


This seems like a bad design to require the ipmi interface type at such a h= igh level in the code tree.  UEFI provides plenty protocol and library= abstractions for IPMI so I would really prefer not to leak this type of in= formation into a PCD defined in MdePkg.  Happy to discuss IPMI support and I would really like to see edk2, edk2-platforms/Features/ManageabilityPkg at master =B7 tianocore/edk2-platf= orms (github.com),  microsoft/mu_featu= re_ipmi: Project Mu - Feature Repo- Firmware support for IPMI (github.com)<= /a>, and commercial vendors find some sort of alignment going forward as no= one wins with the mess that is in the industry now. 

Thanks

Sean

 

On 4/22/2024 3:50 AM, Abdul Lateef Attar via group= s.io wrote:

Gentle reminder, re= view please.

On 30-03-2024 10:52, Abdul Lateef Attar wrote:

Define IPMI interface type as per specification ve= rsion 2.0,
section C1-1.1.

Cc: Abner Chang <abner.chang@amd.= com>
Cc: Michael D Kinney <mich= ael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@by= osoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu= @intel.com>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
---
  MdePkg/MdePkg.dec | 11 ++++++++++-
  1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 0c18e1decd..396d960dca 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -9,7 +9,7 @@
  # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development L= P<BR>
  # Copyright (c) 2022, Loongson Technology Corporation Limited. All r= ights reserved.<BR>
  # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR= >
-# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<= BR>
+# Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights reser= ved.<BR>
  # Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<= BR>
  #
  # SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -2401,6 +2401,15 @@
    # @Prompt Time-out for a response, internal
    gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryInterva= lMicrosecond|60000|UINT32|0x00000036
  +  ## Indicates IPMI Interface Type
+  # The IPMI specification defines the following interface types: (se= ction C1-1.1)
+  # 0 - Unknown
+  # 1 - KCS     : Keyboard Controller Style
+  # 2 - SMIC    : Server Management Interface Chip +  # 3 - BT      : Block Transfer
+  # 4 - SSIF    : SMBus System Interface
+  gEfiMdePkgTokenSpaceGuid.PcdIpmiInterfaceType|0|UINT8|0x00000038 +
  [PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
    ## GUID identifying the Rng algorithm implemented by CPU= instruction.
    # @Prompt CPU Rng algorithm's GUID.



_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118125) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BY3PR19MB49007FF3A0206F123CE0E528C8112BY3PR19MB4900namp_--