From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.92.21.62]) by mx.groups.io with SMTP id smtpd.web11.22651.1682230418134276131 for ; Sat, 22 Apr 2023 23:13:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=P2pWbEOw; spf=pass (domain: outlook.com, ip: 40.92.21.62, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=drLp+mkfLcSZtSJ+tUNGjd2w99+38BnL9jCyeOAr5Y5cwSCRi9HIPqTm8RiDb4TjNyrtEjXyFCjpqkp8YsPSNdcGe72qbPJpHIILheVkeVKBc6kufZ2w9V8oMpg906qV9/GboF2LljEq6xlj7CRgC/2DnorJavZhSc0nsnfwW/OdNG4obDTz22Nn5YnMVoDwnzwrOAc0eRnHgA94/RREFqSSTj+98ddgikdscTpBqokGjpAaoJ2nS/GNYhcndfa3Z2cMbMLcABdEutJ3qKCoXPpOzQ72mRr93baxFPeR4LCNRjoNfuwxZhGQutcPKQVwdZtO17H6xGa+sHFjrFfdlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G0AYcQU2L6p7qn6r9P0V+VbP7CxV9JlmauL2HA6zJX4=; b=SFlt99sZgD23sXeDjQrKGuH52TVBvQmAkZJhp/BhZbFgMyKhCf2NmmNtHcz6GBMp2fRAlAPvrUwdaYsNevPQ5dyJhJCGbdjItPlkYE3cE1KdXEr2LsKXjV2J4uZR+Kf9wZIz3skVP74b07tJLBBL9mYf0gAOjfUfTL/LOQHjltIyBADy6u1VYXdrnEAPX7l6szpOKHHNndWo+IsxNM9rnIJ7lhQMRSlFdghbdcLk7P/sdrKsRUDYcz49j2Va/h2HWjQtX7fVC1aOyhBiLzD6vh03rsKjFIoSys+dCFh2MpO9T9KLjC1y5Qc5V9JK35uV5xSc909zdBrFN89k8k6o7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G0AYcQU2L6p7qn6r9P0V+VbP7CxV9JlmauL2HA6zJX4=; b=P2pWbEOwvoKOln2Whq0tfIYrccL55bNTvethkjyVd+fVDjkEEM8ZFckEnf3ht6+WuFKG47t8FHz23OczkOSWNx36FRqCurvLRHDqkH7dMQFoeI/pY4f934P5Y30oY1nmAUoRujck9wt1/7GGaUqpr4TDpYpWveqmB3tiNq65PUKBfbqlyHLqSh+gMRUHgKiHGgsYaKARjATWMlUyURWIPPBWyYKoGLHwSna2Bv/KDZSG/6r3TvPkf5g7RA1zLAh4Sb2vsqE/ZpGDNeRkucuZXe1ldDUkc3w1qhOrQjJiLYZjr+v1C4jJETSSdvqP//DfJEdgjH2ZWStmbveE8elEhg== Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) by SJ1PR19MB6377.namprd19.prod.outlook.com (2603:10b6:a03:458::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Sun, 23 Apr 2023 06:13:33 +0000 Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::dbe5:112f:db31:2409]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::dbe5:112f:db31:2409%5]) with mapi id 15.20.6086.024; Sun, 23 Apr 2023 06:13:33 +0000 From: "Sean" To: "devel@edk2.groups.io" , "michael.d.kinney@intel.com" , "Guo, Gua" , Chris Fernald CC: Sean Brogan , Michael Kubacki , Oliver Steffen , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool Thread-Topic: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code coverage tool Thread-Index: AQHZdYIODuRTTP9ZzE+IGp0oBX5L+a84ONIAgAAw9Y0= Date: Sun, 23 Apr 2023 06:13:33 +0000 Message-ID: References: <20230423012213.1472-1-gua.guo@intel.com> <20230423012213.1472-2-gua.guo@intel.com> In-Reply-To: Accept-Language: en-US X-Mentions: chfernal@microsoft.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [EWSZMh8rcG2kz/KvEbYGbEf7HKNQ6ANyrnol4HKbsw8=] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY3PR19MB4900:EE_|SJ1PR19MB6377:EE_ x-ms-office365-filtering-correlation-id: 620cc8b4-9b37-472c-9bf9-08db43c1de21 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xiBWeI/v+LRDLg6KkQ2pDq98AuINhVumef2OLHJG0Wq5MGX38sFbCx9uIGlfC/R2AruWUGbTIcY8DLtR17LQtcwy562f2WDgucdQFqgik2unF1+YpDQ3qZbMzPTLtlnnC87CkxvwTBZBtuDQWc4tQ2IwUBxyRPP5iqFc+aSTZOtcf0MmADTjP8T7YrfLDepQbbEDaNnaWAwKVRveeepmZhSwOpuLGFnfSqVwHRPVZ6gdzS87ip4jEhtJW3yavKdJrJlUJ5c74Y13Z/iDSDwx07jRDitm9CIKV7rYGPUPvYkvS1oKTOKbzRL4KJozBcCayNTRKtdloieEFhKl9NeUxbmJSEGCgVDRYwQ+i5n8THYIV9NtoBxRVHwy/HBk1xqW0kCrV7Of5mdL1UpDczA61wD/FYl2xG9zCD/GY4fV3rf1iMRDe0asgqdke58MCjzeBGQiYdUdK/dOKN7AgFPocG5jZiNirbznAnt9atcj9pBPLETl04IdC1o4XtHi3o8DqUxwOeCCIScqZpiE38WZoretT+kS5cRh5Hcna3eLPnvgLu+ZGkeRMoZ39SsA0+yBqWVLR8n9zKekANZqhbS/ZAneWOxFByFDNg9wvLJ2k3pOrbSvHG2Pk8Guzg0H6dK+ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UobMU6j4SWsRxhxj6O98Y4Wa4849hKajDMA5FnkfgvgenigR14OgzGDOUu7h?= =?us-ascii?Q?Z9fl3rCixVsBDZR8KNc/D1t025ouNIjqdFc5OOq81vx9t11TGbQxLfLb9Hgf?= =?us-ascii?Q?vtwSszZ94XmOalvWEKhvmo8cYplvqZ+odhLR5GHzxUbth+YdNIXuWSFVqP7p?= =?us-ascii?Q?NL1NNyXkJuBrTMdENEwqkuiwGG82xfuwWtFSOa0DiFaT9pdPFpCsO9RgDcG9?= =?us-ascii?Q?CeYY5CFGF253jHPHqf8an+mOMtxwIQ2FQQLBJtJ1wZIVzL3V9H2IXkqI4LMq?= =?us-ascii?Q?CSCF5rVFqB3uLl74PbQ81tbrBMYecR4rHhq2HY7ZU701jzO/VrISq2Lds1WQ?= =?us-ascii?Q?yRheGmLjCrnT3NjotA0sSKVP5Zat/fxtlHztSZymJq4DoH+vhzcgn1Tye4Bm?= =?us-ascii?Q?wGOAhKmQEnLsKs/p19//6GiEogKZcemK6A2TzrXNG61jSERK5HIGkFT1SUkR?= =?us-ascii?Q?6gesb/8TT2Rul5r85XBm+x1WQyTYbJMvEXlgMFoM2AZsceO23motPY7F7Yrp?= =?us-ascii?Q?vNT5ps9bFvPzPAC/uDgVv2R/gmEY53mjunNA0J6s573d9oM2yw1Rz9XPrW6f?= =?us-ascii?Q?IxhiKWZIoeA4lQ4cDQj9+JHtdcxhX4rV1qARdvPuXm/oj8CPGrOB4t5gBhWt?= =?us-ascii?Q?Qfh5vKSKhchhcywuKVSwt/QR0vhtndtHZboSm4zb+fq44tollOqriNBTQeZN?= =?us-ascii?Q?Iy7e2JpGx01rUa43VKW6ueE/b7jh5kvOLTLadKArSlSAK7CXjRpJmW004ia/?= =?us-ascii?Q?nAhQYp734d5AuCZf+ld4eBMAo7CvPzW0Jr5/zl+tdFyz5xUibL5pKwRDGKhv?= =?us-ascii?Q?QGZJEG9bgN3I6twnPA9Q2ucl8JeEAi30o6a2oXh6TCZu6FGDBHMkEQu+4TUO?= =?us-ascii?Q?x+kT0drdwCPDSNYx87jkTQobLH97e1VdzEesrAVlMkUKNYEat1/nx+CB3N4o?= =?us-ascii?Q?SV821svXJ18BRtJtDG1Bru/jJpst4vQtnbM9d/h+10O0bvzvjSgDq1irsKzT?= =?us-ascii?Q?Dj68OL+Z0i5gu5d5x7Jw8YfSQ/XuWuB0PYgFE96xf0INd3JS9BfsghuqEBL6?= =?us-ascii?Q?itVb+8+5PgPhb0lHr3AXSc33tVtvTx9B84K4dpVrBcY6mJx5ip+hgf1wi9eY?= =?us-ascii?Q?/1UlguyJD9K5V9e+WD3Lebs3wlle7EHNx14vQL9yRVc1UB4vBVuq8malfqgn?= =?us-ascii?Q?YE6aUq+n1fq7saewg4Dc/mQDy/QNB29w4J0iKE2WDfoS7+wywQRsYeerlRG6?= =?us-ascii?Q?NZV2w6POB7eqZjIKrqBp?= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY3PR19MB4900.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 620cc8b4-9b37-472c-9bf9-08db43c1de21 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2023 06:13:33.6925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR19MB6377 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BY3PR19MB490085078A1EC5E536CE3613C8669BY3PR19MB4900namp_" --_000_BY3PR19MB490085078A1EC5E536CE3613C8669BY3PR19MB4900namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry a little late to review this. It looks like these are container based= builds. If that is the case we should handle this by updating the containe= r. The whole point of the container is to get the requirements all included= in the container. @Chris Fernald can you sh= are details. Thanks Sean ________________________________ From: devel@edk2.groups.io on behalf of Michael D Ki= nney Sent: Saturday, April 22, 2023 8:15:56 PM To: Guo, Gua ; devel@edk2.groups.io Cc: Sean Brogan ; Michael Kubacki ; Oliver Steffen ; Kinney, Michael D <= michael.d.kinney@intel.com> Subject: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install code cove= rage tool Reviewed-by: Michael D Kinney > -----Original Message----- > From: Guo, Gua > Sent: Saturday, April 22, 2023 6:22 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Kinney, Michael D ; Sean Brogan ; > Michael Kubacki ; Oliver Steffen > Subject: [PATCH v2 2/2] .azurepipelines: Install code coverage tool > > From: Gua Guo > > Azure should install code coverage tool (lcov), it didn't > exist on Fedora and Ubuntu by default. > > Cc: Michael D Kinney > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Oliver Steffen > Signed-off-by: Gua Guo > --- > .azurepipelines/Ubuntu-GCC5.yml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/.azurepipelines/Ubuntu-GCC5.yml b/.azurepipelines/Ubuntu-GCC= 5.yml > index b9a3b851cf..d884256148 100644 > --- a/.azurepipelines/Ubuntu-GCC5.yml > +++ b/.azurepipelines/Ubuntu-GCC5.yml > @@ -24,3 +24,7 @@ jobs: > container: ${{ variables.default_linux_image }} > > arch_list: "IA32,X64,ARM,AARCH64,RISCV64,LOONGARCH64" > > usePythonVersion: '' # use Python from the container image > > + extra_install_step: > > + - bash: sudo dnf install -y lcov > > + displayName: Install Code Coverage Tools > > + condition: and(gt(variables.pkg_count, 0), succeeded()) > > -- > 2.39.2.windows.1 --_000_BY3PR19MB490085078A1EC5E536CE3613C8669BY3PR19MB4900namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Sorry a little late to review this. It looks like these ar= e container based builds. If that is the case we should handle this by upda= ting the container. The whole point of the container is to get the requirem= ents all included in the container. @Chris Fernald can you share details. 

Thanks
Sean
From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Michael D Kinney <michael.d.ki= nney@intel.com>
Sent: Saturday, April 22, 2023 8:15:56 PM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io <dev= el@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Michael Kubacki &= lt;mikuback@linux.microsoft.com>; Oliver Steffen <osteffen@redhat.com= >; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/2] .azurepipelines: Install co= de coverage tool
 
Reviewed-by: Michael D Kinney <michael.d.kinney= @intel.com>

> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Saturday, April 22, 2023 6:22 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Kinney, Michael D <michael.= d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Michael Kubacki <mikuback@linux.microsoft.com>; Oliver Steffen &= lt;osteffen@redhat.com>
> Subject: [PATCH v2 2/2] .azurepipelines: Install code coverage tool >
> From: Gua Guo <gua.guo@intel.com>
>
> Azure should install code coverage tool (lcov), it didn't
> exist on Fedora and Ubuntu by default.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Oliver Steffen <osteffen@redhat.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  .azurepipelines/Ubuntu-GCC5.yml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/.azurepipelines/Ubuntu-GCC5.yml b/.azurepipelines/Ubuntu-= GCC5.yml
> index b9a3b851cf..d884256148 100644
> --- a/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/.azurepipelines/Ubuntu-GCC5.yml
> @@ -24,3 +24,7 @@ jobs:
>      container: ${{ variables.default_linux_i= mage }}
>
>      arch_list: "IA32,X64,ARM,AARCH64,RI= SCV64,LOONGARCH64"
>
>      usePythonVersion: ''  # use Python = from the container image
>
> +    extra_install_step:
>
> +    - bash: sudo dnf install -y lcov
>
> +      displayName: Install Code Coverage Too= ls
>
> +      condition: and(gt(variables.pkg_count,= 0), succeeded())
>
> --
> 2.39.2.windows.1






--_000_BY3PR19MB490085078A1EC5E536CE3613C8669BY3PR19MB4900namp_--