Re: [edk2-devel] [PATCH v4 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

["Sean" <spbrogan@outlook.com>]

Thanks for the link as i missed that message.

To me this just points out more problems with how OVMF is being managed 
in the edk2 project and the uselessness of edk2 platforms as anything 
more than just a dumping ground repo to hold sample code.  But that is a 
problem larger than this patchset.

I guess if you are going doing option 2 can we rename the library 
interface you are defining in OvmfPkg so it doesn't conflict with the 
existing one in edk2-platforms/minplatform.  That would mean change:

* name in OvmfPkg.dec file
* header file in OvmfPkg/Include/Library
* all references in DSC file for mapping an instance
* all references in your INFs for dependency

Thanks
Sean






On 8/12/2021 3:19 PM, Stefan Berger wrote:
> 
> On 8/12/21 4:59 PM, Sean Brogan wrote:
>> This seems like a bad place for a general purpose lib that many other 
>> platforms may take a dependency on.
>>
>> In v1 this was SecurityPkg.  OvmfPkg is a platform package and 
>> therefore not a good place to define broad interfaces.
>>
>> What caused this to move here?
> 
> 
> Option 2 from this message: 
> https://listman.redhat.com/archives/edk2-devel-archive/2021-August/msg00398.html 
> 
> 
>    Stefan
> 
> 
>>
>> Thanks
>> Sean
>>
>>