From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.92.45.63]) by mx.groups.io with SMTP id smtpd.web10.40830.1628880429959774075 for ; Fri, 13 Aug 2021 11:47:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=WBH9IyMH; spf=pass (domain: outlook.com, ip: 40.92.45.63, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bxwJVlbOA4GOruAURhqyvbawtXgOmIjQ53XDvqfOaPlvR7sorFKqwRpbccphU1sw+9zLghhrf5IRuUMvnmMYIPBXFBND4Tm/6coX/LSUZTB3eeTi2a3enkytCLORDxVLLXJ/ultFaVDY6j93MShff30jgvCTLYTQ2n2kkd8u7L/eDxloUIS5cvprm3vqlfU3UGSNXpou6XwZoQ6uElPfFFRwxZzyBvs6Tn0hZ2dBaliCmseOb8bAqEXrL28bjoe9uZ0sK4DDjTT3oXAgUvfsAcCWOQHDUHH87Ck28WLB435QiRKDp0SHmLxYwy8WCFAeZuQgh8rqYT8x+1uBsLA2vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SvKDzH9nfiseW1tNIlFatkj0BmykEdAMckXSDKP+9HM=; b=JyNbhlYVkapLcrdh5JN86A2jeK6Fl6uwNHaZxg9lL9f2AtRtmcCGlMkyH8S+Tw5kwGmabOwPRYSv+WoDCX9cZD27gqvXCE0ec4/5FmeKOliL9j7fL+08P992zVFXxmGDrrnibpvUDbiR+jOQnzTSDe82fZdpJLLxvkiczqu3dj0anCiKfaWhcNpN0WB+r3u9AYwiysJZGRbZujCoDgg7CfgLfI79JP+YvW3RhdW0tzQnPGIn7WUJLpc5DzUiNSVw/cpDvevYz9qFm8AuStZqW5rCAsfqIm/bdOAxcjxEUjFmQV4FmuB5X/5nRj9Nn5Bjirco7BIARjzVeluMGDbLlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SvKDzH9nfiseW1tNIlFatkj0BmykEdAMckXSDKP+9HM=; b=WBH9IyMHCYGBfPpmtanbWlHh9NnW8FimJIaDxo4SnnKCxYrdNNtCxALZ7ZD9jiGU2dYlzxOCAW13pN4kDU/LRVEz14ffd4p9MmKUFq7VtZCjWQWvekjPZQjTlzHpsO/PVtOppwCw6tPdEtpLuxTUXF1pwYvWRsEzk5RG72/do/oBGH5HggUHIXyiNs3rbMvASbFPzC9BNz6SApMHQV+pczz1jxwDwRb1D83POWiz/+G0k9BVIxrxv3Cw7CpvyL9ua4kUHYArRLjLe14ts8sDrhIv5WFdAJpc2F9/eUO/BPLA/fVZRvUMYcU7p7XbG3oQoQy731AuKJZjl7k98gIkng== Received: from BN8NAM04FT044.eop-NAM04.prod.protection.outlook.com (2a01:111:e400:7e85::41) by BN8NAM04HT130.eop-NAM04.prod.protection.outlook.com (2a01:111:e400:7e85::351) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Fri, 13 Aug 2021 18:47:08 +0000 Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2a01:111:e400:7e85::46) by BN8NAM04FT044.mail.protection.outlook.com (2a01:111:e400:7e85::252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16 via Frontend Transport; Fri, 13 Aug 2021 18:47:08 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:8CD78699ED8B4A9BB7119867AFEDE394EA7C3FCB9B743108533902D0C948B43D;UpperCasedChecksum:5382F9C821482F4739AC742A28CDD7DE9BF978C0C51D05DD8D12CCB8E7301D6D;SizeAsReceived:9064;Count:48 Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::4991:e984:f0a1:b0c]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::4991:e984:f0a1:b0c%7]) with mapi id 15.20.4415.020; Fri, 13 Aug 2021 18:47:08 +0000 Subject: Re: [edk2-devel] [PATCH v4 1/6] OvmfPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms To: Stefan Berger , devel@edk2.groups.io, stefanb@linux.vnet.ibm.com, jiewen.yao@intel.com CC: marcandre.lureau@redhat.com, lersek@redhat.com, dick_wilkins@phoenix.com, James.Bottomley@HansenPartnership.com References: <20210812165931.3071083-1-stefanb@linux.vnet.ibm.com> <20210812165931.3071083-2-stefanb@linux.vnet.ibm.com> <649733db-0d37-326e-5f83-f6f8ad500cdd@linux.ibm.com> From: "Sean" Message-ID: Date: Fri, 13 Aug 2021 11:47:06 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <649733db-0d37-326e-5f83-f6f8ad500cdd@linux.ibm.com> X-TMN: [9ZAxa8ssxrDUfoZgLlsPDYyXb+VcpWGh] X-ClientProxiedBy: MWHPR04CA0043.namprd04.prod.outlook.com (2603:10b6:300:ee::29) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <89317dcb-3b9f-082f-e83d-3a0e73c96dcb@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR04CA0043.namprd04.prod.outlook.com (2603:10b6:300:ee::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Fri, 13 Aug 2021 18:47:07 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 50704387-febd-42c4-349a-08d95e8ac07e X-MS-TrafficTypeDiagnostic: BN8NAM04HT130: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wH7Rw+aZvPrMRGKRcSKF4GQThzwRx7XBMnZxD6Ltnl/m2+Z/JxxSX+0TvIEfgUAfFX7oM3I8bDxq3LesmvIvb2PXZNlhVCBCX9xxu/S6X2FIwVtbwsbligQm4Wkebq/N22T5/RKEGi+PsBUV+b0VUYdZiIpJwNm05ZMfuFPYk28Jtv8iygiuQ7lg8YZkyjAcXhuYExzDhZ7XC3ArAD/sKpiVuGYatClcAGvQ8HN2op+Ox2MinYV2j/yHUqSU1WajuvNDjDqzR6dvFvkdaIvDiICjZX/x5KOpeoT++3+MMIy6L0oIoL/4W4egps9GP/X5CV75EZK3cSnXm0g4QGebOvy4zJNl5AYLPuuLcAERapKiyjT+KszOMZKaaLBILFcY/a8a+FcoQp36abhBsuNGTw4Uhigv9DvPIT6GVSqyh69Hku6OkTYQaWwVPBpMy4TRUgwzz0/EaYlJ3jCsyDUW/WrjaauuBO5/IhlL0mf5+k8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0GY3eG2sO0nD8huUbrL5XoIDsE8Qq5Nj2h8hyJJF619xbhNkl+kk5+gXwAV0td6vApF0Hox3658TD+jUB1GDc6Ur4TTCPlh1UDFJtRoUSSo/mduqSjxW8kJ+FE0xz8CTu+8wdOIthfVXajlOBxHbsg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50704387-febd-42c4-349a-08d95e8ac07e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2021 18:47:08.0009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN8NAM04FT044.eop-NAM04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM04HT130 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Thanks for the link as i missed that message. To me this just points out more problems with how OVMF is being managed=20 in the edk2 project and the uselessness of edk2 platforms as anything=20 more than just a dumping ground repo to hold sample code. But that is a=20 problem larger than this patchset. I guess if you are going doing option 2 can we rename the library=20 interface you are defining in OvmfPkg so it doesn't conflict with the=20 existing one in edk2-platforms/minplatform. That would mean change: * name in OvmfPkg.dec file * header file in OvmfPkg/Include/Library * all references in DSC file for mapping an instance * all references in your INFs for dependency Thanks Sean On 8/12/2021 3:19 PM, Stefan Berger wrote: >=20 > On 8/12/21 4:59 PM, Sean Brogan wrote: >> This seems like a bad place for a general purpose lib that many other=20 >> platforms may take a dependency on. >> >> In v1 this was SecurityPkg.=C2=A0 OvmfPkg is a platform package and=20 >> therefore not a good place to define broad interfaces. >> >> What caused this to move here? >=20 >=20 > Option 2 from this message:=20 > https://listman.redhat.com/archives/edk2-devel-archive/2021-August/msg003= 98.html=20 >=20 >=20 > =C2=A0 Stefan >=20 >=20 >> >> Thanks >> Sean >> >>