From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.92.43.26]) by mx.groups.io with SMTP id smtpd.web12.25458.1637942044961193658 for ; Fri, 26 Nov 2021 07:54:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=NlQpCDEl; spf=pass (domain: outlook.com, ip: 40.92.43.26, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L7DQ97uW3sZnI1auYRhjW7cx3J6ZWFGqVNvHjPbT+Jyk2qRCgusqpgd27pQvGF/zAD1324vm1z39DVMTMKixmtVs8HH6eCaMPgdMw8c4tmgQyAMsR+4x0VB2fX6ay3fpRZy/qu6o30kuZbHDF7WJCMmiUfJZZ8/AQ7FkchB+hQT/BZOHwa3bvNPJcFBbj3EqO7b6oSl5sSgRz9Fn+Ugg+qBn9GrvNKWnX+UbYveQcVBYziu9MMHSy1BF4VqXnBQRoUG1UiJIK7EFSjJxlS09ojhH8XLSIrPUOdkwMQHWnHL0X6Q1quh+TK7wmQsJxolrdapTefFw+/vqWg3hnBx+GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KKXizkhHBmebMgp6eu5o+0HC7iZdYG1brpSVMOtPDPc=; b=hrH/YV5S7hWoUBJVSuUvL8ZMwgAE8gQCSt8ppLw5Jvqia7FAzo1lpnByboCbzDDCeNi+bO44LTPz7uDqd5AbiKDaJwlw2VHHp/bE+dL1CJ5dF5H28QHQm13zxDx4HvM3b3I1NzD/eHp4XCwZkBXlqyyUDXyiLsdA8TJOsFAV2x58evCWfkgbvStMqAMBWUU2IR9cnDnGqWIzAkPGc5pW9lYpRbMCZMj8uUv8W9oCcQX2auxIyIbYTpOirUhlvw/+FX320VPhXwY2t+qw1ePvfYASkhd6agVl3YmXajmm03acoR53qPMbv48NEWlFHvqYWamQRkThJD0wLhWKYEF8qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KKXizkhHBmebMgp6eu5o+0HC7iZdYG1brpSVMOtPDPc=; b=NlQpCDEl47Flxhr8Hubwj2K132rLffa/xTiZmZ8Yn2x+CesgcQZEcPmoTMexNhRtkGaCFCUJrbdTN0XY4OadZXCbP2wVEgeswLNTkfGiimVU8RXj+xoW5NgSyKE/VMBymMGrEQOKsdZDL6HhJBUBBjEJmEBhhC2bgIY25yfTrXWqBwZodczt/FJd8jY1BgUsNZ29da+AvKyk9Mh0J5Vm2KJfr4KYN7wFD9/8MVSeuJ+GS1Quh7xcCjnVIk4eQ7wtQyybJbRqe1N7GhKC/2Tzv/4K0L5wrNPsMnJxhMA/K8/LG1Hi+F+vKih1adxXSsqweM6AU2jnVnZM//jw8aZsbg== Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) by BY5PR19MB3649.namprd19.prod.outlook.com (2603:10b6:a03:1c9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.21; Fri, 26 Nov 2021 15:53:58 +0000 Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::44c5:11a3:13d9:c2fb]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::44c5:11a3:13d9:c2fb%7]) with mapi id 15.20.4713.025; Fri, 26 Nov 2021 15:53:58 +0000 Message-ID: Date: Fri, 26 Nov 2021 07:53:57 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [edk2-devel] [Patch V2 0/3] Remove git reset and optimize To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , Bret Barkelew , Liming Gao , Michael Kubacki References: <20211123163101.786-1-michael.d.kinney@intel.com> From: "Sean" In-Reply-To: <20211123163101.786-1-michael.d.kinney@intel.com> X-TMN: [JoSK/AvrkU/Uv9dixDXV2cjWc7pV/xBE] X-ClientProxiedBy: MWHPR02CA0001.namprd02.prod.outlook.com (2603:10b6:300:4b::11) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <05d37ca5-28b3-4dfc-a84c-c053419ff195@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR02CA0001.namprd02.prod.outlook.com (2603:10b6:300:4b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.20 via Frontend Transport; Fri, 26 Nov 2021 15:53:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 78029ff2-c795-4556-421f-08d9b0f4f55d X-MS-TrafficTypeDiagnostic: BY5PR19MB3649: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RiAY0GO/rAOQGg1c/mXe4ZWaEb7ZdsIklGjoaFwdfgpKrlZYbdSYN7OLI7oY2KcYh28xmfwlWn36+jk197JoXdWbP1ZwG+iVV8P4ZadBQFQ3wqhYrALnEJY7lMFL2kSajInAS5cxLBzAyHQgURg8W46GkvChnccHB+4vzWMZiSQLO3zaF3/QZecieqX+1fcAbU3AGtvJt6BftcgzFy92awRYtjl+luKAu9zwDjFTBxBKFSbfA0DdxUaa0RW11iigrqvf/B3LgrWuRb1AcI008oe/XMt3BQvQhGJhd/KfyRB+9oTEeBMmQ5imQAqZrWGf5H1B5I6zVsOD6RsxTIp9wMiFe5syNsFCS/rb+CL0WVloOmvs3+odPU5S5AGVTExSZnXJaONvY2ogpTlz5gI8opimSc6HKuTraUnUfD94mObD+QAOX0i5nwSqMMjYQXNG965mv8lfEEgQTNa+E1pBWb4ylGxzrWsf36BBrSmHwVvzc+KeIWnvuW24dZwtBAPK6Nr+XS6UuUv2hmEySrdfHbenOBwwSrCsjwEI9zzFMcXczvFzgyZ+/0i+66q4hv4sjZcUWq3/e/QcCREm61nawgjm/SHPYuUqOI9nFkkV+9MO3e6RECjNY38DvB4K/KZL X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ccsxvVM9pxjGn9WWxHBa+K5PUVW7yNb8ZtuZRN3XRToP2JEDE3y65qNyxNIQw4BvCj24sEEppyCEPDiS1mlnvwZpCBxcivvSNA/Ohg+159ebaSTF4JhahPGKONJXLFcCcVOB8F68n6dZuBrNV2Hu3bZeAxPqISmnGTiZGYGwRJ56BoDxr5EDebjh49pyLWx2CtFPfWib52s79TqF1p1SCGdOVvQ5P5F/KP83cSO4Fm5cUJCG3RV7P7dmHS83ts0dULF2gDIFzY7/hbEIzI3hJUneCAeJh2cEcQKdnI1P6MLcLGZRlvy5nB8qU67lzYRXbcrongJVdnyLTmt3gruVmu83xs/tx9nEyVd9Io+lvs+UldMm5UAWI1lbRC/IMxeZc5CEl+cgE5ydr2q7P8i/IiiisSnl1tPq3pSYX3oHDfwXdykwI5P/aBo+c3JEffcDo0yVSmEqYV+H/Q4rN7M0J5orm0Q9yownCsMzIt74xsJy6+nvcyZlCTGKPMzk0GYuv3vop2kjgLaEiC0CFOAErfebynIBFkMeSzE7GRx5Vef/9i2HR6ISQbetA+Bai4bzAC3Mq2ZKeieEhqgjsnmBKt08qeKRF+NvoxCnPwYRofHc/EnP1dVUt+fwOkJTZVNJifbu23ozp0gM2gfTvx4+SGNwm5bEEBUBTpwOxwcsxTEyKpAusBotdWg2n/pZoEBPbKCL6tJZ1gpfRQR8JXRWgg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78029ff2-c795-4556-421f-08d9b0f4f55d X-MS-Exchange-CrossTenant-AuthSource: BY3PR19MB4900.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2021 15:53:58.6954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR19MB3649 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Acked-by: Sean Brogan On 11/23/2021 8:30 AM, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 > > New in V2 > ---------- > * Change temp directory path from Build/ecctemp to > Build/.pytool/Plugin/EccCheck to provide a unique > temp directory location for any .pytool Plugin. > * Set working directory when ECC runs to temp directory > to guarantee all temp files created by EccCheck are > cleaned up. > > * Use temp directory for all operations to prevent any > changed to git state. > * Remove git reset operation that could corrupt staged > and local changes. > * Improve performance by removing redundant directory scans > * Improve performance and reduce log file sizes by using > --output option of git diff to a temp file instead of > using stdout. > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Liming Gao > Cc: Michael Kubacki > Signed-off-by: Michael D Kinney > > Michael D Kinney (3): > .pytool/Plugin/EccCheck: Remove RevertCode() > .pytool/Plugin/EccCheck: Remove temp directory on exception > .pytool/Plugin/EccCheck: Add performance optimizations > > .pytool/Plugin/EccCheck/EccCheck.py | 242 +++++++++++++++++++--------- > 1 file changed, 169 insertions(+), 73 deletions(-) >