From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.92.21.40]) by mx.groups.io with SMTP id smtpd.web10.1195.1663801782977658590 for ; Wed, 21 Sep 2022 16:09:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@outlook.com header.s=selector1 header.b=GvbwFhrp; spf=pass (domain: outlook.com, ip: 40.92.21.40, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cmZInTCNjR2XswoTt35GSSJodcm9WbgFrme7NvDiVRMuJkDs1B39DeFgI+jzP+UYyMIwxoiE1ZXhwXqVgokXf1hLvdi1e9PIdMxqXFQd10SKiZf3jLlRIh4Udr8wkVcwq8bYhguOFYJ9GXqUoof3ZqESF9eQR+nMT76HKR1fQOCYZUyGGT1apzggs1XanUw7sBL1bRLztzioZ+0GX2IQAb3jnNJjfTTTmkcD1JOOBpyv0NwFNhh2A4KeiYJbRFrkuB7c547mDziHIPcdcxyRLyx+yLRPFLFxyd1THPStYttcI2DWKVFk9Ur2ldJ+RAf0naR6bfYVlULVho7IDUxsBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8dboIVjdD5SL6BQzjSwnmv7zSVF+d+JtiTNRbtKD7Wc=; b=GWOUklGUPM2psehKTNH7N4pZC+SKADEZlOq8BDtow/fpthyMhgpP4+Z4LrLnJynGD+StCMwwOFNw3Dpwr/nhxrpLxDNJhwAS9PeBYQpRftQ8NVhSvcDp9I47YNv+svi7FxahuDxg8bDzw3BYpAlYNwEA6MnQHxN3Abj6TjjJttFtPjkp4r5lrg9LNSmS+ALFGzAiGaQPthx4DoAwAWXy3DWt/Ab0mRB1oK/7jAoBnT+NjWzc8jHooarBl7ZklhzczI47GZkwK5E4kBj8kNTLqGDQEA6RTfGmWxnyvb0VjiozBUSp35PZr7AVEHxaxEuKhjIIwoz7JU06crvdBuHBiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8dboIVjdD5SL6BQzjSwnmv7zSVF+d+JtiTNRbtKD7Wc=; b=GvbwFhrpYfIScL3+xUfH2b0FNYI8FDHLmXHUINnrKKW4rGHN3I9atQ6D4P+p0Ql88NOfEVVxXCJ3E3/aPUD2dh9hEH6cQBT6xC9WxJbX+steq6Z9Ah6kqmq1TTufu3Fhc2/REAAu+4xesYCuPkgvizBeEzGMLRFtjzMDLGGhzKv50EGqTOdv9mzvP292BaG9k5ICVE4TxSBxo191lteQ+lPuJDmC0MuXZQwhoQfy2OFOJwvnkzjYrnn8McG64E7VsAFEWAL6QBUSTsDozShSU4WWGQUS6ePQm6MVGd/mI7mZxA/X972wmaahTdSRE17OF+1khB0768dpsSeNSNRo7A== Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) by BL1PR19MB5964.namprd19.prod.outlook.com (2603:10b6:208:39c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Wed, 21 Sep 2022 23:09:41 +0000 Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::7d15:8282:ba93:bdb6]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::7d15:8282:ba93:bdb6%4]) with mapi id 15.20.5654.014; Wed, 21 Sep 2022 23:09:41 +0000 Message-ID: Date: Wed, 21 Sep 2022 16:09:39 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long To: devel@edk2.groups.io, kuqin12@gmail.com CC: Bob Feng , Liming Gao , Yuwei Chen , Sean Brogan References: <20220921204459.821-1-kuqin12@gmail.com> <20220921204459.821-2-kuqin12@gmail.com> From: "Sean" In-Reply-To: <20220921204459.821-2-kuqin12@gmail.com> X-TMN: [c2qYqfvGJxThjY+bM8EZxtv2aedsAmHhS2pFRkauFwPCps8dxQ0kECIHfpcGj72t] X-ClientProxiedBy: MWH0EPF00056D0E.namprd21.prod.outlook.com (2603:10b6:30f:fff2:0:1:0:12) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <799f7b8a-011a-bcef-ac91-cc4c1ab47613@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR19MB4900:EE_|BL1PR19MB5964:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e5929ad-0718-4edb-5cd0-08da9c265cb1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0aikRj/qUP2JGBJhs6Ltcvd9Rt96DmNHSyQv2OIaZHmG0EUGJWibul4cRefY2RKvbECZBdC7E9vy1Vz+606v6iqRF7j8x/KAUpGCCzMksee66jyttfEZC/ycrleM6Sh7nIaiYAQDmt5d1Ha7pi5XTOkUAs/XIVo3Pv581+XeIRqn/SfA4sl6llLPxALGhIwCPvBnxyRuazOw782IVb4AbHeHT9FfENB/x3eIxKGqcA7vSg1lXmyfEoQalb4uF9VZJXLQ6OTlRrv1a0AX7DY5nsbsXbLdBScKxZdToTDLw9Mftdosat2fsiOY46pqoPVBFKEEDXo+Q13bk6ge1wz0KpIRquwzAx4uyVYrR2vhj1YMeRPTlMgmUHS8MtnLcgVaLR7iGR6bJp8Zc7tkbxZhgneJPDtoxkMjJEjhEtLqGRfcQCo2Sa7XvnB1fabS+sphj1oDjebEGviVCeQcfyFCSZAiQP669Momw5/Eyj6fvwAQtoR8Oh9Zk9mkBuBggZnB1l1ZLW9TDpHxwcuhfamIPjimf4dpN2hsHLEfmdV8TT3fCx6+aRHZHgv/bDW0K4zveKOs0eRSuz2E4i2mmPruOVagmF24Wdo0hHZ6pl5ib8x2rMRiAdbaoYV7+T1db7z1gHvKTTOkpxis+THfs3ghGirVm4l1aQRlVQ7R+2SxZQpb3kV7oHnhuGGaMuIAXHbO X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HEU69aLt6uZNSr9PsfIY2uz2Rfkkj3kbD71IHes3lqhUXZFs89Ld3xfBpYrd?= =?us-ascii?Q?ZmWzL7UvsmBsA3BvYTzrwVUFB4gMGc3Thczgw958PvDppsVaHjKAKcBmm/KQ?= =?us-ascii?Q?AVtuImj/spu4Q+TJkeiViiLms695oN2sj2iAscX0Xr2lZo/H6XpAplNqsLR9?= =?us-ascii?Q?DZDVGuulHip0I8IQhWfTRoehLT+r6jyvhjSAe13Y57ZJV2vqxoDv7MZJBbJh?= =?us-ascii?Q?k5JP+yptgYftMuJ9jrGY0fpxb7N0ocmujqcSSaJyKHK/FXGc4yoQkIA1FEVr?= =?us-ascii?Q?JD+722eCkZr+SvgrebxIc9ptbAITSFEvI36RZjIOuXBfrDFAh7nuuVteP/NI?= =?us-ascii?Q?urumO9LC1Ec60cqgQFUVsUaGt20sUTr5a92AnyUETpIPmKSTOfYyLT7qT+gB?= =?us-ascii?Q?AJNLglx2rBlRHHKBqbbp4U2Hj76oTp8dGPzykWA9KMQ7MsMdxZWjKYxEq8tD?= =?us-ascii?Q?FQ7F7xgvqV+ZHeRyHvSQctl6PwcXf5QHJeKiHzIACf6bvPNFY03ITZekKcJW?= =?us-ascii?Q?7oh7r4ijBHuQpcBHFbiMIx6I7wHgpMgxsPyI5DZI+QVo/gFmTEcckNlJr+Df?= =?us-ascii?Q?c6VWdkvg98gzigXD71G5qkh35tspfsGI2f+uG4rz+L78IjcOKzxAQPZHM2Lx?= =?us-ascii?Q?wLyu8HI1sK1rMX0DxSehfJseMnKpwxYoTH4a9dFzBhUuXdMhNP6edbmkBTsG?= =?us-ascii?Q?JZj4DQK2aqu6y+a6T7EWv8WmCP8i2aK4mcF/9TVg/ZqeY7qOTTCb0phwh34b?= =?us-ascii?Q?VO6//GCHalqMUNsRUOo/7treq2uSYCioyLuFfBc3zHUzerMt7OQAQnHn1B6o?= =?us-ascii?Q?FcsuSJYbrCNvzq1hrVzbfhAAXdELaqOxQoirkpwU231WtdvBIhOz1LgQ48NL?= =?us-ascii?Q?vxWjUS+8KUANOSC0USmW8+uXIV4Z4kQjSMwGhS/JV3i2Y/52aw+9Ub/GzqBI?= =?us-ascii?Q?IQ6qiR2fSK/PGhP/7eDK2Vc3TvNGm00DxRZ5X1gr+mXDPMR3tpQHAOCmZkLR?= =?us-ascii?Q?vAr3E3L8x9waGkbuhpH/E8v/LPlAZx8NnniOHVqTHgbaUaumW8/NNpxwgfFw?= =?us-ascii?Q?7E+hGMJup7OOmymUX7ku8sNBKScEegyyEApojmBtLOPwrtl6lMxyDCk/J2U3?= =?us-ascii?Q?kEHbdQtZ17P1BOSW6YyMvkrguTpvx5PfD1z2EbbqNzi2FJQWSG0+IO/Af0qL?= =?us-ascii?Q?zBgx2QNLFxW2JloUfRUJm/fizwzDQIVZubKJPJvgmEbhnkYlj04q060D+/B9?= =?us-ascii?Q?u+rxSAuJ0ingBhCWEQ6cMUAIU9dB5zvmZxwztYEoJIoX4wbZZghKhqdOuvCs?= =?us-ascii?Q?23zM/JHJgRqPQmpLLZ2j7+RsdoxJDB57H2jLyV5Z2/ETug=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e5929ad-0718-4edb-5cd0-08da9c265cb1 X-MS-Exchange-CrossTenant-AuthSource: BY3PR19MB4900.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 23:09:41.1194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR19MB5964 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Reviewed-by:=C2=A0 Sean Brogan On 9/21/2022 1:44 PM, Kun Qin wrote: > From: Sean Brogan > > Current implementation of looking up toolchain will _insert_ the findings > from vsvarsall.bat to existing path and potentially stuff the variable to > exceed the length of maximal path length accepted by Windows. > > This change updated the logic to use the discovered shell varialbes to > replace the existing path, which is desirable in the specific use case. > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > > Co-authored-by: Sean Brogan > Signed-off-by: Kun Qin > --- > BaseTools/Edk2ToolsBuild.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Edk2ToolsBuild.py b/BaseTools/Edk2ToolsBuild.py > index 1ea8187de693..f862468ce275 100644 > --- a/BaseTools/Edk2ToolsBuild.py > +++ b/BaseTools/Edk2ToolsBuild.py > @@ -122,7 +122,7 @@ class Edk2ToolsBuild(BaseAbstractInvocable): > for key in vc_vars.keys(): > > logging.debug(f"Var - {key} =3D {vc_vars[key]}") > > if key.lower() =3D=3D 'path': > > - shell_env.insert_path(vc_vars[key]) > > + shell_env.set_path(vc_vars[key]) > > else: > > shell_env.set_shell_var(key, vc_vars[key]) > > =20 >