From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.92.22.96]) by mx.groups.io with SMTP id smtpd.web10.1431.1669768133690543686 for ; Tue, 29 Nov 2022 16:28:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=glwfOXrT; spf=pass (domain: outlook.com, ip: 40.92.22.96, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SGhUIq9/dGNnD+DMR49mdw/xSTYTQN73GcjukQbjxOEk1YiGPAYO5JfVqlsiU8UgsbSAvoJAUd7alFZcHs5+oNJ5vnmexAfWRTH5dyx8QFYlWKkqK4D4I+F892QAmA+ny9Z5NWWaluHilPy1fsaak5L3Be8zRfKDcUOdioCwqjAAuG58eBEE9PeBGC4eSaiX9ugGQ0GzHoylvxfnfFpzg45Yz5srmR3giqPrTl5OVn/7u02W9egdDW+l8dAEY3yrcTvag8Sfn8+SULBE+Fx1pWTxK/CwKcLhFVSy7DftOHQ2KaoY8PoMHZFNdMrs/HP6MZEVdxajNBAgne8dnuObZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a3y1142hp3VjwOfZFR1vo5UjDc/QmI8jziUfv4G83U8=; b=ntxEOesO+2H8VpX2+H5WquDZIGF1AmnG/OKGmLdNu7/B1QA/MIA2H5AtIZcaNmIpuoYNze0zR5KRJxzYRoA8krBFNdeAsMqbdbydctk3SBzQeUBa2JvgxB1cgKfrSfLn6TVL1KEZ6sZnZukP33Pc6UhrxsOuVBKA/RooCimDqxSFcijnCPbWL91rzY11GsV8jxUIXLvhKgoHP5Te2V/xr6lDPVgvS3ptN8rb9BgV4uDUta09jj5D+O4KN0lRAlnWa5mLm95K1FKPBaClX64C0sJlX2mAGn31JCR+h24hSuIhChA87TZq368FFv33Yd7GZvFAlRLS4Nm9qlpCHCPy+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a3y1142hp3VjwOfZFR1vo5UjDc/QmI8jziUfv4G83U8=; b=glwfOXrTONmEvG+a7AAJwERkqwBFCJxi+k28sDYZHUgRRNfnS2kSp/OE7ePRpUwjnc20PrpXxTx1L+mMdb6lUkU0RGVGGRK9a4uGXRLKr1a4Cy/yfkTX1cpgSVqgefCcr1i/NEM6Ee4dqYcgfcr2ppFE5tSXEFKOUuSmHIR2vCjynp7mDBUADVr1AO8cOphrnTimYfjkHW6jYKg3zCwAMLKaQakXHuAA+rshRR7gKnLSgs1pucvX5S7JAjMz+faGtXFAlfeGs/eRM83RRTc5eQ4sQgV2qFWCbtvKaiSBgcL3Tl7I/cqWTNORmq3yZF296O8uo+QFnYyq/VBpRnIyDQ== Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) by SJ0PR19MB5464.namprd19.prod.outlook.com (2603:10b6:a03:3d5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Wed, 30 Nov 2022 00:28:49 +0000 Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::bd24:dbff:ccbc:aba]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::bd24:dbff:ccbc:aba%9]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 00:28:49 +0000 Message-ID: Date: Tue, 29 Nov 2022 16:28:45 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [edk2-devel] [PATCH v7 0/6] CI: Use Fedora 35 container for Linux jobs To: devel@edk2.groups.io, osteffen@redhat.com Cc: Abner Chang , Alexei Fedorov , Andrew Fish , Anthony Perard , Ard Biesheuvel , Bob Feng , Brijesh Singh , Chasel Chiu , Daniel Schaefer , Erdem Aktas , Eric Dong , Gerd Hoffmann , Gua Guo , Guo Dong , Guomin Jiang , Hao A Wu , Igor Kulchytskyy , James Bottomley , James Lu , Jian J Wang , Jiaxin Wu , Jiewen Yao , Jordan Justen , Julien Grall , Leif Lindholm , Liming Gao , Maciej Rabeda , Michael D Kinney , Michael Kubacki , Min Xu , Nate DeSimone , Nickle Wang , Peter Grehan , Pierre Gondois , Rahul Kumar , Ray Ni , Rebecca Cran , Sami Mujawar , Sean Brogan , Sean Rhodes , Sebastien Boeuf , Siyuan Fu , Star Zeng , Sunil V L , Supreeth Venkatesh , Tom Lendacky , Wei6 Xu , Xiaoyu Lu , Yuwei Chen , Zhichao Gao , Zhiguang Liu , Pawel Polawski , Chris Fernald , Ard Biesheuvel , Chris Fernald References: From: "Sean" In-Reply-To: X-TMN: [KGlK5O1z7wxzw1IUXyjpWrLVMjUahci/gNgx6AV2aGbxy9MRWCV3ssgmDH+7P/x8] X-ClientProxiedBy: SJ0P220CA0022.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::33) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR19MB4900:EE_|SJ0PR19MB5464:EE_ X-MS-Office365-Filtering-Correlation-Id: 9da25bf6-6625-44c6-0a05-08dad269d8c2 X-MS-Exchange-SLBlob-MailProps: wk1EIbWONa1qUo9LnJAtucBRoU/EHFXS7BsTjPpfgh9n3qrBPdEeoQgakBqrU08pXboWQLTilyBoe4FPlQ4qHkxWrtPPg8RTseB/50qktJvylfYz9YfuFQBSjnGSTyKdkaDQ2E6msAbV7/iq4JAZq53GOq/riUPFBGqj6fqZmdJZl3EOJKcaxvPMIHvMcceIr/afGhM+vy4hbiyyMsOjFbPww4mtcVoSO1CiKMkG+gug/UTkhbLoMYe1za05a77EEIyMmwkIxlFBKBdwSf/pW8rdl7xBJ2lkjEyyoKuJ9uxaurpUDLtx88pou3Z/GPbpbr7jDrkvilbj+qjKVrK8zS2jDiaMliSLDV2TfLqaAgSPvCmA+dhaXoZviJRpWkCa9XJ8CC7pQT+50TtmzlX/Jnnci8jS17w+DNd8uctCfl80SzksfTN4K5GiVCUIp0J2yPYJeHr1HlNmb0oDIjzQoBUOFdKqbYZK+vfDeRV0Ne/5Qoj8shEZsXfTkKBdKEbG/r3myFSW1UJkAj/oUrM8pCknlbZ5ddp0+WggNIvoC6DvoM7IHeuu1/JK71RNL8k1l2LYVqamTPuYZmn9IxMQKfHLG7z5ekriYX6/MKwNzGARSnNoKVXwEk7f1xLbAkZ5/ds59tm+ZyGtQzf4B4kSAaj8OARrKo25bqwQcrj3TCIuY2efWtarh/HV5ByRgxrpEu74+F4yvK4btXjBSfCXGGJjH0zhfQLrLg22fSHc13gcTRsxL+GiJg== X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QNwMD4/NzdfHJ1zfzfH0RIdCnY2QctTyOj0+z3OHv63d3dTIwbZn5AfcRVcloNcjlJ2oINTf+b1I0gTTQZ7KpbusCcl+JJntz11iDjUt882mYknO0zRj97x2Bz2ex/gwXPnmG6uLLQE1D3ER+wcossLReUo+b85KoaQYGcHdlMbN+dmxDyTcUBgrD8N43Z6juDMsHRlKct/wW8vTeMX3HLRnN516NhH5/NrrKZy1Klqx2Hf+pa6UhEEY5SvCew+FIqNDIRg6dEgwmANC7PsbVl0hU4c2C3hvx/d+GpRbNutjRKS9fbC9/9OQv1rUq5cF8ZKgMqi72MbumxcUj0hKUmkHBMeITbaJ1qz9FNAJ7loHp1TD0/Z74M9jEd8yRmmx46YC1toqKIfdfNwAMhsRm5D2P+q5vUcLNumiKjX4++uD3EyKIhMAxrCquxeAqgN49UpIgDfyRUKBVD7Bswh/mYVgnTR/F+/emnifBgzF3ujLtQXK+hQIRFUSb/J9HhSNAm7zKgChWRq/RcawWVkmDlMXhvANC3BEvPklCW76rLzs9/xtgCwQ8yzl9moK1zx+SUyKv0jBlUmkftVk9Wf45opzGKESG0EuyM0YV8BkL2KWpcaXizIyUmMhG8HWQ6GrYyTmbN+Wn38Ktb6jDscLyeakuD1Hf8cNhtAK9PDNmF8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T25OWllDQVRhbXJxNEN5SVluV21XNzZvV2ltRFhDOGgwd2Y5SFJJVGF4cEJ2?= =?utf-8?B?Uk1WdFdiclJjYndvMFVlZHN6SXgrSGM2RzFhNVZyK1RtSWU2aFNKQXBzOTFy?= =?utf-8?B?MGdzYjh3S2grd21UYlVMZFh3NzBZc0loMzlldWo2d0VQdkhqVW9iWVRYRTVy?= =?utf-8?B?WllFUjBsZlFRVWlWWFB2R3dRSGhOUzVaMlFZTnF5bHA4MndKeFZjQkZZV2xv?= =?utf-8?B?a0NoRkw0ODZEak5icmx2eDNuSWNGaWloaitoeGV1azEzZC9SU3hVRmZLZWYr?= =?utf-8?B?Yy9GSHpZV1pWMlhEWjVZYXAzbVM1enhtcUFRZWU2VG4rWjhET0JQWi9PRjhJ?= =?utf-8?B?dHNpbWVTTlZNN1drYXk1dlhlYVhJZGU3VVNMWDVZSFpvK1B1RU84bkVUVjRI?= =?utf-8?B?Vm8vN2VqdEFFanhnYXo3L3Z2RkpiNlVldklXUHdNQUFiZ25FaUc3Q0ptcmUw?= =?utf-8?B?SFB6MFArUUNocER4b0JGQW9QRnVUREVXOUNxZXQwZW5QampGNzZCc2ZpZjdi?= =?utf-8?B?MW5SeXVsVmZ0TFJOTDdhNXpxVUZQUVljT05zQkQ3WWZudGUxVjd0cDF2K3Bh?= =?utf-8?B?RmMwNGlLaUovSFNOWHBNMi8zNTVhdk5tRGV0c2dxMmhsY2x0eGhpdUVEbnVB?= =?utf-8?B?N0sxSDR1eUhSbTFIM2ZieVIrOFdZeGJYRVRDUTQrZ0JTck8zRmVoVExoaGF6?= =?utf-8?B?WGY0bXEyWHEwMkR0Y1JCbTk0bnRwU2s5bVkzcDl5bGE5T1UwRzBtYkkyNmQw?= =?utf-8?B?MUhVaTFHdjRrMmR2bmNWenBQZWJkRnJWeGtHUVMrQVBFQ0ExUzB0MW14ZW00?= =?utf-8?B?cWhjSCtrQXdBb3l3ZXhWNjhMNlRPcUJCTWxEMlZVa3puNXo2U2t3dVFNbENj?= =?utf-8?B?NnVUS3pHWEtxd1Q3VDE3VEJYb1lhbUxTVGhUOUxkMllWZEZsMWJRMjdSbmYx?= =?utf-8?B?dW5NMmljQ1JrZEJ1VGhnSm5hTmdPUSt1Y2kraXE0aEZ2bjN1QVRWeUNuWFNO?= =?utf-8?B?M21tY3gvaml3aTdxTGdMUDR1WmtrUlpNNjlxSDI0WExDS2toRkNob1drUkFK?= =?utf-8?B?YjZ1R2RCN3hOQy8xdDBVQ0pWejZhR1Y2TjNYck05TXh4R01Kd3AydXNwb1E0?= =?utf-8?B?SllBSHBjQmExSGVvQ1BxMlhoNnhWdUNxa0RKblp1Qk5ubGgzbFpxbDNReHpl?= =?utf-8?B?WmRiMDJOa1RDYkNxbUZWbW1BMVhSU1pNc3JyblFLRDBBTjV6Q2NFTHVEOWIz?= =?utf-8?B?WVQ0R0tlWlN1cjA2Ym5zRmo0aEhkOXJRMkpTTGFZS2lkTFhZTTl5VXVUYWht?= =?utf-8?B?SkYxRHBIM00yNDBPT0ViUUk0d3BLWXIyUUhicW03R3BYbGV3RUs5bGV1U1Nw?= =?utf-8?B?ZE5OMm9HblJUV01Td3Q5aFBJeC92Z3lBRnlVdEUzdnA0eTJyYjBnaTZTZTEx?= =?utf-8?B?TVpyL0V3NW9NYUxRNzlFbGtTODhLeHhkc2ppSEFzVUM5VTkxaGFYcThqMm96?= =?utf-8?B?c1JuSDA5ZitUNytpdURZQjN1dGpjM0Z3SnczK0VybXhySzBnOHdGU1BHRzZ2?= =?utf-8?B?R1lxS3hYVUU0TmkyYkdjSmgxRVhWYmZ1bzJLRXBQdURCWElPdkhHL0dHVzhN?= =?utf-8?B?VDlZci8xOHdKK1NuWDRtN2dSWW03QjNSNlA3MWZVMkJqcUxkRFBYNWVRNjNZ?= =?utf-8?B?ZFNhRzd6RUYyMWxMV1dndFR4d1QvUk9MaCt5d1RYMHZNeG9ydEhXVEJtb0ps?= =?utf-8?B?VzFDZVdtQjlMSVBmMmUwc0lYak5sTzIvTVFpSEluZ1hHM09ySFlicm5KUTYy?= =?utf-8?B?eXRkKzY0Z0pQdml6YnBjUT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9da25bf6-6625-44c6-0a05-08dad269d8c2 X-MS-Exchange-CrossTenant-AuthSource: BY3PR19MB4900.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 00:28:49.7193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR19MB5464 Content-Type: multipart/alternative; boundary="------------MfZRhTuouTEuajp24Ahkb861" Content-Language: en-US --------------MfZRhTuouTEuajp24Ahkb861 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Oliver, Thanks for this changeset and i think this is getting closer but over the past few months there have been a few changes that I don't think this series takes into account. A few comments i hope we can address quickly (since 18.04 is going offline tomorrow). 1. Can the whole block at https://github.com/tianocore/edk2/blob/dd3ba82d31a6d3cc4564dc83c9229e13773b55da/.pytool/CISettings.py#L172 be removed.  The only reason these exist is to pick up and download the compilers. 2. what about supporting the loongarch64 compiler? Can we add to container? 3. If loongarch64 is included in container should you delete this file too: edk2/gcc_loongarch64_unknown_linux_ext_dep.yaml at master · tianocore/edk2 (github.com) 4.  Patch 4 has changes in multiple packages.  I believe it is a requirement in edk2 to only change a single package per commit. It makes reviews and cherry-picking/bisection easier. 5. Since only Core CI as controlled by  file .azurepipelines/Ubuntu_GCC5.yml why not use the base container instead of test container?  The Core CI Process will not use qemu.  The platform Ci files have their own yml with container specifier. 6. what about removing the steps for installing node and cspell from the container build?  Since these are managed in the container they should be skipped. Thanks Sean On 11/29/2022 11:26 AM, Oliver Steffen wrote: > -18.04 vm_image since this will no longer be available > after Dec 1st. Use ubuntu-latest instead. --------------MfZRhTuouTEuajp24Ahkb861 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Oliver,

Thanks for this changeset and i think this is getting closer but over the past few months there have been a few changes that I don't think this series takes into account. 

A few comments i hope we can address quickly (since 18.04 is going offline tomorrow).

1. Can the whole block at https://github.com/tianocore/edk2/blob/dd3ba82d31a6d3cc4564dc83c9229e13773b55da/.pytool/CISettings.py#L172 be removed.  The only reason these exist is to pick up and download the compilers. 

2. what about supporting the loongarch64 compiler? Can we add to container?

3. If loongarch64 is included in container should you delete this file too: edk2/gcc_loongarch64_unknown_linux_ext_dep.yaml at master · tianocore/edk2 (github.com)

4.  Patch 4 has changes in multiple packages.  I believe it is a requirement in edk2 to only change a single package per commit.  It makes reviews and cherry-picking/bisection easier. 

5. Since only Core CI as controlled by  file .azurepipelines/Ubuntu_GCC5.yml why not use the base container instead of test container?  The Core CI Process will not use qemu.  The platform Ci files have their own yml with container specifier. 

6. what about removing the steps for installing node and cspell from the container build?  Since these are managed in the container they should be skipped. 


Thanks

Sean



On 11/29/2022 11:26 AM, Oliver Steffen wrote:
-18.04 vm_image since this will no longer be available
  after Dec 1st.  Use ubuntu-latest instead.
--------------MfZRhTuouTEuajp24Ahkb861--