From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.92.22.65]) by mx.groups.io with SMTP id smtpd.web09.11476.1623772793338181612 for ; Tue, 15 Jun 2021 08:59:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=seUuBAt0; spf=pass (domain: outlook.com, ip: 40.92.22.65, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oVyTKzpErCDX0n6Qr/M5Tn6sC7LT6m5idevvjgpRYvte0BDMIYuiD9NzVcKLUqUWxWecWCz46RHSb0g0u8bxnBPvNgAeEJ9QAjX6l2t9jh47du13C+sURX2mUeTYpq2N9xlYZ6ccy0HeUluV+cbAwOkNzhVPRRIlLUkVXnycx7zpUVeegeZXdWfBv2y6tAvIuS42Omf0gOxr7jzmL1SQoOh0LdcUsvjG8OCFKcPyl0HZN+ZaStBUpoZkb8SSGe2Wz+/D4CT+UP67bp7eAlkT18RRQyP4Dko+/iYZVNW/pSw79Pdco4HzWZdd8gOraypqimZTBpYj36z7v61qi24Afw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T5K4CVBHMI5ebswd5p7EgPGLMbDSIaUgd54oeG7ZO60=; b=I9nGhygFm9wQ3fY7AcI4W0RMJOOJIs/f9Kjvz8MtUkfp5ADrs7aStYO6ojJgL3swGPB+hjaLImdkWWk4Vy7URPccC0FRcs3Eht1ERUn31uD6IaiwwvHXfKIrL676ZnTDd3TdT8hK4xtMELZLAd5166wRUANV9uN7/GhX1bu6fAX06yCgHZY2OrZFLS6WRCtApBL3kaSd1LzfYSLXSrPJiMnilyWgCihvIxi0rGAPrefhujL2BhFQDDMGNrV5xkMSmuzd1Sc1fPZ2ZwOCdS1UxFtRLsRD+7lCWwTpnVoI/42clFVUycd0OKyju0phwSRk8v9bKu84miUJ8boql9/sCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T5K4CVBHMI5ebswd5p7EgPGLMbDSIaUgd54oeG7ZO60=; b=seUuBAt05rH/XX9GXjM6Cr4oXIoFVBd5vlf38LIEgvYpKdvePgDGewfjK1nMnYWPhc3fLPpG8Ryhfgrq3S2aogEZy13+E7P987k2r3kM2o4f7l7V+vFshlu50icsKbOV7D/kxxeSZkUYgNhR04NvmlDXUizEJ9Gl8Qbzot6GUNXYs9Nok7hPCYnNmQt9qBGqzaClHUS0FEo75XnSPF1od5dVKwEFM4oElUVfeePkPwQfh7Y72AQG4wclEFiDq7kx3D9x9STAyX91UOXCXVdIMXEMwvEdtGZt2hRiGOiAwzaqmIho3/plE7Z2gZEktK5J7n/NPjbJ7FoUOxwp3YJMMg== Received: from DM6NAM12FT003.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::49) by DM6NAM12HT018.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.9; Tue, 15 Jun 2021 15:59:51 +0000 Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2a01:111:e400:fc64::49) by DM6NAM12FT003.mail.protection.outlook.com (2a01:111:e400:fc64::340) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.9 via Frontend Transport; Tue, 15 Jun 2021 15:59:51 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:8900280776680EAFF21D7C6D6F610246126B8EC4D176FCD771CC38DDBB7CE724;UpperCasedChecksum:023E4C385AF1CEACEE757E64D18FCCA344D30B9BA411F14666994F6973F8F887;SizeAsReceived:8883;Count:48 Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::99cc:b318:2817:77ab]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::99cc:b318:2817:77ab%7]) with mapi id 15.20.4242.016; Tue, 15 Jun 2021 15:59:51 +0000 Subject: Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters To: devel@edk2.groups.io, kuqin12@gmail.com Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao References: <20210612050431.660-1-kuqin12@gmail.com> <20210612050431.660-2-kuqin12@gmail.com> From: "Sean" Message-ID: Date: Tue, 15 Jun 2021 08:59:49 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210612050431.660-2-kuqin12@gmail.com> X-TMN: [s76A3O4TnOsquiy3vrNlTq/Eg/fW9Gza] X-ClientProxiedBy: MW4PR03CA0197.namprd03.prod.outlook.com (2603:10b6:303:b8::22) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <48461638-e038-5f52-16c6-6fdd8be3bce4@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MW4PR03CA0197.namprd03.prod.outlook.com (2603:10b6:303:b8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Tue, 15 Jun 2021 15:59:51 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 15863a76-69e4-448f-a4c4-08d930169bfa X-MS-TrafficTypeDiagnostic: DM6NAM12HT018: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i7t3aM1n/1iXmf4J3HqzxQlI6TvZh7wIfs5komTg4fZuIWZzalvEXysQeVFVeHOb9P2Sxds8EscMABCj3t4uMegXoiaZzuCB+kPQUnZr89N2IOtJ8HM0KVEo3Qxb8yJRWF2t9ofdykHqSwvFX7cMge5kOU92T9ELEsoU5DQ+i1H4nKq7a8Ycp3W88v4NsmO/RdtBT5En+UMKAg2fBz73oI962bwM5qXSjI7FfcdyLJ4emdny0rD7Wt0xQHunWGPvGzvSuwxBMMcd+QeRqrxbdQB4Ka7lP9NhyZfIfs0pLcaNubGsGwSsFiaY6tTnzBF9r0HIz++dwUIsR4+83ProaZuJlvMZzLKUOrb5Le0hMrLglrA24rwESOSnre/hnYXLNpac+tZ8xdE0dfa5P+FYO6A1TLbzBz5wXru30pZFTE+S/SGX6pJRjqqqeKGg3S96kJBD6aLqi9DGJLsC4ykRRWwS0oQwIyx1FuZb0+Eg1L0= X-MS-Exchange-AntiSpam-MessageData: 2xf9GgGBrTK/+YufCuWisYlzkun0oo0jHqmEabkZpEworQ6PXcKXOlLwox0rLuI5gWxq+SHOEph6k0vp1o6qwrJj7TDYfomTzd9NdDCQALSCaV0q8YhrUr97r6K0uLraYfhlA6fJQHsyS1khh7ryKw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15863a76-69e4-448f-a4c4-08d930169bfa X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2021 15:59:51.7209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DM6NAM12FT003.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM12HT018 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Please update the signed-off-by to include yours. Reviewed-by: Sean Brogan Thanks Sean On 6/11/2021 10:04 PM, Kun Qin wrote: > From: Sean Brogan > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 > > On Linux the shell expands the wildcard paths and causes multiple files > to be missed. This change adds additional quotes to defer expansion in > order to bring parity in cspell result. > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > > Signed-off-by: Sean Brogan > --- > .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py b/.pytool/Plugin/SpellCheck/SpellCheck.py > index 43365441b91c..97b240ef747c 100644 > --- a/.pytool/Plugin/SpellCheck/SpellCheck.py > +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py > @@ -133,7 +133,8 @@ class SpellCheck(ICiBuildPlugin): > # > relpath = os.path.relpath(abs_pkg_path) > cpsell_paths = " ".join( > - [f"{relpath}/**/{x}" for x in package_relative_paths_to_spell_check]) > + # Double quote each path to defer expansion to cspell parameters > + [f'"{relpath}/**/{x}"' for x in package_relative_paths_to_spell_check]) > > # Make the config file > config_file_path = os.path.join( >