From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.92.22.61]) by mx.groups.io with SMTP id smtpd.web11.652.1623970385825227633 for ; Thu, 17 Jun 2021 15:53:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=pxy4lgXt; spf=pass (domain: outlook.com, ip: 40.92.22.61, mailfrom: spbrogan@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PtLqEtpiBE//8x6OSZiulZ2ZjZHqYI44PtIgaRZ/N8yh7x2xEiAmRMbcMgAA5DFCDG9fiJrmHdB8SXCdCSzL2o7rDFC/KncI1KA4zsYsiFDnefiYGeyO/t3Pc/VeXhU2cRJxjdUQ/oebBEtDrzejL+UE9ZxhK+DPU2KFq+64XbnqESQfeO/mQ+MqocH9VSBXVkQCZz6iV936YQ7pt/D3LMWpSFMTE1P+mM82r0HcsjucASQj7Y4Uq10qJLNJLnLKblg1oLt5DdNutVBlad3SW54auDCJTGE7Ypn6uA3lD5rmcCnWhRPJVe8jKtfeTYTgUiXAoASLMf1ChDM1w0a6YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yqUFO5NDPRM/xOE5ocS3b+1b6Bb0In5XXg5svI+TbJQ=; b=nwtLtxk76EWOmfxMP/zrrahXf2hc4iMtZNmdDQYJ8ApW25XD+h2qSmTjg6rXNb5fWKyC6WK5oytitlnzdAG0diF3XcRHhrFHtEb3wVjSWGErYVwtROK1MrZEgBd3NXo43UQPDesWMbrnOTBNG+CtsyrEaEh+Gu3J6t+3esAeexkcsfCyA5elijTyU5Kw6KC09TNt0w8qQVQfy7s0L6ZurKmyP5K/tn8jy2XeZoAi6NLiZz+Xl6gE56SWQjcaZL46AfTa8ItcTZAsuPesnH3bQwW9y9W5uhw6TxHhc9bDZqsGeLTH8dD0O8i7S+tsT0hAgdvOfrJi62s2C5Xsi3IPog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yqUFO5NDPRM/xOE5ocS3b+1b6Bb0In5XXg5svI+TbJQ=; b=pxy4lgXtin6cngfOUgzT0SVe/vgPYoYNTGZ/YS0P+9F6I7MoXgOqvERuMCOdqRkIJ3Wt1BDL2/rGocRLseTRqRL2vIwtp6qKJKzX8uRwvoYn9KLQGuHqxqLimcftXLmOLgwM2BkX0FpAeYWrvZxoD7Jc34pABvmRghKuJ9srh+grwIt0Eb4oYqljU+/I4/c1DY6SSeTGESQDL0e2Fx5f7y+WpArMhz8AAHhxcd7GK2z/RezEY6P43f1sWe7Dr1NafymZb7fOsjLo/tnOH+cTHuHG8XpCQCHvSxwoz+XKo0CdDShkDupW0TUPxzlJeev6TyExAocp8IIhDS8BF3Y2PQ== Received: from BN8NAM12FT018.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::43) by BN8NAM12HT067.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc66::200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.10; Thu, 17 Jun 2021 22:53:04 +0000 Received: from BY3PR19MB4900.namprd19.prod.outlook.com (2a01:111:e400:fc66::4b) by BN8NAM12FT018.mail.protection.outlook.com (2a01:111:e400:fc66::347) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.10 via Frontend Transport; Thu, 17 Jun 2021 22:53:04 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:AE10DEDA024763F17955C2A7BA1AAED8150372B65FED33A00E7FE5BB051194C9;UpperCasedChecksum:7E75549B2BC5EEF97A301167E23976E84F1C59E6141BD7185938E20B71602760;SizeAsReceived:8929;Count:48 Received: from BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::99cc:b318:2817:77ab]) by BY3PR19MB4900.namprd19.prod.outlook.com ([fe80::99cc:b318:2817:77ab%7]) with mapi id 15.20.4242.021; Thu, 17 Jun 2021 22:53:04 +0000 Subject: Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x To: devel@edk2.groups.io, kuqin12@gmail.com Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Ard Biesheuvel References: <20210614183431.1657-1-kuqin12@gmail.com> <20210614183431.1657-5-kuqin12@gmail.com> From: "Sean" Message-ID: Date: Thu, 17 Jun 2021 15:53:01 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210614183431.1657-5-kuqin12@gmail.com> X-TMN: [6Kzbgt05pB+YgyIVjgxjDvRLXNrmbpVQ] X-ClientProxiedBy: MWHPR17CA0088.namprd17.prod.outlook.com (2603:10b6:300:c2::26) To BY3PR19MB4900.namprd19.prod.outlook.com (2603:10b6:a03:354::11) Return-Path: spbrogan@outlook.com X-Microsoft-Original-Message-ID: <1a3cb408-f718-eecd-b01e-b5561fb8aab8@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.78] (50.47.113.221) by MWHPR17CA0088.namprd17.prod.outlook.com (2603:10b6:300:c2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.19 via Frontend Transport; Thu, 17 Jun 2021 22:53:03 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 21f0e8c9-541e-4090-2283-08d931e2aa24 X-MS-TrafficTypeDiagnostic: BN8NAM12HT067: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GjYiDsssAPvyCDq9GozyteMnC+h2TeYUD9/jFsz5ZR/WTQ9cqWobm3EnlacHQcqPJWMnW1MjrTIMHLuJMC06eE4J1RFWZOkNOvsan8LPD1SfDGrRtzhsPjV9GkggWnTjhGDPrduv7yp7A8LJFVKcW4EpsxkyeU4bJRBX6+VhqIOjSUxs3aC5rlAexkwd6tKXT87oezrCvP6Rrb7ZzKana2XY63j7/wLhkOI9s2YbMm9m9rTW+nky+zOiqUt+5SVuDQpOtvfq3qathdY0i0aK7yVMPt2l30SRG7Lasn9OfrJYdZ+rExluOTqWzP+R15pSEy7LGHGfKquo9EE0AqgCe2gjPubqBaeAYN2p55ubVfynO1beQx0eanprBGTn32lqwFUZMd3UFK5eTiRMcS/56EQnweSBuX+vRp+VEGlj75TxEXVwr2mEGlHqfHddsVL1j9jQ32IEMd/T2Rt3IwGryQD9ud8nVQ1P6wfgqwZbNyM= X-MS-Exchange-AntiSpam-MessageData: fJn97hrnNVdPJj3l+aNgPmB+r+ei7b7CxD9kLxCt+ANdrxYGQ7f4Bp56TgyCjdVTsWCWUKTvmnkRkZphFQIJ7Vhew70ZOa1hLZJRNbmScN7RYytpYt/Cuu4ooiQ2/dJWvn5fo6kRsQyNRQp3QTtzsg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21f0e8c9-541e-4090-2283-08d931e2aa24 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2021 22:53:04.0652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT018.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM12HT067 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Thanks Reviewed-by: Sean Brogan On 6/14/2021 11:34 AM, Kun Qin wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 > > Per update from Cspell tool, the minimal requirement of Cspell 5.x > regarding Node is 12 and above. This has caused multple Cspell failures > during CI build validation: > "Failed to process "**.c" TypeError: text.matchAll(...) is not a function > or its return value is not iterable" > > This change updates the lowest required node version to 14.x to support > Cspell functionalities. > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > > Signed-off-by: Kun Qin > Reviewed-by: Ard Biesheuvel > --- > > Notes: > v2: > - Added reviewed-by tag [Ard] > > .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml b/.azurepipelines/templates/spell-check-prereq-steps.yml > index e1570d4f2aac..98ee3cfa6bc6 100644 > --- a/.azurepipelines/templates/spell-check-prereq-steps.yml > +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml > @@ -13,7 +13,7 @@ parameters: > steps: > - task: NodeTool@0 > inputs: > - versionSpec: '10.x' > + versionSpec: '14.x' > #checkLatest: false # Optional > condition: and(gt(variables.pkg_count, 0), succeeded()) > >