public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Saloni Kasbekar" <saloni.kasbekar@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"sivaramann@ami.com" <sivaramann@ami.com>,
	"Clark-williams, Zachary" <zachary.clark-williams@intel.com>
Cc: "Natalya Kalistratova" <NatalyaK@ami.com>,
	"Dhanaraj V" <vdhanaraj@ami.com>,
	"Santhosh Kumar V" <santhoshkumarv@ami.com>,
	"GengYou Zhou (周庚佑)" <GengYouZhou@ami.com>
Subject: Re: [edk2-devel] Clarification on LoadFile2 Protocol Installation for Network Boot Devices
Date: Mon, 18 Dec 2023 20:10:58 +0000	[thread overview]
Message-ID: <BY5PR11MB38613EC3037CFE08A2723B4AF190A@BY5PR11MB3861.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BN0PR10MB498143DD2635E546DC88AF38C293A@BN0PR10MB4981.namprd10.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 3954 bytes --]

Hi Siva,

“The EFI_LOAD_FILE2_PROTOCOL is a simple protocol used to obtain files from arbitrary devices that are not boot
options”
“The EFI_LOAD_FILE_PROTOCOL is used for devices that do not directly support file systems. Network devices
commonly boot in this model where the image is materialized without the need of a file system.”

Based on the above statements, I believe the Network stack is fine using the current EFI_LOAD_FILE_PROTOCOL and not the EFI_LOAD_FILE2_PROTOCOL as they are currently loaded as boot options. We currently do install the EFI_LOAD_FILE_PROTOCOL within the Network stack. Eg -
  //
  // Create a child handle for the HTTP boot and install DevPath and Load file protocol on it.
  //
  CopyMem (&Private->Ip6Nic->LoadFile, &gHttpBootDxeLoadFile, sizeof (Private->LoadFile));
  Status = gBS->InstallMultipleProtocolInterfaces (
                  &Private->Ip6Nic->Controller,
                  &gEfiLoadFileProtocolGuid,
                  &Private->Ip6Nic->LoadFile,
                  &gEfiDevicePathProtocolGuid,
                  Private->Ip6Nic->DevicePath,
                  NULL
                  );

Maybe we need to update #18 to include Network devices?

Thanks,
Saloni

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sivaraman Nainar via groups.io
Sent: Friday, December 15, 2023 3:29 AM
To: devel@edk2.groups.io; Clark-williams, Zachary <zachary.clark-williams@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>
Cc: Natalya Kalistratova <NatalyaK@ami.com>; Dhanaraj V <vdhanaraj@ami.com>; Santhosh Kumar V <santhoshkumarv@ami.com>; GengYou Zhou (周庚佑) <GengYouZhou@ami.com>
Subject: [edk2-devel] reg: Clarification on LoadFile2 Protocol Installation for Network Boot Devices

Hello ZClarkWilliams:

Could you please help to clarify if NetworkStack MUST install the LoadFile2 Protocol or not. With reference to the below spec item, the LoadFile2 protocol must be implemented.

In one of the BIOS environment, the Setup Browser Locates the LoadFile2 instance of Network Boot Device and it not found as it not installed by the current NetworkPkg.

Can you please comment if there is any reason behind not installing during the HTTP Boot.
“UEFI SPEC
2.6.3 Driver-Specific Elements There are a number of UEFI elements that can be added or removed depending on the features that a specific driver requires. Drivers can be implemented by platform firmware developers to support buses and devices in a specific platform. Drivers can also be implemented by add-in card vendors for devices that might be integrated into the platform hardware or added to a platform through an expansion slot. The following list includes possible driver features, and the UEFI elements that are required for each feature type:

  1.  If a driver is written for a boot device that is not a block-oriented device, a file system-based device, or a console device, then the EFI_LOAD_FILE2_PROTOCOL must be implemented.
“

Thanks
Siva
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112652): https://edk2.groups.io/g/devel/message/112652
Mute This Topic: https://groups.io/mt/103249982/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 14235 bytes --]

  reply	other threads:[~2023-12-18 20:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BN0PR10MB498176AAFCA5BE15AB416E81C293A@BN0PR10MB4981.namprd10.prod.outlook.com>
2023-12-15 11:29 ` [edk2-devel] reg: Clarification on LoadFile2 Protocol Installation for Network Boot Devices Sivaraman Nainar via groups.io
2023-12-18 20:10   ` Saloni Kasbekar [this message]
2023-12-19  6:54     ` [edk2-devel] " Sivaraman Nainar via groups.io
2023-12-20  3:45       ` Saloni Kasbekar
2023-12-20 22:33         ` Natalya Kalistratova via groups.io
2023-12-21  3:51           ` Sivaraman Nainar via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR11MB38613EC3037CFE08A2723B4AF190A@BY5PR11MB3861.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox