Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP

["Saloni Kasbekar" <saloni.kasbekar@intel.com>]

Mike,

Would you be able to help us merge the patch?

Thanks,
Saloni

-----Original Message-----
From: Luo, Heng <heng.luo@intel.com> 
Sent: Thursday, December 14, 2023 3:20 AM
To: Clark-williams, Zachary <zachary.clark-williams@intel.com>; Kasbekar, Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io
Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP

Hi Saloni,
Could you help to merge the patch?

Thanks,
Heng

> -----Original Message-----
> From: Luo, Heng
> Sent: Monday, December 11, 2023 4:13 PM
> To: Clark-williams, Zachary <Zachary.Clark-williams@intel.com>; 
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; devel@edk2.groups.io
> Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not 
> connect to AP
> 
> Hi Zack,
> Could you please review the change?
> Thanks,
> Heng
> 
> > -----Original Message-----
> > From: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> > Sent: Saturday, December 2, 2023 5:25 AM
> > To: Luo, Heng <heng.luo@intel.com>; devel@edk2.groups.io
> > Cc: Clark-williams, Zachary <zachary.clark-williams@intel.com>
> > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if 
> > not connect to AP
> >
> > Reviewed-by: Kasbekar, Saloni <saloni.kasbekar@intel.com>
> >
> > Thanks,
> > Saloni
> >
> > -----Original Message-----
> > From: Luo, Heng <heng.luo@intel.com>
> > Sent: Monday, November 27, 2023 7:07 PM
> > To: devel@edk2.groups.io
> > Cc: Kasbekar, Saloni <saloni.kasbekar@intel.com>; Clark-williams, 
> > Zachary <zachary.clark-williams@intel.com>
> > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not 
> > connect to AP
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605
> >
> > When UEFI Wi-Fi is in BSS connected state, the platform is 
> > considered as a static and Wi-Fi roaming support is not needed.
> > Wifi connection manager should not initiate Scan requests in this 
> > state affect BSS client connectivity and must be avoided.
> > Triger regularly scan only if not connect to AP.
> >
> > Signed-off-by: Heng Luo <heng.luo@intel.com>
> > Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> > Cc: Zachary Clark-williams <zachary.clark-williams@intel.com>
> > ---
> >  NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++-
> -
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > index d1182e52bd..4c5460b65c 100644
> > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c
> > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick (
> >    }    Nic->ScanTickTime++;-  if (((Nic->ScanTickTime >
> > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&-      (Nic-
> > >ScanState == WifiMgrScanFinished))+  if ((((Nic->ScanTickTime >
> > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=
> WifiMgrConnectedToAp))
> > ||+       Nic->OneTimeScanRequest) && (Nic->ScanState ==
> > WifiMgrScanFinished))   {     Nic->OneTimeScanRequest = FALSE;     Nic-
> > >ScanTickTime       = 0;--
> > 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112548): https://edk2.groups.io/g/devel/message/112548
Mute This Topic: https://groups.io/mt/102844565/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-