From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ED7B3941BE1 for ; Thu, 14 Dec 2023 20:36:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=z6EyMKL8XopZxQqObHvMOMmQjAhlz47ejrOWVmx9wBI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702586182; v=1; b=SdW31bkeMq8fLz9jJzhCMPlvvKLgCSzSW5FFVUQh2N9IAnLGFIW3Gn6zwluU/w7rj4e9CoyV dUqH4KWW8AZUJYqIKVb5SFBfcL9WPeTJz0VVQpzeq32jXNFpb1+GgQAG7oXqvTmugTLNxapgyRV 68NDY55HQel1pSFFsT2U2kuM= X-Received: by 127.0.0.2 with SMTP id LqL5YY7687511xp9oWIGJlVN; Thu, 14 Dec 2023 12:36:22 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mx.groups.io with SMTP id smtpd.web10.39254.1702586181356284903 for ; Thu, 14 Dec 2023 12:36:21 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="2273079" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="2273079" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 12:36:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="892616232" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="892616232" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Dec 2023 12:36:20 -0800 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 14 Dec 2023 12:36:19 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 14 Dec 2023 12:36:19 -0800 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 14 Dec 2023 12:36:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JclidDJvJdgXxpIxHhU+PoHb0RXG3deRiJVhtivA9SY5BHmsSPt6/k9Mx6j2nvedBre+nBwNmBFUSfhWhlB02ttj2kMHP925/I5/hD7iVo5qhH5xlfWTYLz3Lb2N0zemW9YMzPrN14IzPy3NeD8YCOEcF3GjR7/tkF2QGH8wIWtl9CEqlofy1JVEc/+9RXevoDoBKOkKQoEr58zpYCPbo8eJ6693LrP0oXgS4fmUQDNHVtPLVnXNP/Ob/45VtJsgX8Xrkl5MQW9LJHiw6u/IPXiXDvXzKZ6qP40h3d0CVX/guEQ4j3v0V8kMkou+UpOXwFzxUw5BU7xZ9J3DPfLHXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wm30H77cbOPji1VVWaLnnjPTVBZt/GtpbwT4EZrGKVc=; b=eE85lz7d15p3PnI78Dgz4kNiUDduWhQs+yYHXgkQc3RHP3luRs2NxznM1HwFRAQ+SJVg22r5juHeOf5v0BSfkAwhyeOdX9gX1m+5tzBPvdIqq0WPGiEvL4XsY7fxznAk4UtTEcOvqhtLFAae7dGBJEhSZ6+2OBJ+r8jy228LIv5ZFFR2jmf73UXAu6V0x/dEf9HpXAzo28F5R4Lp/Zcf8xHTbD/TP69RUJ6WGib+TUu6rfJGhoRsfdMiJ0EyigCax/VYsFGD5RQM4vQ/guRioiCSr/yD9p3IfFBRB2MlOVqnbeFUOoUvxLd4Z77hl3pL+1K+BbtFQJgf4URH1Dyu/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BY5PR11MB3861.namprd11.prod.outlook.com (2603:10b6:a03:18d::13) by PH7PR11MB6548.namprd11.prod.outlook.com (2603:10b6:510:210::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Thu, 14 Dec 2023 20:36:17 +0000 X-Received: from BY5PR11MB3861.namprd11.prod.outlook.com ([fe80::8243:8f57:5a76:c19b]) by BY5PR11MB3861.namprd11.prod.outlook.com ([fe80::8243:8f57:5a76:c19b%4]) with mapi id 15.20.7091.028; Thu, 14 Dec 2023 20:36:17 +0000 From: "Saloni Kasbekar" To: "Luo, Heng" , "Clark-williams, Zachary" , "devel@edk2.groups.io" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Thread-Topic: [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP Thread-Index: AQHaIaf8hTGKBhWZSEude7fCg2ClbbCU9gPggA7Z3uCABOsO0IAAm/+Q Date: Thu, 14 Dec 2023 20:36:17 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR11MB3861:EE_|PH7PR11MB6548:EE_ x-ms-office365-filtering-correlation-id: 4cfa6bbf-868d-4092-5733-08dbfce4528f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: pAGQ4EGdQFEV6OUsELMjrbNRD4iGPpntkbARZB7UDrVLEstVDVoZ+poHS4L4EgQxcqrbX17QEY5zaGQqLBB8hfIRMTd9Gm9ODgpcqN5gEtPxDd8acLucDR9ecJiHSA6PxVtciOpHzI6l3EJ9L3CNYLWJmBGZLCBules5VyjfZhVLJbDBRb/wDmqJmMPRR05HhYaRYF0vj0vUmwWNXWoJtyYLLVDuaD7A1XVv7hpS+2tmRq7bad4wtB7F6ZAg+qps3PGnD03gr382ktk89CoZoI7tnVAUexyzw8VNpb6o3gKJ1ePqMoy0JP/k83ix+M054gRpyLNRWQ5U5R07OJ32qCHNhBnQFK1fhSQuP4xok6ncvsp9oD2NG5SXwh0vVxKhvPel+mledBftwO64uVm9kVFLp2vgNXzUhX7KD+Sj+F+KsZ3pUWNqGNxVxtnM9BdGYSpiKIAnDd0nf2Gu0HtevE5eX1+A33wCMnaeoMX/Ez+4BKuOPrWuyO2kyaWoYOGIu2Fo0G3WOGX60JKroEnHuiVfL4ig2XXK3fyMTQyz470vhfcMTkgwzkXvwT1hvJ72+A1AGl4Wqb3tFD60Ws14QwGrVZEj+7dxueT3WrFfR2U= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3kFU00bekMXocWIStx5iNmqmiMOYYK7XNztbXXyjqxK3oElDg8p77h79KN2v?= =?us-ascii?Q?H8RhiMCtJv2Xg72sqcwNF0ZNmvGZEgXAfmXkiTCnLTbOskzvTAiPVJuIpxVs?= =?us-ascii?Q?aqOSlmJM69UKX6XDfD453bjwjFAf4FrCPVyvNUJeBU/wDi+mt1xIpulRBSzz?= =?us-ascii?Q?/uXc3vsbvwjIqLy91vEm6GZRvWGJ9oLN5MEdsF8ZUNkUfbe7G8+rtNufsTU2?= =?us-ascii?Q?4u5wYY/mon9ZwYb/8IBdzAlHAGfsnS8/t3F/2+rXy1P38uc2cgLhlTWvUo0Y?= =?us-ascii?Q?atHZHAQNJyksy2qGHhNtIMS007md+d2i6/wH3UfTKA2jC1CGJLkYAd6Bq845?= =?us-ascii?Q?9BmSvRvIF21Vph6Zl9fcct+2iCWza3oBMbMtNAV0/IDZr4lruIGsod50FzB9?= =?us-ascii?Q?/zdr6BWQoXQgooeoGowk/HWnQWQyTl2ekW2C2P7ManMez43/iVS+P+PS057W?= =?us-ascii?Q?nXW3P1iX5ccze/ealeKSivoPa1ktNsvqmys3F1YTG90JZPbofmBAAIFDDu10?= =?us-ascii?Q?mUg5c+ErFxpB9OyTzTynhQoMwevuGp5Yg6deJ+60iRIngF83OqsvIJCLBvMK?= =?us-ascii?Q?T5Zfpb/y37OgUqiWmS6AoDO835T7XTdWn23Qj1UVo0yfbfNnEdSbwXjytYxT?= =?us-ascii?Q?+0vhR3xzZe/PSsF7EvqEuv+HLeXJM5qHk1JauO92i2NJxFSIHhpEdDPVzFE2?= =?us-ascii?Q?WB+pSqa4dVYnBG13DyPYxCwfLsrDFN0PWyijd++P8uH76iYjDsfuzdZogBXl?= =?us-ascii?Q?HgXt6mAP+3BENZDxoiL5GynYNY84WzTkH43L3n07r09U4AQH0OhJE97atugF?= =?us-ascii?Q?hQKBBOpr4rQEpVZSVn/7t9ryYTB9hKuxUvhgus0cWBIgEvc0pwLXf/IOl7b/?= =?us-ascii?Q?QbSObvD0SE7zvgHNILhUOuhogA8kzM8+F242uHAVN0M8bEHWOb03No9VrYHe?= =?us-ascii?Q?J4jdXSMjzg0Hm1pO02f/XSRjoEAvs9PHOKN8fMl17D5fJN0Ws+k4WiMoIWe8?= =?us-ascii?Q?XB0XR9b5VLokZ3MRPQaNPwAOxinPr/YzRysIWfJEAWkAZR0njjdL78u8DING?= =?us-ascii?Q?1psUSaqck4f+Evdvrsg00S8/+40zaN7TZLaomkuVZTRXG/IWHDWgKWS+PwAC?= =?us-ascii?Q?w8oxS0b5H9BybpWAhQu5LXqv92vo3GXfIJK1KURuGbHWN54xFCguft+7vLRV?= =?us-ascii?Q?XqsvRpQ3CdIc7xK8iVi12A8h1H3zefbrCSlooqexc1W+62rJzUFzieIpg2Q0?= =?us-ascii?Q?prpBp+64fa2rY9PCxpmVZU7wQLzLjwZ/0IRJAim+Kl9FoLhD3YsxtMhW0GuD?= =?us-ascii?Q?0ffovQD+bV4mJd3SUtXwIDU17bly/HzgzigBh/bFh13JHUJZ6FL+sywZIIo6?= =?us-ascii?Q?hCIqvDNyHE3nW+2AUQt/GdTicBdoAG/zlSllSx71Zw1R/RnkxZEHudEQBPm2?= =?us-ascii?Q?q6fDUgAVwgVSW81J0GrjzXRxqBkZgm4pM5BU/O8zIeETJwtYGIePZBbggw9N?= =?us-ascii?Q?M72aTZVSuF8LfE4bVmkTbW4tZ7gYXcn7xjGtTMeMM8vdVR8r21UHzE61C+Z6?= =?us-ascii?Q?CA+6uVd4paHKUublzZbzQOcz61SS9yNTu9MdnrNj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB3861.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cfa6bbf-868d-4092-5733-08dbfce4528f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2023 20:36:17.0857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5TQ6we7ZTcksjfW3v2YxOnPlPTBeupGlPUIF9+CKaLfJS4Npvvd1JBoWzMZ14Ay3Zp1mG8ZjUKrRvR0mj68HlaI/pZooIUQV4gTmFGtjvvI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6548 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,saloni.kasbekar@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HMDzXtocUsHQkiIe0aQYQoxKx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=SdW31bke; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Mike, Would you be able to help us merge the patch? Thanks, Saloni -----Original Message----- From: Luo, Heng =20 Sent: Thursday, December 14, 2023 3:20 AM To: Clark-williams, Zachary ; Kasbekar, S= aloni ; devel@edk2.groups.io Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not conne= ct to AP Hi Saloni, Could you help to merge the patch? Thanks, Heng > -----Original Message----- > From: Luo, Heng > Sent: Monday, December 11, 2023 4:13 PM > To: Clark-williams, Zachary ;=20 > Kasbekar, Saloni ; devel@edk2.groups.io > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if not=20 > connect to AP >=20 > Hi Zack, > Could you please review the change? > Thanks, > Heng >=20 > > -----Original Message----- > > From: Kasbekar, Saloni > > Sent: Saturday, December 2, 2023 5:25 AM > > To: Luo, Heng ; devel@edk2.groups.io > > Cc: Clark-williams, Zachary > > Subject: RE: [PATCH v2] NetworkPkg: Triger regularly scan only if=20 > > not connect to AP > > > > Reviewed-by: Kasbekar, Saloni > > > > Thanks, > > Saloni > > > > -----Original Message----- > > From: Luo, Heng > > Sent: Monday, November 27, 2023 7:07 PM > > To: devel@edk2.groups.io > > Cc: Kasbekar, Saloni ; Clark-williams,=20 > > Zachary > > Subject: [PATCH v2] NetworkPkg: Triger regularly scan only if not=20 > > connect to AP > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4605 > > > > When UEFI Wi-Fi is in BSS connected state, the platform is=20 > > considered as a static and Wi-Fi roaming support is not needed. > > Wifi connection manager should not initiate Scan requests in this=20 > > state affect BSS client connectivity and must be avoided. > > Triger regularly scan only if not connect to AP. > > > > Signed-off-by: Heng Luo > > Cc: Saloni Kasbekar > > Cc: Zachary Clark-williams > > --- > > NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c | 4 ++- > - > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > > a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > index d1182e52bd..4c5460b65c 100644 > > --- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > +++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrImpl.c > > @@ -1506,8 +1506,8 @@ WifiMgrOnTimerTick ( > > } Nic->ScanTickTime++;- if (((Nic->ScanTickTime > > > WIFI_SCAN_FREQUENCY) || Nic->OneTimeScanRequest) &&- (Nic- > > >ScanState =3D=3D WifiMgrScanFinished))+ if ((((Nic->ScanTickTime > > > WIFI_SCAN_FREQUENCY) && (Nic->ConnectState !=3D > WifiMgrConnectedToAp)) > > ||+ Nic->OneTimeScanRequest) && (Nic->ScanState =3D=3D > > WifiMgrScanFinished)) { Nic->OneTimeScanRequest =3D FALSE; Ni= c- > > >ScanTickTime =3D 0;-- > > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112548): https://edk2.groups.io/g/devel/message/112548 Mute This Topic: https://groups.io/mt/102844565/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-