* [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings
@ 2020-05-18 0:50 Bjorge, Erik C
2020-05-18 22:50 ` [edk2-devel] " Ashley E Desimone
2020-05-18 22:56 ` Ashley E Desimone
0 siblings, 2 replies; 3+ messages in thread
From: Bjorge, Erik C @ 2020-05-18 0:50 UTC (permalink / raw)
To: devel
Cc: Ashley E Desimone, Nate DeSimone, Puja Pandya, Bret Barkelew,
Prince Agyeman
The repo name was being passed in instead of the path the repo. This
caused all commit templates to be flagged as warnings.
Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
edkrepo/commands/sync_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/sync_command.py b/edkrepo/commands/sync_command.py
index da99397..02e915d 100644
--- a/edkrepo/commands/sync_command.py
+++ b/edkrepo/commands/sync_command.py
@@ -200,7 +200,7 @@ class SyncCommand(EdkrepoCommand):
# Perform submodule updates and url redirection
maintain_submodules(repo_to_sync, repo)
# Update commit message templates
- update_repo_commit_template(workspace_path, repo, repo_to_sync, config, source_global_manifest_repo)
+ update_repo_commit_template(workspace_path, repo, repo_to_sync, config, global_manifest_directory)
if sync_error:
print(SYNC_ERROR)
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings
2020-05-18 0:50 [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings Bjorge, Erik C
@ 2020-05-18 22:50 ` Ashley E Desimone
2020-05-18 22:56 ` Ashley E Desimone
1 sibling, 0 replies; 3+ messages in thread
From: Ashley E Desimone @ 2020-05-18 22:50 UTC (permalink / raw)
To: devel@edk2.groups.io, Bjorge, Erik C
Cc: Desimone, Nathaniel L, Pandya, Puja, Bret Barkelew,
Agyeman, Prince
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bjorge, Erik C
Sent: Sunday, May 17, 2020 5:51 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings
The repo name was being passed in instead of the path the repo. This caused all commit templates to be flagged as warnings.
Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
edkrepo/commands/sync_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/sync_command.py b/edkrepo/commands/sync_command.py
index da99397..02e915d 100644
--- a/edkrepo/commands/sync_command.py
+++ b/edkrepo/commands/sync_command.py
@@ -200,7 +200,7 @@ class SyncCommand(EdkrepoCommand):
# Perform submodule updates and url redirection
maintain_submodules(repo_to_sync, repo)
# Update commit message templates
- update_repo_commit_template(workspace_path, repo, repo_to_sync, config, source_global_manifest_repo)
+ update_repo_commit_template(workspace_path, repo,
+ repo_to_sync, config, global_manifest_directory)
if sync_error:
print(SYNC_ERROR)
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings
2020-05-18 0:50 [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings Bjorge, Erik C
2020-05-18 22:50 ` [edk2-devel] " Ashley E Desimone
@ 2020-05-18 22:56 ` Ashley E Desimone
1 sibling, 0 replies; 3+ messages in thread
From: Ashley E Desimone @ 2020-05-18 22:56 UTC (permalink / raw)
To: devel@edk2.groups.io, Bjorge, Erik C
Cc: Desimone, Nathaniel L, Pandya, Puja, Bret Barkelew,
Agyeman, Prince
Pushed: 39c498261c
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bjorge, Erik C
Sent: Sunday, May 17, 2020 5:51 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings
The repo name was being passed in instead of the path the repo. This caused all commit templates to be flagged as warnings.
Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
edkrepo/commands/sync_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/sync_command.py b/edkrepo/commands/sync_command.py
index da99397..02e915d 100644
--- a/edkrepo/commands/sync_command.py
+++ b/edkrepo/commands/sync_command.py
@@ -200,7 +200,7 @@ class SyncCommand(EdkrepoCommand):
# Perform submodule updates and url redirection
maintain_submodules(repo_to_sync, repo)
# Update commit message templates
- update_repo_commit_template(workspace_path, repo, repo_to_sync, config, source_global_manifest_repo)
+ update_repo_commit_template(workspace_path, repo,
+ repo_to_sync, config, global_manifest_directory)
if sync_error:
print(SYNC_ERROR)
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-18 22:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-18 0:50 [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings Bjorge, Erik C
2020-05-18 22:50 ` [edk2-devel] " Ashley E Desimone
2020-05-18 22:56 ` Ashley E Desimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox