From: "Ashley E Desimone" <ashley.e.desimone@intel.com>
To: "Bjorge, Erik C" <erik.c.bjorge@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Pandya, Puja" <puja.pandya@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [edk2-staging/EdkRepo] [PATCH v2 0/2] Enabling selective submodule initialization
Date: Wed, 20 May 2020 00:24:16 +0000 [thread overview]
Message-ID: <BY5PR11MB3973FF6E1938A31F037911D9B2B60@BY5PR11MB3973.namprd11.prod.outlook.com> (raw)
In-Reply-To: <cover.1589924839.git.erik.c.bjorge@intel.com>
For the patch series.
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>
-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com>
Sent: Tuesday, May 19, 2020 2:51 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v2 0/2] Enabling selective submodule initialization
Enabling the ability to select the submodules to be initialized and maintained via the manifest file.
project_utils.submodule contains the submodule logic and also functions as a command line script.
Includes code review feedback.
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Erik Bjorge (2):
EdkRepo: Adding selective submodule init script
EdkRepo: Update commands to use new submodule code
edkrepo/commands/checkout_pin_command.py | 6 +
edkrepo/commands/clone_command.py | 20 +-
edkrepo/commands/sync_command.py | 25 +-
edkrepo/common/common_repo_functions.py | 43 +--
edkrepo/common/ui_functions.py | 15 +
project_utils/arguments/__init__.py | 8 +
project_utils/arguments/submodule_args.py | 24 ++
project_utils/project_utils_strings.py | 24 ++
project_utils/submodule.py | 373 ++++++++++++++++++++++
setup.py | 50 +--
10 files changed, 514 insertions(+), 74 deletions(-) create mode 100644 project_utils/arguments/__init__.py
create mode 100644 project_utils/arguments/submodule_args.py
create mode 100644 project_utils/project_utils_strings.py
create mode 100644 project_utils/submodule.py
--
2.21.0.windows.1
prev parent reply other threads:[~2020-05-20 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 21:51 [edk2-staging/EdkRepo] [PATCH v2 0/2] Enabling selective submodule initialization Bjorge, Erik C
2020-05-19 21:51 ` [edk2-staging/EdkRepo] [PATCH v2 1/2] EdkRepo: Adding selective submodule init script Bjorge, Erik C
2020-05-28 2:16 ` Ashley E Desimone
2020-05-19 21:51 ` [edk2-staging/EdkRepo] [PATCH v2 2/2] EdkRepo: Update commands to use new submodule code Bjorge, Erik C
2020-05-28 2:17 ` Ashley E Desimone
2020-05-20 0:24 ` Ashley E Desimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB3973FF6E1938A31F037911D9B2B60@BY5PR11MB3973.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox