From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
"Dong, Guo" <guo.dong@intel.com>
Cc: "marcello.bauer@9elements.com" <marcello.bauer@9elements.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"'Leif Lindholm (Nuvia address)'" <leif@nuviainc.com>,
"Doran, Mark" <mark.doran@intel.com>,
'Andrew Fish' <afish@apple.com>,
"Guptha, Soumya K" <soumya.k.guptha@intel.com>
Subject: Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]
Date: Fri, 18 Sep 2020 04:39:04 +0000 [thread overview]
Message-ID: <BY5PR11MB4007255EF713348BEA8B82D48C3F0@BY5PR11MB4007.namprd11.prod.outlook.com> (raw)
In-Reply-To: <31e807dc-6217-f3b6-995b-ab10f4ce789e@redhat.com>
Laszlo,
I support your idea of having a meaningful description for BZ, for commit message, for code comments.
Thinking from 1 or 2 years from now, the simple message we created may help nothing to remind me or others why the changes were made.
We cannot reply on people's memories and even the people that have the memories may left the community.
So, documentation is necessary.
But I remember that our development process document in WIKI doesn't require anything on the commit message perspective.
IMO, at least the commit message should contain:
* current status or reason(fail, lack of a feature, bad coding style)
* impact of the change or result (fail to pass, feature enabled, coding style improved)
Can someone help to emphasize the requirement in the WIKI?
Thanks,
Ray
next prev parent reply other threads:[~2020-09-18 4:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 8:24 [PATCH v5 0/3] UefiPayloadPkg: Runtime MMCONF Marcello Sylvester Bauer
2020-08-18 8:24 ` [PATCH v5 1/3] UefiPayloadPkg: Store the size of the MMCONF window Marcello Sylvester Bauer
2020-08-18 8:24 ` [PATCH v5 2/3] MdePkg: PciExpressLib support variable size MMCONF Marcello Sylvester Bauer
2020-08-20 10:55 ` Liming Gao
2020-08-18 8:24 ` [PATCH v5 3/3] UefiPayloadPkg: Support variable size MMCONF space Marcello Sylvester Bauer
2020-09-08 22:35 ` [edk2-devel] " Guo Dong
2020-09-16 8:56 ` more development process failure [was: UefiPayloadPkg: Runtime MMCONF] Laszlo Ersek
2020-09-16 17:30 ` [edk2-devel] " Guo Dong
2020-09-16 18:14 ` Laszlo Ersek
2020-09-16 21:51 ` Guo Dong
2020-09-17 5:59 ` Laszlo Ersek
2020-09-17 1:49 ` 回复: " gaoliming
2020-09-17 2:31 ` Yao, Jiewen
2020-09-17 6:31 ` Laszlo Ersek
2020-09-17 7:31 ` Yao, Jiewen
2020-09-17 10:26 ` Laszlo Ersek
2020-09-18 4:39 ` Ni, Ray [this message]
2020-09-18 7:37 ` Andrew Fish
2020-09-26 0:34 ` Guo Dong
2020-09-27 1:44 ` 回复: " gaoliming
2020-09-27 17:29 ` Guo Dong
2020-09-28 17:55 ` Laszlo Ersek
2020-09-29 4:13 ` Guo Dong
2020-09-29 11:59 ` Laszlo Ersek
2020-09-17 5:56 ` 回复: " Laszlo Ersek
2020-09-21 9:57 ` Marcello Sylvester Bauer
2020-09-22 6:45 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB4007255EF713348BEA8B82D48C3F0@BY5PR11MB4007.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox