From: "Ni, Ray" <ray.ni@intel.com>
To: "patrick.henz@hpe.com" <patrick.henz@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts
Date: Wed, 2 Sep 2020 03:21:33 +0000 [thread overview]
Message-ID: <BY5PR11MB400766BEBF3751590619E6E28C2F0@BY5PR11MB4007.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ada27224f32b4ac24ca9df31668ab4500fd8fa21.1598978760.git.patrick.henz@hpe.com>
In general, thanks for enhancing the logic to take the cmd execution duration into the timeout.
2 minor comments:
>
> + (EFI_TIMER_PERIOD_MICROSECONDS(0xFFFFFFFF)):
1. Can you enhance the patch to avoid creating the timer event the Timeout is 0.
>
> + } while (!EFI_ERROR(TimerStatus) && EFI_ERROR(gBS->CheckEvent (TimeoutEvent)));
>
2. Can you please move the !EFI_ERROR (TimerStatus) check from the while() to outside of while()?
Because this status value never changes in while loop.
next prev parent reply other threads:[~2020-09-02 3:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 18:55 [PATCH 0/1] Fix XhciDxe Timeouts patrick.henz
2020-09-01 18:55 ` [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts patrick.henz
2020-09-02 3:21 ` Ni, Ray [this message]
2020-09-02 6:45 ` [edk2-devel] " Laszlo Ersek
2020-09-02 5:08 ` [PATCH 0/1] Fix XhciDxe Timeouts Wu, Hao A
2020-09-02 6:49 ` [edk2-devel] " Laszlo Ersek
2020-09-02 6:58 ` Wu, Hao A
2020-09-02 23:03 ` patrick.henz
2020-09-03 3:54 ` [edk2-devel] " Wu, Hao A
2020-09-03 8:53 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB400766BEBF3751590619E6E28C2F0@BY5PR11MB4007.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox