From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.13394.1599016900314515358 for ; Tue, 01 Sep 2020 20:21:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=fST1rXOt; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) IronPort-SDR: tVsgtSmrX1UTNFHt6Gm8LT4HmCGRHBMQj6ZJXVGQDnACfZx1p7uE07Tf1WZCl+WvELk6aKDUip VX8qrnbcHvCQ== X-IronPort-AV: E=McAfee;i="6000,8403,9731"; a="157316263" X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="157316263" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 20:21:39 -0700 IronPort-SDR: /0FZ//C5A+0Q9Ea9Ge54XeEsHkSzfNGqfoWbWJPn+LArQ4YtH/ObWWgaotZX6WhFj2z+oEVyz/ DuTLypHGHXlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="325613570" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 01 Sep 2020 20:21:39 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Sep 2020 20:21:39 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 1 Sep 2020 20:21:39 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 1 Sep 2020 20:21:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DCIGio3xsdmZ4cSpdvTShy/fy1D2tqUbqdLxYmHaSAQPmXkwU3YXRgkMAoRS66+uRwknqOFFG7pyeoEFiJBLNWcAu1XN3cxJXY4lyztaSsaN045+WQwMo9aQ7qEIK56nhgJOr9rQPsyIR/Kv1ilkrQCi9Ec8wOgXUaDLdr18Ob3NeRx9vyqwR7G6o6hdm/HpUoQ+Iz+GYktKgVrFuxJfaD2N+xXQ9WryzW3OBM3gqHH1z+E8dEWbnNYKfuT2UDv8NsBffQPVINAXH2FrXB/ZDCKRNTq3c1jnQVxKzY3Y01nBRICrgnJX/n15Ga39UfZXtsXfU6S4amAQArCUsOJfng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Urstf1SeVoOw/WGBZSY6fgpwFlAdtcGpTYcB9/IcTo8=; b=N3gp8sg3z8/Vgb0CLUoQ2m1E8hYf7NTzH4AIb//O9et1iyhWSlSiINcw66M6EUt+PdzaUHzYcGj4OU9ZRHajZOiBWn2T9jGgSq8MPvDYDgQtEYv3fvToSA8yREb6H2QGEPuxZ5AOktuIeSLdcZtU2vy21o+O06UauaZnd8F0l1GSMROx9vgkCzcqWoHWQORorG+35oyeCzmpYvATuqEJq15z3U1WGsTmNT9/iYk5OM7W66vvqlKgO6lmVvLV2zUkJwNhIBqt75G4tUqBY6MbpELN+dKSeaxpjuXVab1h6c3IbmVgFocoAhwYO+O9fyft+NpSCKi8fFbzdIcjQktX/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Urstf1SeVoOw/WGBZSY6fgpwFlAdtcGpTYcB9/IcTo8=; b=fST1rXOtPVfYOh8jRXWUeFKDD4uxBel36QDJ/t4uVOxFvCAu0ktEtxuY3AEQPxHCF2SGDwjq1QRyo5BhFO8UnhS8WppfbUQIsgY6R5hpDTE4D6/pBqc9WmVtN4Xh9Os6s21MBaZd5MfkbVwdhq6UUZs/2b1RudBbP6W/DfBrxl8= Received: from BY5PR11MB4007.namprd11.prod.outlook.com (2603:10b6:a03:189::28) by BYAPR11MB3303.namprd11.prod.outlook.com (2603:10b6:a03:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.23; Wed, 2 Sep 2020 03:21:33 +0000 Received: from BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::889e:ec52:bb02:db78]) by BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::889e:ec52:bb02:db78%3]) with mapi id 15.20.3326.025; Wed, 2 Sep 2020 03:21:33 +0000 From: "Ni, Ray" To: "patrick.henz@hpe.com" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts Thread-Topic: [PATCH 1/1] MdeModulePkg/XhciDxe: Fix Broken Timeouts Thread-Index: AQHWgJGZqz0eZBIRSEmbx6hNriNG/KlUrb8Q Date: Wed, 2 Sep 2020 03:21:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [180.171.153.78] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 459273a7-0a3d-42bc-2f86-08d84eef4b10 x-ms-traffictypediagnostic: BYAPR11MB3303: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OxDe8LWWCWytQl7v1wmLC9DqP5P/aunFUAdCWNnNCMeRqyvB2bxEmZHiWjxOQVwD38+YWZ5vtWvBKQPn8h4uMXrfrG6GH2Op5q+huYD634hpA7tuzBdvSHV319QW8qMl04vo0fjVjMlx+tLex9h//PBMT1iZV7GGrn2Mi9h8MMlExTUV9RSA8pvD9gxE46YEvjp3WTpRt8akUqQFOAj2ptASz5o1XACsA88D1xkhSVFSnxkbWu4l5dd+B/BpEyzMuoaelUNX/A+dFT8dlIy5wNs3s6ltkov9IbzfrPilvCE5nmNePUrF/XdUSonCUrtP1EgGuzCv8t/cz2RcnLbY4A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4007.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(39860400002)(346002)(396003)(136003)(52536014)(66446008)(4326008)(64756008)(316002)(186003)(66556008)(76116006)(2906002)(66476007)(55016002)(33656002)(478600001)(66946007)(8676002)(5660300002)(8936002)(26005)(107886003)(296002)(54906003)(110136005)(7696005)(86362001)(4744005)(71200400001)(6506007)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 27W1GXrWQ6I/KnDit9f37vveiDXvIGkKY9x6NyE5U6kIIKd6VrM0ocIQQ29o6y6Uj8SVWb0CgEeUt5EnC319RDjLDU/9IQ6QW5vJFpaI+IuNqQmIfL2ATdpiknlrC2uSQS4p0u2Pm3IiEktFBDXdm41CNh0+WN4czkBUFRpoDPQsSgH44nWm+GZPO7o5igA3hm+1lHJO17G427sY3HahfJCRIUnotNJ/M3hLnWxpHtAV7GhRNu676bs15esELwa0mZRza+hWbHC6AdzK9WIwIEc05B5F5SCYkDgQaWWjD230ydd202pMmyoG4r8yvU7OXMySD89Of4ZMDjg2dZA8NvDWVypwJcQay3JTT6yoiaDLuShTqz1Zzzgg2Z5VgrZuUCVvVFZSNX3tHSyGvpFduUJpCP6SJIeQln68kw8caBhHN02NvRAiA7/f/4UkBqQFpXU/abfS/ksq6k625C8Zdhb5YBPH5ZACwagvXlvUYOFxLQIfOtRHQ/sWkNniiOdl0ehpMsmlTxkQcgfsA1tKdnPkKUsOycMOjYoWDpFyOSK455rYHY9vX7qvMNzn/Eg6njyODcHEAwCb+b1JHxjYN8UHVCSbidYyV6WPX5yswB7s5duKsI6K8+ZemDLhWFQMqN9U1KkdHd3fne3BKNnJLw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4007.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 459273a7-0a3d-42bc-2f86-08d84eef4b10 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2020 03:21:33.5627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F5hh3ZCVYeGX6d86Aluf6M22lbSn9jVWU1rPp4wpoYnSGgQQqAgL15npjMM3f9UHewJml1Az7naUTlDfOGG1sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3303 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable In general, thanks for enhancing the logic to take the cmd execution durati= on into the timeout. 2 minor comments: >=20 > + (EFI_TIMER_PERIOD_MICROSECONDS(0xFFFFFF= FF)): 1. Can you enhance the patch to avoid creating the timer event the Timeout = is 0. >=20 > + } while (!EFI_ERROR(TimerStatus) && EFI_ERROR(gBS->CheckEvent (Timeout= Event))); >=20 2. Can you please move the !EFI_ERROR (TimerStatus) check from the while() = to outside of while()? Because this status value never changes in while loop.