From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.5720.1600306883701908237 for ; Wed, 16 Sep 2020 18:41:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=tPOShUaP; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) IronPort-SDR: 7Xk0qO8/+IoxAz4Ifrk6ZuSBGHLqxqnzlDDdnidv8HgzPHneZdaVs4Fs4fQF84Kit3uDHab66w PiG8j/ZjtPuQ== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="159654551" X-IronPort-AV: E=Sophos;i="5.76,434,1592895600"; d="scan'208";a="159654551" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 18:41:23 -0700 IronPort-SDR: ilLxM5kCuiTdLdSN9Lq6OUQUn412rpW9y5CF2LQZORtSL70zdPxd7kYo9/Q7mkt6AZQta4ta/B ANU3Lg2oWFFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,434,1592895600"; d="scan'208";a="336237216" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 16 Sep 2020 18:41:23 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Sep 2020 18:41:22 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Sep 2020 18:41:22 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 16 Sep 2020 18:41:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m/fLRUEAaXrL4uPgCtiKDTxuHnkqyvSZfRfUMeedKuIEz7vaYzWvsrK9zN/4fP3g3zsZaQM1hiT7WutlI55KNZfZ22tDE8cMST8TfkzcOZQ/vOTA3JlpGtRKrUxD7lGyZ3URgwPO4FDg5FS7/dGCj51heCATBAfaeSKi7z7DHqw4wRRF0u9KZLm6SL/Qs1sSwdXyujjaV5Ov35JBTJKWDFr7+Ic8PFEuAgo7CEynM2uKZfnQ8VGVK8yn+0jcGv6bRtp3GudaBKng+AYEi/4aUkswN0XtEiLNFNcXAct//oyJWQxrrlsdcOVH02p5AFzQeST0ZiX2jVF4pqb/n3ouiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VeTE1rJm0TqWaetEdMZyET8JSs38/NKse89HpWhboDw=; b=U8M/HH50dvQPHtoI0mN4085y4jSl/BDJYLeOeugtZ2Dpruc4TcYUup49RNW2Hfwx4LC9HVNLG+MKvOQFwKJPLwnndARvbobBfae9HiFBUDi8o1jlT+6wNDk2gbFZGvlnKRicaa2g5pbJ3EVnU/FT6QEwZm/UFDjwEjVatTSQ9tLIcSwkw90uVs5A8hmgqmE1G6tSC++hK7tvLa+1oUtacsf6cEj4SYZyKHenml27wyEIsc2QFIoxadVRYfhCODM+7IHi3g1FdVO535V4Gs9r5H3L6vYeO9hmjK/c+CK4vNe7LzjF7kDJZ79ASkW5A7VsjhnLQgvteD/pIuX9pnMRwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VeTE1rJm0TqWaetEdMZyET8JSs38/NKse89HpWhboDw=; b=tPOShUaPcLHvQCI2ejdSK/ArEcE0c5lzqZL+htkz0xZKkpAk6Tj2qR6eoQZkVbUpJN/DAXHgzJBqEAGltfm1AR43IuJzG/EBai1X0aalUk71bj6ABnnL1e2DfFVKOvTeM3alINidkMMiwFl1O7DuBG9gAUViTqjwLd67VNbol4U= Received: from BY5PR11MB4007.namprd11.prod.outlook.com (2603:10b6:a03:189::28) by BYAPR11MB2903.namprd11.prod.outlook.com (2603:10b6:a03:89::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 17 Sep 2020 01:41:21 +0000 Received: from BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::1533:4053:1c45:3596]) by BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::1533:4053:1c45:3596%6]) with mapi id 15.20.3370.019; Thu, 17 Sep 2020 01:41:21 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Ni, Ray" , "marcello.bauer@9elements.com" Subject: Re: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs Thread-Topic: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs Thread-Index: AQHWi1tzGzjhTKraNEe3bWC1kVroLKlq5bQggAEoYNA= Date: Thu, 17 Sep 2020 01:41:21 +0000 Message-ID: References: <20200915122616.17196-1-marcello.bauer@9elements.com> <16353648FD0ACD96.16285@groups.io> In-Reply-To: <16353648FD0ACD96.16285@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [180.171.153.78] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 292cffe6-3851-4af1-b6fc-08d85aaac799 x-ms-traffictypediagnostic: BYAPR11MB2903: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ee9GQl5brl4Z2q/QQyLRT4Y5R/7htJIMjP4pc2nXNYQwvUNDPXquImPPCsJH9ezMaRBGI4Ig5gJI+V9pKKdsyzeueHVQmvWxiFsvYamOeE2lOYqE6xb7/bHJVv+I8srJ+VzIvOz3a5pVgWBfW3I5Jkkn0jF/lYzrtx2w+u0VyKdI2QpjC+NN0SQRO9XQFAV7aTPtapqDpxzHmDz84Ux75ysfOCLM7tijymCFmmOsnKzAp9C/KqgjHtkFebI/bH7PjuL46T6w9+YwzFmaaY1g6G1DBy8ax9eAbZKN0ddQuuiyN3hTe0D/ILTBaggHEfH/eW6+Z/44ng1cIK1pdjVwx1lnN6T4cmNVRknAn2Z69YEJVSsJRpTJo2BkbsL09FoAD1D2VdhIrh3wdF3sjRbaCQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4007.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(39860400002)(396003)(136003)(366004)(6506007)(53546011)(33656002)(5660300002)(26005)(19627235002)(52536014)(8676002)(478600001)(8936002)(316002)(186003)(71200400001)(64756008)(55016002)(110136005)(86362001)(9686003)(83380400001)(966005)(7696005)(66556008)(66476007)(66446008)(2906002)(76116006)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: TbBzGsKLBED7sJfufyIC+tw5G1v56d5s/kzBeih4vbwkLR73dBtuF6leQkLZN+k7dVJXiUhIzuNpFcGCFROztt1h5pivO9R7bg7/XFmOS28gFqYsMVM+NoEWooRn2hFjTblUGnBekld7Ogk6A4RJOvjYfY6IwFlgfcGHEF3UPw3QMIwSCz/xeTj5CUh3Sq9L494xhHKL7EkFkeYdv67XPkfcINAVPZ2ZBQpsVqPEPdp8vTOjsuATNULO36GzPbffJydq+9YbA9jOvVPOC6MXhyUeo5w+1sxMQlstISDIqZ5Br/JNwhOHRtcOoRGE2hOXU0IY9ZRcTD3l3iFcVblhPY9U69LeqKHT9WSuPqbNm28DrRKIyvtwY8J6Srqm2kDv/12h47vbnmcwjhbqGI87m0kD0uAjDjxiiZyDtZV418xADdIxkDO4d9Ejd5ojqzUGyBzK2p8BCvDyZMAgzX8AzModXbckdiRCMlUA2zMcHRmAMP4r2u5NOiwOS8drRJ4+a6SXECEA0Jj/376E86z+Am7bnZ7aOqc1DBSSQjYaFlP5qGaycvyy5Pj78ftsYagKBqcaq8qCcUoe9dJt5mFjLTSVQkZd3SfKUJ9/bXA4loRuZiaYucAV9WRUbZ+LZbVinQVdHKxcpkyEPRfowo5Jpw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4007.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 292cffe6-3851-4af1-b6fc-08d85aaac799 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2020 01:41:21.1225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zL3+ZXBtn72LoidJe+3G631uidKYKldxYBIN4YUub5CkStStjLn2ECklNqHiscbQXUPgCA30RFanlOSzyan6kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2903 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Another comment: In your UefiPayloadPkg change, you have an assumption that the option ROM = BAR still contain the correct base address. Is it always true in real world? Do you think maybe the boot loader should= supply a MMIO space range so UeifPayloadPkg can use for option rom decoding? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, September 16, 2020 4:29 PM > To: devel@edk2.groups.io; marcello.bauer@9elements.com > Subject: Re: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option= ROMs >=20 > Why running it will disable the ability of PciPlatform code to scan for = ROMs? >=20 > I guess it is because the PciIoDevice->AllOpRomProcessed is set which ca= uses GetPciRom() is skipped. >=20 > Can you explain more in the code comment? >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Marcell= o > > Sylvester Bauer > > Sent: Tuesday, September 15, 2020 8:26 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option R= OMs > > > > Fix Option ROM enumeration and support scanning. > > > > v2: > > * add correct Maintainer and Reviewer to Cc > > * PciPlatformDxe: > > - Update description > > - add function description > > > > Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg- > > Option_ROMs > > PR: https://github.com/tianocore/edk2/pull/926 > > > > Patrick Rudolph (2): > > MdeModulePkg: Fix OptionROM scanning > > UefiPayloadPkg: Scan for Option ROMs > > > > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 1 + > > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 + > > UefiPayloadPkg/UefiPayloadPkg.fdf | 1 + > > UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf | 46 +++ > > UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h | 19 + > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 10 +- > > UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c | 426 > > ++++++++++++++++++++ > > 7 files changed, 500 insertions(+), 4 deletions(-) > > create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf > > create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h > > create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c > > > > -- > > 2.28.0 > > > > > > >=20 >=20 >=20