From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.6972.1600842314938023491 for ; Tue, 22 Sep 2020 23:25:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=vp/p2bXO; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) IronPort-SDR: bEyyQ8GlFKCDDnMmNPgkTbJDQxm6JI3ZK2HZ7Llhl2KuvD8GyzEPDxcK4jpdfVWNckd/1SbBC9 aSA8/lsJjVjA== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="148465579" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="148465579" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 23:25:13 -0700 IronPort-SDR: MJsBfPbd74eab+OcGgSIgrQUUqFarfhDG1tZ1G77LdcSH7rzj27ikUY8Qy4rs46rRFGDNYGyXK bHWGLh6mXpzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="322495118" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 22 Sep 2020 23:25:06 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Sep 2020 23:24:55 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Sep 2020 23:24:55 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 22 Sep 2020 23:24:55 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 22 Sep 2020 23:24:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J2w27PTYb1U6YjngH7L5soklbprhK2sVUY1r5/uRIujZuccypieNFF1qMog8aLAIj9tsSjC8oZmYWO/O6YtYoLhi9LDWnyj0G/zjE7hf7t814QYbORRGUuQVBYmL4Krq8aI8YHhRHzVhHRfJBkeunW+KS+kK0j46kOa+pY5vPgesAd6PB3uVaOOwe7FMUCrhCD68bKQcgr/Y5RX6qKcmTx1Wd+A1S5Gz13uuXSmgL+O8fGH9PeDiazP+MoOrmF1cMKH3IJ6QEEbqDN2UljZMnPQ30vm1r9aa3RVWb40PvWb+GlWvDjb3RbcORcnK/SmIxqUb/FStGtAMYWX95j6yhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxVdcyBTJSXHz4VG8Tmt7BMRo9fXhGSppHF6lsFrChg=; b=LvVYBgSDQM9jrFOVYces51ErgTNFNJJL1/NPSVT+KERJ5B5QgiDDtdmvsHvyMF1OkZmryaKWW//8CqiBuU04QL7SEwgtJgF1tHoQWvedjrF9laVusJNVltukIGi7H5a60HtjFRqA2aQvrwoYDVYrLlqc18/l4ZMthjPTDFEERrNIfDSFtOLNpbWWT4Zy9WXmMqFrrlbTE0UQVFm4pogz+AWfSMD2t1tls+YwCuZduKGtyAfZ2Zlpe9yIBcAjTfIyOOlrmjlafw/eugnJ2H/tsxobmNmmcGJ/AWT5XwIrYjkXkAIIWsUxWuP/iFupNtgMmybRo1L0QVqAhjdQm/zJyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxVdcyBTJSXHz4VG8Tmt7BMRo9fXhGSppHF6lsFrChg=; b=vp/p2bXO4GK0Zehk8QzMBkYe6dwH2HrUGfOTbXxl7mHHQ3P5HqoWUSICRYuuoTUqcQHBT2aaRwctvwinftMnAy7HWRPcBcTay6i5eIkSXAfI6cWLaRW1/2XtWSzHqg2UiKBg6hJGRgUhR0oYjkfqbnJ/0UNYkjqc6Plq/ZXNU14= Received: from BY5PR11MB4007.namprd11.prod.outlook.com (2603:10b6:a03:189::28) by BYAPR11MB3477.namprd11.prod.outlook.com (2603:10b6:a03:7c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Wed, 23 Sep 2020 06:24:51 +0000 Received: from BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::1533:4053:1c45:3596]) by BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::1533:4053:1c45:3596%6]) with mapi id 15.20.3370.033; Wed, 23 Sep 2020 06:24:51 +0000 From: "Ni, Ray" To: "Li, Aaron" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Fu, Siyuan" Subject: Re: [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add PCD for shadowing all microcode. Thread-Topic: [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add PCD for shadowing all microcode. Thread-Index: AQHWcH3xyuJZ6EUoG028rAn2IG6CzKl2AuzA Date: Wed, 23 Sep 2020 06:24:51 +0000 Message-ID: References: <20200812075452.9054-1-aaron.li@intel.com> In-Reply-To: <20200812075452.9054-1-aaron.li@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eeee2710-31eb-402a-4780-08d85f8960f3 x-ms-traffictypediagnostic: BYAPR11MB3477: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iCZ484KuExs6rXR+4DQNh7lBU0Qo8ezEza6aK9aeIYMVluB9DNsOM8AJVMYlfOmAQQL5KEArDgWn3aDJHEoiaiDRRaB8pJ6uLzqcXdlPI9ePvxNd7VAU86m3RL+a4ZHHmSQRuAVv6T5HIZjrMFm4gst16+441jRrfrlf0HkC/206idXYLXE/kI7z55pNFbgbo5Tkh14rk4fTv65xUxoIi+IBfC5WL6YFHq0XC0hLKioLUKUibYNKaQH3Bi7AKrEvgqA0/apcKW7h22Pk8BuFcUHhD/9X2lEXjI++tYxwcSKhvBglI3TeT6RU8SjwhEu1yxH7ocvWLE8Q1dEaOjDHdnxnYCYdgv0Ba96zJvzyiUrd6D6utaJn9I+IM8Pj4A8K6Kzv/G2qWq6i7WvxvUTuoo+aNncDtWBnv9VDQqAl+V+7NQj0weWI3ylOChak3ZpCwMZVjV8iULPa5Qwr3Yaz9U4B4Jfwy01sM53STaVlo4gE6UUN4nRdc1t6RU539He7 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4007.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(316002)(8936002)(966005)(107886003)(7696005)(55016002)(54906003)(110136005)(26005)(9686003)(186003)(8676002)(478600001)(4326008)(6506007)(53546011)(86362001)(2906002)(5660300002)(52536014)(66446008)(66556008)(64756008)(66476007)(71200400001)(33656002)(83380400001)(76116006)(66946007)(14943795004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: Zpn/cO8ZdWQ3zL1qXDDoNtP5alBH8WHp1rChoitlYMMoEtBQh07cA+2VmJZAUzMpaPX+vT+iJhrUc2SRJkNOrGbfXjPn0+n2TUu71es3e/4QhADcBOgaIud585sC2UYPS5KUPMf5smaU3b3e2DkP3KqgeX0986Mt59Dvr9Qr0ZrcCRJ+YJ8te4KC9sfxmWb3lKFDGLtpEdDMF1S0qwrQwSYaMLllMaxnJG8i535xdgRCAz4kNl4sE7cZrMY41tVF81FS9nrm5riegrSo5MtPIeO/GEnrjz7vmRgfpdZWXy9M+fzvcxlTj+OvzUefxRve26tT/q/92Y4ZaYV/UOYTcQBQBV2GbHy/j3K8Lt+/ITA8DCe15nBnZr4G2sBwqnkEof71g5+BAY/s39xr5AJSQ2uHLte4xYzO314W1q9orkuPe/iB2jajHg0h9hHXU6hNhAgCYCGfx9XNc2Ag34bafw4JJ0YXMLw24I7kdJoOLG3FeTd9dEeMAVZB5SXXURl71Cg/DAqCSnqsKjlOtYXabMKTUK4IUS9msaTUDCqQW0jNqsc41wMI8DngXiSmysIJgXdtCfBwNp9cOY6eQVWrYBdSUSUbUIelaxKBZ8GOxK/LiJXQfEEedKtHT6GHCT/Ulk0GqWx9ukqloqA3tGQY4w== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4007.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eeee2710-31eb-402a-4780-08d85f8960f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2020 06:24:51.3160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pvyQEYiyvOgsFfgHx8fIzo1VBMJwWLpvP4r8Si2T3pkof3e7yfhZChs/GjKJHhqWwZEze9rXGhaDmX7I4lzxqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3477 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MpInitLib already contains logic to shadow microcode to memory. Is this still needed? > -----Original Message----- > From: Li, Aaron > Sent: Wednesday, August 12, 2020 3:55 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > ; Fu, Siyuan > Subject: [PATCH v1 1/1] IntelSiliconPkg/ShadowMicrocodePei: Add PCD for > shadowing all microcode. >=20 > This patch is to add a PCD PcdShadowAllMicrocode to support shadowing > all microcode patch to memory. >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2891 >=20 > Signed-off-by: Aaron Li > Cc: Ray Ni > Cc: Rangasai V Chaganty > Cc: Siyuan Fu > --- >=20 > Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.= c > | 4 ++++ >=20 > Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.= i > nf | 3 +++ > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = | 7 +++++++ > 3 files changed, 14 insertions(+) >=20 > diff --git > a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .c > b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .c > index 8d6574f66794..5c7ee6910c8e 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .c > +++ > b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .c > @@ -132,6 +132,10 @@ IsMicrocodePatchNeedLoad ( > CPU_MICROCODE_EXTENDED_TABLE *ExtendedTable; >=20 > UINTN Index; >=20 >=20 >=20 > + if (FeaturePcdGet (PcdShadowAllMicrocode)) { >=20 > + return TRUE; >=20 > + } >=20 > + >=20 > // >=20 > // Check the 'ProcessorSignature' and 'ProcessorFlags' in microcode pa= tch > header. >=20 > // >=20 > diff --git > a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .inf > b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .inf > index 019400ab31da..581780add891 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .inf > +++ > b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i > .inf > @@ -39,5 +39,8 @@ [Guids] > gEdkiiMicrocodeShadowInfoHobGuid >=20 > gEdkiiMicrocodeStorageTypeFlashGuid >=20 >=20 >=20 > +[Pcd] >=20 > + gIntelSiliconPkgTokenSpaceGuid.PcdShadowAllMicrocode >=20 > + >=20 > [Depex] >=20 > TRUE >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > index e4a7fec3a3ea..3a12fe99fac6 100644 > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > @@ -76,6 +76,13 @@ [Protocols] > # Include/Protocol/PlatformDeviceSecurityPolicy.h >=20 > gEdkiiDeviceSecurityPolicyProtocolGuid =3D {0x7ea41a99, 0x5e32, 0x4c97= , > {0x88, 0xc4, 0xd6, 0xe7, 0x46, 0x84, 0x9, 0xd4}} >=20 >=20 >=20 > +[PcdsFeatureFlag] >=20 > + ## Indicates if all microcode update patches shall be shadowed to memo= ry. >=20 > + # TRUE - All microcode patches will be shadowed.
>=20 > + # FALSE - Only the microcode for current present processors will be > shadowed.
>=20 > + # @Prompt Shadow all microcode update patches. >=20 > + > gIntelSiliconPkgTokenSpaceGuid.PcdShadowAllMicrocode|FALSE|BOOLEAN|0x > 00000006 >=20 > + >=20 > [PcdsFixedAtBuild, PcdsPatchableInModule] >=20 > ## Error code for VTd error.

>=20 > # EDKII_ERROR_CODE_VTD_ERROR =3D (EFI_IO_BUS_UNSPECIFIED | > (EFI_OEM_SPECIFIC | 0x00000000)) =3D 0x02008000
>=20 > -- > 2.23.0.windows.1