From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"marcello.bauer@9elements.com" <marcello.bauer@9elements.com>
Subject: Re: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs
Date: Wed, 16 Sep 2020 08:28:41 +0000 [thread overview]
Message-ID: <BY5PR11MB4007B6563B5FAF0BFE8EF26C8C210@BY5PR11MB4007.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200915122616.17196-1-marcello.bauer@9elements.com>
Why running it will disable the ability of PciPlatform code to scan for ROMs?
I guess it is because the PciIoDevice->AllOpRomProcessed is set which causes GetPciRom() is skipped.
Can you explain more in the code comment?
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcello
> Sylvester Bauer
> Sent: Tuesday, September 15, 2020 8:26 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs
>
> Fix Option ROM enumeration and support scanning.
>
> v2:
> * add correct Maintainer and Reviewer to Cc
> * PciPlatformDxe:
> - Update description
> - add function description
>
> Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg-
> Option_ROMs
> PR: https://github.com/tianocore/edk2/pull/926
>
> Patrick Rudolph (2):
> MdeModulePkg: Fix OptionROM scanning
> UefiPayloadPkg: Scan for Option ROMs
>
> UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 1 +
> UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 +
> UefiPayloadPkg/UefiPayloadPkg.fdf | 1 +
> UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf | 46 +++
> UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h | 19 +
> MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 10 +-
> UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c | 426
> ++++++++++++++++++++
> 7 files changed, 500 insertions(+), 4 deletions(-)
> create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf
> create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h
> create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c
>
> --
> 2.28.0
>
>
>
next prev parent reply other threads:[~2020-09-16 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 12:26 [PATCH v2 0/2] Add support for scanning Option ROMs Marcello Sylvester Bauer
2020-09-15 12:26 ` [PATCH v2 1/2] MdeModulePkg: Fix OptionROM scanning Marcello Sylvester Bauer
2020-09-15 12:34 ` [edk2-devel] " Laszlo Ersek
2020-09-15 12:26 ` [PATCH v2 2/2] UefiPayloadPkg: Scan for Option ROMs Marcello Sylvester Bauer
2020-09-16 8:28 ` Ni, Ray [this message]
2020-09-21 13:25 ` [edk2-devel] [PATCH v2 0/2] Add support for scanning " Marcello Sylvester Bauer
2020-09-22 23:58 ` Michael D Kinney
2020-11-10 15:01 ` Marcello Sylvester Bauer
[not found] ` <16353648FD0ACD96.16285@groups.io>
2020-09-17 1:41 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB4007B6563B5FAF0BFE8EF26C8C210@BY5PR11MB4007.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox